Re: [PATCH 1/2] score: Fix RTEMS_DEFINE_GLOBAL_SYMBOL()

[Chris Johns]

OK

Thanks
Chris

On 13/9/2023 12:44 am, Sebastian Huber wrote:
> The availability of a proper RTEMS_DEFINE_GLOBAL_SYMBOL() implementation
> depends on __asm__() and thus __GNUC__.
> 
> Clarify documentation.
> 
> Update #4953.
> ---
>  cpukit/include/rtems/score/basedefs.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/cpukit/include/rtems/score/basedefs.h 
> b/cpukit/include/rtems/score/basedefs.h
> index 99fda67e8c..0cf7272b5d 100644
> --- a/cpukit/include/rtems/score/basedefs.h
> +++ b/cpukit/include/rtems/score/basedefs.h
> @@ -999,11 +999,12 @@ extern "C" {
>   *
>   * @param _value is the value of the symbol.  On the value a macro expansion 
> is
>   *   performed and afterwards it is stringified.  It shall expand to an 
> integer
> - *   expression understood by the assembler.
> + *   expression understood by the assembler.  The value shall be 
> representable
> + *   in the code model of the target architecture.
>   *
>   * This macro shall be placed at file scope.
>   */
> -#if defined(__USER_LABEL_PREFIX__)
> +#if defined(__GNUC__)
>#define RTEMS_DEFINE_GLOBAL_SYMBOL( _name, _value ) \
>  __asm__( \
>"\t.globl " RTEMS_XSTRING( RTEMS_SYMBOL_NAME( _name ) ) \
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 1/2] score: Fix RTEMS_DEFINE_GLOBAL_SYMBOL()

[Sebastian Huber]

The availability of a proper RTEMS_DEFINE_GLOBAL_SYMBOL() implementation
depends on __asm__() and thus __GNUC__.

Clarify documentation.

Update #4953.
---
 cpukit/include/rtems/score/basedefs.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/cpukit/include/rtems/score/basedefs.h 
b/cpukit/include/rtems/score/basedefs.h
index 99fda67e8c..0cf7272b5d 100644
--- a/cpukit/include/rtems/score/basedefs.h
+++ b/cpukit/include/rtems/score/basedefs.h
@@ -999,11 +999,12 @@ extern "C" {
  *
  * @param _value is the value of the symbol.  On the value a macro expansion is
  *   performed and afterwards it is stringified.  It shall expand to an integer
- *   expression understood by the assembler.
+ *   expression understood by the assembler.  The value shall be representable
+ *   in the code model of the target architecture.
  *
  * This macro shall be placed at file scope.
  */
-#if defined(__USER_LABEL_PREFIX__)
+#if defined(__GNUC__)
   #define RTEMS_DEFINE_GLOBAL_SYMBOL( _name, _value ) \
 __asm__( \
   "\t.globl " RTEMS_XSTRING( RTEMS_SYMBOL_NAME( _name ) ) \
-- 
2.35.3

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel