Re: [PATCH 1/7] bsps: Remove unused memcpy() implementations

2018-03-12 Thread Chris Johns 
Thank you for these changes, I have one small question ...

On 12/03/2018 21:25, Sebastian Huber wrote:
> Update #3285.

The patch makes sense once I looked up the ticket. Would it be possible to have
in the body of the commit message:

 Reorganize BSP source directory
 Update #3285.

?

If I have a git repo and I am reviewing the log having the context of the ticket
makes the process simpler and faster and my old brain does not have to hold all
the ticket numbers in it to make sense of the history via the log.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 1/7] bsps: Remove unused memcpy() implementations

2018-03-12 Thread Sebastian Huber 
Update #3285.
---
 c/src/lib/libcpu/lm32/Makefile.am   | 18 ---
 c/src/lib/libcpu/lm32/configure.ac  | 35 -
 c/src/lib/libcpu/lm32/shared/misc/memcpy.c  | 21 -
 c/src/lib/libcpu/nios2/Makefile.am  | 18 ---
 c/src/lib/libcpu/nios2/configure.ac | 35 -
 c/src/lib/libcpu/nios2/shared/misc/memcpy.c | 21 -
 6 files changed, 148 deletions(-)
 delete mode 100644 c/src/lib/libcpu/lm32/Makefile.am
 delete mode 100644 c/src/lib/libcpu/lm32/configure.ac
 delete mode 100644 c/src/lib/libcpu/lm32/shared/misc/memcpy.c
 delete mode 100644 c/src/lib/libcpu/nios2/Makefile.am
 delete mode 100644 c/src/lib/libcpu/nios2/configure.ac
 delete mode 100644 c/src/lib/libcpu/nios2/shared/misc/memcpy.c

diff --git a/c/src/lib/libcpu/lm32/Makefile.am 
b/c/src/lib/libcpu/lm32/Makefile.am
deleted file mode 100644
index 7c1ce064d5..00
--- a/c/src/lib/libcpu/lm32/Makefile.am
+++ /dev/null
@@ -1,18 +0,0 @@
-ACLOCAL_AMFLAGS = -I ../../../aclocal
-
-include $(top_srcdir)/../../../automake/compile.am
-
-CLEANFILES =
-DISTCLEANFILES =
-noinst_PROGRAMS =
-
-if shared
-## shared/misc
-noinst_PROGRAMS += shared/misc.rel
-shared_misc_rel_SOURCES = shared/misc/memcpy.c
-shared_misc_rel_CPPFLAGS = $(AM_CPPFLAGS) $(LM32_CPPFLAGS)
-shared_misc_rel_LDFLAGS = $(RTEMS_RELLDFLAGS)
-endif
-
-
-include $(top_srcdir)/../../../automake/local.am
diff --git a/c/src/lib/libcpu/lm32/configure.ac 
b/c/src/lib/libcpu/lm32/configure.ac
deleted file mode 100644
index 295ae91ee2..00
--- a/c/src/lib/libcpu/lm32/configure.ac
+++ /dev/null
@@ -1,35 +0,0 @@
-## Process this file with autoconf to produce a configure script.
-
-AC_PREREQ([2.69])
-AC_INIT([rtems-c-src-lib-libcpu-lm32],[_RTEMS_VERSION],[https://devel.rtems.org/newticket])
-RTEMS_TOP([../../../../..],[../../..])
-RTEMS_SOURCE_TOP
-RTEMS_BUILD_TOP
-
-RTEMS_CANONICAL_TARGET_CPU
-
-AM_INIT_AUTOMAKE([no-define foreign subdir-objects 1.12.2])
-AM_MAINTAINER_MODE
-
-RTEMS_ENV_RTEMSBSP
-
-RTEMS_PROJECT_ROOT
-
-RTEMS_PROG_CC_FOR_TARGET
-AM_PROG_CC_C_O
-RTEMS_CANONICALIZE_TOOLS
-RTEMS_PROG_CCAS
-
-# At this time all models should use the shared directory so do this
-AM_CONDITIONAL(shared, true)
-
-AC_PATH_PROG([AMPOLISH3],[ampolish3],[])
-AM_CONDITIONAL([AMPOLISH3],[test x"$USE_MAINTAINER_MODE" = x"yes" \
-  && test -n "$AMPOLISH3"])
-
-RTEMS_AMPOLISH3
-
-# Explicitly list all Makefiles here
-AC_CONFIG_FILES([Makefile
-])
-AC_OUTPUT
diff --git a/c/src/lib/libcpu/lm32/shared/misc/memcpy.c 
b/c/src/lib/libcpu/lm32/shared/misc/memcpy.c
deleted file mode 100644
index 5c5762d8cc..00
--- a/c/src/lib/libcpu/lm32/shared/misc/memcpy.c
+++ /dev/null
@@ -1,21 +0,0 @@
-/*
- *  C library memcpy routine
- *
- *  This routine shall get code to optimize performance on NIOS II
- *
- *  The routine is placed in this source directory to ensure that it
- *  is picked up by all applications.
- */
-
-#include 
-
-void *
-memcpy(void *s1, const void *s2, size_t n)
-{
-  char *p1 = s1;
-  const char *p2 = s2;
-  size_t left = n;
-
-  while(left > 0) *(p1++) = *(p2++);
-return s1;
-}
diff --git a/c/src/lib/libcpu/nios2/Makefile.am 
b/c/src/lib/libcpu/nios2/Makefile.am
deleted file mode 100644
index d5bfc578c3..00
--- a/c/src/lib/libcpu/nios2/Makefile.am
+++ /dev/null
@@ -1,18 +0,0 @@
-ACLOCAL_AMFLAGS = -I ../../../aclocal
-
-include $(top_srcdir)/../../../automake/compile.am
-
-CLEANFILES =
-DISTCLEANFILES =
-noinst_PROGRAMS =
-
-if shared
-## shared/misc
-noinst_PROGRAMS += shared/misc.rel
-shared_misc_rel_SOURCES = shared/misc/memcpy.c
-shared_misc_rel_CPPFLAGS = $(AM_CPPFLAGS) $(NIOS2_CPPFLAGS)
-shared_misc_rel_LDFLAGS = $(RTEMS_RELLDFLAGS)
-endif
-
-
-include $(top_srcdir)/../../../automake/local.am
diff --git a/c/src/lib/libcpu/nios2/configure.ac 
b/c/src/lib/libcpu/nios2/configure.ac
deleted file mode 100644
index ce7fe1b4e9..00
--- a/c/src/lib/libcpu/nios2/configure.ac
+++ /dev/null
@@ -1,35 +0,0 @@
-## Process this file with autoconf to produce a configure script.
-
-AC_PREREQ([2.69])
-AC_INIT([rtems-c-src-lib-libcpu-nios2],[_RTEMS_VERSION],[https://devel.rtems.org/newticket])
-RTEMS_TOP([../../../../..],[../../..])
-RTEMS_SOURCE_TOP
-RTEMS_BUILD_TOP
-
-RTEMS_CANONICAL_TARGET_CPU
-
-AM_INIT_AUTOMAKE([no-define foreign subdir-objects 1.12.2])
-AM_MAINTAINER_MODE
-
-RTEMS_ENV_RTEMSBSP
-
-RTEMS_PROJECT_ROOT
-
-RTEMS_PROG_CC_FOR_TARGET
-AM_PROG_CC_C_O
-RTEMS_CANONICALIZE_TOOLS
-RTEMS_PROG_CCAS
-
-# At this time all models should use the shared directory so do this
-AM_CONDITIONAL(shared, true)
-
-AC_PATH_PROG([AMPOLISH3],[ampolish3],[])
-AM_CONDITIONAL([AMPOLISH3],[test x"$USE_MAINTAINER_MODE" = x"yes" \
-  && test -n "$AMPOLISH3"])
-
-RTEMS_AMPOLISH3
-
-# Explicitly list all Makefiles here
-AC_CONFIG_FILES([Makefile
-])
-AC_OUTPUT
diff --git a/c/src/lib/libcpu/nios2/shared/misc/memcpy.c 
b/c/src/lib/libcpu/nios2/shared/misc/memcpy.c
deleted file mode 100