Re: [PATCH 2/2] bsp/stm32f4.h: Remove double define
It's on line 131. Both defines are referring to the same address (0x40023C00) --one define just starts from STM32F4_BASE and the other from STM32F4_AHB1_BASE. On 19.10.22 14:46, Joel Sherrill wrote: Looks ok but where was the other one? On Wed, Oct 19, 2022, 5:57 AM Matthew Joyce wrote: From: Matt Joyce Remove double define of STM32F4_FLASH. --- bsps/arm/stm32f4/include/bsp/stm32f4.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/bsps/arm/stm32f4/include/bsp/stm32f4.h b/bsps/arm/stm32f4/include/bsp/stm32f4.h index 7f84480ece..3b1f9ff9ba 100644 --- a/bsps/arm/stm32f4/include/bsp/stm32f4.h +++ b/bsps/arm/stm32f4/include/bsp/stm32f4.h @@ -54,16 +54,6 @@ /** @} */ -/** - * @name STM32F4 FLASH - * @{ - */ - -#include -#define STM32F4_FLASH ((volatile stm32f4_flash *) (STM32F4_BASE + 0x40023C00)) - -/** @} */ - #include /** -- 2.31.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel -- embedded brains GmbH Herr Matthew JOYCE Dornierstr. 4 82178 Puchheim Germany ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 2/2] bsp/stm32f4.h: Remove double define
Looks ok but where was the other one? On Wed, Oct 19, 2022, 5:57 AM Matthew Joyce < matthew.jo...@embedded-brains.de> wrote: > From: Matt Joyce > > Remove double define of STM32F4_FLASH. > --- > bsps/arm/stm32f4/include/bsp/stm32f4.h | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/bsps/arm/stm32f4/include/bsp/stm32f4.h > b/bsps/arm/stm32f4/include/bsp/stm32f4.h > index 7f84480ece..3b1f9ff9ba 100644 > --- a/bsps/arm/stm32f4/include/bsp/stm32f4.h > +++ b/bsps/arm/stm32f4/include/bsp/stm32f4.h > @@ -54,16 +54,6 @@ > > /** @} */ > > -/** > - * @name STM32F4 FLASH > - * @{ > - */ > - > -#include > -#define STM32F4_FLASH ((volatile stm32f4_flash *) (STM32F4_BASE + > 0x40023C00)) > - > -/** @} */ > - > #include > > /** > -- > 2.31.1 > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH 2/2] bsp/stm32f4.h: Remove double define
From: Matt Joyce Remove double define of STM32F4_FLASH. --- bsps/arm/stm32f4/include/bsp/stm32f4.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/bsps/arm/stm32f4/include/bsp/stm32f4.h b/bsps/arm/stm32f4/include/bsp/stm32f4.h index 7f84480ece..3b1f9ff9ba 100644 --- a/bsps/arm/stm32f4/include/bsp/stm32f4.h +++ b/bsps/arm/stm32f4/include/bsp/stm32f4.h @@ -54,16 +54,6 @@ /** @} */ -/** - * @name STM32F4 FLASH - * @{ - */ - -#include -#define STM32F4_FLASH ((volatile stm32f4_flash *) (STM32F4_BASE + 0x40023C00)) - -/** @} */ - #include /** -- 2.31.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel