Re: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-04-14 Thread Gedare Bloom 
looks good.

On Wed, Apr 14, 2021 at 9:33 AM Joel Sherrill  wrote:
>
> I'll pick on you. :)
>
> Please don't use the "title" that says "Fix ABC". There has to be a better 
> description.
>
> Hopefully someone will ack the technical. I think it is right.
>
> --joel
>
> On Wed, Apr 14, 2021 at 9:20 AM Ryan Long  wrote:
>>
>> ping
>>
>> -Original Message-
>> From: Ryan Long 
>> Sent: Friday, March 12, 2021 8:56 AM
>> To: devel@rtems.org
>> Cc: Ryan Long 
>> Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID 
>> #1399709)
>>
>> CID 1399709: Dereference after null check in 
>> rtems_trace_buffering_shell_save().
>>
>> Closes #4329
>> ---
>>  cpukit/libmisc/shell/main_rtrace.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/cpukit/libmisc/shell/main_rtrace.c 
>> b/cpukit/libmisc/shell/main_rtrace.c
>> index 753ab9d..e4f59c4 100644
>> --- a/cpukit/libmisc/shell/main_rtrace.c
>> +++ b/cpukit/libmisc/shell/main_rtrace.c
>> @@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char *argv[])
>>{
>>  close (out);
>>  printf ("error: no memory\n");
>> +return 1;
>>}
>>
>>memset (buf, 0, SAVE_BUF_SIZE);
>> --
>> 1.8.3.1
>>
>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-04-14 Thread Joel Sherrill 
I'll pick on you. :)

Please don't use the "title" that says "Fix ABC". There has to be a better
description.

Hopefully someone will ack the technical. I think it is right.

--joel

On Wed, Apr 14, 2021 at 9:20 AM Ryan Long  wrote:

> ping
>
> -Original Message-
> From: Ryan Long 
> Sent: Friday, March 12, 2021 8:56 AM
> To: devel@rtems.org
> Cc: Ryan Long 
> Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID
> #1399709)
>
> CID 1399709: Dereference after null check in
> rtems_trace_buffering_shell_save().
>
> Closes #4329
> ---
>  cpukit/libmisc/shell/main_rtrace.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cpukit/libmisc/shell/main_rtrace.c
> b/cpukit/libmisc/shell/main_rtrace.c
> index 753ab9d..e4f59c4 100644
> --- a/cpukit/libmisc/shell/main_rtrace.c
> +++ b/cpukit/libmisc/shell/main_rtrace.c
> @@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char
> *argv[])
>{
>  close (out);
>  printf ("error: no memory\n");
> +return 1;
>}
>
>memset (buf, 0, SAVE_BUF_SIZE);
> --
> 1.8.3.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

RE: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-04-14 Thread Ryan Long 
ping

-Original Message-
From: Ryan Long  
Sent: Friday, March 12, 2021 8:56 AM
To: devel@rtems.org
Cc: Ryan Long 
Subject: [PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID 
#1399709)

CID 1399709: Dereference after null check in rtems_trace_buffering_shell_save().

Closes #4329
---
 cpukit/libmisc/shell/main_rtrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cpukit/libmisc/shell/main_rtrace.c 
b/cpukit/libmisc/shell/main_rtrace.c
index 753ab9d..e4f59c4 100644
--- a/cpukit/libmisc/shell/main_rtrace.c
+++ b/cpukit/libmisc/shell/main_rtrace.c
@@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char *argv[])
   {
 close (out);
 printf ("error: no memory\n");
+return 1;
   }
 
   memset (buf, 0, SAVE_BUF_SIZE);
--
1.8.3.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 2/2] main_rtrace.c: Fix Dereference after null check (CID #1399709)

2021-03-12 Thread Ryan Long 
CID 1399709: Dereference after null check in
rtems_trace_buffering_shell_save().

Closes #4329
---
 cpukit/libmisc/shell/main_rtrace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cpukit/libmisc/shell/main_rtrace.c 
b/cpukit/libmisc/shell/main_rtrace.c
index 753ab9d..e4f59c4 100644
--- a/cpukit/libmisc/shell/main_rtrace.c
+++ b/cpukit/libmisc/shell/main_rtrace.c
@@ -473,6 +473,7 @@ rtems_trace_buffering_shell_save (int argc, char *argv[])
   {
 close (out);
 printf ("error: no memory\n");
+return 1;
   }
 
   memset (buf, 0, SAVE_BUF_SIZE);
-- 
1.8.3.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel