Re: [PATCH 2/3] cpukit: Change _COMPILING_NEWLIB to _LIBC for helper functions decls
On 15/6/2022 2:42 am, Joel Sherrill wrote: > This is OK. Changed in newlib here: > > commit 6226bad0eafe762b811c62d1dc096bc0858b0d1a > Author: Mike Frysinger mailto:vap...@gentoo.org>> > Date: Mon Nov 8 22:22:27 2021 -0500 > > change _COMPILING_NEWLIB to _LIBC > > Use the same name as glibc & gnulib to indicate "newlib itself is > being compiled". This also harmonizes the codebase a bit in that > _LIBC was already used in places instead of _COMPILING_NEWLIB. > > Building for bfin-elf, mips-elf, and x86_64-pc-cygwin produces > the same object code. Thanks. I found another ... cpukit/libcsupport/src/__gettod.c:#define _COMPILING_NEWLIB I will update the patch. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 2/3] cpukit: Change _COMPILING_NEWLIB to _LIBC for helper functions decls
This is OK. Changed in newlib here: commit 6226bad0eafe762b811c62d1dc096bc0858b0d1a Author: Mike Frysinger Date: Mon Nov 8 22:22:27 2021 -0500 change _COMPILING_NEWLIB to _LIBC Use the same name as glibc & gnulib to indicate "newlib itself is being compiled". This also harmonizes the codebase a bit in that _LIBC was already used in places instead of _COMPILING_NEWLIB. Building for bfin-elf, mips-elf, and x86_64-pc-cygwin produces the same object code. On Mon, Jun 13, 2022 at 8:24 PM wrote: > From: Chris Johns > > Updates #4662 > --- > cpukit/libcsupport/src/__times.c | 4 ++-- > cpukit/posix/src/_execve.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/cpukit/libcsupport/src/__times.c > b/cpukit/libcsupport/src/__times.c > index 629a7bc633..14625b5aae 100644 > --- a/cpukit/libcsupport/src/__times.c > +++ b/cpukit/libcsupport/src/__times.c > @@ -38,9 +38,9 @@ > #endif > > /* > - * Needed to get the prototype for this newlib helper method > + * Needed to get the prototype for this libc helper method > */ > -#define _COMPILING_NEWLIB > +#define _LIBC > > #include > > diff --git a/cpukit/posix/src/_execve.c b/cpukit/posix/src/_execve.c > index 2858d13082..63afadec43 100644 > --- a/cpukit/posix/src/_execve.c > +++ b/cpukit/posix/src/_execve.c > @@ -43,9 +43,9 @@ > #endif > > /* > - * Needed to get the prototype for this newlib helper method > + * Needed to get the prototype for this libc helper method > */ > -#define _COMPILING_NEWLIB > +#define _LIBC > > #include > #include > -- > 2.19.1 > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
[PATCH 2/3] cpukit: Change _COMPILING_NEWLIB to _LIBC for helper functions decls
From: Chris Johns Updates #4662 --- cpukit/libcsupport/src/__times.c | 4 ++-- cpukit/posix/src/_execve.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cpukit/libcsupport/src/__times.c b/cpukit/libcsupport/src/__times.c index 629a7bc633..14625b5aae 100644 --- a/cpukit/libcsupport/src/__times.c +++ b/cpukit/libcsupport/src/__times.c @@ -38,9 +38,9 @@ #endif /* - * Needed to get the prototype for this newlib helper method + * Needed to get the prototype for this libc helper method */ -#define _COMPILING_NEWLIB +#define _LIBC #include diff --git a/cpukit/posix/src/_execve.c b/cpukit/posix/src/_execve.c index 2858d13082..63afadec43 100644 --- a/cpukit/posix/src/_execve.c +++ b/cpukit/posix/src/_execve.c @@ -43,9 +43,9 @@ #endif /* - * Needed to get the prototype for this newlib helper method + * Needed to get the prototype for this libc helper method */ -#define _COMPILING_NEWLIB +#define _LIBC #include #include -- 2.19.1 ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
