Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-15 Thread Gedare Bloom 
On Thu, Jun 9, 2022 at 12:09 AM Sebastian Huber
 wrote:
>
> On 08/06/2022 18:09, Joel Sherrill wrote:
> >
> > On Wed, Jun 8, 2022, 10:45 AM Gedare Bloom  > > wrote:
> >
> > Does this code have an upstream?
> >
> >
> > I tried to find it. Maybe whoever added it has memory of the source.
> >
> > As best I can tell, it is lightly or not maintained reference code.
>
> Maybe we should replace the libmd stuff with the latest code from
> OpenBSD or FreeBSD.
>
That would be good.

> --
> embedded brains GmbH
> Herr Sebastian HUBER
> Dornierstr. 4
> 82178 Puchheim
> Germany
> email: sebastian.hu...@embedded-brains.de
> phone: +49-89-18 94 741 - 16
> fax:   +49-89-18 94 741 - 08
>
> Registergericht: Amtsgericht München
> Registernummer: HRB 157899
> Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
> Unsere Datenschutzerklärung finden Sie hier:
> https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-09 Thread Sebastian Huber 

On 08/06/2022 18:09, Joel Sherrill wrote:


On Wed, Jun 8, 2022, 10:45 AM Gedare Bloom > wrote:


Does this code have an upstream?


I tried to find it. Maybe whoever added it has memory of the source.

As best I can tell, it is lightly or not maintained reference code.


Maybe we should replace the libmd stuff with the latest code from 
OpenBSD or FreeBSD.


--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Joel Sherrill 
On Wed, Jun 8, 2022, 10:45 AM Gedare Bloom  wrote:

> Does this code have an upstream?
>

I tried to find it. Maybe whoever added it has memory of the source.

As best I can tell, it is lightly or not maintained reference code.



> On Wed, Jun 8, 2022 at 7:35 AM Matthew Joyce
>  wrote:
> >
> > From: Matt Joyce 
> >
> > Specify array size in parameter to match function prototype. This
> > fixes a new warning in gcc 12.
> > ---
> >  cpukit/libmd/md5.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/cpukit/libmd/md5.c b/cpukit/libmd/md5.c
> > index 4c909f37a0..5e3a100c7b 100644
> > --- a/cpukit/libmd/md5.c
> > +++ b/cpukit/libmd/md5.c
> > @@ -165,7 +165,7 @@ void MD5Update (
> > ends with the desired message digest in mdContext->digest[0...15].
> >   */
> >  void MD5Final (
> > -  unsigned char hash[],
> > +  unsigned char hash[16],
> >MD5_CTX *mdContext )
> >  {
> >UINT4 in[16];
> > --
> > 2.31.1
> >
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Gedare Bloom 
Does this code have an upstream?

On Wed, Jun 8, 2022 at 7:35 AM Matthew Joyce
 wrote:
>
> From: Matt Joyce 
>
> Specify array size in parameter to match function prototype. This
> fixes a new warning in gcc 12.
> ---
>  cpukit/libmd/md5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cpukit/libmd/md5.c b/cpukit/libmd/md5.c
> index 4c909f37a0..5e3a100c7b 100644
> --- a/cpukit/libmd/md5.c
> +++ b/cpukit/libmd/md5.c
> @@ -165,7 +165,7 @@ void MD5Update (
> ends with the desired message digest in mdContext->digest[0...15].
>   */
>  void MD5Final (
> -  unsigned char hash[],
> +  unsigned char hash[16],
>MD5_CTX *mdContext )
>  {
>UINT4 in[16];
> --
> 2.31.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH 3/5] cpukit/libmd/md5.c: fix warning

2022-06-08 Thread Matthew Joyce 
From: Matt Joyce 

Specify array size in parameter to match function prototype. This
fixes a new warning in gcc 12.
---
 cpukit/libmd/md5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cpukit/libmd/md5.c b/cpukit/libmd/md5.c
index 4c909f37a0..5e3a100c7b 100644
--- a/cpukit/libmd/md5.c
+++ b/cpukit/libmd/md5.c
@@ -165,7 +165,7 @@ void MD5Update (
ends with the desired message digest in mdContext->digest[0...15].
  */
 void MD5Final (
-  unsigned char hash[],
+  unsigned char hash[16],
   MD5_CTX *mdContext )
 {
   UINT4 in[16];
-- 
2.31.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel