Re: [PATCH 4/5] bsps: Add xilinx_zynq_rpu BSP variant

2024-03-22 Thread Kinsey Moore
This patch looks good.

Kinsey

On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber <
sebastian.hu...@embedded-brains.de> wrote:

> Add a BSP variant without a board-specific name.
> ---
>  .../arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml   | 87 +--
>  .../bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml | 17 
>  spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml | 69 +++
>  spec/build/bsps/arm/xilinx-zynqmp-rpu/obj.yml | 42 +
>  4 files changed, 132 insertions(+), 83 deletions(-)
>  create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
>  create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
>  create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/obj.yml
>
> diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
> b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
> index 3fa210d8e7..f6c228c79d 100644
> --- a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
> +++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
> @@ -8,89 +8,10 @@ copyrights:
>  cppflags: []
>  enabled-by: true
>  family: xilinx-zynqmp-rpu
> -includes:
> -- bsps/include/xil/
> -- bsps/include/xil/${XIL_SUPPORT_PATH}/
> -install:
> -- destination: ${BSP_INCLUDEDIR}
> -  source:
> -  - bsps/arm/xilinx-zynqmp-rpu/include/bsp.h
> -- destination: ${BSP_INCLUDEDIR}/bsp
> -  source:
> -  - bsps/arm/xilinx-zynqmp-rpu/include/bsp/irq.h
> -- destination: ${BSP_INCLUDEDIR}/peripheral_maps
> -  source:
> -  - bsps/include/peripheral_maps/xilinx_zynqmp.h
> +includes: []
> +install: []
>  links:
>  - role: build-dependency
> -  uid: ../grp
> -- role: build-dependency
> -  uid: ../start
> -- role: build-dependency
> -  uid: abi
> -- role: build-dependency
> -  uid: optclkfastidle
> -- role: build-dependency
> -  uid: optclkuart
> -- role: build-dependency
> -  uid: optconirq
> -- role: build-dependency
> -  uid: ../../optconminor
> -- role: build-dependency
> -  uid: optint0len
> -- role: build-dependency
> -  uid: optint0ori
> -- role: build-dependency
> -  uid: optint1len
> -- role: build-dependency
> -  uid: optint1ori
> -- role: build-dependency
> -  uid: optramlen
> -- role: build-dependency
> -  uid: optramori
> -- role: build-dependency
> -  uid: optresetvec
> -- role: build-dependency
> -  uid: optnocachelen
> -- role: build-dependency
> -  uid: ../../obj
> -- role: build-dependency
> -  uid: ../../objirq
> -- role: build-dependency
> -  uid: ../../objdevserialzynq
> -- role: build-dependency
> -  uid: ../../objdevspizynq
> -- role: build-dependency
> -  uid: ../../objdevspixil
> -- role: build-dependency
> -  uid: ../../objmem
> -- role: build-dependency
> -  uid: ../../opto0
> -- role: build-dependency
> -  uid: linkcmds
> -- role: build-dependency
> -  uid: ../../bspopts
> -- role: build-dependency
> -  uid: ../../objxilinxsupport
> -source:
> -- bsps/shared/cache/nocache.c
> -- bsps/arm/shared/cp15/arm-cp15-set-exception-handler.c
> -- bsps/arm/shared/cp15/arm-cp15-set-ttb-entries.c
> -- bsps/arm/shared/start/bsp-start-memcpy.S
> -- bsps/arm/xilinx-zynqmp-rpu/console/console-config.c
> -- bsps/arm/xilinx-zynqmp-rpu/start/bspreset.c
> -- bsps/arm/xilinx-zynqmp-rpu/start/bspstart.c
> -- bsps/arm/xilinx-zynqmp-rpu/start/bspstarthooks.c
> -- bsps/arm/xilinx-zynqmp-rpu/start/bspstartmpu.c
> -- bsps/shared/dev/clock/xil-ttc.c
> -- bsps/shared/dev/btimer/btimer-cpucounter.c
> -- bsps/shared/dev/getentropy/getentropy-cpucounter.c
> -- bsps/shared/dev/irq/arm-gicv2.c
> -- bsps/shared/dev/irq/arm-gicv2-zynqmp.c
> -- bsps/shared/dev/serial/console-termios.c
> -- bsps/shared/irq/irq-default-handler.c
> -- bsps/shared/start/bspfatal-default.c
> -- bsps/shared/start/gettargethash-default.c
> -- bsps/shared/start/sbrk.c
> -- bsps/shared/start/stackalloc.c
> +  uid: grp
> +source: []
>  type: build
> diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
> b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
> new file mode 100644
> index 00..d4073d8248
> --- /dev/null
> +++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
> @@ -0,0 +1,17 @@
> +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> +arch: arm
> +bsp: xilinx_zynqmp_rpu
> +build-type: bsp
> +cflags: []
> +copyrights:
> +- Copyright (C) 2024 embedded brains GmbH
> +cppflags: []
> +enabled-by: true
> +family: xilinx-zynqmp-rpu
> +includes: []
> +install: []
> +links:
> +- role: build-dependency
> +  uid: grp
> +source: []
> +type: build
> diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
> b/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
> new file mode 100644
> index 00..b886948d47
> --- /dev/null
> +++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
> @@ -0,0 +1,69 @@
> +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
> +build-type: group
> +cflags: []
> +copyrights:
> +- Copyright (C) 2023 Reflex Aerospace GmbH
> +cppflags: []
> +cxxflags: []
> +enabled-by: true
> +includes:
> +- bsps/include/xil
> +- bsps/include/xil/${XIL_SUPPORT_PATH}
> +install: []
> +ldflags: []
> 

[PATCH 4/5] bsps: Add xilinx_zynq_rpu BSP variant

2024-03-18 Thread Sebastian Huber
Add a BSP variant without a board-specific name.
---
 .../arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml   | 87 +--
 .../bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml | 17 
 spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml | 69 +++
 spec/build/bsps/arm/xilinx-zynqmp-rpu/obj.yml | 42 +
 4 files changed, 132 insertions(+), 83 deletions(-)
 create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
 create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
 create mode 100644 spec/build/bsps/arm/xilinx-zynqmp-rpu/obj.yml

diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml 
b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
index 3fa210d8e7..f6c228c79d 100644
--- a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
+++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bspmercuryxu5.yml
@@ -8,89 +8,10 @@ copyrights:
 cppflags: []
 enabled-by: true
 family: xilinx-zynqmp-rpu
-includes:
-- bsps/include/xil/
-- bsps/include/xil/${XIL_SUPPORT_PATH}/
-install:
-- destination: ${BSP_INCLUDEDIR}
-  source:
-  - bsps/arm/xilinx-zynqmp-rpu/include/bsp.h
-- destination: ${BSP_INCLUDEDIR}/bsp
-  source:
-  - bsps/arm/xilinx-zynqmp-rpu/include/bsp/irq.h
-- destination: ${BSP_INCLUDEDIR}/peripheral_maps
-  source:
-  - bsps/include/peripheral_maps/xilinx_zynqmp.h
+includes: []
+install: []
 links:
 - role: build-dependency
-  uid: ../grp
-- role: build-dependency
-  uid: ../start
-- role: build-dependency
-  uid: abi
-- role: build-dependency
-  uid: optclkfastidle
-- role: build-dependency
-  uid: optclkuart
-- role: build-dependency
-  uid: optconirq
-- role: build-dependency
-  uid: ../../optconminor
-- role: build-dependency
-  uid: optint0len
-- role: build-dependency
-  uid: optint0ori
-- role: build-dependency
-  uid: optint1len
-- role: build-dependency
-  uid: optint1ori
-- role: build-dependency
-  uid: optramlen
-- role: build-dependency
-  uid: optramori
-- role: build-dependency
-  uid: optresetvec
-- role: build-dependency
-  uid: optnocachelen
-- role: build-dependency
-  uid: ../../obj
-- role: build-dependency
-  uid: ../../objirq
-- role: build-dependency
-  uid: ../../objdevserialzynq
-- role: build-dependency
-  uid: ../../objdevspizynq
-- role: build-dependency
-  uid: ../../objdevspixil
-- role: build-dependency
-  uid: ../../objmem
-- role: build-dependency
-  uid: ../../opto0
-- role: build-dependency
-  uid: linkcmds
-- role: build-dependency
-  uid: ../../bspopts
-- role: build-dependency
-  uid: ../../objxilinxsupport
-source:
-- bsps/shared/cache/nocache.c
-- bsps/arm/shared/cp15/arm-cp15-set-exception-handler.c
-- bsps/arm/shared/cp15/arm-cp15-set-ttb-entries.c
-- bsps/arm/shared/start/bsp-start-memcpy.S
-- bsps/arm/xilinx-zynqmp-rpu/console/console-config.c
-- bsps/arm/xilinx-zynqmp-rpu/start/bspreset.c
-- bsps/arm/xilinx-zynqmp-rpu/start/bspstart.c
-- bsps/arm/xilinx-zynqmp-rpu/start/bspstarthooks.c
-- bsps/arm/xilinx-zynqmp-rpu/start/bspstartmpu.c
-- bsps/shared/dev/clock/xil-ttc.c
-- bsps/shared/dev/btimer/btimer-cpucounter.c
-- bsps/shared/dev/getentropy/getentropy-cpucounter.c
-- bsps/shared/dev/irq/arm-gicv2.c
-- bsps/shared/dev/irq/arm-gicv2-zynqmp.c
-- bsps/shared/dev/serial/console-termios.c
-- bsps/shared/irq/irq-default-handler.c
-- bsps/shared/start/bspfatal-default.c
-- bsps/shared/start/gettargethash-default.c
-- bsps/shared/start/sbrk.c
-- bsps/shared/start/stackalloc.c
+  uid: grp
+source: []
 type: build
diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml 
b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
new file mode 100644
index 00..d4073d8248
--- /dev/null
+++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/bsprpu.yml
@@ -0,0 +1,17 @@
+SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
+arch: arm
+bsp: xilinx_zynqmp_rpu
+build-type: bsp
+cflags: []
+copyrights:
+- Copyright (C) 2024 embedded brains GmbH
+cppflags: []
+enabled-by: true
+family: xilinx-zynqmp-rpu
+includes: []
+install: []
+links:
+- role: build-dependency
+  uid: grp
+source: []
+type: build
diff --git a/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml 
b/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
new file mode 100644
index 00..b886948d47
--- /dev/null
+++ b/spec/build/bsps/arm/xilinx-zynqmp-rpu/grp.yml
@@ -0,0 +1,69 @@
+SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause
+build-type: group
+cflags: []
+copyrights:
+- Copyright (C) 2023 Reflex Aerospace GmbH
+cppflags: []
+cxxflags: []
+enabled-by: true
+includes:
+- bsps/include/xil
+- bsps/include/xil/${XIL_SUPPORT_PATH}
+install: []
+ldflags: []
+links:
+- role: build-dependency
+  uid: ../grp
+- role: build-dependency
+  uid: ../start
+- role: build-dependency
+  uid: abi
+- role: build-dependency
+  uid: optclkfastidle
+- role: build-dependency
+  uid: optclkuart
+- role: build-dependency
+  uid: optconirq
+- role: build-dependency
+  uid: ../../optconminor
+- role: build-dependency
+  uid: optint0len
+- role: build-dependency
+  uid: optint0ori
+- role: build-dependen