Re: [PATCH rtems-libbsd 2/2] builder.py: Only disable tests if they are there

[Christian Mauderer]

On 15/06/2021 17:11, Gedare Bloom wrote:

ok


Thanks.



On Fri, Jun 11, 2021 at 6:20 AM Christian Mauderer  wrote:


For checking the dependencies, the tests are removed. But if the tests
are not enabled at all, that triggers a python exception.
---
  builder.py | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/builder.py b/builder.py
index cbe5dc59..a34a1518 100755
--- a/builder.py
+++ b/builder.py
@@ -1062,7 +1062,8 @@ class ModuleManager(object):

  def _checkDependencies(self):
  enabled_modules = self.getEnabledModules()
-enabled_modules.remove('tests')
+if 'tests' in enabled_modules:
+enabled_modules.remove('tests')
  for mod in enabled_modules:
  if mod not in self.modules:
  raise KeyError('enabled module not found: %s' % (mod))
--
2.32.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel



___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems-libbsd 2/2] builder.py: Only disable tests if they are there

[Gedare Bloom]

ok

On Fri, Jun 11, 2021 at 6:20 AM Christian Mauderer  wrote:
>
> For checking the dependencies, the tests are removed. But if the tests
> are not enabled at all, that triggers a python exception.
> ---
>  builder.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/builder.py b/builder.py
> index cbe5dc59..a34a1518 100755
> --- a/builder.py
> +++ b/builder.py
> @@ -1062,7 +1062,8 @@ class ModuleManager(object):
>
>  def _checkDependencies(self):
>  enabled_modules = self.getEnabledModules()
> -enabled_modules.remove('tests')
> +if 'tests' in enabled_modules:
> +enabled_modules.remove('tests')
>  for mod in enabled_modules:
>  if mod not in self.modules:
>  raise KeyError('enabled module not found: %s' % (mod))
> --
> 2.32.0
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH rtems-libbsd 2/2] builder.py: Only disable tests if they are there

[Christian Mauderer]

For checking the dependencies, the tests are removed. But if the tests
are not enabled at all, that triggers a python exception.
---
 builder.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/builder.py b/builder.py
index cbe5dc59..a34a1518 100755
--- a/builder.py
+++ b/builder.py
@@ -1062,7 +1062,8 @@ class ModuleManager(object):
 
 def _checkDependencies(self):
 enabled_modules = self.getEnabledModules()
-enabled_modules.remove('tests')
+if 'tests' in enabled_modules:
+enabled_modules.remove('tests')
 for mod in enabled_modules:
 if mod not in self.modules:
 raise KeyError('enabled module not found: %s' % (mod))
-- 
2.32.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel