Re: [PATCH rtems-source-builder] dtc: Add patch to build for ticket 4783
Sorry, I'll make sure to avoid this going forward. Kinsey On Mon, Jan 30, 2023 at 5:41 PM Chris Johns wrote: > On 31/1/2023 10:23 am, Kinsey Moore wrote: > > On 1/30/2023 5:13 PM, Chris Johns wrote: > >> Can the subject please be: > >> > >> dtc: Add patch to build for cygwin builds > >> > >> ? > > > > Unfortunately, Joel pushed this and a tools hash bump along with the > other two > > patches, so that would require rewriting history. > > That is a shame. We should limit references to tickets to the body of a > commit > message and not the subject line. I needed to inspect the ticket to > determine > what the change was about. > > Chris > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH rtems-source-builder] dtc: Add patch to build for ticket 4783
On 31/1/2023 10:23 am, Kinsey Moore wrote: > On 1/30/2023 5:13 PM, Chris Johns wrote: >> Can the subject please be: >> >> dtc: Add patch to build for cygwin builds >> >> ? > > Unfortunately, Joel pushed this and a tools hash bump along with the other two > patches, so that would require rewriting history. That is a shame. We should limit references to tickets to the body of a commit message and not the subject line. I needed to inspect the ticket to determine what the change was about. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH rtems-source-builder] dtc: Add patch to build for ticket 4783
On 1/30/2023 5:13 PM, Chris Johns wrote: Can the subject please be: dtc: Add patch to build for cygwin builds ? Unfortunately, Joel pushed this and a tools hash bump along with the other two patches, so that would require rewriting history. Kinsey ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH rtems-source-builder] dtc: Add patch to build for ticket 4783
Can the subject please be:
dtc: Add patch to build for cygwin builds
?
Chris
On 31/1/2023 4:30 am, Kinsey Moore wrote:
> This patch resolves a build error with dtc on cygwin until upstream
> adopts a fix.
> ---
> bare/config/devel/dtc-1.6.1-1.cfg | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/bare/config/devel/dtc-1.6.1-1.cfg
> b/bare/config/devel/dtc-1.6.1-1.cfg
> index 54aed09..acf2cd8 100644
> --- a/bare/config/devel/dtc-1.6.1-1.cfg
> +++ b/bare/config/devel/dtc-1.6.1-1.cfg
> @@ -12,6 +12,9 @@
>
> %hash sha256 dtc-%{dtc_version}.tar.gz
> 38a6257f2c23cb9dfa1781ac4ad122d8358e1a22d33b2da0eb492c190644a376
>
> +%patch add dtc
> https://devel.rtems.org/raw-attachment/ticket/4783/0001-checks.c-Ensure-argument-is-an-integer-v2.patch
> +%hash sha256 0001-checks.c-Ensure-argument-is-an-integer-v2.patch
> dd83c10326188732ac26c1fd8dce70b796a7dde204b31c67cf4d04f29ed4dfef
> +
> #
> # The DTC build instructions. We use 1.x.x Release 1.
> #
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
[PATCH rtems-source-builder] dtc: Add patch to build for ticket 4783
This patch resolves a build error with dtc on cygwin until upstream
adopts a fix.
---
bare/config/devel/dtc-1.6.1-1.cfg | 3 +++
1 file changed, 3 insertions(+)
diff --git a/bare/config/devel/dtc-1.6.1-1.cfg
b/bare/config/devel/dtc-1.6.1-1.cfg
index 54aed09..acf2cd8 100644
--- a/bare/config/devel/dtc-1.6.1-1.cfg
+++ b/bare/config/devel/dtc-1.6.1-1.cfg
@@ -12,6 +12,9 @@
%hash sha256 dtc-%{dtc_version}.tar.gz
38a6257f2c23cb9dfa1781ac4ad122d8358e1a22d33b2da0eb492c190644a376
+%patch add dtc
https://devel.rtems.org/raw-attachment/ticket/4783/0001-checks.c-Ensure-argument-is-an-integer-v2.patch
+%hash sha256 0001-checks.c-Ensure-argument-is-an-integer-v2.patch
dd83c10326188732ac26c1fd8dce70b796a7dde204b31c67cf4d04f29ed4dfef
+
#
# The DTC build instructions. We use 1.x.x Release 1.
#
--
2.30.2
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
