Re: [PATCH v2] psxtests: Fix math function build warnings
Please see my prior email on the first version of this patch, and address those comments. Thanks On Thu, Mar 18, 2021 at 11:31 AM Stephen Clark wrote: > > Added conditionals to ensure that long double function tests were only > built when newlib has long double math functions. > --- > testsuites/psxtests/psxhdrs/math/acoshl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/acosl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/asinhl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/asinl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/atan2l.c| 3 +++ > testsuites/psxtests/psxhdrs/math/atanhl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/atanl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/cbrtl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/ceill.c | 3 +++ > testsuites/psxtests/psxhdrs/math/copysignl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/coshl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/cosl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/erfcl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/erfl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/exp2l.c | 3 +++ > testsuites/psxtests/psxhdrs/math/expl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/expm1l.c| 3 +++ > testsuites/psxtests/psxhdrs/math/fabsl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/fdiml.c | 3 +++ > testsuites/psxtests/psxhdrs/math/floorl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/fmal.c | 3 +++ > testsuites/psxtests/psxhdrs/math/fmaxl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/fminl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/fmodl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/frexpl.c| 3 +++ > .../psxtests/psxhdrs/math/has_long_double.h | 16 > testsuites/psxtests/psxhdrs/math/hypotl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/ilogbl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/ldexpl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/lgammal.c | 3 +++ > testsuites/psxtests/psxhdrs/math/llrintl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/llroundl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/log10l.c| 3 +++ > testsuites/psxtests/psxhdrs/math/log1pl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/log2l.c | 3 +++ > testsuites/psxtests/psxhdrs/math/logbl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/logl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/lrintl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/lroundl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/modfl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/nanl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/nearbyintl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/nextafterl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/nexttoward.c| 3 +++ > testsuites/psxtests/psxhdrs/math/nexttowardf.c | 3 +++ > testsuites/psxtests/psxhdrs/math/nexttowardl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/powl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/remainderl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/remquol.c | 3 +++ > testsuites/psxtests/psxhdrs/math/rintl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/roundl.c| 3 +++ > testsuites/psxtests/psxhdrs/math/scalblnl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/scalbnl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/sinhl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/sinl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/sqrtl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/tanhl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/tanl.c | 3 +++ > testsuites/psxtests/psxhdrs/math/tgammal.c | 3 +++ > testsuites/psxtests/psxhdrs/math/truncl.c| 3 +++ > 60 files changed, 193 insertions(+) > create mode 100644 testsuites/psxtests/psxhdrs/math/has_long_double.h > > diff --git a/testsuites/psxtests/psxhdrs/math/acoshl.c > b/testsuites/psxtests/psxhdrs/math/acoshl.c > index b6bf0bd16c..fd25a3a1e4 100644 > --- a/testsuites/psxtests/psxhdrs/math/acoshl.c > +++ b/testsuites/psxtests/psxhdrs/math/acoshl.c > @@ -35,7 +35,9 @@ > #endif > > #include > +#include "has_long_double.h" > > +#if defined NEWLIB_HAS_LONG_DOUBLE_MATH_FUNCTIONS > int test( void ); > > int test( void ) > @@ -47,3 +49,4 @@ int test( void ) > >return (result); > } > +#endif > diff --git a/testsuites/psxtests/psxhdrs/math/acosl.c > b/testsuites/psxtests/psxhdrs/math/acosl.c > index d2235aea76..9176131294 100644 > --- a/testsuites/psxtests/psxhdrs/math/acosl.c > +++ b/testsuites/psxtests/psxhdrs/math/acosl.c > @@ -35,7 +35,9 @@ > #endif > > #include > +#include "has_long_double.h" > > +#if defined NEWLIB_HAS_LONG_DOUBLE_MATH_FUNCTIONS > int test( void ); > > int test( void ) > @@ -47,3 +49,4 @@
[PATCH v2] psxtests: Fix math function build warnings
Added conditionals to ensure that long double function tests were only built when newlib has long double math functions. --- testsuites/psxtests/psxhdrs/math/acoshl.c| 3 +++ testsuites/psxtests/psxhdrs/math/acosl.c | 3 +++ testsuites/psxtests/psxhdrs/math/asinhl.c| 3 +++ testsuites/psxtests/psxhdrs/math/asinl.c | 3 +++ testsuites/psxtests/psxhdrs/math/atan2l.c| 3 +++ testsuites/psxtests/psxhdrs/math/atanhl.c| 3 +++ testsuites/psxtests/psxhdrs/math/atanl.c | 3 +++ testsuites/psxtests/psxhdrs/math/cbrtl.c | 3 +++ testsuites/psxtests/psxhdrs/math/ceill.c | 3 +++ testsuites/psxtests/psxhdrs/math/copysignl.c | 3 +++ testsuites/psxtests/psxhdrs/math/coshl.c | 3 +++ testsuites/psxtests/psxhdrs/math/cosl.c | 3 +++ testsuites/psxtests/psxhdrs/math/erfcl.c | 3 +++ testsuites/psxtests/psxhdrs/math/erfl.c | 3 +++ testsuites/psxtests/psxhdrs/math/exp2l.c | 3 +++ testsuites/psxtests/psxhdrs/math/expl.c | 3 +++ testsuites/psxtests/psxhdrs/math/expm1l.c| 3 +++ testsuites/psxtests/psxhdrs/math/fabsl.c | 3 +++ testsuites/psxtests/psxhdrs/math/fdiml.c | 3 +++ testsuites/psxtests/psxhdrs/math/floorl.c| 3 +++ testsuites/psxtests/psxhdrs/math/fmal.c | 3 +++ testsuites/psxtests/psxhdrs/math/fmaxl.c | 3 +++ testsuites/psxtests/psxhdrs/math/fminl.c | 3 +++ testsuites/psxtests/psxhdrs/math/fmodl.c | 3 +++ testsuites/psxtests/psxhdrs/math/frexpl.c| 3 +++ .../psxtests/psxhdrs/math/has_long_double.h | 16 testsuites/psxtests/psxhdrs/math/hypotl.c| 3 +++ testsuites/psxtests/psxhdrs/math/ilogbl.c| 3 +++ testsuites/psxtests/psxhdrs/math/ldexpl.c| 3 +++ testsuites/psxtests/psxhdrs/math/lgammal.c | 3 +++ testsuites/psxtests/psxhdrs/math/llrintl.c | 3 +++ testsuites/psxtests/psxhdrs/math/llroundl.c | 3 +++ testsuites/psxtests/psxhdrs/math/log10l.c| 3 +++ testsuites/psxtests/psxhdrs/math/log1pl.c| 3 +++ testsuites/psxtests/psxhdrs/math/log2l.c | 3 +++ testsuites/psxtests/psxhdrs/math/logbl.c | 3 +++ testsuites/psxtests/psxhdrs/math/logl.c | 3 +++ testsuites/psxtests/psxhdrs/math/lrintl.c| 3 +++ testsuites/psxtests/psxhdrs/math/lroundl.c | 3 +++ testsuites/psxtests/psxhdrs/math/modfl.c | 3 +++ testsuites/psxtests/psxhdrs/math/nanl.c | 3 +++ testsuites/psxtests/psxhdrs/math/nearbyintl.c| 3 +++ testsuites/psxtests/psxhdrs/math/nextafterl.c| 3 +++ testsuites/psxtests/psxhdrs/math/nexttoward.c| 3 +++ testsuites/psxtests/psxhdrs/math/nexttowardf.c | 3 +++ testsuites/psxtests/psxhdrs/math/nexttowardl.c | 3 +++ testsuites/psxtests/psxhdrs/math/powl.c | 3 +++ testsuites/psxtests/psxhdrs/math/remainderl.c| 3 +++ testsuites/psxtests/psxhdrs/math/remquol.c | 3 +++ testsuites/psxtests/psxhdrs/math/rintl.c | 3 +++ testsuites/psxtests/psxhdrs/math/roundl.c| 3 +++ testsuites/psxtests/psxhdrs/math/scalblnl.c | 3 +++ testsuites/psxtests/psxhdrs/math/scalbnl.c | 3 +++ testsuites/psxtests/psxhdrs/math/sinhl.c | 3 +++ testsuites/psxtests/psxhdrs/math/sinl.c | 3 +++ testsuites/psxtests/psxhdrs/math/sqrtl.c | 3 +++ testsuites/psxtests/psxhdrs/math/tanhl.c | 3 +++ testsuites/psxtests/psxhdrs/math/tanl.c | 3 +++ testsuites/psxtests/psxhdrs/math/tgammal.c | 3 +++ testsuites/psxtests/psxhdrs/math/truncl.c| 3 +++ 60 files changed, 193 insertions(+) create mode 100644 testsuites/psxtests/psxhdrs/math/has_long_double.h diff --git a/testsuites/psxtests/psxhdrs/math/acoshl.c b/testsuites/psxtests/psxhdrs/math/acoshl.c index b6bf0bd16c..fd25a3a1e4 100644 --- a/testsuites/psxtests/psxhdrs/math/acoshl.c +++ b/testsuites/psxtests/psxhdrs/math/acoshl.c @@ -35,7 +35,9 @@ #endif #include +#include "has_long_double.h" +#if defined NEWLIB_HAS_LONG_DOUBLE_MATH_FUNCTIONS int test( void ); int test( void ) @@ -47,3 +49,4 @@ int test( void ) return (result); } +#endif diff --git a/testsuites/psxtests/psxhdrs/math/acosl.c b/testsuites/psxtests/psxhdrs/math/acosl.c index d2235aea76..9176131294 100644 --- a/testsuites/psxtests/psxhdrs/math/acosl.c +++ b/testsuites/psxtests/psxhdrs/math/acosl.c @@ -35,7 +35,9 @@ #endif #include +#include "has_long_double.h" +#if defined NEWLIB_HAS_LONG_DOUBLE_MATH_FUNCTIONS int test( void ); int test( void ) @@ -47,3 +49,4 @@ int test( void ) return (result); } +#endif diff --git a/testsuites/psxtests/psxhdrs/math/asinhl.c b/testsuites/psxtests/psxhdrs/math/asinhl.c index e3a2a0ec9b..607b02dd68 100644 --- a/testsuites/psxtests/psxhdrs/math/asinhl.c +++ b/testsuites/psxtests/psxhdrs/math/asinhl.c @@ -35,7 +35,9 @@ #endif #include +#include
