Re: [PATCH v4 5/5] Change filesystem utime_h handler to utimens_h
On Sat, May 15, 2021, 9:44 AM Joel Sherrill wrote: > IMD is the legal predecessor to Embedded Brains but Thomas probably should > clear that > Thomas replied quite quickly and confirmed that it is ok to relicense. He added to the ticket tracking this for future reference. > > I don't think we have heard from Oktet so that can't change. > Reverse this change. I've starting tracking the submitter down. --joel > > On Sat, May 15, 2021, 9:06 AM Gedare Bloom wrote: > >> On Fri, May 14, 2021 at 11:32 AM Ryan Long wrote: >> > >> > Also updated licenses. >> > >> > Closes #4400 >> > --- >> > bsps/arm/csb337/umon/tfsDriver.c| 2 +- >> > cpukit/Makefile.am | 4 +- >> > cpukit/include/rtems/confdefs/libio.h | 4 +- >> > cpukit/include/rtems/imfs.h | 35 - >> > cpukit/include/rtems/libio.h| 55 >> +-- >> > cpukit/libcsupport/src/__usrenv.c | 39 +-- >> > cpukit/libcsupport/src/futimens.c | 2 +- >> > cpukit/libcsupport/src/utimensat.c | 2 +- >> > cpukit/libfs/src/defaults/default_ops.c | 34 - >> > cpukit/libfs/src/defaults/default_utime.c | 32 >> > cpukit/libfs/src/defaults/default_utimens.c | 49 >> >> > cpukit/libfs/src/dosfs/msdos_init.c | 48 >> >> > cpukit/libfs/src/ftpfs/ftpfs.c | 44 -- >> > cpukit/libfs/src/ftpfs/tftpDriver.c | 28 +++--- >> > cpukit/libfs/src/imfs/imfs_init.c | 30 --- >> > cpukit/libfs/src/imfs/imfs_utime.c | 41 >> > cpukit/libfs/src/imfs/imfs_utimens.c| 58 >> + >> > cpukit/libfs/src/jffs2/src/fs-rtems.c | 11 +++--- >> > cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 16 >> > spec/build/cpukit/librtemscpu.yml | 4 +- >> > 20 files changed, 345 insertions(+), 193 deletions(-) >> > delete mode 100644 cpukit/libfs/src/defaults/default_utime.c >> > create mode 100644 cpukit/libfs/src/defaults/default_utimens.c >> > delete mode 100644 cpukit/libfs/src/imfs/imfs_utime.c >> > create mode 100644 cpukit/libfs/src/imfs/imfs_utimens.c >> > >> > diff --git a/bsps/arm/csb337/umon/tfsDriver.c >> b/bsps/arm/csb337/umon/tfsDriver.c >> > index 0195346..caf3a4b 100644 >> > --- a/bsps/arm/csb337/umon/tfsDriver.c >> > +++ b/bsps/arm/csb337/umon/tfsDriver.c >> > @@ -657,7 +657,7 @@ static const rtems_filesystem_operations_table >> rtems_tfs_ops = { >> >.mount_h = rtems_filesystem_default_mount, >> >.unmount_h = rtems_filesystem_default_unmount, >> >.fsunmount_me_h = rtems_filesystem_default_fsunmount, >> > - .utime_h = rtems_filesystem_default_utime, >> > + .utimens_h = rtems_filesystem_default_utimens, >> >.symlink_h = rtems_filesystem_default_symlink, >> >.readlink_h = rtems_filesystem_default_readlink, >> >.rename_h = rtems_filesystem_default_rename, >> > diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am >> > index 29b4207..c144773 100644 >> > --- a/cpukit/Makefile.am >> > +++ b/cpukit/Makefile.am >> > @@ -377,7 +377,7 @@ librtemscpu_a_SOURCES += >> libfs/src/defaults/default_rmnod.c >> > librtemscpu_a_SOURCES += libfs/src/defaults/default_statvfs.c >> > librtemscpu_a_SOURCES += libfs/src/defaults/default_symlink.c >> > librtemscpu_a_SOURCES += libfs/src/defaults/default_unmount.c >> > -librtemscpu_a_SOURCES += libfs/src/defaults/default_utime.c >> > +librtemscpu_a_SOURCES += libfs/src/defaults/default_utimens.c >> > librtemscpu_a_SOURCES += libfs/src/defaults/default_write.c >> > librtemscpu_a_SOURCES += libfs/src/defaults/default_writev.c >> > librtemscpu_a_SOURCES += libfs/src/dosfs/fat.c >> > @@ -434,7 +434,7 @@ librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat.c >> > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat_file.c >> > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_symlink.c >> > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_unmount.c >> > -librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utime.c >> > +librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utimens.c >> > librtemscpu_a_SOURCES += libfs/src/imfs/ioman.c >> > librtemscpu_a_SOURCES += libfs/src/pipe/fifo.c >> > librtemscpu_a_SOURCES += libfs/src/pipe/pipe.c >> > diff --git a/cpukit/include/rtems/confdefs/libio.h >> b/cpukit/include/rtems/confdefs/libio.h >> > index 16a4fb69..1b84f8c 100644 >> > --- a/cpukit/include/rtems/confdefs/libio.h >> > +++ b/cpukit/include/rtems/confdefs/libio.h >> > @@ -231,9 +231,9 @@ static const rtems_filesystem_operations_table >> IMFS_root_ops = { >> >#endif >> >rtems_filesystem_default_fsunmount, >> >#ifdef CONFIGURE_IMFS_DISABLE_UTIME >> > -rtems_filesystem_default_utime, >> > +rtems_filesystem_default_utimens, >> >#else >> > -IMFS_utime, >> > +IMFS_utimens, >> >#endif >> >#ifdef
Re: [PATCH v4 5/5] Change filesystem utime_h handler to utimens_h
IMD is the legal predecessor to Embedded Brains but Thomas probably should clear that I don't think we have heard from Oktet so that can't change. On Sat, May 15, 2021, 9:06 AM Gedare Bloom wrote: > On Fri, May 14, 2021 at 11:32 AM Ryan Long wrote: > > > > Also updated licenses. > > > > Closes #4400 > > --- > > bsps/arm/csb337/umon/tfsDriver.c| 2 +- > > cpukit/Makefile.am | 4 +- > > cpukit/include/rtems/confdefs/libio.h | 4 +- > > cpukit/include/rtems/imfs.h | 35 - > > cpukit/include/rtems/libio.h| 55 > +-- > > cpukit/libcsupport/src/__usrenv.c | 39 +-- > > cpukit/libcsupport/src/futimens.c | 2 +- > > cpukit/libcsupport/src/utimensat.c | 2 +- > > cpukit/libfs/src/defaults/default_ops.c | 34 - > > cpukit/libfs/src/defaults/default_utime.c | 32 > > cpukit/libfs/src/defaults/default_utimens.c | 49 > > > cpukit/libfs/src/dosfs/msdos_init.c | 48 > > > cpukit/libfs/src/ftpfs/ftpfs.c | 44 -- > > cpukit/libfs/src/ftpfs/tftpDriver.c | 28 +++--- > > cpukit/libfs/src/imfs/imfs_init.c | 30 --- > > cpukit/libfs/src/imfs/imfs_utime.c | 41 > > cpukit/libfs/src/imfs/imfs_utimens.c| 58 > + > > cpukit/libfs/src/jffs2/src/fs-rtems.c | 11 +++--- > > cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 16 > > spec/build/cpukit/librtemscpu.yml | 4 +- > > 20 files changed, 345 insertions(+), 193 deletions(-) > > delete mode 100644 cpukit/libfs/src/defaults/default_utime.c > > create mode 100644 cpukit/libfs/src/defaults/default_utimens.c > > delete mode 100644 cpukit/libfs/src/imfs/imfs_utime.c > > create mode 100644 cpukit/libfs/src/imfs/imfs_utimens.c > > > > diff --git a/bsps/arm/csb337/umon/tfsDriver.c > b/bsps/arm/csb337/umon/tfsDriver.c > > index 0195346..caf3a4b 100644 > > --- a/bsps/arm/csb337/umon/tfsDriver.c > > +++ b/bsps/arm/csb337/umon/tfsDriver.c > > @@ -657,7 +657,7 @@ static const rtems_filesystem_operations_table > rtems_tfs_ops = { > >.mount_h = rtems_filesystem_default_mount, > >.unmount_h = rtems_filesystem_default_unmount, > >.fsunmount_me_h = rtems_filesystem_default_fsunmount, > > - .utime_h = rtems_filesystem_default_utime, > > + .utimens_h = rtems_filesystem_default_utimens, > >.symlink_h = rtems_filesystem_default_symlink, > >.readlink_h = rtems_filesystem_default_readlink, > >.rename_h = rtems_filesystem_default_rename, > > diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am > > index 29b4207..c144773 100644 > > --- a/cpukit/Makefile.am > > +++ b/cpukit/Makefile.am > > @@ -377,7 +377,7 @@ librtemscpu_a_SOURCES += > libfs/src/defaults/default_rmnod.c > > librtemscpu_a_SOURCES += libfs/src/defaults/default_statvfs.c > > librtemscpu_a_SOURCES += libfs/src/defaults/default_symlink.c > > librtemscpu_a_SOURCES += libfs/src/defaults/default_unmount.c > > -librtemscpu_a_SOURCES += libfs/src/defaults/default_utime.c > > +librtemscpu_a_SOURCES += libfs/src/defaults/default_utimens.c > > librtemscpu_a_SOURCES += libfs/src/defaults/default_write.c > > librtemscpu_a_SOURCES += libfs/src/defaults/default_writev.c > > librtemscpu_a_SOURCES += libfs/src/dosfs/fat.c > > @@ -434,7 +434,7 @@ librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat.c > > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat_file.c > > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_symlink.c > > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_unmount.c > > -librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utime.c > > +librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utimens.c > > librtemscpu_a_SOURCES += libfs/src/imfs/ioman.c > > librtemscpu_a_SOURCES += libfs/src/pipe/fifo.c > > librtemscpu_a_SOURCES += libfs/src/pipe/pipe.c > > diff --git a/cpukit/include/rtems/confdefs/libio.h > b/cpukit/include/rtems/confdefs/libio.h > > index 16a4fb69..1b84f8c 100644 > > --- a/cpukit/include/rtems/confdefs/libio.h > > +++ b/cpukit/include/rtems/confdefs/libio.h > > @@ -231,9 +231,9 @@ static const rtems_filesystem_operations_table > IMFS_root_ops = { > >#endif > >rtems_filesystem_default_fsunmount, > >#ifdef CONFIGURE_IMFS_DISABLE_UTIME > > -rtems_filesystem_default_utime, > > +rtems_filesystem_default_utimens, > >#else > > -IMFS_utime, > > +IMFS_utimens, > >#endif > >#ifdef CONFIGURE_IMFS_DISABLE_SYMLINK > > rtems_filesystem_default_symlink, > > diff --git a/cpukit/include/rtems/imfs.h b/cpukit/include/rtems/imfs.h > > index b2a9868..57c498c 100644 > > --- a/cpukit/include/rtems/imfs.h > > +++ b/cpukit/include/rtems/imfs.h > > @@ -1,3 +1,5 @@ > > +/* SPDX-License-Identifier: BSD-2-Clause */ > > + > > /** > > * @file > > * > > @@ -5,12 +7,28 @@ >
Re: [PATCH v4 5/5] Change filesystem utime_h handler to utimens_h
On Fri, May 14, 2021 at 11:32 AM Ryan Long wrote: > > Also updated licenses. > > Closes #4400 > --- > bsps/arm/csb337/umon/tfsDriver.c| 2 +- > cpukit/Makefile.am | 4 +- > cpukit/include/rtems/confdefs/libio.h | 4 +- > cpukit/include/rtems/imfs.h | 35 - > cpukit/include/rtems/libio.h| 55 +-- > cpukit/libcsupport/src/__usrenv.c | 39 +-- > cpukit/libcsupport/src/futimens.c | 2 +- > cpukit/libcsupport/src/utimensat.c | 2 +- > cpukit/libfs/src/defaults/default_ops.c | 34 - > cpukit/libfs/src/defaults/default_utime.c | 32 > cpukit/libfs/src/defaults/default_utimens.c | 49 > cpukit/libfs/src/dosfs/msdos_init.c | 48 > cpukit/libfs/src/ftpfs/ftpfs.c | 44 -- > cpukit/libfs/src/ftpfs/tftpDriver.c | 28 +++--- > cpukit/libfs/src/imfs/imfs_init.c | 30 --- > cpukit/libfs/src/imfs/imfs_utime.c | 41 > cpukit/libfs/src/imfs/imfs_utimens.c| 58 > + > cpukit/libfs/src/jffs2/src/fs-rtems.c | 11 +++--- > cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 16 > spec/build/cpukit/librtemscpu.yml | 4 +- > 20 files changed, 345 insertions(+), 193 deletions(-) > delete mode 100644 cpukit/libfs/src/defaults/default_utime.c > create mode 100644 cpukit/libfs/src/defaults/default_utimens.c > delete mode 100644 cpukit/libfs/src/imfs/imfs_utime.c > create mode 100644 cpukit/libfs/src/imfs/imfs_utimens.c > > diff --git a/bsps/arm/csb337/umon/tfsDriver.c > b/bsps/arm/csb337/umon/tfsDriver.c > index 0195346..caf3a4b 100644 > --- a/bsps/arm/csb337/umon/tfsDriver.c > +++ b/bsps/arm/csb337/umon/tfsDriver.c > @@ -657,7 +657,7 @@ static const rtems_filesystem_operations_table > rtems_tfs_ops = { >.mount_h = rtems_filesystem_default_mount, >.unmount_h = rtems_filesystem_default_unmount, >.fsunmount_me_h = rtems_filesystem_default_fsunmount, > - .utime_h = rtems_filesystem_default_utime, > + .utimens_h = rtems_filesystem_default_utimens, >.symlink_h = rtems_filesystem_default_symlink, >.readlink_h = rtems_filesystem_default_readlink, >.rename_h = rtems_filesystem_default_rename, > diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am > index 29b4207..c144773 100644 > --- a/cpukit/Makefile.am > +++ b/cpukit/Makefile.am > @@ -377,7 +377,7 @@ librtemscpu_a_SOURCES += > libfs/src/defaults/default_rmnod.c > librtemscpu_a_SOURCES += libfs/src/defaults/default_statvfs.c > librtemscpu_a_SOURCES += libfs/src/defaults/default_symlink.c > librtemscpu_a_SOURCES += libfs/src/defaults/default_unmount.c > -librtemscpu_a_SOURCES += libfs/src/defaults/default_utime.c > +librtemscpu_a_SOURCES += libfs/src/defaults/default_utimens.c > librtemscpu_a_SOURCES += libfs/src/defaults/default_write.c > librtemscpu_a_SOURCES += libfs/src/defaults/default_writev.c > librtemscpu_a_SOURCES += libfs/src/dosfs/fat.c > @@ -434,7 +434,7 @@ librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat.c > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat_file.c > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_symlink.c > librtemscpu_a_SOURCES += libfs/src/imfs/imfs_unmount.c > -librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utime.c > +librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utimens.c > librtemscpu_a_SOURCES += libfs/src/imfs/ioman.c > librtemscpu_a_SOURCES += libfs/src/pipe/fifo.c > librtemscpu_a_SOURCES += libfs/src/pipe/pipe.c > diff --git a/cpukit/include/rtems/confdefs/libio.h > b/cpukit/include/rtems/confdefs/libio.h > index 16a4fb69..1b84f8c 100644 > --- a/cpukit/include/rtems/confdefs/libio.h > +++ b/cpukit/include/rtems/confdefs/libio.h > @@ -231,9 +231,9 @@ static const rtems_filesystem_operations_table > IMFS_root_ops = { >#endif >rtems_filesystem_default_fsunmount, >#ifdef CONFIGURE_IMFS_DISABLE_UTIME > -rtems_filesystem_default_utime, > +rtems_filesystem_default_utimens, >#else > -IMFS_utime, > +IMFS_utimens, >#endif >#ifdef CONFIGURE_IMFS_DISABLE_SYMLINK > rtems_filesystem_default_symlink, > diff --git a/cpukit/include/rtems/imfs.h b/cpukit/include/rtems/imfs.h > index b2a9868..57c498c 100644 > --- a/cpukit/include/rtems/imfs.h > +++ b/cpukit/include/rtems/imfs.h > @@ -1,3 +1,5 @@ > +/* SPDX-License-Identifier: BSD-2-Clause */ > + > /** > * @file > * > @@ -5,12 +7,28 @@ > */ > > /* > - * COPYRIGHT (c) 1989-2011. > - * On-Line Applications Research Corporation (OAR). > - * > - * The license and distribution terms for this file may be > - * found in the file LICENSE in this distribution or at > - * http://www.rtems.org/license/LICENSE. > + * COPYRIGHT (C) 1989, 2021 On-Line Applications Research Corporation (OAR). > + * > + * Redistribution and
[PATCH v4 5/5] Change filesystem utime_h handler to utimens_h
Also updated licenses. Closes #4400 --- bsps/arm/csb337/umon/tfsDriver.c| 2 +- cpukit/Makefile.am | 4 +- cpukit/include/rtems/confdefs/libio.h | 4 +- cpukit/include/rtems/imfs.h | 35 - cpukit/include/rtems/libio.h| 55 +-- cpukit/libcsupport/src/__usrenv.c | 39 +-- cpukit/libcsupport/src/futimens.c | 2 +- cpukit/libcsupport/src/utimensat.c | 2 +- cpukit/libfs/src/defaults/default_ops.c | 34 - cpukit/libfs/src/defaults/default_utime.c | 32 cpukit/libfs/src/defaults/default_utimens.c | 49 cpukit/libfs/src/dosfs/msdos_init.c | 48 cpukit/libfs/src/ftpfs/ftpfs.c | 44 -- cpukit/libfs/src/ftpfs/tftpDriver.c | 28 +++--- cpukit/libfs/src/imfs/imfs_init.c | 30 --- cpukit/libfs/src/imfs/imfs_utime.c | 41 cpukit/libfs/src/imfs/imfs_utimens.c| 58 + cpukit/libfs/src/jffs2/src/fs-rtems.c | 11 +++--- cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 16 spec/build/cpukit/librtemscpu.yml | 4 +- 20 files changed, 345 insertions(+), 193 deletions(-) delete mode 100644 cpukit/libfs/src/defaults/default_utime.c create mode 100644 cpukit/libfs/src/defaults/default_utimens.c delete mode 100644 cpukit/libfs/src/imfs/imfs_utime.c create mode 100644 cpukit/libfs/src/imfs/imfs_utimens.c diff --git a/bsps/arm/csb337/umon/tfsDriver.c b/bsps/arm/csb337/umon/tfsDriver.c index 0195346..caf3a4b 100644 --- a/bsps/arm/csb337/umon/tfsDriver.c +++ b/bsps/arm/csb337/umon/tfsDriver.c @@ -657,7 +657,7 @@ static const rtems_filesystem_operations_table rtems_tfs_ops = { .mount_h = rtems_filesystem_default_mount, .unmount_h = rtems_filesystem_default_unmount, .fsunmount_me_h = rtems_filesystem_default_fsunmount, - .utime_h = rtems_filesystem_default_utime, + .utimens_h = rtems_filesystem_default_utimens, .symlink_h = rtems_filesystem_default_symlink, .readlink_h = rtems_filesystem_default_readlink, .rename_h = rtems_filesystem_default_rename, diff --git a/cpukit/Makefile.am b/cpukit/Makefile.am index 29b4207..c144773 100644 --- a/cpukit/Makefile.am +++ b/cpukit/Makefile.am @@ -377,7 +377,7 @@ librtemscpu_a_SOURCES += libfs/src/defaults/default_rmnod.c librtemscpu_a_SOURCES += libfs/src/defaults/default_statvfs.c librtemscpu_a_SOURCES += libfs/src/defaults/default_symlink.c librtemscpu_a_SOURCES += libfs/src/defaults/default_unmount.c -librtemscpu_a_SOURCES += libfs/src/defaults/default_utime.c +librtemscpu_a_SOURCES += libfs/src/defaults/default_utimens.c librtemscpu_a_SOURCES += libfs/src/defaults/default_write.c librtemscpu_a_SOURCES += libfs/src/defaults/default_writev.c librtemscpu_a_SOURCES += libfs/src/dosfs/fat.c @@ -434,7 +434,7 @@ librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat.c librtemscpu_a_SOURCES += libfs/src/imfs/imfs_stat_file.c librtemscpu_a_SOURCES += libfs/src/imfs/imfs_symlink.c librtemscpu_a_SOURCES += libfs/src/imfs/imfs_unmount.c -librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utime.c +librtemscpu_a_SOURCES += libfs/src/imfs/imfs_utimens.c librtemscpu_a_SOURCES += libfs/src/imfs/ioman.c librtemscpu_a_SOURCES += libfs/src/pipe/fifo.c librtemscpu_a_SOURCES += libfs/src/pipe/pipe.c diff --git a/cpukit/include/rtems/confdefs/libio.h b/cpukit/include/rtems/confdefs/libio.h index 16a4fb69..1b84f8c 100644 --- a/cpukit/include/rtems/confdefs/libio.h +++ b/cpukit/include/rtems/confdefs/libio.h @@ -231,9 +231,9 @@ static const rtems_filesystem_operations_table IMFS_root_ops = { #endif rtems_filesystem_default_fsunmount, #ifdef CONFIGURE_IMFS_DISABLE_UTIME -rtems_filesystem_default_utime, +rtems_filesystem_default_utimens, #else -IMFS_utime, +IMFS_utimens, #endif #ifdef CONFIGURE_IMFS_DISABLE_SYMLINK rtems_filesystem_default_symlink, diff --git a/cpukit/include/rtems/imfs.h b/cpukit/include/rtems/imfs.h index b2a9868..57c498c 100644 --- a/cpukit/include/rtems/imfs.h +++ b/cpukit/include/rtems/imfs.h @@ -1,3 +1,5 @@ +/* SPDX-License-Identifier: BSD-2-Clause */ + /** * @file * @@ -5,12 +7,28 @@ */ /* - * COPYRIGHT (c) 1989-2011. - * On-Line Applications Research Corporation (OAR). - * - * The license and distribution terms for this file may be - * found in the file LICENSE in this distribution or at - * http://www.rtems.org/license/LICENSE. + * COPYRIGHT (C) 1989, 2021 On-Line Applications Research Corporation (OAR). + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. +