Re: [patch] medit issue

[Joel Sherrill]

On Mon, Feb 13, 2023, 11:04 PM Gedare Bloom  wrote:

> Hi Zack,
>
> This is very close but I think something is still going strangely with
> your patch commit message or with your git-send-email. The subject
> line of the git-send-email should inherit from the first line of your
> commit message, so either your commit message has "medit issue" as its
> first line, or there is something strange in how your patch is being
> emailed.
>

Copy and pasted in an email? Rather than git send-email or attaching it?

>
> Can you either check your configuration and command for
> git-send-email, or just send the patch as a diff/.patch file?
>
> Gedare
>
> On Fri, Feb 10, 2023 at 7:35 PM zack leung 
> wrote:
> >
> > libmisc/shell: User can't cut using ctrl e and x in medit
> >
> > Closes #4557
> > ---
> >  cpukit/libmisc/shell/main_edit.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/cpukit/libmisc/shell/main_edit.c
> b/cpukit/libmisc/shell/main_edit.c
> > index 6e954639e2..8317452b7b 100644
> > --- a/cpukit/libmisc/shell/main_edit.c
> > +++ b/cpukit/libmisc/shell/main_edit.c
> > @@ -1713,7 +1713,6 @@ static void copy_selection(struct editor *ed) {
> >ed->env->clipboard = (unsigned char *) realloc(ed->env->clipboard,
> ed->env->clipsize);
> >if (!ed->env->clipboard) return;
> >copy(ed, ed->env->clipboard, selstart, ed->env->clipsize);
> > -  select_toggle(ed);
> >  }
> >
> >  static void cut_selection(struct editor *ed) {
> > @@ -2132,7 +2131,7 @@ static void edit(struct editor *ed) {
> >
> >  case ctrl('e'): select_toggle(ed); break;
> >  case ctrl('a'): select_all(ed); break;
> > -case ctrl('c'): copy_selection(ed); break;
> > +case ctrl('c'): copy_selection(ed);select_toggle(ed); break;
> >  case ctrl('f'): find_text(ed, 0); break;
> >  case ctrl('l'): goto_line(ed); break;
> >  case ctrl('g'): find_text(ed, 1); break;
> > --
> > 2.39.1
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [patch] medit issue

[Gedare Bloom]

Hi Zack,

This is very close but I think something is still going strangely with
your patch commit message or with your git-send-email. The subject
line of the git-send-email should inherit from the first line of your
commit message, so either your commit message has "medit issue" as its
first line, or there is something strange in how your patch is being
emailed.

Can you either check your configuration and command for
git-send-email, or just send the patch as a diff/.patch file?

Gedare

On Fri, Feb 10, 2023 at 7:35 PM zack leung  wrote:
>
> libmisc/shell: User can't cut using ctrl e and x in medit
>
> Closes #4557
> ---
>  cpukit/libmisc/shell/main_edit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/cpukit/libmisc/shell/main_edit.c 
> b/cpukit/libmisc/shell/main_edit.c
> index 6e954639e2..8317452b7b 100644
> --- a/cpukit/libmisc/shell/main_edit.c
> +++ b/cpukit/libmisc/shell/main_edit.c
> @@ -1713,7 +1713,6 @@ static void copy_selection(struct editor *ed) {
>ed->env->clipboard = (unsigned char *) realloc(ed->env->clipboard, 
> ed->env->clipsize);
>if (!ed->env->clipboard) return;
>copy(ed, ed->env->clipboard, selstart, ed->env->clipsize);
> -  select_toggle(ed);
>  }
>
>  static void cut_selection(struct editor *ed) {
> @@ -2132,7 +2131,7 @@ static void edit(struct editor *ed) {
>
>  case ctrl('e'): select_toggle(ed); break;
>  case ctrl('a'): select_all(ed); break;
> -case ctrl('c'): copy_selection(ed); break;
> +case ctrl('c'): copy_selection(ed);select_toggle(ed); break;
>  case ctrl('f'): find_text(ed, 0); break;
>  case ctrl('l'): goto_line(ed); break;
>  case ctrl('g'): find_text(ed, 1); break;
> --
> 2.39.1
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[patch] medit issue

[zack leung]

libmisc/shell: User can't cut using ctrl e and x in medit

Closes #4557
---
 cpukit/libmisc/shell/main_edit.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/cpukit/libmisc/shell/main_edit.c
b/cpukit/libmisc/shell/main_edit.c
index 6e954639e2..8317452b7b 100644
--- a/cpukit/libmisc/shell/main_edit.c
+++ b/cpukit/libmisc/shell/main_edit.c
@@ -1713,7 +1713,6 @@ static void copy_selection(struct editor *ed) {
   ed->env->clipboard = (unsigned char *) realloc(ed->env->clipboard,
ed->env->clipsize);
   if (!ed->env->clipboard) return;
   copy(ed, ed->env->clipboard, selstart, ed->env->clipsize);
-  select_toggle(ed);
 }

 static void cut_selection(struct editor *ed) {
@@ -2132,7 +2131,7 @@ static void edit(struct editor *ed) {

 case ctrl('e'): select_toggle(ed); break;
 case ctrl('a'): select_all(ed); break;
-case ctrl('c'): copy_selection(ed); break;
+case ctrl('c'): copy_selection(ed);select_toggle(ed); break;
 case ctrl('f'): find_text(ed, 0); break;
 case ctrl('l'): goto_line(ed); break;
 case ctrl('g'): find_text(ed, 1); break;
-- 
2.39.1
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel