Re: [PATCH] covoar/Target_arm: Add THUMB branch instructions

2021-03-26 Thread Gedare Bloom
Looks fine to me.

On Fri, Mar 26, 2021 at 11:53 AM Alex White  wrote:
>
> ping
>
> > -Original Message-
> > From: Alex White 
> > Sent: Thursday, March 11, 2021 12:26 PM
> > To: devel@rtems.org
> > Cc: Alex White 
> > Subject: [PATCH] covoar/Target_arm: Add THUMB branch instructions
> >
> > The ".n" and ".w" variants of the THUMB branch instructions were not
> > included in the list of conditional branch instructions. They have been 
> > added.
> > ---
> >  tester/covoar/Target_arm.cc | 34
> > ++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/tester/covoar/Target_arm.cc b/tester/covoar/Target_arm.cc
> > index 4b7b2e1..75ec406 100644
> > --- a/tester/covoar/Target_arm.cc
> > +++ b/tester/covoar/Target_arm.cc
> > @@ -36,6 +36,40 @@ namespace Target {
> >  conditionalBranchInstructions.push_back("bvc");
> >  conditionalBranchInstructions.push_back("bvs");
> >
> > +conditionalBranchInstructions.push_back("beq.n");
> > +conditionalBranchInstructions.push_back("bne.n");
> > +conditionalBranchInstructions.push_back("bcs.n");
> > +conditionalBranchInstructions.push_back("bhs.n");
> > +conditionalBranchInstructions.push_back("bcc.n");
> > +conditionalBranchInstructions.push_back("blo.n");
> > +conditionalBranchInstructions.push_back("bmi.n");
> > +conditionalBranchInstructions.push_back("bpl.n");
> > +conditionalBranchInstructions.push_back("bvs.n");
> > +conditionalBranchInstructions.push_back("bvc.n");
> > +conditionalBranchInstructions.push_back("bhi.n");
> > +conditionalBranchInstructions.push_back("bls.n");
> > +conditionalBranchInstructions.push_back("bge.n");
> > +conditionalBranchInstructions.push_back("blt.n");
> > +conditionalBranchInstructions.push_back("bgt.n");
> > +conditionalBranchInstructions.push_back("ble.n");
> > +
> > +conditionalBranchInstructions.push_back("beq.w");
> > +conditionalBranchInstructions.push_back("bne.w");
> > +conditionalBranchInstructions.push_back("bcs.w");
> > +conditionalBranchInstructions.push_back("bhs.w");
> > +conditionalBranchInstructions.push_back("bcc.w");
> > +conditionalBranchInstructions.push_back("blo.w");
> > +conditionalBranchInstructions.push_back("bmi.w");
> > +conditionalBranchInstructions.push_back("bpl.w");
> > +conditionalBranchInstructions.push_back("bvs.w");
> > +conditionalBranchInstructions.push_back("bvc.w");
> > +conditionalBranchInstructions.push_back("bhi.w");
> > +conditionalBranchInstructions.push_back("bls.w");
> > +conditionalBranchInstructions.push_back("bge.w");
> > +conditionalBranchInstructions.push_back("blt.w");
> > +conditionalBranchInstructions.push_back("bgt.w");
> > +conditionalBranchInstructions.push_back("ble.w");
> > +
> >  conditionalBranchInstructions.sort();
> >
> >}
> > --
> > 2.27.0
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


RE: [PATCH] covoar/Target_arm: Add THUMB branch instructions

2021-03-26 Thread Alex White
ping

> -Original Message-
> From: Alex White 
> Sent: Thursday, March 11, 2021 12:26 PM
> To: devel@rtems.org
> Cc: Alex White 
> Subject: [PATCH] covoar/Target_arm: Add THUMB branch instructions
> 
> The ".n" and ".w" variants of the THUMB branch instructions were not
> included in the list of conditional branch instructions. They have been added.
> ---
>  tester/covoar/Target_arm.cc | 34
> ++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/tester/covoar/Target_arm.cc b/tester/covoar/Target_arm.cc
> index 4b7b2e1..75ec406 100644
> --- a/tester/covoar/Target_arm.cc
> +++ b/tester/covoar/Target_arm.cc
> @@ -36,6 +36,40 @@ namespace Target {
>  conditionalBranchInstructions.push_back("bvc");
>  conditionalBranchInstructions.push_back("bvs");
> 
> +conditionalBranchInstructions.push_back("beq.n");
> +conditionalBranchInstructions.push_back("bne.n");
> +conditionalBranchInstructions.push_back("bcs.n");
> +conditionalBranchInstructions.push_back("bhs.n");
> +conditionalBranchInstructions.push_back("bcc.n");
> +conditionalBranchInstructions.push_back("blo.n");
> +conditionalBranchInstructions.push_back("bmi.n");
> +conditionalBranchInstructions.push_back("bpl.n");
> +conditionalBranchInstructions.push_back("bvs.n");
> +conditionalBranchInstructions.push_back("bvc.n");
> +conditionalBranchInstructions.push_back("bhi.n");
> +conditionalBranchInstructions.push_back("bls.n");
> +conditionalBranchInstructions.push_back("bge.n");
> +conditionalBranchInstructions.push_back("blt.n");
> +conditionalBranchInstructions.push_back("bgt.n");
> +conditionalBranchInstructions.push_back("ble.n");
> +
> +conditionalBranchInstructions.push_back("beq.w");
> +conditionalBranchInstructions.push_back("bne.w");
> +conditionalBranchInstructions.push_back("bcs.w");
> +conditionalBranchInstructions.push_back("bhs.w");
> +conditionalBranchInstructions.push_back("bcc.w");
> +conditionalBranchInstructions.push_back("blo.w");
> +conditionalBranchInstructions.push_back("bmi.w");
> +conditionalBranchInstructions.push_back("bpl.w");
> +conditionalBranchInstructions.push_back("bvs.w");
> +conditionalBranchInstructions.push_back("bvc.w");
> +conditionalBranchInstructions.push_back("bhi.w");
> +conditionalBranchInstructions.push_back("bls.w");
> +conditionalBranchInstructions.push_back("bge.w");
> +conditionalBranchInstructions.push_back("blt.w");
> +conditionalBranchInstructions.push_back("bgt.w");
> +conditionalBranchInstructions.push_back("ble.w");
> +
>  conditionalBranchInstructions.sort();
> 
>}
> --
> 2.27.0

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel