Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1
On 3/9/21 10:07 pm, Ryan Long wrote: > I haven't been building these with clang, so I'll make sure to start doing > that. I've got a Macbook, so I can test it on there as well. This great and thanks. I am amazed how each compiler and version of that compiler generates new issues. On the positive side the code is getting cleaner. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
RE: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1
I haven't been building these with clang, so I'll make sure to start doing that. I've got a Macbook, so I can test it on there as well. -Original Message- From: Chris Johns Sent: Thursday, September 2, 2021 11:59 PM To: Ryan Long ; devel@rtems.org Subject: Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1 On 3/9/21 5:24 am, Ryan Long wrote: > For this and the following series of patches I followed this series of > steps. > > 1. Convert a file from the C way of doing things to C++ 2. Go through > all the files that had to do with the converted file and make the > formatting consistent. Looks good and thanks for taking this on. Have you built this with clang on FreeBSD? I only ask because the minor fix I pushed where clang complained about the `std::ostream::tellp()` return value being compared to `long int` https://lists.rtems.org/pipermail/build/2021-September/028853.html I suspect if this change build on FreeBSD it will also build on MacOS. Do you have access to a MacOS machine? There is a new piece of code around `gcount()` and this is the reason for my question. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v1 00/10] Convert and reformat rtems-tools pt. 1
On 3/9/21 5:24 am, Ryan Long wrote: > For this and the following series of patches I followed this series of > steps. > > 1. Convert a file from the C way of doing things to C++ > 2. Go through all the files that had to do with the converted file and > make the formatting consistent. Looks good and thanks for taking this on. Have you built this with clang on FreeBSD? I only ask because the minor fix I pushed where clang complained about the `std::ostream::tellp()` return value being compared to `long int` https://lists.rtems.org/pipermail/build/2021-September/028853.html I suspect if this change build on FreeBSD it will also build on MacOS. Do you have access to a MacOS machine? There is a new piece of code around `gcount()` and this is the reason for my question. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
