Re: [PATCH 5/5] bsps: Add xilinx_zynqmp_lp64_a53 BSP variant
On 22.03.24 20:57, Gedare Bloom wrote: In some other architectures we have had "generic" BSP targets. It would be good to have something following the lp64 part. I'm not quite clear on what the purpose of this generic BSP target is here. For this platform, there is no need for having specific BSPs. The customization can be done through BSP options and a device tree. The only thing we need are the right compiler options. -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 5/5] bsps: Add xilinx_zynqmp_lp64_a53 BSP variant
On 22.03.24 16:48, Kinsey Moore wrote: This patch looks good. I would suggest dropping the a53 from the BSP name since all AArch64 ZynqMP BSPs will run on the A53 cores. We should keep this name. Maybe Xilinx provides a Zynq variant with other cores in the future and for the Cortex-A53 we have to enable some errata workarounds: https://devel.rtems.org/ticket/5003 -- embedded brains GmbH & Co. KG Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 5/5] bsps: Add xilinx_zynqmp_lp64_a53 BSP variant
In some other architectures we have had "generic" BSP targets. It would be good to have something following the lp64 part. I'm not quite clear on what the purpose of this generic BSP target is here. On Fri, Mar 22, 2024 at 9:48 AM Kinsey Moore wrote: > > This patch looks good. I would suggest dropping the a53 from the BSP name > since all AArch64 ZynqMP BSPs will run on the A53 cores. > > Kinsey > > On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber > wrote: >> >> Add a BSP variant without a board-specific name. >> --- >> .../bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml | 21 +++ >> .../bsps/aarch64/xilinx-zynqmp/optloadoff.yml | 1 + >> .../bsps/aarch64/xilinx-zynqmp/optramori.yml | 1 + >> spec/build/bsps/objxilinxsupportlp64.yml | 1 + >> spec/build/bsps/optxilsupportpath.yml | 1 + >> 5 files changed, 25 insertions(+) >> create mode 100644 spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml >> >> diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml >> b/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml >> new file mode 100644 >> index 00..42316db4d3 >> --- /dev/null >> +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml >> @@ -0,0 +1,21 @@ >> +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause >> +arch: aarch64 >> +bsp: xilinx_zynqmp_lp64_a53 >> +build-type: bsp >> +cflags: [] >> +copyrights: >> +- Copyright (C) 2024 embedded brains GmbH >> +cppflags: [] >> +enabled-by: true >> +family: xilinx-zynqmp >> +includes: [] >> +install: [] >> +links: >> +- role: build-dependency >> + uid: grp >> +- role: build-dependency >> + uid: linkcmds_lp64 >> +- role: build-dependency >> + uid: objfdtzynqmp >> +source: [] >> +type: build >> diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml >> b/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml >> index 869181a95e..3a78b9af38 100644 >> --- a/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml >> +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml >> @@ -9,6 +9,7 @@ copyrights: >> - Copyright (C) 2020 On-Line Applications Research (OAR) >> default: >> - enabled-by: >> + - aarch64/xilinx_zynqmp_lp64_a53 >>- aarch64/xilinx_zynqmp_ilp32_zu3eg >>- aarch64/xilinx_zynqmp_lp64_cfc400x >>- aarch64/xilinx_zynqmp_lp64_zu3eg >> diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml >> b/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml >> index c4d33094fb..33f0946532 100644 >> --- a/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml >> +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml >> @@ -9,6 +9,7 @@ copyrights: >> - Copyright (C) 2020 On-Line Applications Research (OAR) >> default: >> - enabled-by: >> + - aarch64/xilinx_zynqmp_lp64_a53 >>- aarch64/xilinx_zynqmp_ilp32_zu3eg >>- aarch64/xilinx_zynqmp_lp64_cfc400x >>- aarch64/xilinx_zynqmp_lp64_zu3eg >> diff --git a/spec/build/bsps/objxilinxsupportlp64.yml >> b/spec/build/bsps/objxilinxsupportlp64.yml >> index 330ffc34fd..252851a5aa 100644 >> --- a/spec/build/bsps/objxilinxsupportlp64.yml >> +++ b/spec/build/bsps/objxilinxsupportlp64.yml >> @@ -7,6 +7,7 @@ cppflags: [] >> cxxflags: [] >> enabled-by: >> - bsps/aarch64/xilinx_versal >> +- aarch64/xilinx_zynqmp_lp64_a53 >> - aarch64/xilinx_zynqmp_lp64_cfc400x >> - aarch64/xilinx_zynqmp_lp64_qemu >> - aarch64/xilinx_zynqmp_lp64_zu3eg >> diff --git a/spec/build/bsps/optxilsupportpath.yml >> b/spec/build/bsps/optxilsupportpath.yml >> index 298f9d5286..a90e6d3418 100644 >> --- a/spec/build/bsps/optxilsupportpath.yml >> +++ b/spec/build/bsps/optxilsupportpath.yml >> @@ -20,6 +20,7 @@ default: >>- aarch64/xilinx_zynqmp_ilp32_zu3eg >>value: arm/ARMv8/32bit >> - enabled-by: >> + - aarch64/xilinx_zynqmp_lp64_a53 >>- aarch64/xilinx_zynqmp_lp64_cfc400x >>- aarch64/xilinx_zynqmp_lp64_qemu >>- aarch64/xilinx_zynqmp_lp64_zu3eg >> -- >> 2.35.3 >> >> ___ >> devel mailing list >> devel@rtems.org >> http://lists.rtems.org/mailman/listinfo/devel > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH 5/5] bsps: Add xilinx_zynqmp_lp64_a53 BSP variant
This patch looks good. I would suggest dropping the a53 from the BSP name since all AArch64 ZynqMP BSPs will run on the A53 cores. Kinsey On Mon, Mar 18, 2024 at 11:30 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Add a BSP variant without a board-specific name. > --- > .../bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml | 21 +++ > .../bsps/aarch64/xilinx-zynqmp/optloadoff.yml | 1 + > .../bsps/aarch64/xilinx-zynqmp/optramori.yml | 1 + > spec/build/bsps/objxilinxsupportlp64.yml | 1 + > spec/build/bsps/optxilsupportpath.yml | 1 + > 5 files changed, 25 insertions(+) > create mode 100644 spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml > > diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml > b/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml > new file mode 100644 > index 00..42316db4d3 > --- /dev/null > +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/bspa53lp64.yml > @@ -0,0 +1,21 @@ > +SPDX-License-Identifier: CC-BY-SA-4.0 OR BSD-2-Clause > +arch: aarch64 > +bsp: xilinx_zynqmp_lp64_a53 > +build-type: bsp > +cflags: [] > +copyrights: > +- Copyright (C) 2024 embedded brains GmbH > +cppflags: [] > +enabled-by: true > +family: xilinx-zynqmp > +includes: [] > +install: [] > +links: > +- role: build-dependency > + uid: grp > +- role: build-dependency > + uid: linkcmds_lp64 > +- role: build-dependency > + uid: objfdtzynqmp > +source: [] > +type: build > diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml > b/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml > index 869181a95e..3a78b9af38 100644 > --- a/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml > +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/optloadoff.yml > @@ -9,6 +9,7 @@ copyrights: > - Copyright (C) 2020 On-Line Applications Research (OAR) > default: > - enabled-by: > + - aarch64/xilinx_zynqmp_lp64_a53 >- aarch64/xilinx_zynqmp_ilp32_zu3eg >- aarch64/xilinx_zynqmp_lp64_cfc400x >- aarch64/xilinx_zynqmp_lp64_zu3eg > diff --git a/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml > b/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml > index c4d33094fb..33f0946532 100644 > --- a/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml > +++ b/spec/build/bsps/aarch64/xilinx-zynqmp/optramori.yml > @@ -9,6 +9,7 @@ copyrights: > - Copyright (C) 2020 On-Line Applications Research (OAR) > default: > - enabled-by: > + - aarch64/xilinx_zynqmp_lp64_a53 >- aarch64/xilinx_zynqmp_ilp32_zu3eg >- aarch64/xilinx_zynqmp_lp64_cfc400x >- aarch64/xilinx_zynqmp_lp64_zu3eg > diff --git a/spec/build/bsps/objxilinxsupportlp64.yml > b/spec/build/bsps/objxilinxsupportlp64.yml > index 330ffc34fd..252851a5aa 100644 > --- a/spec/build/bsps/objxilinxsupportlp64.yml > +++ b/spec/build/bsps/objxilinxsupportlp64.yml > @@ -7,6 +7,7 @@ cppflags: [] > cxxflags: [] > enabled-by: > - bsps/aarch64/xilinx_versal > +- aarch64/xilinx_zynqmp_lp64_a53 > - aarch64/xilinx_zynqmp_lp64_cfc400x > - aarch64/xilinx_zynqmp_lp64_qemu > - aarch64/xilinx_zynqmp_lp64_zu3eg > diff --git a/spec/build/bsps/optxilsupportpath.yml > b/spec/build/bsps/optxilsupportpath.yml > index 298f9d5286..a90e6d3418 100644 > --- a/spec/build/bsps/optxilsupportpath.yml > +++ b/spec/build/bsps/optxilsupportpath.yml > @@ -20,6 +20,7 @@ default: >- aarch64/xilinx_zynqmp_ilp32_zu3eg >value: arm/ARMv8/32bit > - enabled-by: > + - aarch64/xilinx_zynqmp_lp64_a53 >- aarch64/xilinx_zynqmp_lp64_cfc400x >- aarch64/xilinx_zynqmp_lp64_qemu >- aarch64/xilinx_zynqmp_lp64_zu3eg > -- > 2.35.3 > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel