Re: [PATCH v2 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-16 Thread Gedare Bloom
On Fri, Apr 16, 2021 at 8:57 AM  wrote:
>
>
>
> > On Apr 15, 2021, at 08:55 , Joel Sherrill  wrote:
> >
> > No one has posted publicly about these in 5 days and asking privately a
> > group of mvme users, I only got feedback from Heinz
> >
> > ==
> > I can only note that we have some (many) users who would like to stay at 
> > the fixed 9600 baud because that is what
> > they have been used to since "forever”.
> > I had received feedback on the MVME2500. There I had set the console of 
> > this QorIQ based system to the typical
> > 125600 baud for arm (also with the option BSP_CONSOLE_BAUD). Some were not 
> > happy that there are two different
> > baud rates for the different MVME boards.
> > I personally find Paul's approach ok and if the default value 
> > (bsp-defaults) eventually stays at 9600 baud on all
> > these boards could everyone be happy?
>
> I kept all the defaults at what they are now (usually 9600) to avoid 
> surprises.
>
> >
> >  ==
> >
> > This patch series makes all the mvme BSPs consistent so I plan to
> > merge these today.
> >
>
> Moving the legacy network code broke the patches that added baud rate 
> configuration to the ".yml" files.  I'll resubmit  the patches after I've 
> tested a recent version, but I'll need to pull down the new legacy network 
> branch and build that as well.  Hopefully all goes smoothly and I'll find 
> time today.
>
We'll get the pending patches merged that are ready to go in for your
rebase. Feel free to reach out directly to Vijay and myself if you run
into trouble.

> FYI, since other people are working in this area: I'll soon submit a PCI 
> multi-port serial driver for an eight port PMC serial port card.  Some of the 
> files will need to be shuffled around.
>
> Peter
> -
> Peter Dufault
> HD Associates, Inc.  Software and System Engineering
>
> This email is delivered through the public internet using protocols subject 
> to interception and tampering.
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v2 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-16 Thread dufault


> On Apr 15, 2021, at 08:55 , Joel Sherrill  wrote:
> 
> No one has posted publicly about these in 5 days and asking privately a
> group of mvme users, I only got feedback from Heinz
> 
> ==
> I can only note that we have some (many) users who would like to stay at the 
> fixed 9600 baud because that is what
> they have been used to since "forever”.
> I had received feedback on the MVME2500. There I had set the console of this 
> QorIQ based system to the typical
> 125600 baud for arm (also with the option BSP_CONSOLE_BAUD). Some were not 
> happy that there are two different
> baud rates for the different MVME boards.
> I personally find Paul's approach ok and if the default value (bsp-defaults) 
> eventually stays at 9600 baud on all
> these boards could everyone be happy?

I kept all the defaults at what they are now (usually 9600) to avoid surprises.

> 
>  ==
> 
> This patch series makes all the mvme BSPs consistent so I plan to
> merge these today.
> 

Moving the legacy network code broke the patches that added baud rate 
configuration to the ".yml" files.  I'll resubmit  the patches after I've 
tested a recent version, but I'll need to pull down the new legacy network 
branch and build that as well.  Hopefully all goes smoothly and I'll find time 
today.

FYI, since other people are working in this area: I'll soon submit a PCI 
multi-port serial driver for an eight port PMC serial port card.  Some of the 
files will need to be shuffled around.

Peter
-
Peter Dufault
HD Associates, Inc.  Software and System Engineering

This email is delivered through the public internet using protocols subject to 
interception and tampering.



signature.asc
Description: Message signed with OpenPGP
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v2 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-15 Thread Joel Sherrill
No one has posted publicly about these in 5 days and asking privately a
group of mvme users, I only got feedback from Heinz

==
I can only note that we have some (many) users who would like to stay at
the fixed 9600 baud because that is what
they have been used to since "forever”.
I had received feedback on the MVME2500. There I had set the console of
this QorIQ based system to the typical
125600 baud for arm (also with the option BSP_CONSOLE_BAUD). Some were not
happy that there are two different
baud rates for the different MVME boards.
I personally find Paul's approach ok and if the default value
(bsp-defaults) eventually stays at 9600 baud on all
these boards could everyone be happy?

 ==

This patch series makes all the mvme BSPs consistent so I plan to
merge these today.

--joel


On Sat, Apr 10, 2021 at 7:41 AM  wrote:

> From: Peter Dufault 
>
> The "powerpc/shared/console" code has the start-up console value fixed
> at 9600 baud.  This changes the hard-wired constant "9600" in the code
> to the configuration setting "BSP_CONSOLE_BAUD" and adds configuration
> support in both the "waf" and the legacy configuration systems.
>
> In addition, once the shared console baud rate can be set to start at
> anything other than 9600 the termios code will reset it to 9600 at the
> first open.
>
> Peter Dufault (2):
>   powerpc/shared/console: Make console baud rate configurable.
>   powerpc/shared/console: "termios" first open sets console baud to 9600
>
>  bsps/powerpc/shared/console/console.c  | 4 ++--
>  bsps/powerpc/shared/console/uart.c | 5 -
>  c/src/lib/libbsp/powerpc/beatnik/configure.ac  | 4 
>  c/src/lib/libbsp/powerpc/haleakala/configure.ac| 4 
>  c/src/lib/libbsp/powerpc/motorola_powerpc/configure.ac | 4 
>  c/src/lib/libbsp/powerpc/mvme3100/configure.ac | 4 
>  c/src/lib/libbsp/powerpc/mvme5500/configure.ac | 4 
>  spec/build/bsps/optconsolebaud.yml | 5 +
>  spec/build/bsps/powerpc/beatnik/bspbeatnik.yml | 2 ++
>  spec/build/bsps/powerpc/haleakala/bsphaleakala.yml | 2 ++
>  spec/build/bsps/powerpc/motorola_powerpc/obj.yml   | 4 +++-
>  spec/build/bsps/powerpc/mvme3100/bspmvme3100.yml   | 2 ++
>  spec/build/bsps/powerpc/mvme5500/bspmvme5500.yml   | 2 ++
>  13 files changed, 42 insertions(+), 4 deletions(-)
>
> --
> 1.8.3.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v2 0/2] powerpc/shared/console: Console baud rate fixes

2021-04-10 Thread dufault



> On Apr 10, 2021, at 08:41 ,   wrote:
> 
> The "powerpc/shared/console" code has the start-up console value fixed
> at 9600 baud.  This changes the hard-wired constant "9600" in the code
> to the configuration setting "BSP_CONSOLE_BAUD" and adds configuration
> support in both the "waf" and the legacy configuration systems.
> 
> In addition, once the shared console baud rate can be set to start at
> anything other than 9600 the termios code will reset it to 9600 at the
> first open.

I did this over incorporating both patches and using "git send-email" from my 
"git" server.  Joel told me it appeared I'd cut-and-pasted the previous patch.  
I hadn't, I imported it into Apple mail as "mbox" format and then sent it.  I 
don't know if it was the import or the fact it was digitally signed that looked 
odd.

At any rate, this patch should at least be received properly.

Peter
-
Peter Dufault
HD Associates, Inc.  Software and System Engineering

This email is delivered through the public internet using protocols subject to 
interception and tampering.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel