Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
Hello Martin, On 19/03/15 01:11, Martin Galvan wrote: This patch adds support for the following devices to the LPC176x BSP: * CAN * PWM * ADC what is LPC176X specific in these drivers? See also https://lists.rtems.org/pipermail/devel/2014-June/007110.html Independent of this, I checked in the patch, since its not your fault that the RTEMS project has no clear BSP developers guide. In the long run I think that this driver diversity will lead to an unmaintainable state. -- Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail :sebastian.hu...@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
Please fix the URLs to be rtems.org (especially the license) -Gedare On Fri, Mar 20, 2015 at 4:18 AM, Sebastian Huber wrote: > Hello Martin, > > On 19/03/15 01:11, Martin Galvan wrote: >> >> This patch adds support for the following devices to the LPC176x BSP: >> >> * CAN >> * PWM >> * ADC > > > what is LPC176X specific in these drivers? See also > > https://lists.rtems.org/pipermail/devel/2014-June/007110.html > > Independent of this, I checked in the patch, since its not your fault that > the RTEMS project has no clear BSP developers guide. In the long run I think > that this driver diversity will lead to an unmaintainable state. > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail :sebastian.hu...@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > > > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
Maybe it makes sense to add a git commit hook, that rejects such patches. We already have this issue in other places as well: ./cpukit/libmisc/shell/main_md5.c: * http://www.rtems.com/license/LICENSE. ./cpukit/score/cpu/or1k/rtems/score/cpu.h: * http://www.rtems.com/license/LICENSE. ./cpukit/score/cpu/or1k/cpu.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-trace.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj-cache.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj-comp.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rap-shell.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-unresolved.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-elf.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rap.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-trace.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-rap.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-error.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rap-shell.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/dlfcn.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-fwd.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-rap.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj-comp.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/dlfcn-shell.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-unresolved.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-chain-iterator.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-chain-iterator.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-find-file.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-sym.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-sym.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-indirect-ptr.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rap.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-error.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-find-file.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/dlfcn-shell.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-shell.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-debugger.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-shell.h: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-elf.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj-cache.c: * http://www.rtems.com/license/LICENSE. ./cpukit/libdl/rtl-obj-fwd.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_syscfg.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_exti.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_tim.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_adc.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_otgfs.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_pwr.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_flash.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/include/bsp.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/include/i2c.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/clock.c: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/irq.c: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/console/console-config.c: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/beagle/misc/i2c.c: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/gpio/gpio.c: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/system-clocks.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/watchdog-defs.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/io-defs.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/timer-defs.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/lpc-clock-config.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/can-defs.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/can.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/bsp.h: * http://www.rtems.com/license/LICENSE. ./c/src/lib/libbsp/arm/lpc176x/include/l
Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
On Fri, Mar 20, 2015 at 9:08 AM, Sebastian Huber wrote: > Maybe it makes sense to add a git commit hook, that rejects such patches. We > already have this issue in other places as well: Perhaps if we get Phabricator up, it can be configured to reject patches containing rtems.com easily? ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
File a ticket. This type of thing is very hard to get rid of and have it stay gone. All it takes is someone updating code from an older tree and submitting a patch. Bam! We have it again. Needs to either reject or auto-correct. And go into the review cycle of Phabricator. On an odd note, did we finally kill that misformatted license text? --joel On 3/20/2015 8:08 AM, Sebastian Huber wrote: > Maybe it makes sense to add a git commit hook, that rejects such > patches. We already have this issue in other places as well: > > ./cpukit/libmisc/shell/main_md5.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/score/cpu/or1k/rtems/score/cpu.h: * > http://www.rtems.com/license/LICENSE. > ./cpukit/score/cpu/or1k/cpu.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-trace.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj-cache.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj-comp.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rap-shell.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-unresolved.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-elf.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rap.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-trace.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-rap.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-error.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rap-shell.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/dlfcn.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-fwd.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-rap.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj-comp.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/dlfcn-shell.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-unresolved.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-chain-iterator.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-chain-iterator.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-find-file.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-sym.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-sym.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-indirect-ptr.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rap.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-error.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-find-file.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/dlfcn-shell.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-shell.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-debugger.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-shell.h: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-elf.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj-cache.c: * http://www.rtems.com/license/LICENSE. > ./cpukit/libdl/rtl-obj-fwd.h: * http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_syscfg.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_exti.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_tim.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_adc.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_otgfs.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_pwr.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/stm32f4/include/stm32f4_flash.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/include/bsp.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/include/i2c.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/clock.c: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/irq.c: * http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/console/console-config.c: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/beagle/misc/i2c.c: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/lpc176x/gpio/gpio.c: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/lpc176x/include/system-clocks.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/lpc176x/include/watchdog-defs.h: * > http://www.rtems.com/license/LICENSE. > ./c/src/lib/libbsp/arm/lpc176x/include/io-defs.h: * > http://ww
Re: [PING][PATCH] LPC176x: Add CAN, PWM, ADC and UART1/2/3 support to the BSP.
On Fri, Mar 20, 2015 at 10:47 AM, Joel Sherrill wrote: > On an odd note, did we finally kill that misformatted > license text? > Not sure what you mean. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
