Re: pc386 BSP documentation tweaks.
On Mon, Sep 21, 2020 at 12:40 PM Karel Gardas wrote: > On 9/21/20 7:34 PM, Gedare Bloom wrote: > > On Sat, Sep 19, 2020 at 2:31 PM Karel Gardas > wrote: > >> > >> > >> Hello, > >> > >> attached are three patches: > >> > >> pc386 BSP: add runtime options for debugging and move few lines > >> around for better context. > >> pc386 BSP: add a note about default baud rate for console over > UART/COM. > >> pc386 BSP: remove USE_COM1_AS_CONSOLE reference, the option is long > >> time gone. > > > > We still have this option, but I don't think it does anything. Maybe > > it should be noted as "Obsolete"? > > By "long gone" I mean this option is handled by configure/make and now > also waf, but is not preserved in the C code at all. So basically the > option does nothing as implementation C code was probably removed. > > Or am I looking wrong? > No. It is dead as in "He's dead, Jim". :) It is still in the README: pc386/README:+ BSP_ENABLE_COM1_COM4 - value of 1 to enable, 0 to disable pc386/README:+ BSP_USE_COM1_AS_CONSOLE - value of 1 forces console to COM1 pc386/README: USE_COM1_AS_CONSOLE=1 --enable-rtemsbsp=pc386 \ And I think providing guidance in the user's manual that if you used to use this option when building, that there is a new way to achieve the same result would be desirable. --joel > > Thanks, > Karel > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel > ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: pc386 BSP documentation tweaks.
On 9/21/20 7:52 PM, Gedare Bloom wrote: >> By "long gone" I mean this option is handled by configure/make and now >> also waf, but is not preserved in the C code at all. So basically the >> option does nothing as implementation C code was probably removed. >> >> Or am I looking wrong? >> > > I think you're correct. I'm just wondering if it is better to note > that this option exists but doesn't do anything, as opposed to just > removing its documentation. I've not managed this over my weekend RTEMS hobby but my idea was to submit doc change first and then also submit source code change which would remove configuration bits of the option completely -- result would be RTEMS clean of the option completely. Sorry about missing source code removal yet. Karel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: pc386 BSP documentation tweaks.
On Mon, Sep 21, 2020 at 11:40 AM Karel Gardas wrote: > > On 9/21/20 7:34 PM, Gedare Bloom wrote: > > On Sat, Sep 19, 2020 at 2:31 PM Karel Gardas > > wrote: > >> > >> > >> Hello, > >> > >> attached are three patches: > >> > >> pc386 BSP: add runtime options for debugging and move few lines > >> around for better context. > >> pc386 BSP: add a note about default baud rate for console over > >> UART/COM. > >> pc386 BSP: remove USE_COM1_AS_CONSOLE reference, the option is long > >> time gone. > > > > We still have this option, but I don't think it does anything. Maybe > > it should be noted as "Obsolete"? > > By "long gone" I mean this option is handled by configure/make and now > also waf, but is not preserved in the C code at all. So basically the > option does nothing as implementation C code was probably removed. > > Or am I looking wrong? > I think you're correct. I'm just wondering if it is better to note that this option exists but doesn't do anything, as opposed to just removing its documentation. > Thanks, > Karel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: pc386 BSP documentation tweaks.
On 9/21/20 7:34 PM, Gedare Bloom wrote: > On Sat, Sep 19, 2020 at 2:31 PM Karel Gardas wrote: >> >> >> Hello, >> >> attached are three patches: >> >> pc386 BSP: add runtime options for debugging and move few lines >> around for better context. >> pc386 BSP: add a note about default baud rate for console over UART/COM. >> pc386 BSP: remove USE_COM1_AS_CONSOLE reference, the option is long >> time gone. > > We still have this option, but I don't think it does anything. Maybe > it should be noted as "Obsolete"? By "long gone" I mean this option is handled by configure/make and now also waf, but is not preserved in the C code at all. So basically the option does nothing as implementation C code was probably removed. Or am I looking wrong? Thanks, Karel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: pc386 BSP documentation tweaks.
On Sat, Sep 19, 2020 at 2:31 PM Karel Gardas wrote: > > > Hello, > > attached are three patches: > > pc386 BSP: add runtime options for debugging and move few lines > around for better context. > pc386 BSP: add a note about default baud rate for console over UART/COM. > pc386 BSP: remove USE_COM1_AS_CONSOLE reference, the option is long > time gone. We still have this option, but I don't think it does anything. Maybe it should be noted as "Obsolete"? > > please review/commit or request change(s). > > The patches are based on my playing with BSP and seeing documentation > limitations or missing info bits... > > Thanks, > Karel > ___ > devel mailing list > devel@rtems.org > http://lists.rtems.org/mailman/listinfo/devel ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
