rtems-tester coverage patches break or1k/sis runs

2014-10-01 Thread Joel Sherrill
Krzysztof/Hesham,

And devel@ since this needs to be public now.

I am trying to test or1ksim and sis using rtems-tester.
We need to get Krzysztof's patches merged and I am
just trying to run down all the issues I can.

You both have made some changes to the repository
and I am having issues. Krzysztof's are on a branch
for me and I have attached them.  Except for the note
before the remains of the old email, all issues are
with Krzysztof's changes.

Hesham's are all committed.

$ ~/rtems-4.11-work/rtems-tools/tester/rtems-test --log=or1ksim.log
--rtems-bsp=sis --rtems-tools=/users/joel/rtems-4.11-work/tools 
sparc-rtems4.11/c/sis/testsuites/samples/hello/
RTEMS Testing - Tester, v0.2.0
error: gdb.cfg:59: macro '%{_coverage}' not found
warning: switched to dry run due to errors
error: gdb.cfg:59: invalid if bool value:  %if %{_coverage}
[1/1] p:0 f:0 t:0 i:0 | sparc/sis: hello.exe

When I use Krzysztof's branch with the or1ksim as shown below,
it adds a 1 to the end of the qemu-system-or32 invocation.

On 10/1/2014 11:19 AM, Hesham Moustafa wrote:
> I cloned a vanilla RTEMS tester, and it works fine with me with the
> following command 
> "~/development/rtems/test/rtems-tester/tester/rtems-test
> --log=or1ksim.log --rtems-bsp=or1ksim
> /home/hesham/build/or1k-rtems4.11/c/or1ksim/testsuites/"
>
But it seemed to run a long time and then I killed it when
I used your command.

And when I try to run it on sis, you do need the --rtems-tools
argument to find the simulator. I don't know what the difference
for this is when doing the or1ksim. I think it should be required
for consistency.

-- 
Joel Sherrill, Ph.D. Director of Research & Development
joel.sherr...@oarcorp.comOn-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available(256) 722-9985



krzy-patches.tar.bz2
Description: Binary data
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: rtems-tester coverage patches break or1k/sis runs

2014-10-01 Thread Chris Johns

On 2/10/2014 3:44 am, Joel Sherrill wrote:

Krzysztof/Hesham,

And devel@ since this needs to be public now.

I am trying to test or1ksim and sis using rtems-tester.
We need to get Krzysztof's patches merged and I am
just trying to run down all the issues I can.

You both have made some changes to the repository
and I am having issues. Krzysztof's are on a branch
for me and I have attached them.  Except for the note
before the remains of the old email, all issues are
with Krzysztof's changes.

Hesham's are all committed.

$ ~/rtems-4.11-work/rtems-tools/tester/rtems-test --log=or1ksim.log
--rtems-bsp=sis --rtems-tools=/users/joel/rtems-4.11-work/tools
sparc-rtems4.11/c/sis/testsuites/samples/hello/
RTEMS Testing - Tester, v0.2.0
error: gdb.cfg:59: macro '%{_coverage}' not found
warning: switched to dry run due to errors
error: gdb.cfg:59: invalid if bool value:  %if %{_coverage}
[1/1] p:0 f:0 t:0 i:0 | sparc/sis: hello.exe



There is something missing in the default configuration. The pattern 
often used in this case is to define a default if the macro is not 
defined before any logic that uses it.



When I use Krzysztof's branch with the or1ksim as shown below,
it adds a 1 to the end of the qemu-system-or32 invocation.

On 10/1/2014 11:19 AM, Hesham Moustafa wrote:

I cloned a vanilla RTEMS tester, and it works fine with me with the
following command
"~/development/rtems/test/rtems-tester/tester/rtems-test
--log=or1ksim.log --rtems-bsp=or1ksim
/home/hesham/build/or1k-rtems4.11/c/or1ksim/testsuites/"


But it seemed to run a long time and then I killed it when
I used your command.

And when I try to run it on sis, you do need the --rtems-tools
argument to find the simulator. I don't know what the difference
for this is when doing the or1ksim. I think it should be required
for consistency.


Yes, dependence on environment variables should not occur.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: rtems-tester coverage patches break or1k/sis runs

2014-10-01 Thread Krzysztof Mięsowicz
Hi,

I will check this in the evening and prepare a fix - it should not be
difficult.

2014-10-02 1:57 GMT+02:00 Chris Johns :

> On 2/10/2014 3:44 am, Joel Sherrill wrote:
>
>> Krzysztof/Hesham,
>>
>> And devel@ since this needs to be public now.
>>
>> I am trying to test or1ksim and sis using rtems-tester.
>> We need to get Krzysztof's patches merged and I am
>> just trying to run down all the issues I can.
>>
>> You both have made some changes to the repository
>> and I am having issues. Krzysztof's are on a branch
>> for me and I have attached them.  Except for the note
>> before the remains of the old email, all issues are
>> with Krzysztof's changes.
>>
>> Hesham's are all committed.
>>
>> $ ~/rtems-4.11-work/rtems-tools/tester/rtems-test --log=or1ksim.log
>> --rtems-bsp=sis --rtems-tools=/users/joel/rtems-4.11-work/tools
>> sparc-rtems4.11/c/sis/testsuites/samples/hello/
>> RTEMS Testing - Tester, v0.2.0
>> error: gdb.cfg:59: macro '%{_coverage}' not found
>> warning: switched to dry run due to errors
>> error: gdb.cfg:59: invalid if bool value:  %if %{_coverage}
>> [1/1] p:0 f:0 t:0 i:0 | sparc/sis: hello.exe
>>
>>
> There is something missing in the default configuration. The pattern often
> used in this case is to define a default if the macro is not defined before
> any logic that uses it.
>
>  When I use Krzysztof's branch with the or1ksim as shown below,
>> it adds a 1 to the end of the qemu-system-or32 invocation.
>>
>> On 10/1/2014 11:19 AM, Hesham Moustafa wrote:
>>
>>> I cloned a vanilla RTEMS tester, and it works fine with me with the
>>> following command
>>> "~/development/rtems/test/rtems-tester/tester/rtems-test
>>> --log=or1ksim.log --rtems-bsp=or1ksim
>>> /home/hesham/build/or1k-rtems4.11/c/or1ksim/testsuites/"
>>>
>>>  But it seemed to run a long time and then I killed it when
>> I used your command.
>>
>> And when I try to run it on sis, you do need the --rtems-tools
>> argument to find the simulator. I don't know what the difference
>> for this is when doing the or1ksim. I think it should be required
>> for consistency.
>>
>
> Yes, dependence on environment variables should not occur.
>
> Chris
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: rtems-tester coverage patches break or1k/sis runs

2014-10-02 Thread Hesham Moustafa
On Wed, Oct 1, 2014 at 7:44 PM, Joel Sherrill 
wrote:

> Krzysztof/Hesham,
>
> And devel@ since this needs to be public now.
>
> I am trying to test or1ksim and sis using rtems-tester.
> We need to get Krzysztof's patches merged and I am
> just trying to run down all the issues I can.
>
> You both have made some changes to the repository
> and I am having issues. Krzysztof's are on a branch
> for me and I have attached them.  Except for the note
> before the remains of the old email, all issues are
> with Krzysztof's changes.
>
> Hesham's are all committed.
>
> $ ~/rtems-4.11-work/rtems-tools/tester/rtems-test --log=or1ksim.log
> --rtems-bsp=sis --rtems-tools=/users/joel/rtems-4.11-work/tools
> sparc-rtems4.11/c/sis/testsuites/samples/hello/
> RTEMS Testing - Tester, v0.2.0
> error: gdb.cfg:59: macro '%{_coverage}' not found
> warning: switched to dry run due to errors
> error: gdb.cfg:59: invalid if bool value:  %if %{_coverage}
> [1/1] p:0 f:0 t:0 i:0 | sparc/sis: hello.exe
>
> When I use Krzysztof's branch with the or1ksim as shown below,
> it adds a 1 to the end of the qemu-system-or32 invocation.
>
> On 10/1/2014 11:19 AM, Hesham Moustafa wrote:
> > I cloned a vanilla RTEMS tester, and it works fine with me with the
> > following command
> > "~/development/rtems/test/rtems-tester/tester/rtems-test
> > --log=or1ksim.log --rtems-bsp=or1ksim
> > /home/hesham/build/or1k-rtems4.11/c/or1ksim/testsuites/"
> >
> But it seemed to run a long time and then I killed it when
> I used your command.
>
> Yes, that a know issue. I used to run RTEMS tester like that and not
killing it to wait until each test time-outl; that's why it usually takes
too long. Adding a shutdown signal to qemu will solve this issue.

> And when I try to run it on sis, you do need the --rtems-tools
> argument to find the simulator. I don't know what the difference
> for this is when doing the or1ksim. I think it should be required
> for consistency.
>
> --
> Joel Sherrill, Ph.D. Director of Research & Development
> joel.sherr...@oarcorp.comOn-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
> Support Available(256) 722-9985
>
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: rtems-tester coverage patches break or1k/sis runs

2014-10-04 Thread Krzysztof Mięsowicz
Hi,

First, sorry for so late response. I've finally make a fix - it should help
with this error. Macro _coverage is defined if --coverage option has been
passed to rtems-test. I've encountered and fixed this problem in qemu.cfg
before and forgot about gdb.cfg...

Please, let me know if it solve the problem.

2014-10-02 8:37 GMT+02:00 Krzysztof Mięsowicz :

> Hi,
>
> I will check this in the evening and prepare a fix - it should not be
> difficult.
>
> 2014-10-02 1:57 GMT+02:00 Chris Johns :
>
>> On 2/10/2014 3:44 am, Joel Sherrill wrote:
>>
>>> Krzysztof/Hesham,
>>>
>>> And devel@ since this needs to be public now.
>>>
>>> I am trying to test or1ksim and sis using rtems-tester.
>>> We need to get Krzysztof's patches merged and I am
>>> just trying to run down all the issues I can.
>>>
>>> You both have made some changes to the repository
>>> and I am having issues. Krzysztof's are on a branch
>>> for me and I have attached them.  Except for the note
>>> before the remains of the old email, all issues are
>>> with Krzysztof's changes.
>>>
>>> Hesham's are all committed.
>>>
>>> $ ~/rtems-4.11-work/rtems-tools/tester/rtems-test --log=or1ksim.log
>>> --rtems-bsp=sis --rtems-tools=/users/joel/rtems-4.11-work/tools
>>> sparc-rtems4.11/c/sis/testsuites/samples/hello/
>>> RTEMS Testing - Tester, v0.2.0
>>> error: gdb.cfg:59: macro '%{_coverage}' not found
>>> warning: switched to dry run due to errors
>>> error: gdb.cfg:59: invalid if bool value:  %if %{_coverage}
>>> [1/1] p:0 f:0 t:0 i:0 | sparc/sis: hello.exe
>>>
>>>
>> There is something missing in the default configuration. The pattern
>> often used in this case is to define a default if the macro is not defined
>> before any logic that uses it.
>>
>>  When I use Krzysztof's branch with the or1ksim as shown below,
>>> it adds a 1 to the end of the qemu-system-or32 invocation.
>>>
>>> On 10/1/2014 11:19 AM, Hesham Moustafa wrote:
>>>
 I cloned a vanilla RTEMS tester, and it works fine with me with the
 following command
 "~/development/rtems/test/rtems-tester/tester/rtems-test
 --log=or1ksim.log --rtems-bsp=or1ksim
 /home/hesham/build/or1k-rtems4.11/c/or1ksim/testsuites/"

  But it seemed to run a long time and then I killed it when
>>> I used your command.
>>>
>>> And when I try to run it on sis, you do need the --rtems-tools
>>> argument to find the simulator. I don't know what the difference
>>> for this is when doing the or1ksim. I think it should be required
>>> for consistency.
>>>
>>
>> Yes, dependence on environment variables should not occur.
>>
>> Chris
>>
>
>
From 3926bbea154ff351a2316f9ba9dfcbdcbc88b4ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krzysztof=20Mi=C4=99sowicz?= 
Date: Sat, 4 Oct 2014 21:04:28 +0200
Subject: [PATCH] Coverage requested check in gdb.cfg fix

---
 tester/rtems/testing/gdb.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tester/rtems/testing/gdb.cfg b/tester/rtems/testing/gdb.cfg
index 5ca344a..f77e2d5 100644
--- a/tester/rtems/testing/gdb.cfg
+++ b/tester/rtems/testing/gdb.cfg
@@ -56,7 +56,7 @@
 #
 # Coverage analysis
 #
-%if %{_coverage}
+%if %{defined _coverage}
  %error "Coverage analysis unsupported"
 %endif
 
-- 
1.9.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel