[developer] Re: [openzfs/openzfs] 8435 zpool.1m and zfs.1m: minor cleanup (#415)
gmelikov commented on this pull request. > @@ -77,7 +78,7 @@ .Nm .Cm import .Op Fl D -.Op Fl d Ar dir +.Op Fl c Ar cachefile Ns | Ns Fl d Ar dir @yuripv @ahrens thanks for clarification, I removed it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/415#discussion_r126650259 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Ta6738782f37e9432-Mdfa479a64b3f5b1c649adde9 Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)
brad-lewis approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/407#pullrequestreview-49254397 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T693650e65dc896fc-M66d9fdb6f42734cb8c61d036 Powered by Topicbox: https://topicbox.com
[developer] [openzfs/openzfs] 8473 scrub does not detect errors on active spares (#422)
ZFS should scrub spare devices that have already finished resilvering You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/422 -- Commit Summary -- * 8473 scrub does not detect errors on active spares -- File Changes -- M usr/src/uts/common/fs/zfs/vdev_mirror.c (53) -- Patch Links -- https://github.com/openzfs/openzfs/pull/422.patch https://github.com/openzfs/openzfs/pull/422.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/422 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Te100c9e22da2b1d8-M70f3100326cbbaca6e39a343 Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)
alek-p commented on this pull request. > + } else if (*cmd != POOL_SCRUB_NORMAL) { + return (SET_ERROR(ENOTSUP)); + } + + return (0); +} + +static void +dsl_scrub_pause_resume_sync(void *arg, dmu_tx_t *tx) +{ + pool_scrub_cmd_t *cmd = arg; + dsl_pool_t *dp = dmu_tx_pool(tx); + spa_t *spa = dp->dp_spa; + dsl_scan_t *scn = dp->dp_scan; + + looks like I have an extra blank line here, I'll remove that in a min -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/407#pullrequestreview-49300907 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T693650e65dc896fc-M57b16702199bc78c5d6b8640 Powered by Topicbox: https://topicbox.com
[developer] [openzfs/openzfs] 8484 Implement aggregate sum and use for arc counters (#423)
Reviewed by: Pavel Zakharov Reviewed by: Matthew Ahrens In pursuit of improving performance on multi-core systems, this patch implements fanned out counters and uses them to improve the performance of some of the arc statistics. These stats are updated extremely frequently, and can consume a significant amount of CPU time. The cityhash code is copied from google's github, where it is MIT licensed. Upstream bugs: DLPX-51685 You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/423 -- Commit Summary -- * 8484 Implement aggregate sum and use for arc counters -- File Changes -- M exception_lists/copyright (1) M usr/src/pkg/manifests/system-file-system-zfs.mf (4) M usr/src/uts/common/Makefile.files (2) A usr/src/uts/common/fs/zfs/THIRDPARTYLICENSE.cityhash (19) A usr/src/uts/common/fs/zfs/THIRDPARTYLICENSE.cityhash.descrip (1) A usr/src/uts/common/fs/zfs/aggsum.c (232) M usr/src/uts/common/fs/zfs/arc.c (170) A usr/src/uts/common/fs/zfs/cityhash.c (63) M usr/src/uts/common/fs/zfs/dbuf.c (20) A usr/src/uts/common/fs/zfs/sys/aggsum.h (61) A usr/src/uts/common/fs/zfs/sys/cityhash.h (41) -- Patch Links -- https://github.com/openzfs/openzfs/pull/423.patch https://github.com/openzfs/openzfs/pull/423.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/423 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/Tdd11813c34a59905-M4ce258dd3fcc9217dd5b1403 Powered by Topicbox: https://topicbox.com