[developer] Re: [openzfs/openzfs] 6363 Add UNMAP/TRIM functionality to ZFS and Illumos (#172)

2018-06-13 Thread Igor K
what is it status of this implementation ?
how to hard rebase it to latest master?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/172#issuecomment-397102771
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Ta7c0d14ddf82209a-Mf335a4492a01b4f2d1530941
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9591 ms_shift can be incorrectly changed in MOS config for indirect vdevs that have been historically expanded (#651)

2018-06-13 Thread John Wren Kennedy
jwk404 requested changes on this pull request.

The Makefile in tests/functional/removal is the old style, which required 
enumeration of all the tests. Rather than add this test to that file, could you 
convert it to look like the one in use at Delphix?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/651#pullrequestreview-128458778
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Taa3327c923b01149-M6bf03c847428c7280a8d59ee
Delivery options: https://openzfs.topicbox.com/groups


[developer] Re: [openzfs/openzfs] 9591 ms_shift can be incorrectly changed in MOS config for indirect vdevs that have been historically expanded (#651)

2018-06-13 Thread Tim Chase
dweeezil approved this pull request.

LGTM.  Tested under ZoL as part of the pool checkpoint work.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/651#pullrequestreview-128454673
--
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/Taa3327c923b01149-Md10ef7d354937f8d7be7b708
Delivery options: https://openzfs.topicbox.com/groups