[developer] Re: [openzfs/openzfs] 9466 add JSON output support to channel programs (#619)
I was going to make a post similar to what @behlendorf posted, but I deleted what I had typed when I realized that we might end up breaking a bunch of people's scripts who are using non `POSIXLY_CORRECT` option formats. I don't really have a good answer for how to do that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/619#issuecomment-424454432 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T0465226805877059-Ma03b4d871c845cb18294379d Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)
I wouldn't worry about the encryption related `zfs recv -o / -x` changes until the PR has been merged into ZoL. It's passing tests right now, but I still need to add some documentation / man pages to it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/489#issuecomment-403521773 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T02d6a9917e14b170-Me1afd97ee3658a3a688d5cf7 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (7dec52f)
match style of original PR (no curly braces) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/commit/7dec52f2003048788e25e86bd2e6561687c30a76#commitcomment-29548864 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T519b227f08969fb1-Mc068fb9e03ff94a3e10f208b Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)
tcaputi approved this pull request. This patch looks good and all the edge cases I could think of are handled appropriately (zfs upgrade, etc). As a minor convenience, I would want a way to determine how much memory my metadata cache is using (in ZoL we would make this a read-only tunable, maybe you can already see this in Illumos with your debugging tools). I would also be interested to know what the limiting performance factor is after applying this diff. 51 seconds still seems like a long time when all the data is already in memory. This, however, is not really a concern for this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#pullrequestreview-106650144 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-M52593237719a1891e9e13fe9 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)
@ahrens care to weigh in on how to handle this at all? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#issuecomment-321138143 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T1625245905c55186-M18cd1ca4806f349e0ba3dd2c Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)
tcaputi commented on this pull request. > @@ -1200,6 +1210,18 @@ transactions. Not all damaged pools can be recovered by using this option. If successful, the data from the discarded transactions is irretrievably lost. This option is ignored if the pool is importable or already imported. +.It Fl l +Indicates that the zpool command will request encryption keys for all +encrypted datasets it attempts to mount as it is bringing the pool +online. This is equivalent to running +.Nm Cm mount +on each encrypted dataset immediately after the pool is imported. +If any datasets have a +.Sy prompt +keysource this command will block waiting for the key to be entered. +Otherwise, encrypted datasets will be left unavailable until the keys are +loaded. +>>> 97611e4... Native data and metadata encryption for zfs This looks like a merge mistake :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/124#pullrequestreview-48158899 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T1625245905c55186-Me048bd654cdd9a6c1bd9a0cb Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)
@avg-I yes it is -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/407#issuecomment-311765827 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/discussions/T693650e65dc896fc-Maf73b078a6d385db63fc4e29 Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] 7432 Reserve send stream flag for large dnode feature (#381)
OK. I will adjust the encryption patch to use bit 24 for raw sends then. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/381#issuecomment-302234139 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/ Powered by Topicbox: https://topicbox.com
[developer] Re: [openzfs/openzfs] 7432 Reserve send stream flag for large dnode feature (#381)
doesn't the large dnodes send feature use bit 21? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/381#issuecomment-302202756 -- openzfs-developer Archives: https://openzfs.topicbox.com/groups/developer/ Powered by Topicbox: https://topicbox.com
