[developer] Re: [openzfs/openzfs] 7823 implement autoreplace matching based on FRU slot number (#416)

2017-06-28 Thread Yuri Pankov 
@yuripv pushed 1 commit.

28ae1bb  choose slice depending on the boot size property (thanks, @tsoome)


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/416/files/6c0a9010b3a3719c1e3b7d3aeb571fcc70c5a8f4..28ae1bbdeb148b841c5c678bc34c24ec8b4b287d

--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T97ec8ed8719a97d0-M6e3b932f3564fa185ed2a3a0
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 7823 implement autoreplace matching based on FRU slot number (#416)

2017-07-23 Thread Alek P 
alek-p approved this pull request.

this is illumos specific and LGTM

> + return (tmp);
+}
+
+/*
+ * Check if given FRUs match by slot number to skip comparing disk specific
+ * fields of the FRU.
+ */
+/* ARGSUSED */
+int
+libzfs_fru_cmp_slot(libzfs_handle_t *hdl, const char *a, const char *b,
+size_t len)
+{
+   char *slota, *slotb;
+   int ret = -1;
+
+   if (a == NULL || b == NULL)

I believe means that auto replace won't take place on drives, not in an 
enclosure or drives inside enclosures that don't report a bay number.
It would be nice to allow autoreplace on non-enclosure devices but that comes 
with the risk of screwing up jbod affinity in other use cases so I'm not sure 
there is a better way to deal with theses cases...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/416#pullrequestreview-51649863
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T97ec8ed8719a97d0-M2883c363ecd2f7cd6ce140f0
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 7823 implement autoreplace matching based on FRU slot number (#416)

2017-08-23 Thread Yuri Pankov 
Given no interest in reviewing this, I'm going to close the PR and try to RTI 
this as is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/416#issuecomment-324478316
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T97ec8ed8719a97d0-Md456ed1a331b5c8abdeea030
Powered by Topicbox: https://topicbox.com

[developer] Re: [openzfs/openzfs] 7823 implement autoreplace matching based on FRU slot number (#416)

2017-08-23 Thread Yuri Pankov 
Closed #416.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/416#event-1218744542
--
openzfs-developer
Archives: 
https://openzfs.topicbox.com/groups/developer/discussions/T97ec8ed8719a97d0-M2624dc9b3894499394a46c57
Powered by Topicbox: https://topicbox.com