[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)
And to pull back in to OpenZFS, here's the commit https://github.com/zfsonlinux/zfs/commit/5e021f56d3437d3523904652fe3cc23ea1f4cb70. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#issuecomment-37600 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-Madc7663fd493f262d2096ecf Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)
In ZoL there is a dbuf_stats kstat that is the appropriate place for these. It will be natural to extend for the ZoL port. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#issuecomment-375989049 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-M5ccf1db6c1bc5c2d18dbb8ea Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)
@tcaputi To determine the cache size, you could look at `dbuf_caches[DB_DBUF_METADATA_CACHE].size`. While this is trivial with mdb (assuming you have root access), I agree it would be nice to add a kstat for this. IIRC, it seemed like kind of a pain since the kstats seem to be specific to each .c file, and there isn't already a kstat set up in dbuf.c. But that doesn't mean we shouldn't do it at some point :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#issuecomment-375810016 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-Mc7e019ff12d62a302f8726e4 Delivery options: https://openzfs.topicbox.com/groups
[developer] Re: [openzfs/openzfs] 9337 zfs get all is slow due to uncached metadata (#599)
tcaputi approved this pull request. This patch looks good and all the edge cases I could think of are handled appropriately (zfs upgrade, etc). As a minor convenience, I would want a way to determine how much memory my metadata cache is using (in ZoL we would make this a read-only tunable, maybe you can already see this in Illumos with your debugging tools). I would also be interested to know what the limiting performance factor is after applying this diff. 51 seconds still seems like a long time when all the data is already in memory. This, however, is not really a concern for this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/599#pullrequestreview-106650144 -- openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T644dae5d5a17704c-M52593237719a1891e9e13fe9 Delivery options: https://openzfs.topicbox.com/groups
