Re: [Development] pushes to gerrit failing

2012-06-06 Thread Samuel Rødal
On 06/06/2012 01:59 AM, ext Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

Not just for Girish, happens here as well.

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to 'ssh://codereview.qt-project.org/qt/qtbase'

http://asheepapart.blogspot.no/2011/10/gerrit-code-review-unpack-error-missing.html

Seems like a pretty severe issue.

--
Samuel
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] mkspec linux-arm-armcc for qt5

2012-06-06 Thread song.7.liu
Thanks for sharing...

Anyway, the armcc4.1 is still used for our project... and now theQtCore can be 
successfully build out, but I still have one C++ template related error in 
qtnetwork module as bellow:

access/qnetworkrequest_p.h, line 94: Error:  #2574: explicit 
specialization of class QTypeInfoQPairQByteArray, QByteArray must precede 
its first use (at line 105 of 
../../include/QtCore/../../src/corelib/tools/qlist.h)
  Q_DECLARE_TYPEINFO(QNetworkHeadersPrivate::RawHeaderPair, Q_MOVABLE_TYPE);

Code of qnetworkrequest_p.h:
L1:  class QNetworkHeadersPrivate
L2:  {
L3:  public:
L4:  typedef QPairQByteArray, QByteArray RawHeaderPair;
L5:  typedef QListRawHeaderPair RawHeadersList;
L6:  ...
  };

L94:  Q_DECLARE_TYPEINFO(QNetworkHeadersPrivate::RawHeaderPair, Q_MOVABLE_TYPE);

And the above code indicates that QListRawHeaderPair (L4) will firstly use 
the QTypeInfoRawHeaderPair, which is declared in last code L94.
So it seems an error, but does anyone know how to fix it ? or how to ignore 
such error ?

Thanks,
Song

-Original Message-
From: development-bounces+song.7.liu=nokia@qt-project.org 
[mailto:development-bounces+song.7.liu=nokia@qt-project.org] On Behalf Of 
ext Thiago Macieira
Sent: Monday, June 04, 2012 7:20 PM
To: development@qt-project.org
Subject: Re: [Development] mkspec linux-arm-armcc  for qt5

On segunda-feira, 4 de junho de 2012 08.32.03, song.7@nokia.com wrote:
 Hi,
 
 We are trying to use armcc to build qt5, and meet many compiling issues...
 Here, I just want to confirm that is there some assumption / 
 limitation in our qt5 code base about use armcc or gcc ???

I don't think anyone has compiler using that compiler for months or even years.

It's completely untested. Here there be dragons.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Qt5 Alpha doesn't compile any projects on WinXP x86

2012-06-06 Thread Daniel Kreuter
Hello,

when I try to compile an Qt5 example I get the following error:

jom: C:\Documents and Settings\USER\My
Documents\Projekt\Qt5MultimediaDemo02\Makefile [release] Error 2
08:39:20: Der Prozess C:\Qt\qtcreator-2.5.0\bin\jom.exe wurde mit
dem Rückgabewert 2 beendet.
Fehler beim Erstellen/Deployment des Projekts Qt5MultimediaDemo02(Ziel: Desktop)
Bei der Ausführung von Schritt 'Make'

Anyone an idea?

For the ones who don't understand the german parts in the error
message: jom exits with error code 2 while compiling.

-- 
Mit freundlichen Grüßen

Greetings

Daniel Kreuter
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread 1+1=2
$ git push gerrit HEAD:refs/for/master
Counting objects: 15, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 854 bytes, done.
Total 8 (delta 7), reused 0 (delta 0)
fatal: Unpack error, check server logremote: Resolving deltas:   0% (0/7)

error: unpack failed: error Missing unknown
e8b7a949c3099611437abf65ebd94e822f3aba9e
To dbzhang...@codereview.qt-project.org:qt/qtbase
 ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
error: failed to push some refs to
'dbzhang...@codereview.qt-project.org:qt/qtbase'

On Tue, Jun 5, 2012 at 11:29 PM, Samuel Rødal samuel.ro...@nokia.com wrote:
 On 06/06/2012 01:59 AM, ext Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

 Not just for Girish, happens here as well.

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to 
 'ssh://codereview.qt-project.org/qt/qtbase'

 http://asheepapart.blogspot.no/2011/10/gerrit-code-review-unpack-error-missing.html

 Seems like a pretty severe issue.

 --
 Samuel
 ___
 Development mailing list
 Development@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] mkspec linux-arm-armcc for qt5

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 06.27.06, song.7@nokia.com wrote:
 L94:  Q_DECLARE_TYPEINFO(QNetworkHeadersPrivate::RawHeaderPair,
 Q_MOVABLE_TYPE);

 And the above code indicates that QListRawHeaderPair (L4) will firstly use
 the QTypeInfoRawHeaderPair, which is declared in last code L94. So it
 seems an error, but does anyone know how to fix it ? or how to ignore such
 error ?

You can remove this line. Declaring a QPair's type info is not necessary since
there's a partial template specialisation for it in qpair.h which will do the
right thing.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Thiago Macieira
On terça-feira, 5 de junho de 2012 16.59.41, Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to
 'ssh://codereview.qt-project.org/qt/qtbase'

Yeah, I broke it yesterday somehow creating a topic branch. I got a database
error when pushing and let Matias know immediately, but I guess he had already
left for the day.

That SHA-1 above is the commit for this patch:
https://codereview.qt-project.org/28033

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt5 Alpha doesn't compile any projects on WinXP x86

2012-06-06 Thread 1+1=2
You should go to qt-interest or qt-project.org/forums
This list is for developing Qt  instead of developing with Qt.

Debao

2012/6/5 Daniel Kreuter daniel.kreute...@googlemail.com:
 Hello,

 when I try to compile an Qt5 example I get the following error:

 jom: C:\Documents and Settings\USER\My
 Documents\Projekt\Qt5MultimediaDemo02\Makefile [release] Error 2
 08:39:20: Der Prozess C:\Qt\qtcreator-2.5.0\bin\jom.exe wurde mit
 dem Rückgabewert 2 beendet.
 Fehler beim Erstellen/Deployment des Projekts Qt5MultimediaDemo02(Ziel: 
 Desktop)
 Bei der Ausführung von Schritt 'Make'

 Anyone an idea?

 For the ones who don't understand the german parts in the error
 message: jom exits with error code 2 while compiling.

 --
 Mit freundlichen Grüßen

 Greetings

 Daniel Kreuter
 ___
 Development mailing list
 Development@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt5 Alpha doesn't compile any projects on WinXP x86

2012-06-06 Thread 1+1=2
On Wed, Jun 6, 2012 at 12:05 AM, Thiago Macieira
thiago.macie...@intel.com wrote:
 The alpha package is too old. Can you retry with a recent Git version and let
 us know if the problem still happens?


The fail should be caused by the space in the path: C:\Documents
and Settings\USER\My...
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread Giuseppe D'Angelo
Hi,

On 6 June 2012 02:42,  song.7@nokia.com wrote:
 We are doing a customized build on qt5, but can I disable the pcre in qt5 ?

it does not exactly work out of the box, but with little effort you
should be able to define QT_NO_REGEXP (to avoid compiling
QRegularExpression) and remove the PCRE inclusion from tools.pri...

May I ask which kind of customized build are you doing and why you'd
like to strip PCRE? Size? Or do you have a platform on which PCRE does
not work?

Cheers,
-- 
Giuseppe D'Angelo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread song.7.liu
Yes, we are creating a super minimal build with basic functionalities...
But is there some feature depending on the REGEXP in case if it's disabled 
other features don't work then.

Thanks,
Song

-Original Message-
From: ext Giuseppe D'Angelo [mailto:dange...@gmail.com] 
Sent: Wednesday, June 06, 2012 4:34 PM
To: Liu Song.7 (Nokia-MP/Beijing)
Cc: development@qt-project.org
Subject: Re: [Development] About pcre in qt5
Importance: High

Hi,

On 6 June 2012 02:42,  song.7@nokia.com wrote:
 We are doing a customized build on qt5, but can I disable the pcre in qt5 ?

it does not exactly work out of the box, but with little effort you should be 
able to define QT_NO_REGEXP (to avoid compiling
QRegularExpression) and remove the PCRE inclusion from tools.pri...

May I ask which kind of customized build are you doing and why you'd like to 
strip PCRE? Size? Or do you have a platform on which PCRE does not work?

Cheers,
--
Giuseppe D'Angelo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 08.44.22, song.7@nokia.com wrote:
 Yes, we are creating a super minimal build with basic functionalities...
 But is there some feature depending on the REGEXP in case if it's disabled
 other features don't work then.

There's probably nothing out there depending on QRegularExpression, but that
may change at any time. Also note that there's no feature define for
QRegularExpression, but only QT_NO_REGEXP which also disables QRegExp and that
is used everywhere.

Are you sure disabling PCRE support is the best use of your time, cost/benefit-
wise?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread song.7.liu
Not sure about the PCRE, but now I am trying the regx disabling, if it's 
impossible or big efforts I will keep this feature in for my minimal-build.

And also, we find that so many feature flags can't be easily disabled for 
example: QT_NO_DATASTREAM etc., as it seems many codes are not fully controlled 
on some feature flag.
So is that caused as the Qt5 code refine ??

Thanks,
Song

-Original Message-
From: development-bounces+song.7.liu=nokia@qt-project.org 
[mailto:development-bounces+song.7.liu=nokia@qt-project.org] On Behalf Of 
ext Thiago Macieira
Sent: Wednesday, June 06, 2012 5:17 PM
To: development@qt-project.org
Subject: Re: [Development] About pcre in qt5

On quarta-feira, 6 de junho de 2012 08.44.22, song.7@nokia.com wrote:
 Yes, we are creating a super minimal build with basic functionalities...
 But is there some feature depending on the REGEXP in case if it's 
 disabled other features don't work then.

There's probably nothing out there depending on QRegularExpression, but that 
may change at any time. Also note that there's no feature define for 
QRegularExpression, but only QT_NO_REGEXP which also disables QRegExp and that 
is used everywhere.

Are you sure disabling PCRE support is the best use of your time, cost/benefit- 
wise?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 09.23.47, song.7@nokia.com wrote:
 Not sure about the PCRE, but now I am trying the regx disabling, if it's
 impossible or big efforts I will keep this feature in for my minimal-build.

 And also, we find that so many feature flags can't be easily disabled for
 example: QT_NO_DATASTREAM etc., as it seems many codes are not fully
 controlled on some feature flag. So is that caused as the Qt5 code refine
 ??

Tasuku Suzuki has been trying to fix the feature system, but I guess he hasn't
managed all combinations yet. Try talking to him and coordinating your efforts
to get this fixed.

Right now, please understand that if you turn *any* of the feature flags (that
is, if you disable any API), you're in wholly uncharted territory and
completely unsupported. Those combinations are not tested by the CI system and
I doubt anyone except Suzuki-san has tried running with them.

From the Qt Project's point of view, I don't think we want to support them.
There was a discussion a while ago about supporting only the default builds
and reducing the amount of configuration choices. It's probably still the
current position. Other people could support them if they want to, though.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Oswald Buddenhagen
On Wed, Jun 06, 2012 at 09:03:46AM +0200, ext Thiago Macieira wrote:
 Yeah, I broke it yesterday somehow creating a topic branch. I got a database 
 error when pushing and let Matias know immediately, but I guess he had 
 already 
 left for the day.
 
we run periodic prunes, which matches the situation in the blog post.
it would seem that jgit lacks some locking, so a push coinciding with
the prune in just the wrong moment can mess up things royally.
we are working on avoiding the need to prune.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread Sean Harmer
Hi list,

We have been working hard to improve Qt support on the QNX platform. At this 
stage we have good support for widgets and QtQuick 1  2, and sensors.

The next stage is to promote QNX to a Tier 1 platform so that users understand 
that QNX is a fully supported platform for Qt.

To do so we of course need to integrate QNX into the CI system so that we can 
catch regressions just like the other Tier 1 platforms. This mail is intended 
to kick off a discussion about the practicalities of elevating a platform to 
Tier 1 status as I think this is the first time this has been requested since 
the uptake of Open Governance.

As a concrete issue, how would we go about integrating QNX into the CI system? 
Initially as a build node but eventually to also run all applicable unit 
tests.

At present we have a small Jenkins installation but this of course only 
catches build failures after offending commits have been merged.

What other gates do we also have to pass to promote QNX to Tier 1?

Many thanks in advance,

Sean
--
Dr Sean Harmer | sean.har...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 11.54.16, Oswald Buddenhagen wrote:
 On Wed, Jun 06, 2012 at 09:03:46AM +0200, ext Thiago Macieira wrote:
  Yeah, I broke it yesterday somehow creating a topic branch. I got a
  database error when pushing and let Matias know immediately, but I guess
  he had already left for the day.

 we run periodic prunes, which matches the situation in the blog post.
 it would seem that jgit lacks some locking, so a push coinciding with
 the prune in just the wrong moment can mess up things royally.
 we are working on avoiding the need to prune.

I don't think that's the root cause.

The root cause is the database error that I got when I did a gpush with
reviewers to a topic branch. Matias tells me that this somehow violates some
database constraints and the operation is dropped.

The review 28033 was created only partially (you can see that the sanity bot
wasn't added to it). The commit that was missing is the commit from that
review. So we had the problem the moment the database failed upon creating
28033 and left the repository in a bad state. The review exists, but not the
reference in Git:

$ git ls-remote gerrit refs/changes/* | grep /2803.
cfd19434b4fdd1846295c379531bda6ceb030a39refs/changes/32/28032/1

When the prune was run, it removed the objects that the database expected to
be there. Now we have a disconnect between what the database says should be
there and the Git repository actually has.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 11.46.18, Sean Harmer wrote:
 What other gates do we also have to pass to promote QNX to Tier 1?

The major target is that, at release time, you're able to confidently say that
this platform is working properly and all the showstopper issues (as judged by
the release testing) have been fixed. This, in turn, requires that there are
people testing that platform at release time and can report issues. If no one
tests, we'll have zero out of zero fixes and we can't give the Tier 1 label out
of a division by zero :-)

Being in the CI system is just one of the common ways of achieving that. If
you can compile and run unit tests on that platform at every commit, it helps
avoiding them at release time. But it's not strictly necessary: it might be
acceptable to run the unit tests at release time and say they're passing,
along with the rest of the release testing. I wouldn't recommend this, though.

I don't know the technical details on how to integrate with the current CI
system. But the first thing you're going to need is to have some way for the CI
manager to tell you test this SHA-1 / build number[1] and then you have to
report back a pass or fail, with the logs. Are you able to do that already?

[1] the commit that a build IDs refers to can be obtained from the Gerrit
repository

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread Sean Harmer
On Wednesday 06 June 2012 13:22:21 Thiago Macieira wrote:
 On quarta-feira, 6 de junho de 2012 11.46.18, Sean Harmer wrote:
  What other gates do we also have to pass to promote QNX to Tier 1?
 
 The major target is that, at release time, you're able to confidently say
 that this platform is working properly and all the showstopper issues (as
 judged by the release testing) have been fixed. This, in turn, requires
 that there are people testing that platform at release time and can report
 issues. If no one tests, we'll have zero out of zero fixes and we can't
 give the Tier 1 label out of a division by zero :-)
 
 Being in the CI system is just one of the common ways of achieving that. If
 you can compile and run unit tests on that platform at every commit, it
 helps avoiding them at release time. But it's not strictly necessary: it
 might be acceptable to run the unit tests at release time and say they're
 passing, along with the rest of the release testing. I wouldn't recommend
 this, though.

I understand and integrating into the CI system would seem by far the most 
sensible way to go in terms of maintainability, reducing man-power at release 
time and preventing introduction of regressions.

Until such time as the CI integration is completed, we will work to ensure 
that release testing happens in a timely manner.

 I don't know the technical details on how to integrate with the current CI
 system. But the first thing you're going to need is to have some way for the
 CI manager to tell you test this SHA-1 / build number[1] and then you
 have to report back a pass or fail, with the logs. Are you able to do that
 already?

At present we are polling gitorious for new commits. I will take a look into 
how we can get hold of the sha1's that are used for integration testing from 
gerrit.

Once we have that aspect working we can take a look at feeding back the 
results of the build and eventually tests.

 [1] the commit that a build IDs refers to can be obtained from the Gerrit
 repository

OK I will take a look. Thanks for the pointer.

Sean
--
Dr Sean Harmer | sean.har...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread lars.knoll
On 6/6/12 1:56 PM, ext Sean Harmer sean.har...@kdab.com wrote:

On Wednesday 06 June 2012 13:22:21 Thiago Macieira wrote:
 On quarta-feira, 6 de junho de 2012 11.46.18, Sean Harmer wrote:
  What other gates do we also have to pass to promote QNX to Tier 1?
 
 The major target is that, at release time, you're able to confidently
say
 that this platform is working properly and all the showstopper issues
(as
 judged by the release testing) have been fixed. This, in turn, requires
 that there are people testing that platform at release time and can
report
 issues. If no one tests, we'll have zero out of zero fixes and we can't
 give the Tier 1 label out of a division by zero :-)
 
 Being in the CI system is just one of the common ways of achieving
that. If
 you can compile and run unit tests on that platform at every commit, it
 helps avoiding them at release time. But it's not strictly necessary: it
 might be acceptable to run the unit tests at release time and say
they're
 passing, along with the rest of the release testing. I wouldn't
recommend
 this, though.

I understand and integrating into the CI system would seem by far the
most 
sensible way to go in terms of maintainability, reducing man-power at
release 
time and preventing introduction of regressions.

Absolutely. But that requires that someone steps up and creates a CI
infrastructure we can use. The current one is based on a commercial
solution that Nokia unfortunately can't hand out to everybody. It should
however be possible to use the existing scripts (with some modifications)
on Jenkins.

Until such time as the CI integration is completed, we will work to
ensure 
that release testing happens in a timely manner.

 I don't know the technical details on how to integrate with the current
CI
 system. But the first thing you're going to need is to have some way
for the
 CI manager to tell you test this SHA-1 / build number[1] and then you
 have to report back a pass or fail, with the logs. Are you able to do
that
 already?

At present we are polling gitorious for new commits. I will take a look
into 
how we can get hold of the sha1's that are used for integration testing
from 
gerrit.

For packages we currently always use the tested combinations from qt5.git.

Once we have that aspect working we can take a look at feeding back the
results of the build and eventually tests.

Please also subscribe on relea...@qt-project.org where the testing results
should go.

Cheers,
Lars


 [1] the commit that a build IDs refers to can be obtained from the
Gerrit
 repository

OK I will take a look. Thanks for the pointer.

Sean
--
Dr Sean Harmer | sean.har...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread Sean Harmer
On Wednesday 06 June 2012 12:02:23 lars.kn...@nokia.com wrote:
 On 6/6/12 1:56 PM, ext Sean Harmer sean.har...@kdab.com wrote:
 I understand and integrating into the CI system would seem by far the
 most
 sensible way to go in terms of maintainability, reducing man-power at
 release
 time and preventing introduction of regressions.
 
 Absolutely. But that requires that someone steps up and creates a CI
 infrastructure we can use. The current one is based on a commercial
 solution that Nokia unfortunately can't hand out to everybody. It should
 however be possible to use the existing scripts (with some modifications)
 on Jenkins.

Can you elucidate on what you mean by someone steps up and creates a CI 
infrastructure please?

Do you mean that the existing one needs hooks adding to allow additional 
external nodes to be plugged in? Or that new hardware, hosting, CI tool and 
everything else is needed from fresh? Or something in between?

 For packages we currently always use the tested combinations from qt5.git.

OK so we have 2 things to support:

* Test integrating commits in gerrit
* Test release candidates

We have also done some work on building Qt SDKs targeted at QNX/Blackberry 10 
including Qt Creator integration. These will hopefully get upstreamed at some 
point too.

 Once we have that aspect working we can take a look at feeding back the
 results of the build and eventually tests.
 
 Please also subscribe on relea...@qt-project.org where the testing results
 should go.

Done ;)

Thanks,

Sean
--
Dr Sean Harmer | sean.har...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Release Testing Form: http://testresults.qt-project.org/forms/release-testing/

2012-06-06 Thread marius.storm-olsen
Hi,

I have created an online form
(http://testresults.qt-project.org/forms/release-testing/) based on the
list I sent previously
(http://lists.qt-project.org/pipermail/releasing/2012-May/000275.html).

The form will send an email with the form data directly to the
releas...@qt-project.org mailing list, making reporting unified, and
ensuring that everyone looks at the same things on all platforms and
consistently from package to package.

Of course, you are allowed to look for more issues than those noted, just
fill in issues in the comment fields!

From now on, when testing packages, please use this form since it makes it
easier for everyone to read the reports, and quickly spot problem areas.

The form is completely open, and in Gerrit (git clone
ssh://codereview.qt-project.org:29418/qtqa/release-testing.git).
Feel free to improve, fix and add suggestions to other items to look for.

Thanks!

-- 
.marius

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt5 Alpha doesn't compile any projects on WinXP x86

2012-06-06 Thread Joerg Bornemann
On 06/06/2012 08:44, ext Daniel Kreuter wrote:

 jom: C:\Documents and Settings\USER\My
 Documents\Projekt\Qt5MultimediaDemo02\Makefile [release] Error 2
 08:39:20: Der Prozess C:\Qt\qtcreator-2.5.0\bin\jom.exe wurde mit
 dem Rückgabewert 2 beendet.
 Fehler beim Erstellen/Deployment des Projekts Qt5MultimediaDemo02(Ziel: 
 Desktop)
 Bei der Ausführung von Schritt 'Make'

That log doesn't tell us much. Is that all you get?
There should be an error message of the compiler or linker further up.


BR,

Jörg
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Another late API addition in QScreen

2012-06-06 Thread shane.kearns
 -Original Message-
 From: development-bounces+shane.kearns=accenture@qt-project.org
 [mailto:development-bounces+shane.kearns=accenture@qt-project.org]
 On Behalf Of Samuel Rødal
 Sent: 05 June 2012 13:30
 To: development@qt-project.org
 Subject: [Development] Another late API addition in QScreen

 Hello,

 the current QScreen API forces the platform to always have an
 accelerometer sensor or similar running in order to provide
 QScreen::orientation() updates, which might lead to wasted resources in
 the case of handheld embedded devices.

 As a fix for this I've introduced a new function in QScreen,
 setOrientationUpdateMask(), in order force the application to
 explicitly have to ask for orientation updates.

 https://codereview.qt-project.org/#change,27981


Late comment, but should the default have been updates on?
Qt 4 behaviour on symbian/harmattan was to have screen rotation be automatic 
unless opted out from (which was unfortunately a different Qt API on each 
platform)

--




Subject to local law, communications with Accenture and its affiliates 
including telephone calls and emails (including content), may be monitored by 
our systems for the purposes of security and the assessment of internal 
compliance with Accenture policy.
__

www.accenture.com

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Qt5 qtwebkit packaging

2012-06-06 Thread Zoltán Balogh
Hi,

I am packaging the Qt5 modules for Ubuntu Precise/Quantal for both x86 
and ARM targets: 
https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily

  It is a fun exercise :) as week to week it requires some creativity as 
the code base evolves.

Most of the modules build well and their packaging is rather straight 
forward.

But the qtwebkit module (alias qt5-module) archives (ar cqs) 2184 object 
files to libWebCore.a That makes in most build environment/system even 
with a very short package name 120k size argument. It will be a huge 
(literally) problem. Is here anybody who I can work together to solve 
this problem. I am 1 inch away to provide the full set of Qt5 x86/armel 
packages for Ubuntu Precise and Quantal... the qtwebkit compiles, that 
is the last glitch.

I wonder if there is anybody who I can work together to prevent problems 
when we start packaging Qt5 for the distributions.

cheers,

z
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Another late API addition in QScreen

2012-06-06 Thread Samuel Rødal
On 06/06/2012 03:38 PM, ext shane.kea...@accenture.com wrote:
 -Original Message-
 From: development-bounces+shane.kearns=accenture@qt-project.org
 [mailto:development-bounces+shane.kearns=accenture@qt-project.org]
 On Behalf Of Samuel Rødal
 Sent: 05 June 2012 13:30
 To: development@qt-project.org
 Subject: [Development] Another late API addition in QScreen

 Hello,

 the current QScreen API forces the platform to always have an
 accelerometer sensor or similar running in order to provide
 QScreen::orientation() updates, which might lead to wasted resources in
 the case of handheld embedded devices.

 As a fix for this I've introduced a new function in QScreen,
 setOrientationUpdateMask(), in order force the application to
 explicitly have to ask for orientation updates.

 https://codereview.qt-project.org/#change,27981

 
 Late comment, but should the default have been updates on?
 Qt 4 behaviour on symbian/harmattan was to have screen rotation be automatic 
 unless opted out from (which was unfortunately a different Qt API on each 
 platform)

As I commented in the change, that would make the mask mostly useless,
since an application that doesn't care about orientations probably
wouldn't go and explicitly disable the orientation updates.

--
Samuel
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] One qmake problem for rvct

2012-06-06 Thread song.7.liu
Hi,

When using the armcc to compile qt5, there is one Makefile generation issue for 
widgets:
You know the widgets is depending on platformsupport static library, but the 
libQtPlatformSupport.so is appended into LIBS flag within this Makefile.

After checked with the source code of qmake/generators/unix/unixmake.cpp, where:
bool UnixMakefileGenerator::findLibraries()
... ...
else if (project-isActiveConfig(rvct_linker) || 
project-isActiveConfig(armcc_linker)) {
(*it) = lib + opt.mid(2) + .so;
}

You will see that it treats all the dependency as a so without any checking.
Then I am trying to modify here but can't find the current object indicated by 
current opt is static or shared...

Anyone can help point out what's the correct way to fix this issue ?

Thanks,
Song
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Deprecating QFile::encodeName/decodeName

2012-06-06 Thread João Abecasis
Thiago Macieira wrote:
 On terça-feira, 5 de junho de 2012 16.48.58, João Abecasis wrote:
 Thiago Macieira wrote:
 On terça-feira, 5 de junho de 2012 13.20.36, João Abecasis wrote:
 I would not go as far as saying that the concept is broken, but it
 definitely isn't portable. One big issue is that nowadays we don't
 use an 8-bit encoding on Windows and those functions assume QString
 - QByteArray conversions.
 
 I called it broken due to the ambiguity when it comes to interpreting
 data that may or may not contain file names, like command-line
 arguments. See the next paragraph of what I had written.
 
 Codecs must never be used in a situation where there's an ambiguity on
 what the encoding is. That will lead to mojibake sooner or later.
 
 That's the whole point, you shouldn't treat file names differently when
 processing the command line or configuration files. Those should be
 interpreted using their specific rules: command line goes according to
 locale, configuration goes according to established convention (say,
 UTF-8).
 
 So you're asking that filenames be passed on the locale encoding (say, UTF-8) 
 on the command-line, regardless of what the filesystem encoding is?

I see no other sane way, unless your application is able to take the byte 
sequences it gets without additional processing. In Qt, strings are 16-bit, so 
8-bit strings typically need conversion.

 That is a possible solution, it requires that all tools be taught to do that, 
 including the ones that currently couldn't care less about encodings. Many 
 shell tools assume that the file name can be copied verbatim from the DIR* 
 entry (from readdir(2)) to the screen.

I think phrasing the problem as such that we require all tools [to] be taught 
a new trick doesn't really help. We're obviously not going to be able to force 
every other tool out there to change. Not any time soon, anyway. Still, some of 
the same tools you want be taught a new trick don't have a problem to begin 
with, as they're quite capable of reading and writing files with funny names.

Tools that do all processing in 8-bit can just wait for system calls to error 
out, they don't really need to interpret encodings the same way Qt does.

Qt has a problem and it's one that allows it to show files with funny names 
in file dialogs and through QDir(Iterator), but will prevent most attempts to 
interact with those files in practice. Again, encode/decodeName enabled 
application developers to handle these issues.

 I don't see that happening any more than I see any of the other solutions. 
 The 
 only pragmatic solution is to enforce filesystem encoding == locale encoding.

Locales change, either between users or because some users switch locales. 
Unless you can enforce that all locales use the same encoding (nowadays much 
less of a problem, granted) using user locale is just wrong. Even if not on the 
same computer, USB sticks are still a source of files with funny names.

 In fact, there is one more possible solution which stands a chance: forcing 
 the problem onto the kernel. Make the entire userspace API be UTF-8 and have 
 the kernel recode to the filesystem encoding as necessary. The problem with 
 this solution is that it a) will suffer extreme resistance from kernel 
 developers and other people who think of file names as binary data instead 
 of 
 human-readable text; and b) is no different from the other solution of 
 enforcing the encoding.

Forcing this onto the Linux kernel would in the long term make the situation 
better for Linux users that don't receive files from any other OSs or kernel 
versions. It doesn't help everyone.

 [snip]
QtGit commit -m $'R\xc3\xa9sum\xc3\xa9' 'R%E9sum%E9.txt'
 
 Bash enables you to pass around byte sequences it doesn't understand.
 That would help in getting UTF-8 into the application but would not help
 pass in Latin1, as the application would (correctly) flag it as an
 invalid UTF-8 sequence and replace 'é' with '?'. Instead, we need to
 escape the file name in a way that will not be misinterpreted by bash or
 command line processing, giving code that actually expects a path (say,
 QFile, encodeName or QFileSystemEntry) a chance to interpret it.
 
 For this to work, command line parsing need not understand more than
 UTF-8, but encodeName would then be able to convert those \xHH sequences
 to the proper Latin1-encoded Résumé and retrieve the right file from
 the file system.
 
 You used %HH instead of \xHH in your example, which is the URL encoding and 
 for which there are well-defined rules. I'd prefer that.

Indeed, my mistake mixing the two. That's what I get for going back and 
partially editing the e-mail ;-)

For the record, this was meant as simple contrived example, not to propose a 
final solution. If escaping is something we'd want to support we would need to 
spend some time looking at it.

 We're talking about the edge cases, right? 99% of uses will work with or
 without the need for encode/decodeName.

Re: [Development] Deprecating QFile::encodeName/decodeName

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 16.51.14, João Abecasis wrote:
  From there, we come to the conclusion that the QString representing such a
  file  name must contain special processing instructions (e.g., one or
  more special characters). One form of special processing instruction is
  escaping each character, like URLs do. The problem with the approach of
  escaping is what to do when the escape character occurs in a file name.
  If that is a possibility, the escape character needs to be escaped by
  itself (like \\ for backslashes in C or %25 for percents in URLs). If
  we use this approach, then we will not interoperate properly with non-Qt
  applications when this character happens.
 
 
  The only sane solution, then, is to use a character that has a very small
  chance of ever being used or, better yet, a zero chance (I don't think
  there's  any). If that happens, then this character will be close to
  untypeable on the terminal. Not a big loss, I'd say.

 We could use some magic sequence. Windows, for instance, uses the \\?\
 prefix to support longer paths. We could use '' and '', which are rare
 but valid, we could give a specific meaning to sequences of 3 or more
 slashes.

 I don't have a concrete solution at the moment.

I really think we should not use a character that is easily used on file names,
and that includes , , commas, percents, backslashes, spaces, etc. It needs
to be a Unicode character that has a close-to-zero chance of being
intentionally used.

I recommend selecting one or two characters from the Unicode private use area
for this. We could use a non-character (such as U+FDD0), but that will cause
problems elsewhere. For example, if you add such a path to QTextBrowser, it
might do weird things. For another, such characters are dropped by the UTF-8
encoder and decoder, aren't allowed in D-Bus, etc.

This character will be all but untypeable on the command-line. I don't think
we care, though, since Qt applications are seldomly launched from the command-
line and, besides, if the user sees the broken file name anyway (in either
form), the user is likely to fix the problem.

  If it was named βιογραφικό σημείωμα.txt in ISO-8859-7, the QString
  representation would be:
/home/foo/έγγραφα/escapeâéïãñáöéêü óçìåßùìá.txt
 
  That has the drawback of being hard to use when it comes to path
  manipulation.  Appending, prepending, extracting or inserting text could
  have unexpected consequences.

 I think any such scheme should support both absolute and relative paths and
 should allow a relative path to be combined with an absolute path with:

 absolute-path + '/' + relative-path

If you append a slash, it unshifts back to normal. But imagine someone
appending a suffix. Thankfully, non-ASCII suffixes / extensions are really rare.

  Limitations:
  a) Qt-only, I don't expect anyone else to use such file names
  b) if encodeName() isn't used properly, it leads to a bad encoding of the
  file  name onto 8-bit. Applications dealing with the filesystem need to
  be extra careful so as to not show two representations of the same file.
  c) for that matter, it's possible to produce an escaped form that matches
  a  regular file name
  d) double representations are often a source of security issues if not
  handled carefully (cf. overlong sequences in UTF-8)

 I don't see a) as such a big problem, since currently Qt can't even handle
 such file names. As for b) I think ideally we'd come up with something that
 makes the use of encode/decodeName invisible and doesn't require users to
 register their own encoding/decoding functions. c) is what we want to
 minimize.

 As for d), if we make it all transparent and handled in a seamless way in Qt
 the problem that remains is how those paths interoperate with other
 applications and user code. It really helps to minimize c).

I'm not sure I agree with your dismissal of D. I'd like to see more research
into this topic first.

 On the other hand we already have Qt-only paths in resource files and
 QDir::searchPaths(). We could easily use a well-known prefix for the
 special paths: url-encoded:/usr/joao/R%E9sum%E9.txt, which only supports
 absolute paths, but would already enable all items in my wish list.
  As you can see, I didn't come up with this today. I've known these
  alternatives for years. I don't think they're worth our time.

Search paths and the filesystem engines are misfeatures. One is gone, the other
not yet. They are potential security issues too.

Anyway, what I recommend for now:

 1) immediately, de-inline QFile::decodeName and QFile::encodeName
 2) un-deprecate them and update the text in changes-5.0.0
 3) make QProcess use QFile::encodeName for its arguments (no-op right now)
 4) make QCoreApplication parse its arguments using QFile::decodeName (no-op
right now)
 5) idem for Laszlo's command-line parser class

Later, we can decide whether to add escaping to those functions.

However, I cannot agree with bringing the 

Re: [Development] One qmake problem for rvct

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 14.38.46, song.7@nokia.com wrote:
 Hi,

 When using the armcc to compile qt5, there is one Makefile generation issue
 for widgets: You know the widgets is depending on platformsupport static
 library, but the libQtPlatformSupport.so is appended into LIBS flag
 within this Makefile.

That is a mistake and needs to be fixed. QtWidgets cannot link to
QtPlatformSupport (which, by the way, is a .a file, never a .so one).

However, can you check if the platform plugins have the same issue?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Help reviewing my own changes to QSharedPointer

2012-06-06 Thread lars.knoll
Can't remember that you asked me. I can certainly review them if you don't have 
anyone else. I'll do so later tonight.


Cheers,

Lars


On 06.06.12 18:54 ext Thiago Macieira wrote:

Cf. thread: Maintainer TrustMes
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://lists.qt-project.org/pipermail/development/2012-April/002930.html

I need help again reviewing my own changes. Since I am the maintainer of the
module that the changes are going to, there's no one else to call upon. I
asked Lars and he said he can't safely review them. I'm asking the community
here to help out.

The first two changes are extremely important and must be done before 5.0:

http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Remove delete value
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Remove virtuals from the private

The next few changes are cleanups:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Merge two private classes
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Merge the private to the public
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Use 
the copy  swap trick

Then there are some optimisations:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Optimise the constructor
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
Optimise deletion

One new feature (we should leave for 5.1):
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - Add 
create() with variadic arguments
and perfect forwarding

And one unit test:
http://lists.qt-project.org/pipermail/development/2012-April/002930.html - 
lambda as custom deleter

--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt5 qtwebkit packaging

2012-06-06 Thread Zoltán Balogh
Hi Csaba,

I was in contact with Lauro earlier  and I know his repository. He has 
binary only repository for the qtwebkit.

After the alpha release I managed to package all the important modules 
of the Qt5.

But now the qtwebkit gives me hard time. Right now I managed to  fix 
(hack) the code to compile, but it fails on linking: 
http://pastebin.com/5yXJTvfY

Any kind of help is appreciated. My objective is to provide source and 
binary distribution of the Qt5 for both ARM and x86 targets.

cheers,

Zoltan

On 06/06/2012 06:50 PM, Becsi Andras (Nokia-MP/Oslo) wrote:
 Hi Zoltan,

 I think the guys from Snowshoe might be able to help you with packaging.
 CC'ing Lauro, who is packaging QtWebkit trunk and Qt5 weekly for the N9
 (Harmattan).

 /Andras

 On 06/06/2012 03:46 PM, ext Zoltán Balogh wrote:
 Hi,

 I am packaging the Qt5 modules for Ubuntu Precise/Quantal for both x86
 and ARM targets:
 https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily

 It is a fun exercise :) as week to week it requires some creativity as
 the code base evolves.

 Most of the modules build well and their packaging is rather straight
 forward.

 But the qtwebkit module (alias qt5-module) archives (ar cqs) 2184 object
 files to libWebCore.a That makes in most build environment/system even
 with a very short package name 120k size argument. It will be a huge
 (literally) problem. Is here anybody who I can work together to solve
 this problem. I am 1 inch away to provide the full set of Qt5 x86/armel
 packages for Ubuntu Precise and Quantal... the qtwebkit compiles, that
 is the last glitch.

 I wonder if there is anybody who I can work together to prevent problems
 when we start packaging Qt5 for the distributions.

 cheers,

 z
 ___
 Development mailing list
 Development@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Help reviewing my own changes to QSharedPointer

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 17.08.29, lars.kn...@nokia.com wrote:
 Can't remember that you asked me. I can certainly review them if you don't
 have anyone else. I'll do so later tonight.

I asked on IRC how you felt about reviewing QSharedPointer changes and you
said you'd rather not do it.
--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] About pcre in qt5

2012-06-06 Thread Brett Stottlemyer
 And also, we find that so many feature flags can't be easily disabled 
 for
 example: QT_NO_DATASTREAM etc., as it seems many codes are not fully 
 controlled on some feature flag. So is that caused as the Qt5 code 
 refine ??

 Tasuku Suzuki has been trying to fix the feature system, but I guess he
hasn't managed all combinations yet. Try 
 talking to him and coordinating your efforts to get this fixed.

 Right now, please understand that if you turn *any* of the feature flags
(that is, if you disable any API), you're  in wholly uncharted territory
and completely unsupported. Those combinations are not tested by the CI
system and I   doubt anyone except Suzuki-san has tried running with them.


I'm hitting the same issue the QT_NO_CURSOR.  If I don't compile with this
flag, apps crash because the cursor isn't built onto the device.  QCursor
has no constructor when compiled with QT_NO_CURSOR, but the QMetatype seems
to assume it is there.  That is QT_FOR_EACH_STATIC_CORE_CLASS includes
QCursor, and the FOR_EACH crashes trying to create meta information and is
also used to create QVariant support (which breaks without a public
constructor as explained in the QVariant docs).

Does Suzuki-san follow this list?  Hopefully compiling without a cursor
isn't an edge case and this can be addressed in Qt5.

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Help reviewing my own changes to QSharedPointer

2012-06-06 Thread lars.knoll
On 6/6/12 7:33 PM, ext Thiago Macieira thiago.macie...@intel.com wrote:

On quarta-feira, 6 de junho de 2012 17.08.29, lars.kn...@nokia.com wrote:
 Can't remember that you asked me. I can certainly review them if you
don't
 have anyone else. I'll do so later tonight.

I asked on IRC how you felt about reviewing QSharedPointer changes and
you 
said you'd rather not do it.

thiago lars: btw, how comfortable are you reviewing QSharedPointer
changes?
lars thiago: depends on the change... ;-)


I certainly can/will have a look. Will tell when I want another pair of
eyes :)

Cheers,
Lars

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Help reviewing my own changes to QSharedPointer

2012-06-06 Thread lars.knoll
On 6/6/12 6:53 PM, ext Thiago Macieira thiago.macie...@intel.com wrote:

Cf. thread: Maintainer TrustMes
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://comments.gmane.org/gmane.comp.lib.qt.devel/2953

I need help again reviewing my own changes. Since I am the maintainer of
the 
module that the changes are going to, there's no one else to call upon. I
asked Lars and he said he can't safely review them. I'm asking the
community 
here to help out.

The first two changes are extremely important and must be done before 5.0:

https://codereview.qt-project.org/26974 - Remove delete value
https://codereview.qt-project.org/26975 - Remove virtuals from the private

The next few changes are cleanups:
https://codereview.qt-project.org/26977 - Merge two private classes
https://codereview.qt-project.org/26978 - Merge the private to the public
https://codereview.qt-project.org/26979 - Use the copy  swap trick

Then there are some optimisations:
https://codereview.qt-project.org/26980 - Optimise the constructor

Got until the change above and gave up for today at the next one. Will get
back to it tomorrow.

https://codereview.qt-project.org/26981 - Optimise deletion

I might be wrong (getting tired), but I think this reintroduces the
problem with forward declared pointers that the first patch fixes.

Cheers,
Lars


One new feature (we should leave for 5.1):
https://codereview.qt-project.org/26982 - Add create() with variadic
arguments 
and perfect forwarding

And one unit test:
https://codereview.qt-project.org/27043 - lambda as custom deleter

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt CS videos of module maintainers

2012-06-06 Thread Quim Gil
Silence = freedom for me to decide. See below.

On 06/01/2012 04:12 PM, ext Quim Gil wrote:
 (((Posting here to reach module maintainers and humans alike)))

 Most Qt Essentials module maintainers will be at the Qt Contributors
 Summit and we want to take this chance to shot video interviews to be
 edited and be part of the Qt 5 launch. The idea of these interviews is
 to explain to the masses what the module does, why it's important in Qt
 5 and what is new  interesting.

 I need to come up with the exact list of people to interview, in order
 to arrange time slots with them. If you are a maintainer and you are
 happy with the idea please send me an email (if you are not happy send
 me the email as well).  ;)


 Questions:

 - No offense but... do all the modules need to be featured to give an
 overall picture of Qt 5? Looking at
 http://qt-project.org/wiki/Qt-Essentials-Modules I wonder about Qt JS
 Backend, Qt SQL  Qt Test. Also, would it make sense to have a single
 person to cover Qt GUI, Qt QML  Qt Quick? This would make 5 interviews
 less (7 maintainers + Lars).

Unless someone protests this is what we will do, except that Qt GUI will 
be coupled with QPA - see below.

 - Is there an add-on module maintainer that should get a video interview
 as well? Qt Wayland fit in the buzzword count.  ;)

If nobody answers then the answer will be No.

 - Qt Platform Abstraction is a top topic. Should we have a speaker? Who?

Samuel is now the default candidate.


 - If the maintainer won't make it to the interview then he needs to
 nominate the speaker.

I will contact each of the maintainers in order to book 1h of their time 
during Qt CS. That will be your chance to delegate if you won't make it.


 Also a question to those that have been to the venue: what is the best
 place to have these interviews? The video company can bring a but of
 furniture for a cozy corner in the main hall, I guess it shouldn't be
 too noisy during sessions. Is it outside in the terrace an alternative?
 Another option would be to borrow a Seminaar room during lunch breaks.
 Ideas welcome - it's difficult to decide without having been there.

I will ask the venue directly.

--
Quim
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Deprecating QFile::encodeName/decodeName

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 21.21.28, Oswald Buddenhagen wrote:
   3) make QProcess use QFile::encodeName for its arguments (no-op right
 now) 4) make QCoreApplication parse its arguments using QFile::decodeName
 (no-op
  right now)
 
   5) idem for Laszlo's command-line parser class
 

 no. see first paragraph. doing this would only increase the mess.

How do you figure making no-op changes increase the mess?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Becoming a Tier 1 platform and the CI System

2012-06-06 Thread Rohan McGovern
Sean Harmer said:
 On Wednesday 06 June 2012 12:02:23 lars.kn...@nokia.com wrote:
  On 6/6/12 1:56 PM, ext Sean Harmer sean.har...@kdab.com wrote:
  I understand and integrating into the CI system would seem by far the
  most
  sensible way to go in terms of maintainability, reducing man-power at
  release
  time and preventing introduction of regressions.
  
  Absolutely. But that requires that someone steps up and creates a CI
  infrastructure we can use. The current one is based on a commercial
  solution that Nokia unfortunately can't hand out to everybody. It should
  however be possible to use the existing scripts (with some modifications)
  on Jenkins.
 
 Can you elucidate on what you mean by someone steps up and creates a CI 
 infrastructure please?
 
 Do you mean that the existing one needs hooks adding to allow additional 
 external nodes to be plugged in? Or that new hardware, hosting, CI tool and 
 everything else is needed from fresh? Or something in between?
 

It means that the current CI infrastructure is operated by Nokia and
can't have build nodes plugged in from outside of Nokia premises.  So,
if you need to manage your own build nodes, there is currently no way to
integrate with the Qt Project CI system.  Fixing this is a significant
project which I am not aware of anyone currently working on :(

However, if testing (at least compile testing) for your platform can be
done with commodity hardware and freely available software, and is not
particularly demanding in other respects, there's a possibility of
making progress with the current setup.  If that's the case, please
create a task with some of the technical details on
https://bugreports.qt-project.org/browse/QTQAINFRA .
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Help reviewing my own changes to QSharedPointer

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 21.56.16, lars.kn...@nokia.com wrote:
 https://codereview.qt-project.org/26981-Optimisedeletion

 I might be wrong (getting tired), but I think this reintroduces the
 problem with forward declared pointers that the first patch fixes.

It's a different solution.

The Qt 4 solution for this was to return false from a virtual function (the
default implementation), which would require the caller to perform the
deletion. The code was like this:

if (!d-destroy())
delete value;

This function was called from deref(), which meant that where a reference
could be dropped also required a full definition of the class.

The new optimisation does not introduce delete value into the reference-
dropping code path. That is still:

d-destroy()
which does:
void destroy() { destroyer(this); }
(destroyer is a function pointer)

The optimisation simply changes what the pointed function does. Wiithout it,
it will call another stored function pointer. With it, it will call delete
directly.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] One qmake problem for rvct

2012-06-06 Thread song.7.liu
Hi,

Same issue happened in platform plugins...

Could someone share what's the idea to change qmake or something else ?

Thanks,
Song

-Original Message-
From: development-bounces+song.7.liu=nokia@qt-project.org 
[mailto:development-bounces+song.7.liu=nokia@qt-project.org] On Behalf Of 
ext Thiago Macieira
Sent: Wednesday, June 06, 2012 11:44 PM
To: development@qt-project.org
Subject: Re: [Development] One qmake problem for rvct

On quarta-feira, 6 de junho de 2012 14.38.46, song.7@nokia.com wrote:
 Hi,
 
 When using the armcc to compile qt5, there is one Makefile generation 
 issue for widgets: You know the widgets is depending on 
 platformsupport static library, but the libQtPlatformSupport.so is 
 appended into LIBS flag within this Makefile.

That is a mistake and needs to be fixed. QtWidgets cannot link to 
QtPlatformSupport (which, by the way, is a .a file, never a .so one).

However, can you check if the platform plugins have the same issue?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development