Re: [Development] HEADS UP: Starting preparations for Qt 5.2.0 - merge 'dev' into 'stable'
Hi, The merge from 'dev' to 'stable' is happening now as we speak. The plan is the following: - We will block the "Merge Patch Set X to Staging" button for all the repositories listed below (for the 'dev' branch). - We will wait for changes still under test until they are all merged and/or back to Review in Progress. - We will proceed with the merge for all the repositories listed below. - We will leave the "Merge Patch Set X to Staging" blocked for around two to three days, to avoid that changes get merged to the wrong branch and need to be cherry-picked. If your changes didn't make it and they are meant for Qt 5.2.0 please re-target them to the 'stable' branch after the merges are done. The same policies apply as before for the 'stable' branch after the merges are done. Cheers, -- Sergio Ahumada Release Engineer - Digia, Qt From: development-bounces+sergio.ahumada=digia@qt-project.org [development-bounces+sergio.ahumada=digia@qt-project.org] on behalf of Sergio Ahumada [sergio.ahum...@digia.com] Sent: Wednesday, September 11, 2013 12:42 To: development@qt-project.org Cc: releas...@qt-project.org Subject: [Development] HEADS UP: Starting preparations for Qt 5.2.0 - merge 'dev' into 'stable' Hi, We are starting the preparations for the Qt 5.2.0 release, which means that: - We plan to merge 'dev' into 'stable' branch on September 23rd. - After Sept 23rd any changes that are required for 5.2.0 need to be pushed to the 'stable' branch. So if your changes are not in by that day, please wait until the merge is done and re-target it to the 'stable' branch. The repositories that will be part of the Qt 5.2.0 merge are: - qtactiveqt - qtbase - qtconnectivity [*] - qtdeclarative - qtdoc - qtgraphicaleffects - qtimageformats - qtlocation [1][*] - qtmacextras [2][*] - qtmultimedia - qtquick1 - qtquickcontrols - qtscript - qtsensors - qtserialport - qtsvg - qttools - qttranslations - qtwebkit - qtwebkit-examples - qtwinextras [*] - qtxmlpatterns - qtx11extras Cheers, [1]: pending status, see https://codereview.qt-project.org/65075 [2]: pending status, see https://codereview.qt-project.org/64435 [*]: since there is no 'stable' branch, we will create it out of 'dev' instead of doing a merge -- Sergio Ahumada Release Engineer - Digia, Qt ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] QValidator in QtCore
On domingo, 22 de setembro de 2013 23:28:48, Olivier Goffart wrote: > On Saturday 21 September 2013 19:13:41 Thiago Macieira wrote: > > On domingo, 22 de setembro de 2013 02:21:40, Konstantin Ritt wrote: > > > I remember some classes were moved from QtXml to QtCore without breaking > > > the compatibility. Am I wrong? > > > > The moving did break compatibility. Which is why for Mac 32-bit builds, > > the > > classes aren't moved at all: we added new classes to QtCore and > > typedef'ed. > > > > That only broke source compatibility because you couldn't forward-declare > > those classes. > > The name change was done using #define QXmlStreamWriter QCoreXmlStreamWriter > There is a comment saying it was done using typedef, but apparently it was > not. http://code.woboq.org/kde/qt4/src/corelib/xml/qxmlstream.h.html So > compatibility was not broken (but there was ugly macro) > > I think this prove that this is possible. > > (And for forward declaration, i think we should have header with them and > forbid them) Right now, we allow them and I don't like the idea of forbidding forward declarations. Therefore, doing anything that breaks them is source-incompatible and should not be permitted until Qt 6. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center signature.asc Description: This is a digitally signed message part. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] QValidator in QtCore
On Sun, Sep 22, 2013 at 5:28 PM, Olivier Goffart wrote: > On Saturday 21 September 2013 19:13:41 Thiago Macieira wrote: > > On domingo, 22 de setembro de 2013 02:21:40, Konstantin Ritt wrote: > > > I remember some classes were moved from QtXml to QtCore without > breaking > > > the compatibility. Am I wrong? > > > > The moving did break compatibility. Which is why for Mac 32-bit builds, > the > > classes aren't moved at all: we added new classes to QtCore and > typedef'ed. > > > > That only broke source compatibility because you couldn't forward-declare > > those classes. > > The name change was done using #define QXmlStreamWriter > QCoreXmlStreamWriter > There is a comment saying it was done using typedef, but apparently it was > not. http://code.woboq.org/kde/qt4/src/corelib/xml/qxmlstream.h.html > So compatibility was not broken (but there was ugly macro) > > I think this prove that this is possible. > > (And for forward declaration, i think we should have header with them and > forbid them) > > I've sort of revised my stance here: I'm more on the side of proposing a useful alternative than moving it at this point. Not only should QValidator be in QtCore, it also is needlessly defined as a QObject. Beyond that, it only validates strings (rather than QVariants), so I think through and through a better alternative could be provided. I'm working on something now (well its done but I'm mostly massaging the api and seeing how it feels to use in my code), I'll put it up for review when it's complete. Matt > -- > Olivier > > Woboq - Qt services and support - http://woboq.com - http://code.woboq.org > > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] QValidator in QtCore
On Saturday 21 September 2013 19:13:41 Thiago Macieira wrote: > On domingo, 22 de setembro de 2013 02:21:40, Konstantin Ritt wrote: > > I remember some classes were moved from QtXml to QtCore without breaking > > the compatibility. Am I wrong? > > The moving did break compatibility. Which is why for Mac 32-bit builds, the > classes aren't moved at all: we added new classes to QtCore and typedef'ed. > > That only broke source compatibility because you couldn't forward-declare > those classes. The name change was done using #define QXmlStreamWriter QCoreXmlStreamWriter There is a comment saying it was done using typedef, but apparently it was not. http://code.woboq.org/kde/qt4/src/corelib/xml/qxmlstream.h.html So compatibility was not broken (but there was ugly macro) I think this prove that this is possible. (And for forward declaration, i think we should have header with them and forbid them) -- Olivier Woboq - Qt services and support - http://woboq.com - http://code.woboq.org ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Nominating Thorbjørn Martsum (ThorbjornTux) as approver
Thanks for the rights, congratulations and secondings! - and especially thanks for the nomination and the nice words, Steve. I am glad and proud to be an approver :). Thanks, guys! Regards Thorbjørn On Sun, Sep 22, 2013 at 10:26 AM, Knoll Lars wrote: > Jira should be fine as well now. > > Congratulations Thorbjørn! > > Cheers, > Lars > > On 9/21/13 10:22 PM, "Ahumada Sergio" wrote: > > >gerrit done > >-- > >Sergio Ahumada > >Release Engineer - Digia, Qt > > > > > >From: development-bounces+sergio.ahumada=digia@qt-project.org > >[development-bounces+sergio.ahumada=digia@qt-project.org] on behalf > >of Nurmi J-P [jpnu...@digia.com] > >Sent: Saturday, September 21, 2013 22:19 > >To: development@qt-project.org > >Subject: Re: [Development] Nominating Thorbjørn Martsum (ThorbjornTux) as > >approver > > > >On Aug 30, 2013, at 3:05 PM, Stephen Kelly > wrote: > > > >> > >> Hello, > >> > >> I'd like to nominate Thorbjørn for approver status. Thorbjørn has been > >> contributing to Qt for almost two years, and has been quite active in > >>the last > >> year in submitting patches and reviewing other patches. > >> > >> https://codereview.qt-project.org/#dashboard,1000708 > >> https://codereview.qt-project.org/#q,reviewer:tmartsum,n,z > >> > >> His reviews are thorough, and often catch issues, he's often on IRC and > >> responsive and friendly. He has made a lot of great quality patches in > >> itemviews, particularly in QHeaderView and other widgets, as well as > >>more > >> recent work on the container classes in Qt. > >> > >> Any seconds? > > > > > >More than enough time has passed - time to congratulate Thorbjørn! :) > > > >Could someone fix the approver rights in JIRA/Gerrit? Thanks! > > > >-- > >J-P Nurmi > > > >___ > >Development mailing list > >Development@qt-project.org > >http://lists.qt-project.org/mailman/listinfo/development > >___ > >Development mailing list > >Development@qt-project.org > >http://lists.qt-project.org/mailman/listinfo/development > > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development > ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Nominating Thorbjørn Martsum (ThorbjornTux) as approver
Jira should be fine as well now. Congratulations Thorbjørn! Cheers, Lars On 9/21/13 10:22 PM, "Ahumada Sergio" wrote: >gerrit done >-- >Sergio Ahumada >Release Engineer - Digia, Qt > > >From: development-bounces+sergio.ahumada=digia@qt-project.org >[development-bounces+sergio.ahumada=digia@qt-project.org] on behalf >of Nurmi J-P [jpnu...@digia.com] >Sent: Saturday, September 21, 2013 22:19 >To: development@qt-project.org >Subject: Re: [Development] Nominating Thorbjørn Martsum (ThorbjornTux) as >approver > >On Aug 30, 2013, at 3:05 PM, Stephen Kelly wrote: > >> >> Hello, >> >> I'd like to nominate Thorbjørn for approver status. Thorbjørn has been >> contributing to Qt for almost two years, and has been quite active in >>the last >> year in submitting patches and reviewing other patches. >> >> https://codereview.qt-project.org/#dashboard,1000708 >> https://codereview.qt-project.org/#q,reviewer:tmartsum,n,z >> >> His reviews are thorough, and often catch issues, he's often on IRC and >> responsive and friendly. He has made a lot of great quality patches in >> itemviews, particularly in QHeaderView and other widgets, as well as >>more >> recent work on the container classes in Qt. >> >> Any seconds? > > >More than enough time has passed - time to congratulate Thorbjørn! :) > >Could someone fix the approver rights in JIRA/Gerrit? Thanks! > >-- >J-P Nurmi > >___ >Development mailing list >Development@qt-project.org >http://lists.qt-project.org/mailman/listinfo/development >___ >Development mailing list >Development@qt-project.org >http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
