[Development] Maintainers: Your action needed

2016-10-25 Thread Jani Heikkinen 
Hi all,

Qt 5.7.1 change files are still badly ongoing, see 
https://codereview.qt-project.org/#/q/branch:5.7.1+message:%22Add+changes+file+for+5.7.1%22,n,z

I created initial drafts so maintainers, please finalize those now & get those 
approved!

br,
Jani
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira 
On terça-feira, 25 de outubro de 2016 18:12:27 PDT Massimo Callegari via 
Development wrote:
> > It was never supported, therefore it can't be a bug, much less a
> > regression. Indeed we removed some functionality, but one that was
> > technically abusing
> > qmake because it wasn't supported.
> 
> That is not true. See the official Qt documentation, end of page,
> "Configuration Features" paragraph:
> http://doc.qt.io/qt-5/qmake-project-files.html
> 
> Honestly I don't care much if it was there by mistake or unsupported or
> whatever. It was a usable feature. Period.

By abusing qmake. Your bug report showed you used this line:

macx:QT_CONFIG -= no-pkg-config

That above is the abuse. Show us code that worked without that line and has 
stopped working. That will qualify as a regression.

You can continue to abuse Qt's configuration in 5.8. It just changed what 
variables you have to abuse. No compatiblity is guaranteed because it's an 
abuse.

> As I stated before, pkg-config is fundamental to access libraries outside of
> Qt's scope, either on Linux, MSYS2 on Windows or Homebrew/Macports on Mac
> OS, so we need to keep on having that feature from Qt.

I'm not disputing that. That's why I reopened the issue and made it a feature 
request so that we officially support it, without abuses required.

> If you want developers to stop having such access, then I would much like
> call it a regression and IMHO it should be fixed before releasing Qt 5.8.0.

It wasn't a feature before, therefore it's not a bug and not a regression.

Alternatively, we can call it a bug that has been present for a long time. It 
still wouldn't be a regression.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Backporting the "stop unloading plugins" change to 5.6

2016-10-25 Thread Thiago Macieira 
On segunda-feira, 17 de outubro de 2016 14:46:29 PDT Lars Knoll wrote:
> I have to agree with Thiago. For QFactoryLoader, it doesn't make a lot of
> sense to try to unload the plugins, as we only do that on program exit.
> 
> It would be great to make plugins safe to unload, but we all know that this
> is tricky to get right. In addition, we don't even control all the plugins
> we might be loading (thing about additional image formats of styles
> provided by others), so we have no way of knowing whether we can safely
> unload the plugin.
> 
> So I think it's the right thing to change this in 5.6 and not unload those
> plugins on app exit.

https://codereview.qt-project.org/174911

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira 
Em terça-feira, 25 de outubro de 2016, às 17:54:02 PDT, Kevin Kofler escreveu:
> Thiago Macieira wrote:
> > Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari
> > 
> > via Development escreveu:
> >> Hi, please add the following to the blockers list:
> >> https://bugreports.qt.io/browse/QTBUG-56164
> > 
> > That's not a bug, so it can't be a blocker.
> 
> It's a regression, ergo it is a bug.

It was never supported, therefore it can't be a bug, much less a regression. 
Indeed we removed some functionality, but one that was technically abusing 
qmake because it wasn't supported.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira 
Em terça-feira, 25 de outubro de 2016, às 17:14:47 PDT, Benjamin TERRIER 
escreveu:
> This patch fixes tools\configure\environment.cpp
> 
> However in 5.8 the fixed line does not exist anymore in this file, but
> the same regexp appeared in configure.pri (which is a new file
> compared to 5.6).
> So the same fix should be applied to configure.pri, but at 2 places
> (see bug report).
> 
> I guess it is because of the new configure system.

It's possible.

I would much rather extract from the compiler's macros, but that patch wasn't 
added.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Kevin Kofler 
Thiago Macieira wrote:

> Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari
> via Development escreveu:
>> Hi, please add the following to the blockers list:
>> https://bugreports.qt.io/browse/QTBUG-56164
> 
> That's not a bug, so it can't be a blocker.

It's a regression, ergo it is a bug.

Kevin Kofler

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Benjamin TERRIER 
2016-10-25 16:53 GMT+02:00 Thiago Macieira :
>
> Em terça-feira, 25 de outubro de 2016, às 16:42:43 PDT, Benjamin TERRIER
> escreveu:
> > I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
> > French systems:
> >
> >  https://bugreports.qt.io/browse/QTBUG-56731
> >
> > There is a workaround though: fix qconfig.pri after running configure.
> >
> > On a side note this bug might cause side effects on English systems as
> > QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.
> >
> > Best regards,
>
> Should be fixed by https://codereview.qt-project.org/172928, which landed in
> 5.6 as 6851cf52afe188e94344ce22074af97e054f5896 but hasn't made its way to 5.8
> yet.


This patch fixes tools\configure\environment.cpp

However in 5.8 the fixed line does not exist anymore in this file, but
the same regexp appeared in configure.pri (which is a new file
compared to 5.6).
So the same fix should be applied to configure.pri, but at 2 places
(see bug report).

I guess it is because of the new configure system.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira 
Em terça-feira, 25 de outubro de 2016, às 16:42:43 PDT, Benjamin TERRIER 
escreveu:
> I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
> French systems:
> 
>  https://bugreports.qt.io/browse/QTBUG-56731
> 
> There is a workaround though: fix qconfig.pri after running configure.
> 
> On a side note this bug might cause side effects on English systems as
> QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.
> 
> Best regards,

Should be fixed by https://codereview.qt-project.org/172928, which landed in 
5.6 as 6851cf52afe188e94344ce22074af97e054f5896 but hasn't made its way to 5.8 
yet.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Benjamin TERRIER 
Hi,

I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
French systems:

 https://bugreports.qt.io/browse/QTBUG-56731

There is a workaround though: fix qconfig.pri after running configure.

On a side note this bug might cause side effects on English systems as
QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.

Best regards,

Benjamin Terrier

2016-10-24 15:09 GMT+02:00 Jani Heikkinen :

> Hi all,
>
> We have finally (almost) full set of Qt 5.8.0 beta installers for testing
>
>
>
> windows: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/627/
>
> mac: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/521/
>
> linux: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/553/
>
> src: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/
> (submodules are just copied so mirroring is still ongoing)
>
>
>
> Packages are RTA tested & seems to be pretty much OK so please test the
> packages and make sure all blockers are visible in blocker list (
> https://bugreports.qt.io/issues/?filter=17924 )
> . All known blockers
> should be fixed in these packages so these will be released as Qt 5.8.0
> beta if no new blockers found during testing.
>
>
>
> Packages are based on https://codereview.qt-project.org/#/c/174531/
>
>
>
> br,
>
> Jani
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira 
Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari via 
Development escreveu:
> Hi, please add the following to the blockers list:
> https://bugreports.qt.io/browse/QTBUG-56164

That's not a bug, so it can't be a blocker.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Coin update

2016-10-25 Thread Jedrzej Nowacki 
Hi,

   The update went terribly wrong. We essentially lost the machine, because of 
a snapshot which corrupted partition. We needed to reinstall everything. The 
machinery is running now, but it doesn't accept standard builds until we 
reconstruct cache (qt5 builds for all active branches). It can take 2-3 hours.

  Sorry for the inconvenience.

Cheers,
  Jędrek

From: Development  on 
behalf of Jedrzej Nowacki 
Sent: Tuesday, October 25, 2016 9:26:02 AM
To: development@qt-project.org
Subject: [Development] Coin update

Hi,
  We need to update the Coin server, so the service will be interrupted for a 
while today. Sorry for the short notice.
Cheers,
  Jędrek
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtWebChannel: Upstreaming of Python client

2016-10-25 Thread Johannes Lochmann 
Hi Arno,

>On 24 October 2016 at 00:53, Arno Rehn  wrote:
>> Hey everybody,
>>
>> At my company we've developed a Python client for QtWebChannel. It 
>> consists of a more or less direct translation of qwebchannel.js and 
>> an additional layer on top of it, providing async/await syntax 
>> support for Python3.5+.
>> Ideally, we'd like to push this upstream. Before I post a patch to 
>> gerrit, I'd like to get some feedback on whether this is wanted at all.
>> QtWebChannel seems to be pretty much focused on HTML and the web, but 
>> the infrastructure behind it can be used for remoting from pretty 
>> much any scripting language.
>> I'd also plan on implementing a C++ client, maybe also Ruby and 
>> Matlab (since we're using this in a scientific setting).
>>
>> What's your take on this?
>
>Seems useful. Would be interested to try it out.

I agree, this sounds pretty useful, especially given that we’re also working 
again on pyside since this spring.

...especially an implementation in Python and C++ both from the Qt Project 
could be a really nice combo - sign me up!

Regards,

Johannes
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Coin news

2016-10-25 Thread Oswald Buddenhagen 
On Tue, Oct 25, 2016 at 07:22:41AM +, Jędrzej Nowacki wrote:
> I would like to also remind everyone, that intermodule API changes need to be 
> merged in two steps. For example if you plan to change a method "void foo()" 
> in qtbase to "void foo(const QString&)", that would be the right order of 
> execution:
> 1. Commit a change to qtbase that _adds_  foo(const QString&)
>
1a. wait for qt5 integration. 2 would not integrate in the submodules
without 1 being in qt5 already.

> 2. Update all modules that use foo() to use foo(const QString&)
> 3. Wait until Qt5(dev branch) submodule update, that gathers changes from 1 
> and 2
>
only 2 at this point.

> 4. Remove old foo() from qtbase
>
4a. wait again until the final qt5 integration to see it in packages.

so six steps in total. and it takes exactly as long as it sounds.

> If you do not follow we would have to revert your changes.
> 
> Cheers,
>   J�drek
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtWebChannel: Upstreaming of Python client

2016-10-25 Thread Lars Knoll 
On 25/10/16 05:17, "Development on behalf of Jonathan Liu" 
 wrote:



>Hi Arno,
>
>On 24 October 2016 at 00:53, Arno Rehn  wrote:
>> Hey everybody,
>>
>> At my company we've developed a Python client for QtWebChannel. It
>> consists of a more or less direct translation of qwebchannel.js and an
>> additional layer on top of it, providing async/await syntax support for
>> Python3.5+.
>> Ideally, we'd like to push this upstream. Before I post a patch to
>> gerrit, I'd like to get some feedback on whether this is wanted at all.
>> QtWebChannel seems to be pretty much focused on HTML and the web, but
>> the infrastructure behind it can be used for remoting from pretty much
>> any scripting language.
>> I'd also plan on implementing a C++ client, maybe also Ruby and Matlab
>> (since we're using this in a scientific setting).
>>
>> What's your take on this?
>
>Seems useful. Would be interested to try it out.

I agree, this sounds pretty useful, especially given that we’re also working 
again on pyside since this spring.

Cheers,
Lars

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Massimo Callegari via Development 
Hi, please add the following to the blockers list:
https://bugreports.qt.io/browse/QTBUG-56164

Without it, I am either stuck on Qt 5.7 or forced to say goodbye to Qt.
Thanks,Massimo
  Da: Jani Heikkinen 
 A: "development@qt-project.org"  
 Inviato: Lunedì 24 Ottobre 2016 15:09
 Oggetto: [Development] Qt 5.8.0 Beta packages available for testing
   
 Hi all, We have finally (almost) full set of 
Qt 5.8.0 beta installers for testing    
windows:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/627/ 
mac:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/521/ 
linux:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/553/ 
src:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/ (submodules 
are just copied so mirroring is still ongoing)    Packages are RTA tested & 
seems to be pretty much OK so please test the packages and make sure all 
blockers are visible in blocker list 
(https://bugreports.qt.io/issues/?filter=17924 ). All known blockers should be 
fixed in these packages so these will be released as Qt 5.8.0 beta if no new 
blockers found during testing.    Packages are based 
onhttps://codereview.qt-project.org/#/c/174531/    br, Jani 
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


   ___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Coin update

2016-10-25 Thread Jedrzej Nowacki 
Hi,
  We need to update the Coin server, so the service will be interrupted for a 
while today. Sorry for the short notice.
Cheers,
  Jędrek
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Coin news

2016-10-25 Thread Jedrzej Nowacki 

Good news everyone!

Changing Coin to test changes against Qt5 instead of the latest version of all 
modules reduced load on the CI significantly and now the build queue is sane 
even in rush hours (reaching around ~250 items instead of ~1700). I hope every 
one feels that integrations are quicker, especially on leaf modules.

As we managed to reduce the load, we are now hitting a new bottle neck in CI. 
Qt5 updates are not passing often enough and they are crucial, not only for 
releases, but for the whole system. As the first step, we will reduce quality 
criteria for "flaky" definition for Qt5 integrations. Currently, if Coin 
encounters a test failure it tries to re-run it 5 times in addition. If all 
pass then the test run is accepted. For Qt5 we will re-run the test only once. 
The change is based on assumption that flakiness, in most cases, is not caused 
by an intermodule operation and we believe that the assumption is correct. 

I would like to also remind everyone, that intermodule API changes need to be 
merged in two steps. For example if you plan to change a method "void foo()" in 
qtbase to "void foo(const QString&)", that would be the right order of 
execution:
1. Commit a change to qtbase that _adds_  foo(const QString&)
2. Update all modules that use foo() to use foo(const QString&)
3. Wait until Qt5(dev branch) submodule update, that gathers changes from 1 and 
2
4. Remove old foo() from qtbase
If you do not follow we would have to revert your changes.

Cheers,
  Jędrek

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development