Re: [Development] Closing issues automatically with new keyword

2018-09-23 Thread Christian Ehrlicher

Hi,

I get this warning when I only add 'Fixes:' in the footer:

***
*** Suspicious changes in commit HEAD (QSqlQuery: add another testcase 
for bindBool()):

***
***   commit message:
*** - 8: Text following footers (key "footer")
***
***   See http://wiki.qt.io/Early_Warning_System for explanations.

But gerrit does not complain: https://codereview.qt-project.org/#/c/240736/


Christian
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Closing issues automatically with new keyword

2018-09-23 Thread Christian Ehrlicher

Am 23.09.2018 um 17:39 schrieb Christian Ehrlicher:

Hi,

I get this warning when I only add 'Fixes:' in the footer:

***
*** Suspicious changes in commit HEAD (QSqlQuery: add another testcase 
for bindBool()):

***
***   commit message:
*** - 8: Text following footers (key "footer")
***
***   See http://wiki.qt.io/Early_Warning_System for explanations.

But gerrit does not complain: 
https://codereview.qt-project.org/#/c/240736/

Ok, I thought I updated qtrepotools but it wasn't the case.


Christian
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Orphan modules

2018-09-23 Thread Sune Vuorela
On 2018-09-12, Gatis Paeglis  wrote:
> +1 for deprecating qtx11extras as well and moving the code closer to actual 
> plugin. It is frustrating to have all that boilerplate code for 1 header file 
> - qx11info_x11.h

I think it makes sense to have qtx11extras. A stable api and abi that
X11 users can rely on.

I see the only alternative is to provide stable apis in QPA and friends
instead. But that has so far been refused.

/Sune

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development