Re: [Development] Issues with 'Fixes' keyword

2018-12-26 Thread Christian Ehrlicher

Am 27.12.2018 um 07:43 schrieb Kari Oikarinen:

On 26.12.2018 17.58, Christian Ehrlicher wrote:

Hi,

looks like under some circumstances the 'Fixes' keyword in the commit message
does trigger the automatic closing of a bug when the bug is in 'In progress'
state. Is this the intended behavior?

Yes. You can use the "Task-number" keyword if you want to link commits to a bug,
but still keep it open. For example if fixing it properly requires multiple
changes.
Ah, I forgot a 'not'... Bugs in 'In Progress' state and with a 'Fixes' 
keyword are *not* automatically closed.



Christian
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Issues with 'Fixes' keyword

2018-12-26 Thread Kari Oikarinen


On 26.12.2018 17.58, Christian Ehrlicher wrote:
> Hi,
> 
> looks like under some circumstances the 'Fixes' keyword in the commit message 
> does trigger the automatic closing of a bug when the bug is in 'In progress' 
> state. Is this the intended behavior?

Yes. You can use the "Task-number" keyword if you want to link commits to a bug,
but still keep it open. For example if fixing it properly requires multiple
changes.

-- 
Kari
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


[Development] Issues with 'Fixes' keyword

2018-12-26 Thread Christian Ehrlicher

Hi,

looks like under some circumstances the 'Fixes' keyword in the commit 
message does trigger the automatic closing of a bug when the bug is in 
'In progress' state. Is this the intended behavior?


Here some examples:
https://bugreports.qt.io/browse/QTBUG-72545
https://bugreports.qt.io/browse/QTBUG-44746

Thx,
Christian
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development