Re: [Development] Nominating Nicholas Bennett as Approver
+1 Nick has been doing excellent work dealing with documentation in multiple projects. \topi From: Development on behalf of Paul Wicking Sent: Monday, August 30, 2021 10:02 AM To: development Subject: [Development] Nominating Nicholas Bennett as Approver Hi all, I’d like to nominate Nicholas Bennett as approver for the Qt Project. Nicholas has been working with Qt since he joined the Qt Company as a Documentation Engineer at the start of the year. He does stellar work, in my opinion, both with his own changes [0] and as a reviewer [1]. I trust he'll use the approver rights responsibly. [0] - https://codereview.qt-project.org/q/owner:nicholas.bennett%2540qt.io [1] - https://codereview.qt-project.org/q/reviewer:nicholas.bennett%2540qt.io //! Paul ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Should null QPixmaps be allowed in a QCoreApplication?
On 7/27/21 6:41 PM, Sze Howe Koh wrote: Current Qt behaviours: A) If you create any QPixmap after creating QGuiApplication, the result is probably the pixmap that you asked for. All is well. B) If you create any QPixmap after creating QCoreApplication, the result is a null QPixmap. No warnings are produced. C) If you create any QPixmap _in a secondary thread_ after creating QCoreApplication, the result is a segfault due to a nullptr dereference [1]. D) If you create any QPixmap without creating Q(Core|Gui|)Application, the result is a qFatal() telling you that you must have a QGuiApplication. The description of B) is not quite correct I think. The actual behaviour is that, if you have a QCoreApplication, then B1) If you create a QPixmap through QPixmap::fromImage(), either directly or indirectly via QVariant or reading from QDataStream, you get a runtime warning and a null QPixmap. B2) If you create a QPixmap any other way, you get a qFatal() with a message, i.e. same as D). Now the logs indicate that the exception for the B1 situation is there to let headless, QCoreApplication-based apps handle QDataStreams that may contain QPixmaps without crashing. DBus is mentioned as a case. This is the reason there is an autotest that explicitly ensures this behaviour. It was clearly done intentionally. What is anyway clear is that behaviour C) is not intended and is a bug. So C) can and should be fixed; to behave the same as B), I think. - Eirik Aa. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] Nominating Craig Scott as approver
Congratulations to Craig. Approver rights have been set. -- Alex From: Development on behalf of Andrei Golubev Sent: Wednesday, 11 August 2021 10:27 To: development@qt-project.org Subject: Re: [Development] Nominating Craig Scott as approver Hi, +1. -- Best Regards, Andrei From: Development on behalf of Max Goldstein Sent: Tuesday, August 10, 2021 2:28 PM To: development@qt-project.org Subject: Re: [Development] Nominating Craig Scott as approver It's a +1 from me as well. Best, Max From: Development on behalf of Joerg Bornemann Sent: Tuesday, August 10, 2021 9:13 AM To: development@qt-project.org Subject: [Development] Nominating Craig Scott as approver Hi there! I'd like to nominate Craig Scott as approver. Craig, whom you might know as CMake co-maintainer and author of "Professional CMake: A Practical Guide", is helping us with the Qt6 build system since last year. He's a never drying up source of CMake wisdom which he shares in his thorough reviews. His gerrit dashboard is here: https://codereview.qt-project.org/q/owner:craig.scott%2540qt.io I trust he'll use the approver rights responsibly. Joerg ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
