Re: [Development] Nominating Ivan Komissarov as approver

2020-05-07 Thread Andre Hartmann

Hello,

> I'd like to nominate Ivan Komissarov as an approver.

+1

André

Am 07.05.2020 um 10:23 schrieb Christian Kandeler:

Hello,

I'd like to nominate Ivan Komissarov as an approver.
Ivan has been doing valuable work in the qbs project for a while now, both as a 
contributor and a reviewer.
I trust him to use his approver rights responsibly.

His commits can be found here:
https://codereview.qt-project.org/q/owner:ABBAPOH%2540gmail.com


Best regards,
Christian
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Session notes for "Code Review: Sharing the load" and follow-up session

2019-11-20 Thread Andre Hartmann
Hi Nils,

thanks for the summary.

I have two additions:

* Reactivate the QDoc bot to sanity check the docs
* Improve the output of sanity bot, especially for new users: 
https://bugreports.qt.io/browse/QTQAINFRA-1478

Best regards,
Andre

Am Mittwoch, 20. November 2019 schrieb Nils Jeisecke via Development:
> Hi list,
> 
> these are my notes for "Code Review: Sharing the load" session, extended
> by "Improve the contributor experience of the Qt project"
> 
> ---
> 
> * Situation: Many reviews in queue for long time (forever?)
>   * Android: They have a button: Find "Maintainers" (Plugin for Gerrit)
>   * Thiago: Would solve the first 15 Minutes for Contributors, not enough
>   * Improve the culture, appreciate the effort ("Thank you!")
>   * Get more people on-board as reviewers (not as approvers yet)
>   * Idea: Should not be +1 and +1, should be "Thumbs up" and "Tick!"
> * Some reviewers don't understand the implication of "+1" (two "+1" != 
> "+2")
> 
> * What does a good patch looks like?
>  * breaking patch up into multiple patches
>  * Is the documentation really good enough (opinions vary)
> 
> * Ask contributors whose changes have just been review to review others 
> (sometimes happens)
> 
> * Gerrit
>   * Sanity bot is good
>   * Revive early warning bot!
> * Should changes only be approved after tests has run on CI?
> * Can we get a "small CI" run (just Linux, "does it build?")
> * Should the bot automatically run tests if tests have been changed?
> * Should the bot automatically give a warning if tests have not been 
> added (excluding doc only changes)?
>   * "Auto defer" bot is currently not active, would be useful to automatically
> defer patches where contributor did not response to requests.
>   * Automatically stage when change is approved? Faster turnaround time.
>   * Mail (monthly?) reports to maintainers (or others?) (based on gerrit 
> dashboard config?): "N Changes approved, but not staged? Link to staging 
> page", List per module? 
>   * Let's try it and see how it works out
> 
> * Gerrit Features unused right now
>   * Attach labels
>   * Bot could apply hashtags ("wants adoption", "stage-me")
>   * Has a feature to make clazy automatically appply improvements to the 
> change ("contributor has to click a button")
>   
> * Public Community Feedback does not exist
>   * Alex: Use Thiago's script to highlight new contributions (Grafana?)? 
> "Welcome new contributor!" for blog post (Like KDE does)?
> 
> ---
> 
> Follow-up session extensions (lots of overlapping topics)
> 
> * Give contributor feedback
>   * Bot should say: "Welcome, Thanks for your first contribution"
>   * Monthly blog post advertising external contributors?
>   * Send out physical awards? T-Shirts, "Thank you" letter, ...?
> 
> * Make contributing easier
>   * Put contributor documentation into Qt's documentation ("Gettings 
> started")?
>   * Link freenode IRC Web-Backend to simplify access to IRC for new 
> contributors
>   * Use Qt account profile to setup everything needed for contributing (ssh 
> keys, CLA check, ...)
>   * Adapt github workflow (Checklist "Auto test done", "Documentation done", 
> ...)
> 
> * Triage bugs
>   * Add Jira label ("for juniors")?
> 
> * Community
>   * Missing Community manager (Consent: Yes, it's needed)
>   * Missing "qt-project" entity, kind of a foundation? Funding?
>   * Redefine: What is the qt-project?
> 
> * Activating new contributors
>   * Communication of Qt (company) targets companies, not community (qt.org => 
> qt.io => sales)
>   * Microsoft pushes its stuff to universities, why not Qt (or qt-project?)
>   * Qt project needs a proper homepage. With nice, contemporary Howtos, ...
> 
> ---
> 
> Nils
>

-- 
Von meinem Jolla gesendet
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Gerrit: Sanity-Review is lost after moving changes

2019-06-05 Thread Andre Hartmann

Or if it is, the sanity bot should probably be triggered again. > yes, make a 
jira task for qtqainfra/sanity bot.

Done: https://bugreports.qt.io/browse/QTQAINFRA-3026
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Why are my merged patches not in dev after checkout?

2018-07-19 Thread Andre Hartmann
Hi Daniel,

Am Donnerstag, 19. Juli 2018 schrieb Daniel Savi:
> Hello everybody. I'm sorry for the probably stupid question again. Two 
> of my patches have been merged in April (to dev I assume).

Correct, they landed in dev i.e. upcoming 5.12.

> Now, I did a 
> "git checkout dev" and "git rebase origin/dev" on my local machine that 
> didn't have the dev branch on it before. The rebase command told me, 
> that my local branch was up to date. "git branch" shows that I'm on "dev"

Have you done 'git fetch' before?
 
> My expectation was to have my patches included in that branch. But they 
> aren't, the files are still as they have been before my patch was merged.
> 
> If anyone wants to check, I'm talking about these two patches:
> Change-Id: Iaa8ec0246aaba004d98c9e8c66609795101519a9
> Change-Id: I2d269ef0f842e73af64d48bfef531d5fa3078088
> 
> What am I doing wrong?
> 
> Regards,
> 
> Daniel Savi

Andre

 ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>

-- 
Von meinem Jolla gesendet
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development