Re: [Development] Code contributions via bug reports and forum posts

[Tuukka Turunen]

On 16/05/2018, 19.07, "Development on behalf of Thiago Macieira" 
 wrote:
>
>   To all users: please continue submitting contributions through the 
>contribution system as much as you can. Submitting patches via the bug 
>reporting tool may not work if the assignee or maintainer in question does 
> not 
>work for the Qt Company and there's no one who does that is willing to 
> accept 
>the responsibility of submitting it on your behalf.

Yes, absolutely. We should not reduce normal codereview use. For any of these 
"casual contributions", someone needs to do the work to get the patch in via 
codereview (and in most cases also do some changes to the patch as well). 
Intention is not do regular contributions in this way, just to allow similar 
approach for all users as has been the case for commercial license holders 
since ages. 

Yours,

Tuukka

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Code contributions via bug reports and forum posts

[Thiago Macieira]

On Wednesday, 16 May 2018 10:02:42 PDT Oswald Buddenhagen wrote:
> > My IANAL reading is that I'm not allowed. I don't see anywhere in the Qt
> > Account agreement that says a third party is allowed to pick up the code
> > and submit it through the CLA.
> 
> you wouldn't be submitting it under CLA (though you need it for
> purely technical reasons). qt employees obviously also don't submit
> under the CLA (because the code is already owned by tqtc) even though we
> use the same technical process.

You have not convinced me enough.

I will continue to ignore patches in JIRA.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Code contributions via bug reports and forum posts

[Oswald Buddenhagen]

On Wed, May 16, 2018 at 09:46:57AM -0700, Thiago Macieira wrote:
> On Wednesday, 16 May 2018 09:31:56 PDT Oswald Buddenhagen wrote:
> > On Wed, May 16, 2018 at 09:06:59AM -0700, Thiago Macieira wrote:
> > > Please note this grants The Qt Company this right, presumably because
> > > that "Feedback" is submitted to a web service they control.
> > 
> > uh? it does because it's submitted to a service which has these TOS. you
> > could put the same terms on a site *you* control, and the benefactor
> > would still be tqtc.
> 
> The point is that the grant is being made to The Qt Company and the grant 
> only 
> applies because it is done by using a service that TQtC controls.
> 
no, it *doesn't*. your interpretation is absurd.

> > > For other people in the Qt Project, nothing changes: you (and I) are
> > > not allowed to pick up patches submitted to the bug reporting system
> > > or forums and apply it to Qt no more than we are allowed to pick up
> > > patches submitted to Stack Overflow or pastebin.com.
> > 
> > that's nonsense. you wouldn't be using the code for your own purposes,
> > but just acting as a proxy, re-submitting the code under terms the
> > author has already accepted, including attribution.
> > 
> > IANAL, blah blah blah.
> 
> My IANAL reading is that I'm not allowed. I don't see anywhere in the Qt 
> Account agreement that says a third party is allowed to pick up the code and 
> submit it through the CLA.
> 
you wouldn't be submitting it under CLA (though you need it for
purely technical reasons). qt employees obviously also don't submit
under the CLA (because the code is already owned by tqtc) even though we
use the same technical process.

also note that the TOS grant of rights is essentially the same as the
central grant in the CLA, just a bit less verbose.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Code contributions via bug reports and forum posts

[Thiago Macieira]

On Wednesday, 16 May 2018 09:31:56 PDT Oswald Buddenhagen wrote:
> On Wed, May 16, 2018 at 09:06:59AM -0700, Thiago Macieira wrote:
> > Please note this grants The Qt Company this right, presumably because
> > that "Feedback" is submitted to a web service they control.
> 
> uh? it does because it's submitted to a service which has these TOS. you
> could put the same terms on a site *you* control, and the benefactor
> would still be tqtc.

The point is that the grant is being made to The Qt Company and the grant only 
applies because it is done by using a service that TQtC controls.

> > For other people in the Qt Project, nothing changes: you (and I) are
> > not allowed to pick up patches submitted to the bug reporting system
> > or forums and apply it to Qt no more than we are allowed to pick up
> > patches submitted to Stack Overflow or pastebin.com.
> 
> that's nonsense. you wouldn't be using the code for your own purposes,
> but just acting as a proxy, re-submitting the code under terms the
> author has already accepted, including attribution.
> 
> IANAL, blah blah blah.

My IANAL reading is that I'm not allowed. I don't see anywhere in the Qt 
Account agreement that says a third party is allowed to pick up the code and 
submit it through the CLA. Or, in my case, through the CCLA that applies 
between Intel and The Qt Company.

So I will continue not to do it. Patches to JIRA will continue to be ignored 
and will mostly go unread in the first place.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Code contributions via bug reports and forum posts

[Oswald Buddenhagen]

On Wed, May 16, 2018 at 09:06:59AM -0700, Thiago Macieira wrote:
> Please note this grants The Qt Company this right, presumably because
> that "Feedback" is submitted to a web service they control.
>
uh? it does because it's submitted to a service which has these TOS. you
could put the same terms on a site *you* control, and the benefactor
would still be tqtc.

> For other people in the Qt Project, nothing changes: you (and I) are
> not allowed to pick up patches submitted to the bug reporting system
> or forums and apply it to Qt no more than we are allowed to pick up
> patches submitted to Stack Overflow or pastebin.com.
> 
that's nonsense. you wouldn't be using the code for your own purposes,
but just acting as a proxy, re-submitting the code under terms the
author has already accepted, including attribution.

IANAL, blah blah blah.

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Code contributions via bug reports and forum posts

[Thiago Macieira]

On Wednesday, 16 May 2018 02:20:45 PDT Tuukka Turunen wrote:
> Contribution of source code is now allowed via Qt systems such as bug
> reports and forums. Traditionally all source code contributions to the Qt
> Project are governed via Contribution License Agreement (CLA), except
> possibility given to the commercial license holders to provide bug fixes
> and similar small modifications that The Qt Company has pushed into Qt. We
> have now updated the Qt Account service terms to more clearly state that
> source code can be contributed via the Qt systems. The preferred way to
> contribute source code to the Qt Project is still via the CLA, according to
> the contribution guidelines. But sometimes a user who has not accepted the
> CLA has a patch that would, for example, fix a bug in Qt. Providing such a
> patch is now also possible via the Qt systems, for example via the bug
> reports or forum posts.
> 
> Please check a blog post for more information:
> http://blog.qt.io/blog/2018/05/16/code-contributions-via-bug-reports-forum-> 
> posts/

"n addition to the license above in Section 3 granted to the Content, you as 
User may decide to give The Qt Company input or feedback (including but not 
limited to software code) on the Services or relating to your Subscription 
(“Feedback”). You grant to The Qt Company ..."

Please note this grants The Qt Company this right, presumably because that 
"Feedback" is submitted to a web service they control. For other people in the 
Qt Project, nothing changes: you (and I) are not allowed to pick up patches 
submitted to the bug reporting system or forums and apply it to Qt no more 
than we are allowed to pick up patches submitted to Stack Overflow or 
pastebin.com.

To all users: please continue submitting contributions through the 
contribution system as much as you can. Submitting patches via the bug 
reporting tool may not work if the assignee or maintainer in question does not 
work for the Qt Company and there's no one who does that is willing to accept 
the responsibility of submitting it on your behalf.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] Code contributions via bug reports and forum posts

[Tuukka Turunen]

Hi,

Contribution of source code is now allowed via Qt systems such as bug reports 
and forums. Traditionally all source code contributions to the Qt Project are 
governed via Contribution License Agreement (CLA), except possibility given to 
the commercial license holders to provide bug fixes and similar small 
modifications that The Qt Company has pushed into Qt. We have now updated the 
Qt Account service terms to more clearly state that source code can be 
contributed via the Qt systems. The preferred way to contribute source code to 
the Qt Project is still via the CLA, according to the contribution guidelines. 
But sometimes a user who has not accepted the CLA has a patch that would, for 
example, fix a bug in Qt. Providing such a patch is now also possible via the 
Qt systems, for example via the bug reports or forum posts.

Please check a blog post for more information: 
http://blog.qt.io/blog/2018/05/16/code-contributions-via-bug-reports-forum-posts/

Note that any existing source code in the systems is not covered, only items 
pushed from now on.

Yours,

Tuukka


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development