Re: [Development] Give reviewers ample time to respond
> On 1 Aug 2017, at 10:44 pm, Kai Koehne wrote: > > I'd like to remind everyone about our commit policy: > https://wiki.qt.io/Review_Policy . In particular, it says 'Give reviewers > ample time to respond', which is assumed to be a full working day minimum > (preferably two days). > > That is, even if you have a +2 by an approver, you should _not_ stage > immediately if there are other reviewers who haven't given feedback yet. +1 I have often woken up to see changes pushed through over (my) night that I wish I had a chance to comment on, or at least be given the chance to even be aware of some change before it’s been integrated. There also might be reviewers not listed for review that might want to comment. I also understand some P0/urgent changes might need to be rushed through. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Give reviewers ample time to respond
Hi, I'd like to remind everyone about our commit policy: https://wiki.qt.io/Review_Policy . In particular, it says 'Give reviewers ample time to respond', which is assumed to be a full working day minimum (preferably two days). That is, even if you have a +2 by an approver, you should _not_ stage immediately if there are other reviewers who haven't given feedback yet. Regards Kai -- Kai Koehne, Senior Manager R&D | The Qt Company The Qt Company GmbH, Rudower Chaussee 13, D-12489 Berlin Geschäftsführer: Mika Pälsi, Juha Varelius, Mika Harjuaho. Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 144331 B ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
