Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Thiago Macieira
On quarta-feira, 22 de janeiro de 2014 09:26:57, Blasche Alexander wrote:
> It's the first time that I had to provide a changes file for my modules. 
> Obviously I was a bit too ambitious ;) but yes:
> 
> qt.gitorious.org/qt/qtconnectivity/blobs/release/dist/changes-5.2.1

Thanks Alex

I'll split the changelog today. Looks like I've captured the changes that 
people talked about so far.
-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Frederik Gladhorn
Mandag 20. januar 2014 12.59.49 skrev Thiago Macieira:
> On segunda-feira, 20 de janeiro de 2014 12:39:04, Thiago Macieira wrote:
> > Accessibility
> > -
> > 
> >  - On Linux action names were returned as empty strings in AT-SPI
> >  
> >getActions, now returns the proper names.
> 
> Should I move this to QtGui? Or to QtWidgets? Or leave?

In this case it is part of QtGui. I don't mind gui or leaving it separate. 
Since it's only one entry maybe gui is the better place.

-- 
Best regards,
Frederik Gladhorn
Senior Software Engineer - Digia, Qt
Visit us on: http://qt.digia.com

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-22 Thread Blasche Alexander


--
Alex


> -Original Message-
> From: development-bounces+alexander.blasche=digia@qt-project.org
> [mailto:development-bounces+alexander.blasche=digia@qt-project.org]
> On Behalf Of Thiago Macieira
> Sent: Tuesday, 21 January 2014 17:58
> To: development@qt-project.org
> Subject: Re: [Development] How to write a ChangeLog entry
> 
> On terça-feira, 21 de janeiro de 2014 08:09:43, Blasche Alexander wrote:
> > Why are you pushing change log items for modules outside of qtbase to
> > qtbase?

> I'm editing everything in one file so it's easier for me, but I'll split them
> to each module after we're done.

Ok good to know for the next time.


> > >> QtBluetooth
> > >> ---
> > >>
> > >>  - Documentation:
> > >>* Fix cases where device and service discovery classes emitted an
> > >>error
> > >>
> > >>  signal but the human readable error string was not adjusted.
> > >
> > >How is this a documentation issue? If it's a minor documentation fix, it
> > >probably isn't relevant for the changelog.
> >
> > The release branch of the git repo for this module has had the relevant fix
> > for the above issue for some time.
> 
> You mean in the changes file?

It's the first time that I had to provide a changes file for my modules.  
Obviously I was a bit too ambitious ;)
but yes:

qt.gitorious.org/qt/qtconnectivity/blobs/release/dist/changes-5.2.1

--
Alex

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Samuel Gaist

On 21 janv. 2014, at 00:43, Thiago Macieira  wrote:

> On segunda-feira, 20 de janeiro de 2014 23:58:21, Samuel Gaist wrote:
>> On 20 janv. 2014, at 23:44, Thiago Macieira  
> wrote:
>>> On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote:
 Yes it does, with that, QLocale supports the various possible negative
 signs> 
>>> Can you verify if the change also affects QString::toInt, toDouble, etc.?
>>> 
>>> 5.1.1 doesn't support U+2212.
>> 
>> Sure, I'll do it tomorrow
>> 
>> IIRC, the patch went in for 5.2
> 
> Right, this is the 5.2.1 change log.

As promised:

QString str("\u2212\x31\x36");

qDebug() << str.toShort() << str.toInt() << str.toDouble() << str.toLong() << 
str.toLongLong() << str.toFloat();

all returns -16

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Thiago Macieira
On terça-feira, 21 de janeiro de 2014 08:09:43, Blasche Alexander wrote:
> Why are you pushing change log items for modules outside of qtbase to
> qtbase?
> 
> http://qt-project.org/wiki/Change-files-in-Qt-5.2
> 
> clearly accumulates the various files from the various git repos.

I'm editing everything in one file so it's easier for me, but I'll split them 
to each module after we're done.

Someone will have to put it back together to publish the Qt 5.2.1 changelog in 
the website, alongside the download packages.

> >> QtBluetooth
> >> ---
> >> 
> >>  - Documentation:
> >>* Fix cases where device and service discovery classes emitted an
> >>error
> >>
> >>  signal but the human readable error string was not adjusted.
> >
> >How is this a documentation issue? If it's a minor documentation fix, it
> >probably isn't relevant for the changelog.
> 
> The release branch of the git repo for this module has had the relevant fix
> for the above issue for some time.

You mean in the changes file?

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Joerg Bornemann
On 20.01.2014 21:59, Thiago Macieira wrote:

>>   - QProcess:
>> * [QTBUG-35357] Fixed a regression from Qt4 in QProcess that
>>   prevented altering the pipe modes of stdin in the child process.
>
> I've rewritten this text. Please confirm that it is accurate.

I hereby confirm the accuracy of your rewrite. :)


Cheers,

Joerg
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-21 Thread Blasche Alexander
> -Original Message-
> From: development-bounces+alexander.blasche=digia@qt-project.org
> [mailto:development-bounces+alexander.blasche=digia@qt-project.org]
> On Behalf Of Thiago Macieira

> Here's the edited changelog. Please re-read it. You can also find it here:
>   https://codereview.qt-project.org/76094
> 
> If you have updates, please reply to this email or leave a comment in the
> change above. I'll update the changelog file.

I hope I am not rehashing something old with this question but at least I am 
not aware of it.

Why are you pushing change log items for modules outside of qtbase to qtbase? 

http://qt-project.org/wiki/Change-files-in-Qt-5.2

clearly accumulates the various files from the various git repos.

>> QtBluetooth
>> ---
>> 
>>  - Documentation:
>>* Fix cases where device and service discovery classes emitted an error
>>  signal but the human readable error string was not adjusted.
>
>How is this a documentation issue? If it's a minor documentation fix, it 
>probably isn't relevant for the changelog.

The release branch of the git repo for this module has had the relevant fix for 
the above issue for some time.

If you want to put the change files for all modules into qtbase then I suggest 
you grab them from the relevant module. I cannot modify already committed 
changelog entries but I do maintain a sane changes file for the module. 
Nevertheless I maintain my believe that it's wrong to put them all into qtbase 
which would also raises the question why the modules still have them.

--
Alex

P.S. I do use you change log script as well but I tend to cut the irrelevant 
stuff out and then push to the module repo.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 21:46:22, Sune Vuorela wrote:
> On 2014-01-20, Thiago Macieira  wrote:
> > On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote:
> >> On 2014-01-20, Thiago Macieira  wrote:
> >> > Windows
> >> > ---
> >> 
> >> [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page
> >> sizes for system printers.
> > 
> > Sounds like I should merge with the OS X fix:
> >  - [QTBUG-34700] QtPrintSupport will now respect the custom paper size
> >  
> >settings when printing.
> 
> It is kind of the opposite than that one.  But it could be grouped into
> a PrintSUpport group rather than in platform groups.
> 
> I don't feel that strongly for it, but I just spent half a day today
> trying to figure out what was up and down and ended up finding this fix.

Well, not entirely the opposite. They're both about paper sizes, it's just 
that one is about custom sizes and the other is about any size at all.

So I wrote:
 - [QTBUG-34700][QTBUG-35500] Fixed bugs that caused QtPrintSupport
   not to report the correct the paper sizes on Windows and on OS X.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 23:58:21, Samuel Gaist wrote:
> On 20 janv. 2014, at 23:44, Thiago Macieira  
wrote:
> > On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote:
> >> Yes it does, with that, QLocale supports the various possible negative
> >> signs> 
> > Can you verify if the change also affects QString::toInt, toDouble, etc.?
> > 
> > 5.1.1 doesn't support U+2212.
> 
> Sure, I'll do it tomorrow
> 
> IIRC, the patch went in for 5.2

Right, this is the 5.2.1 changelog.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist

On 20 janv. 2014, at 23:44, Thiago Macieira  wrote:

> On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote:
>> Yes it does, with that, QLocale supports the various possible negative signs
> 
> Can you verify if the change also affects QString::toInt, toDouble, etc.?
> 
> 5.1.1 doesn't support U+2212.
> 

Sure, I'll do it tomorrow

IIRC, the patch went in for 5.2

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 22:59:09, Samuel Gaist wrote:
> Yes it does, with that, QLocale supports the various possible negative signs

Can you verify if the change also affects QString::toInt, toDouble, etc.?

5.1.1 doesn't support U+2212.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist

On 20 janv. 2014, at 22:40, Thiago Macieira  wrote:

> On segunda-feira, 20 de janeiro de 2014 22:21:54, Samuel Gaist wrote:
>> On 20 janv. 2014, at 21:59, Thiago Macieira  
> wrote:
 QtCore
 --
 
 - [QTBUG-35069] Fixed a bug that caused negative number input using '-'
 to
 
  be rejected because the current locale uses e.g. 0x2212. QIntValidator
  and QDoubleValidator now accepts both signs as well as the locale minus
  sign.
>>> 
>>> Neither class is in QtCore. I'm moving this to QtWidgets.
>> 
>> Hi,
>> 
>> shouldn't the major area be the place where the fix is ?
>> 
>> Here the "side effect" is that it solves a problem reported in QtWidgets.
>> 
>> In that case, my log message might not be clear enough
> 
> It should be where the fix is visible, what code gets affected. Does this 
> affect 
> QLocale too? If so, then I can leave it in the QtCore part and just add the 
> extra info.
> 
> -- 

Yes it does, with that, QLocale supports the various possible negative signs
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Sune Vuorela
On 2014-01-20, Thiago Macieira  wrote:
> On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote:
>> On 2014-01-20, Thiago Macieira  wrote:
>> > Windows
>> > ---
>> 
>> [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page
>> sizes for system printers.
>
> Sounds like I should merge with the OS X fix:
>
>  - [QTBUG-34700] QtPrintSupport will now respect the custom paper size
>settings when printing.

It is kind of the opposite than that one.  But it could be grouped into
a PrintSUpport group rather than in platform groups.

I don't feel that strongly for it, but I just spent half a day today
trying to figure out what was up and down and ended up finding this fix.

/Sune

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 22:21:54, Samuel Gaist wrote:
> On 20 janv. 2014, at 21:59, Thiago Macieira  
wrote:
> >> QtCore
> >> --
> >> 
> >> - [QTBUG-35069] Fixed a bug that caused negative number input using '-'
> >> to
> >> 
> >>   be rejected because the current locale uses e.g. 0x2212. QIntValidator
> >>   and QDoubleValidator now accepts both signs as well as the locale minus
> >>   sign.
> > 
> > Neither class is in QtCore. I'm moving this to QtWidgets.
> 
> Hi,
> 
> shouldn't the major area be the place where the fix is ?
> 
> Here the "side effect" is that it solves a problem reported in QtWidgets.
> 
> In that case, my log message might not be clear enough

It should be where the fix is visible, what code gets affected. Does this 
affect 
QLocale too? If so, then I can leave it in the QtCore part and just add the 
extra info.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 21:30:37, Sune Vuorela wrote:
> On 2014-01-20, Thiago Macieira  wrote:
> > Windows
> > ---
> 
> [QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page
> sizes for system printers.

Sounds like I should merge with the OS X fix:

 - [QTBUG-34700] QtPrintSupport will now respect the custom paper size
   settings when printing.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Sune Vuorela
On 2014-01-20, Thiago Macieira  wrote:
> Windows
> ---
[QTBUG-35500] Fix printing on Windows. QPrinter now reports proper page
sizes for system printers.


(I would like another sentence about the actual implications. For me, it
was that my custom printing code went from 'completely broken' to
'actually working')

/Sune

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Samuel Gaist

On 20 janv. 2014, at 21:59, Thiago Macieira  wrote:
> 
>> QtCore
>> --
>> 
>> - [QTBUG-35069] Fixed a bug that caused negative number input using '-' to
>>   be rejected because the current locale uses e.g. 0x2212. QIntValidator
>>   and QDoubleValidator now accepts both signs as well as the locale minus
>>   sign.
> 
> Neither class is in QtCore. I'm moving this to QtWidgets.
> 


Hi,

shouldn't the major area be the place where the fix is ? 

Here the "side effect" is that it solves a problem reported in QtWidgets. 

In that case, my log message might not be clear enough 
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
Requesting comments below.

On segunda-feira, 20 de janeiro de 2014 12:39:04, Thiago Macieira wrote:
> Accessibility
> -
> 
>  - On Linux action names were returned as empty strings in AT-SPI
>getActions, now returns the proper names.

Should I move this to QtGui? Or to QtWidgets? Or leave?

> QtBluetooth
> ---
> 
>  - Documentation:
>* Fix cases where device and service discovery classes emitted an error
>  signal but the human readable error string was not adjusted.

How is this a documentation issue? If it's a minor documentation fix, it 
probably isn't relevant for the changelog.

> QtCore
> --
> 
>  - [QTBUG-35069] Fixed a bug that caused negative number input using '-' to
>be rejected because the current locale uses e.g. 0x2212. QIntValidator
>and QDoubleValidator now accepts both signs as well as the locale minus
>sign.

Neither class is in QtCore. I'm moving this to QtWidgets.

>  - QProcess:
>* [QTBUG-35357] Fixed a regression from Qt4 in QProcess that
>  prevented altering the pipe modes of stdin in the child process.

I've rewritten this text. Please confirm that it is accurate.

> QtGui
> -
> 
>  - QKeySequence:
>* [QTBUG-24406] return Qt::Key_unknown with invalid modifiers on OS X

I need help rewriting this one. What are invalid modifiers? Can the end-user 
press invalid modifiers? If the end-user can press invalid modifiers, how is 
this a good fix? If the end-user can't press them, what is the situation being 
fixed?

> QtMultimedia
> 
> 
>  - Android:
>* [QTBUG-31422] Enable mediaplayer to read files from the Qt Resource
>  system.

Oops, rewritten as:

   * [QTBUG-31422] The mediaplayer can now read files from the Qt
 Resource system.

>* [QTBUG-35564] Camera operations moved to a dedicated thread
>* [QTBUG-35416] QVideoProbe support for camera

Please help rewriting these. And make sure the information is relevant to the 
user. Why should our users care that the operations have been moved to a 
thread? What's the benefit or the issue fixed?

> QtQuickControls
> ---
> 
>  - On Mac, ComboBox will now only get tab focus when it is editable.
>  - [QTBUG-35794] It is now possible to set currentIndex to -1 to clear
>selection
>  - Editable Combobox now updates currentText when accepting a
>substring of an existing value.

Please note the different spellings of Combobox. Is that a QML type? If it is, 
case is important. If it isn't, please add spaces and use correct plural rules 
("Editable combo boxes now update [...]")

I accidentally remove the "ComboBox" from the second entry. I've re-added at 
the end. ("clear selection in a ComboBox")

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
On segunda-feira, 20 de janeiro de 2014 12:08:37, Thiago Macieira wrote:
> Hello everyone
> 
[snip]

Here's the edited changelog. Please re-read it. You can also find it here:
https://codereview.qt-project.org/76094

If you have updates, please reply to this email or leave a comment in the 
change above. I'll update the changelog file.


*   Important Behavior Changes *


 - [QTBUG-34345][QTBUG-26008][QTBUG-26430] QPrinter no longer allows you to
   set an invalid printer name.
 - [QTBUG-34141] Parsing of Qt::ISODate by QDate::fromString() and
   QDateTime()::fromString() is not as lenient as before, the date
   component separators are now required to be non-numeric. This means a
   string like "2000901901" will no longer be recognized as a valid ISO
   Date, but "2000/01/01" will still be even though it doesn't strictly
   meet the ISO format of "2000-01-01".


*  Library *


Accessibility
-

 - On Linux action names were returned as empty strings in AT-SPI
   getActions, now returns the proper names.

ActiveQt


 - [QTBUG-34989] ActiveQt now picks up plugins from deployment
   location of Active X DLLs.

QtBluetooth
---

 - Documentation:
   * Fix cases where device and service discovery classes emitted an error
 signal but the human readable error string was not adjusted.

QtCore
--

 - [QTBUG-35069] Fixed a bug that caused negative number input using '-' to
   be rejected because the current locale uses e.g. 0x2212. QIntValidator
   and QDoubleValidator now accepts both signs as well as the locale minus
   sign.
 - Fixed sign conversion warnings in code using QMetaTypeId.

 - QProcess:
   * [QTBUG-35357] Fixed a regression from Qt4 in QProcess that
 prevented altering the pipe modes of stdin in the child process.

 - QTemporaryDir:
   * Fixed a bug in QTemporaryDir name generator that dramatically reduced
 randomness of the name.

 - QThread:
   * [QTBUG-34840] Fixed handle leaks on Windows.

QtGui
-

 - [QTBUG-35421] Fixed crash when sending accessibility updates when the
   corresponding widget does not have a corresponding QAccessibleInterface.
   This showed on Mac for example with QStatusBar.
 - Qt's generic font database now adds OpenType fonts (.otf).

 - QKeySequence:
   * [QTBUG-24406] return Qt::Key_unknown with invalid modifiers on OS X

 - Text:
   * [QTBUG-35740] Fixed regression when shaping some strings containing
 characters from multiple fonts.

QtMultimedia


 - Android:
   * [QTBUG-31422] Enable mediaplayer to read files from the Qt Resource
 system.
   * [QTBUG-35564] Camera operations moved to a dedicated thread
   * [QTBUG-35416] QVideoProbe support for camera

QtPositioning
-

 - Applications no longer need to register common Qt Positioning data
   types with the metatype system.

QtQml
-

 - [QTBUG-35979] Fixed JavaScript Array.pop() not updating the
   internal array length correctly

QtQuick
---

 - [QTBUG-35128] Fixed TextInput to call fixup() on its validator when
   being accepted or losing focus, and the validator reports that the input
   is in "intermediate" state ie. the input should be fixed up.
 - [QTBUG-34517] Fixed an issue that caused QQuickTextInput to not
   accept delete/home/backspace/left/right keys when the key was used
   in a shortcut.

QtQuickControls
---

 - On Mac, ComboBox will now only get tab focus when it is editable.
 - [QTBUG-35794] It is now possible to set currentIndex to -1 to clear
   selection
 - Editable Combobox now updates currentText when accepting a
   substring of an existing value.
 - Fixed a TableView regression where the last row in a TableView
   could not be selected by keyboard.

QtSql
-

 - IBase support:
   * [QTBUG-33345] Custom port numbers are now supported.
   * [QTBUG-13435] Fixed the internal state of IBase driver after a failed
 open call.

 - MySQL / MariaDB support:
   * [QTBUG-31124] Fixed handling of fractions of second.

 - Oracle support:
   * [QTBUG-34794] Fixed the compilation

 - Sqlite support:
   * [QTBUG-24200] Fixed handling of fractions of second.
   * [QTBUG-35186] Fixed evaluation of driver options

QtTestLib
-

 - [QTBUG-34630] The (default) plain text logger on Windows now logs to
   either the system debug log (in case no console is open), or stdout, not
   both.

QtWidgets
-

 - QSpinBox:
   * [QTBUG-20691] Entering positive values with the '+' prefix is now
 allowed.

 - Windows:
   * [QTBUG-34799] Update QWidgetBackingStore and QWindowsBackingStore to
 suppor

[Development] How to write a ChangeLog entry

2014-01-20 Thread Thiago Macieira
Hello everyone

I've attached the raw output of the Qt 5.2.1 changelog, as created by the 
create_changelog.pl tool. As you can see, it has several mistakes. This email 
is meant to explain how to properly write a changelog entry in your commit 
message.

The basic format is:

[ChangeLog][Major area][Minor area] Text with a verb in the past, like 
"added", "fixed", "made" if you're describing the issue that was fixed. 
Alternatively, you can say what Qt will now do, as in "ClassName will now do 
that" if the new behaviour is more important. Constructs like "now does" and 
"no longer does" are acceptable to indicate future behaviour (present 
continues to the future or "general truth" sentences).

Notes:
 * you can add as many [ChangeLog] blocks as necessary to your commit message

 * only add them if you have something important to tell the user. You do not 
have to write an entry for every commit and fix you do.

 * each block MUST be a single Git commit message paragraph. That is, there 
must be a blank line before and one after. That means: the Change-Id or Task-
Number lines must be separated from the ChangeLog paragraph

 * if you need continuation lines, you need to insert a non-empty blank line. 
It's very hard to do it in a regular git commit, since you need to pass the --
cleanup=verbatim option, but you can insert NBSP instead.

 * it's ok to word-wrap the paragraph. The script will re-wrap as necessary 
and strip any leading or trailing whitespaces.

 * the task number is automatically extracted. Do not add it.

 * the "Major area" should be the Qt module name, a platform name or a tool 
name

 * the "Minor area" is optional, but you can use it to describe a subsystem of 
the major area, like a class name. If you can't think of anything, don't use 
it. If the "Major area" isn't a Qt module, consider not using a minor one.

 * it's possible to use a "Micro area" (and "nano area" and so forth), but you 
should think about it first.


Mistakes in the attached file:

 - QTBUG-34989:
   * [QTBUG-34989] Pick up plugins from deployment location of Active X
 DLLs.

 - QTBUG-35129:
   * [QTBUG-35129] Update deployed plugins and imports when APK is updated
 on the device.

Do not include the task number in the changelog line. It's extracted 
automatically.

Messages should be with verbs in the past or future, not present or 
imperative.

 - Make mailto links work again in Qt Assistant:

 - Editable Combobox would not update
currentText when accepting a substring of an existing value.:
   * [QTBUG-35521] 

 - Fixed: TableView regression where
the last row in a TableView could not be selected by keyboard.:
   * [QTBUG-35572] 

The changelog message was in brackets, making it an area:
[ChangeLog][Qt Assistant][Make mailto links work again in Qt Assistant]

The colon after "Fixed" should not be there. Make it a sentence.

 - General:
   * Applications no longer need to register common Qt Positioning data
 types with the metatype system.

Small issue. The "General" minor area is optional, you can leave it out.

   * [QTBUG-33345] Support custom port number Reviewed-by: Mark Brand
 
   * [QTBUG-13435] Fixed the internal state of IBase driver after a failed
 open call Reviewed-by: Mark Brand 
[and others]

Missing blank line after the [ChangeLog] paragraph.

qtbase
--

"qtbase" is not an area, it's an organisation detail of the packages. The 
correct area would be "Tools".

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
Accessibility
-

 - On Linux action names were returned as empty strings in AT-SPI
   getActions, now returns the proper names.

ActiveQt


 - QTBUG-34989:
   * [QTBUG-34989] Pick up plugins from deployment location of Active X
 DLLs.

Android
---

 - [QTBUG-34984] Add workarounds for OpenGL bugs on Samsung Galaxy Tab 3.

 - QTBUG-35129:
   * [QTBUG-35129] Update deployed plugins and imports when APK is updated
 on the device.

Important Behavior Changes
--

 - [QTBUG-34345][QTBUG-26008][QTBUG-26430] QPrinter no longer allows you to
   set an invalid printer name.
 - [QTBUG-34141] Parsing of Qt::ISODate by QDate::fromString() and
   QDateTime()::fromString() is not as lenient as before, the date
   component separators are now required to be non-numeric. This means a
   string like "2000901901" will no longer be recognized as a valid ISO
   Date, but "2000/01/01" will still be even though it doesn't strictly
   meet the ISO format of "2000-01-01".

Platform Specific Changes
-

 - OS X:
   * [QTBUG-34411] Implemented QMainWindow::setUnifiedTitleAndToolBarOnMac.

 - OS X / QtPrintSupport:
   * [QTBUG-34700] Respect the custom paper size settings when printing.

 - X11 / XCB:
   * [QTBUG-32683] Fixed a bug that caused Qt applications to think the
 screen DPI had changed when it had not, after connecting or
 disconnecting moni