Re: [Development] IMPORTANT: topic reviews on gerrit disabled

2011-11-17 Thread Oswald Buddenhagen
On 11/16/11 16:44, Storm-Olsen Marius (Nokia-MP-Qt/Austin) wrote:
 On 11/14/11 5:13 PM, ext Oswald Buddenhagen oswald.buddenha...@nokia.com  
 wrote:
 due to about a dozen bugs, a few of them fairly serious, i went ahead
 and disabled the topic review functionality. it will come back, but not
 necessarily this year. :}

 Have you made a note of those dozen bugs on the wiki, so we can get them
 looked at properly?

it's all in our jira (as far as people could be bothered to report it 
properly), and the upstream topic review issue (51) links to those i 
knew of as of monday or so.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] IMPORTANT: topic reviews on gerrit disabled

2011-11-16 Thread Marcus D. Hanwell
On Wed, Nov 16, 2011 at 10:44 AM,  marius.storm-ol...@nokia.com wrote:
 On 11/14/11 5:13 PM, ext Oswald Buddenhagen
 oswald.buddenha...@nokia.com wrote:

moin,

due to about a dozen bugs, a few of them fairly serious, i went ahead
and disabled the topic review functionality. it will come back, but not
necessarily this year. :}

 Have you made a note of those dozen bugs on the wiki, so we can get them
 looked at properly?

That would be extremely useful for us, as we are developing against
the topic branch Gerrit changes, and are working on fixing bugs and
issues before we start using the topic review functionality. Some of
them are linked to in the Gerrit issue tracker already.

Thanks,

Marcus
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] IMPORTANT: topic reviews on gerrit disabled

2011-11-14 Thread Oswald Buddenhagen
moin,

due to about a dozen bugs, a few of them fairly serious, i went ahead 
and disabled the topic review functionality. it will come back, but not 
necessarily this year. :}

how to work without the functionality (i.e., how we worked up to a few 
weeks ago): you just have to talk more (shock!). put the necessary info 
into the first change of the topic: tell the invited reviewers that the 
subsequent changes (under dependencies = needed by) actually belong to 
a topic, and tell them not to submit/stage anything themselves (which is 
good practice anyway, to allow other reviewers to have a say). to see 
the whole topic (and some more), just click the author in the change 
list. staging becomes a bit annoying for the authors again, but then, 
that feature wasn't *that* commonly used anyway, so i'm positive we'll 
survive it.

ps: i'm not sure what about the existing topics. just try to continue to 
use them ...

-- 
Oswald Buddenhagen
Software Developer
Nokia, Qt Development Frameworks
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development