[Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-28 Thread Konstantin Tokarev
Hello,

Currently, MinGW builds in Coin use -system-zlib configuration. It happens
because MinGW is shipped with zlib headers and libz.a. However, linking zlib
to several Qt modules (at least, QtCore, QtGui, QtNetwork, and QtSvg) is
suboptimal, while with -system-zlib one copy in QtCore is shared between all
modules.

Also this would be consistent with MSVC builds.

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-29 Thread Konrad Rosenbaum
Hi,

On Monday 28 November 2016 17:11:19 Konstantin Tokarev wrote:
> Currently, MinGW builds in Coin use -system-zlib configuration. It happens
> because MinGW is shipped with zlib headers and libz.a. However, linking zlib
> to several Qt modules (at least, QtCore, QtGui, QtNetwork, and QtSvg) is
> suboptimal, while with -system-zlib one copy in QtCore is shared between
> all modules.

Please be aware that there are quite a few Applications out there that use 
zlib independently of Qt - e.g. to encode/decode ZIP files. Unfortunately Qt 
does not expose its internal zlib headers, nor does it wrap all functionality 
of zlib. So at the very least qt-zlib needs to be linked in a way that allows 
an additional version of zlib to be linked.



Konrad

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-29 Thread Kai Koehne
> -Original Message-
> From: Development [mailto:development-bounces+kai.koehne=qt.io@qt-
> project.org] On Behalf Of Konrad Rosenbaum
> Sent: Tuesday, November 29, 2016 11:03 AM
> To: development@qt-project.org
> Subject: Re: [Development] Proposal: Use -qt-zlib configuration in official
> MinGW builds
> 
> Hi,
> 
> On Monday 28 November 2016 17:11:19 Konstantin Tokarev wrote:
> > Currently, MinGW builds in Coin use -system-zlib configuration. It
> > happens because MinGW is shipped with zlib headers and libz.a.
> > However, linking zlib to several Qt modules (at least, QtCore, QtGui,
> > QtNetwork, and QtSvg) is suboptimal, while with -system-zlib one copy
> > in QtCore is shared between all modules.
> 
> Please be aware that there are quite a few Applications out there that use
> zlib independently of Qt - e.g. to encode/decode ZIP files. Unfortunately Qt
> does not expose its internal zlib headers, nor does it wrap all functionality 
> of
> zlib. So at the very least qt-zlib needs to be linked in a way that allows an
> additional version of zlib to be linked.

This shouldn't be a problem, because the symbol ones from the internal version
are prefixed with "z_". See change 1f461ac45bf in qtbase.

Regards

Kai
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-29 Thread Konstantin Tokarev


29.11.2016, 13:02, "Konrad Rosenbaum" :
> Hi,
>
> On Monday 28 November 2016 17:11:19 Konstantin Tokarev wrote:
>>  Currently, MinGW builds in Coin use -system-zlib configuration. It happens
>>  because MinGW is shipped with zlib headers and libz.a. However, linking zlib
>>  to several Qt modules (at least, QtCore, QtGui, QtNetwork, and QtSvg) is
>>  suboptimal, while with -system-zlib one copy in QtCore is shared between
>>  all modules.
>
> Please be aware that there are quite a few Applications out there that use
> zlib independently of Qt - e.g. to encode/decode ZIP files. Unfortunately Qt
> does not expose its internal zlib headers, nor does it wrap all functionality
> of zlib.

qt-zlib builds provide zlib headers in include/QtZlib

> So at the very least qt-zlib needs to be linked in a way that allows
> an additional version of zlib to be linked.

zlib in QtCore is built with prefixed symbols.

>
> Konrad
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-29 Thread Kai Koehne


> -Original Message-
> From: Development [mailto:development-bounces+kai.koehne=qt.io@qt-
> project.org] On Behalf Of Konstantin Tokarev
> Sent: Monday, November 28, 2016 3:11 PM
> To: development@qt-project.org
> Subject: [Development] Proposal: Use -qt-zlib configuration in official
> MinGW builds
> 
> Hello,
> 
> Currently, MinGW builds in Coin use -system-zlib configuration. It happens
> because MinGW is shipped with zlib headers and libz.a. However, linking zlib
> to several Qt modules (at least, QtCore, QtGui, QtNetwork, and QtSvg) is
> suboptimal, while with -system-zlib one copy in QtCore is shared between all
> modules.

I think this is a good idea.

Could you create a suggestion for this on bugreports.qt.io, component 
"Packaging & Installer" (https://bugreports.qt.io/browse/QTBUG/component/19211) 
?

Thanks

Kai
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Proposal: Use -qt-zlib configuration in official MinGW builds

2016-11-29 Thread Konstantin Tokarev


29.11.2016, 13:19, "Kai Koehne" :
>>  -Original Message-
>>  From: Development [mailto:development-bounces+kai.koehne=qt.io@qt-
>>  project.org] On Behalf Of Konstantin Tokarev
>>  Sent: Monday, November 28, 2016 3:11 PM
>>  To: development@qt-project.org
>>  Subject: [Development] Proposal: Use -qt-zlib configuration in official
>>  MinGW builds
>>
>>  Hello,
>>
>>  Currently, MinGW builds in Coin use -system-zlib configuration. It happens
>>  because MinGW is shipped with zlib headers and libz.a. However, linking zlib
>>  to several Qt modules (at least, QtCore, QtGui, QtNetwork, and QtSvg) is
>>  suboptimal, while with -system-zlib one copy in QtCore is shared between all
>>  modules.
>
> I think this is a good idea.
>
> Could you create a suggestion for this on bugreports.qt.io, component 
> "Packaging & Installer" 
> (https://bugreports.qt.io/browse/QTBUG/component/19211) ?

Done: https://bugreports.qt.io/browse/QTBUG-57376

>
> Thanks
>
> Kai

-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development