Re: [Development] Qt 5.8 API review (vs 5.7.0)
On 2016 September 9 I announced: > It's that time in the release cycle again - API review time. > If you can catch a moment when Gerrit isn't hiding, please > take a look at any modules you care for: > https://codereview.qt-project.org/170634 -- qtbase > https://codereview.qt-project.org/170635 -- qtdeclarative > https://codereview.qt-project.org/170636 -- qtactiveqt > https://codereview.qt-project.org/170637 -- qtmultimedia > https://codereview.qt-project.org/170638 -- qttools > https://codereview.qt-project.org/170639 -- qtlocation > https://codereview.qt-project.org/170640 -- qtconnectivity > https://codereview.qt-project.org/170641 -- qtwayland > https://codereview.qt-project.org/170642 -- qt3d > https://codereview.qt-project.org/170643 -- qtserialbus > https://codereview.qt-project.org/170644 -- qtserialport > https://codereview.qt-project.org/170645 -- qtandroidextras > https://codereview.qt-project.org/170646 -- qtwebsockets > https://codereview.qt-project.org/170647 -- qtwebengine > https://codereview.qt-project.org/170648 -- qtcanvas3d > https://codereview.qt-project.org/170649 -- qtcharts > https://codereview.qt-project.org/170650 -- qtdatavis3d > https://codereview.qt-project.org/170651 -- qtvirtualkeyboard > https://codereview.qt-project.org/170652 -- qtscxml I've today done an update to pick up fixes to issues found there, plus on-going changes to 5.8; and the review scripts are a bit smarter now, so have refined some details. In particular, they now find (possibly recent) changes also in: https://codereview.qt-project.org/171662 -- qtquickcontrols2 ... and I seem to need to kick a few where the update landed in a new review; somehow I failed at amending :-( In any case, if you grumbled about one of these reviews, you should have mail about its update (if it got one - or you'll get one shortly when I fix the failed amends). Eddy. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.8 API review (vs 5.7.0)
On 2016-09-09, Edward Welbourne wrote: > https://codereview.qt-project.org/170634 -- qtbase Added some comments. Though didn't detailed read all template magic. One enum have reordered some members. This is likely an issue. > https://codereview.qt-project.org/170635 -- qtdeclarative Kind of looks ok to me from a BC standpoint. > https://codereview.qt-project.org/170637 -- qtmultimedia OK. Single added enum and single added function. > https://codereview.qt-project.org/170638 -- qttools How much of this is actually changes in installed headers, and how much is just internal stuff ? > https://codereview.qt-project.org/170647 -- qtwebengine How much of this is external api, and how much is internal ? Comment on one set of the api provided. /Sune ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.8 API review (vs 5.7.0)
I mentioned: >> https://codereview.qt-project.org/170651 -- qtvirtualkeyboard Mitch Curtis replied: > qtvirtualkeyboard looks OK. Please give review responses on the reviews themselves (if you can catch Gerrit up for long enough to do so). Eddy. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.8 API review (vs 5.7.0)
> -Original Message- > From: Development [mailto:development-bounces+mitch.curtis=qt.io@qt- > project.org] On Behalf Of Edward Welbourne > Sent: Friday, 9 September 2016 1:56 PM > To: development@qt-project.org > Subject: [Development] Qt 5.8 API review (vs 5.7.0) > > Hi all, > > It's that time in the release cycle again - API review time. > If you can catch a moment when Gerrit isn't hiding, please take a look at > any modules you care for: > > https://codereview.qt-project.org/170634 -- qtbase > https://codereview.qt-project.org/170635 -- qtdeclarative > https://codereview.qt-project.org/170636 -- qtactiveqt > https://codereview.qt-project.org/170637 -- qtmultimedia > https://codereview.qt-project.org/170638 -- qttools > https://codereview.qt-project.org/170639 -- qtlocation > https://codereview.qt-project.org/170640 -- qtconnectivity > https://codereview.qt-project.org/170641 -- qtwayland > https://codereview.qt-project.org/170642 -- qt3d > https://codereview.qt-project.org/170643 -- qtserialbus > https://codereview.qt-project.org/170644 -- qtserialport > https://codereview.qt-project.org/170645 -- qtandroidextras > https://codereview.qt-project.org/170646 -- qtwebsockets > https://codereview.qt-project.org/170647 -- qtwebengine > https://codereview.qt-project.org/170648 -- qtcanvas3d > https://codereview.qt-project.org/170649 -- qtcharts > https://codereview.qt-project.org/170650 -- qtdatavis3d > https://codereview.qt-project.org/170651 -- qtvirtualkeyboard qtvirtualkeyboard looks OK. > https://codereview.qt-project.org/170652 -- qtscxml > > Eddy. > ___ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
Re: [Development] Qt 5.8 API review (vs 5.7.0)
On Friday 09 September 2016 13:56:26 Edward Welbourne wrote: > https://codereview.qt-project.org/170641 -- qtwayland > https://codereview.qt-project.org/170643 -- qtserialbus > https://codereview.qt-project.org/170652 -- qtscxml These three are exiting TP state on 5.8, so the whole API needs to be reviewed, not just changes to 5.7. Thanks, Marc -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company Tel: +49-30-521325470 KDAB - Qt, C++ and OpenGL Experts ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
[Development] Qt 5.8 API review (vs 5.7.0)
Hi all, It's that time in the release cycle again - API review time. If you can catch a moment when Gerrit isn't hiding, please take a look at any modules you care for: https://codereview.qt-project.org/170634 -- qtbase https://codereview.qt-project.org/170635 -- qtdeclarative https://codereview.qt-project.org/170636 -- qtactiveqt https://codereview.qt-project.org/170637 -- qtmultimedia https://codereview.qt-project.org/170638 -- qttools https://codereview.qt-project.org/170639 -- qtlocation https://codereview.qt-project.org/170640 -- qtconnectivity https://codereview.qt-project.org/170641 -- qtwayland https://codereview.qt-project.org/170642 -- qt3d https://codereview.qt-project.org/170643 -- qtserialbus https://codereview.qt-project.org/170644 -- qtserialport https://codereview.qt-project.org/170645 -- qtandroidextras https://codereview.qt-project.org/170646 -- qtwebsockets https://codereview.qt-project.org/170647 -- qtwebengine https://codereview.qt-project.org/170648 -- qtcanvas3d https://codereview.qt-project.org/170649 -- qtcharts https://codereview.qt-project.org/170650 -- qtdatavis3d https://codereview.qt-project.org/170651 -- qtvirtualkeyboard https://codereview.qt-project.org/170652 -- qtscxml Eddy. ___ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
