Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-26 Thread Lars Knoll

On 25/10/16 20:43, "Development on behalf of Thiago Macieira" 
 wrote:

>On terça-feira, 25 de outubro de 2016 18:12:27 PDT Massimo Callegari via 
>Development wrote:
>> > It was never supported, therefore it can't be a bug, much less a
>> > regression. Indeed we removed some functionality, but one that was
>> > technically abusing
>> > qmake because it wasn't supported.
>> 
>> That is not true. See the official Qt documentation, end of page,
>> "Configuration Features" paragraph:
>> http://doc.qt.io/qt-5/qmake-project-files.html
>> 
>> Honestly I don't care much if it was there by mistake or unsupported or
>> whatever. It was a usable feature. Period.
>
>By abusing qmake. Your bug report showed you used this line:
>
>macx:QT_CONFIG -= no-pkg-config
>
>That above is the abuse. Show us code that worked without that line and has 
>stopped working. That will qualify as a regression.
>
>You can continue to abuse Qt's configuration in 5.8. It just changed what 
>variables you have to abuse. No compatiblity is guaranteed because it's an 
>abuse.
>
>> As I stated before, pkg-config is fundamental to access libraries outside of
>> Qt's scope, either on Linux, MSYS2 on Windows or Homebrew/Macports on Mac
>> OS, so we need to keep on having that feature from Qt.
>
>I'm not disputing that. That's why I reopened the issue and made it a feature 
>request so that we officially support it, without abuses required.
>
>> If you want developers to stop having such access, then I would much like
>> call it a regression and IMHO it should be fixed before releasing Qt 5.8.0.
>
>It wasn't a feature before, therefore it's not a bug and not a regression.
>
>Alternatively, we can call it a bug that has been present for a long time. It 
>still wouldn't be a regression.

Agree with Thiago. Having said that, as we have been doing quite many changes 
to the configuration system, let’s see if we can get this fixed somewhat 
properly for 5.8 final. But it’s not a blocker for the beta.

Cheers,
Lars

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira
On terça-feira, 25 de outubro de 2016 18:12:27 PDT Massimo Callegari via 
Development wrote:
> > It was never supported, therefore it can't be a bug, much less a
> > regression. Indeed we removed some functionality, but one that was
> > technically abusing
> > qmake because it wasn't supported.
> 
> That is not true. See the official Qt documentation, end of page,
> "Configuration Features" paragraph:
> http://doc.qt.io/qt-5/qmake-project-files.html
> 
> Honestly I don't care much if it was there by mistake or unsupported or
> whatever. It was a usable feature. Period.

By abusing qmake. Your bug report showed you used this line:

macx:QT_CONFIG -= no-pkg-config

That above is the abuse. Show us code that worked without that line and has 
stopped working. That will qualify as a regression.

You can continue to abuse Qt's configuration in 5.8. It just changed what 
variables you have to abuse. No compatiblity is guaranteed because it's an 
abuse.

> As I stated before, pkg-config is fundamental to access libraries outside of
> Qt's scope, either on Linux, MSYS2 on Windows or Homebrew/Macports on Mac
> OS, so we need to keep on having that feature from Qt.

I'm not disputing that. That's why I reopened the issue and made it a feature 
request so that we officially support it, without abuses required.

> If you want developers to stop having such access, then I would much like
> call it a regression and IMHO it should be fixed before releasing Qt 5.8.0.

It wasn't a feature before, therefore it's not a bug and not a regression.

Alternatively, we can call it a bug that has been present for a long time. It 
still wouldn't be a regression.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira
Em terça-feira, 25 de outubro de 2016, às 17:54:02 PDT, Kevin Kofler escreveu:
> Thiago Macieira wrote:
> > Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari
> > 
> > via Development escreveu:
> >> Hi, please add the following to the blockers list:
> >> https://bugreports.qt.io/browse/QTBUG-56164
> > 
> > That's not a bug, so it can't be a blocker.
> 
> It's a regression, ergo it is a bug.

It was never supported, therefore it can't be a bug, much less a regression. 
Indeed we removed some functionality, but one that was technically abusing 
qmake because it wasn't supported.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira
Em terça-feira, 25 de outubro de 2016, às 17:14:47 PDT, Benjamin TERRIER 
escreveu:
> This patch fixes tools\configure\environment.cpp
> 
> However in 5.8 the fixed line does not exist anymore in this file, but
> the same regexp appeared in configure.pri (which is a new file
> compared to 5.6).
> So the same fix should be applied to configure.pri, but at 2 places
> (see bug report).
> 
> I guess it is because of the new configure system.

It's possible.

I would much rather extract from the compiler's macros, but that patch wasn't 
added.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Kevin Kofler
Thiago Macieira wrote:

> Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari
> via Development escreveu:
>> Hi, please add the following to the blockers list:
>> https://bugreports.qt.io/browse/QTBUG-56164
> 
> That's not a bug, so it can't be a blocker.

It's a regression, ergo it is a bug.

Kevin Kofler

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Benjamin TERRIER
2016-10-25 16:53 GMT+02:00 Thiago Macieira :
>
> Em terça-feira, 25 de outubro de 2016, às 16:42:43 PDT, Benjamin TERRIER
> escreveu:
> > I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
> > French systems:
> >
> >  https://bugreports.qt.io/browse/QTBUG-56731
> >
> > There is a workaround though: fix qconfig.pri after running configure.
> >
> > On a side note this bug might cause side effects on English systems as
> > QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.
> >
> > Best regards,
>
> Should be fixed by https://codereview.qt-project.org/172928, which landed in
> 5.6 as 6851cf52afe188e94344ce22074af97e054f5896 but hasn't made its way to 5.8
> yet.


This patch fixes tools\configure\environment.cpp

However in 5.8 the fixed line does not exist anymore in this file, but
the same regexp appeared in configure.pri (which is a new file
compared to 5.6).
So the same fix should be applied to configure.pri, but at 2 places
(see bug report).

I guess it is because of the new configure system.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira
Em terça-feira, 25 de outubro de 2016, às 16:42:43 PDT, Benjamin TERRIER 
escreveu:
> I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
> French systems:
> 
>  https://bugreports.qt.io/browse/QTBUG-56731
> 
> There is a workaround though: fix qconfig.pri after running configure.
> 
> On a side note this bug might cause side effects on English systems as
> QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.
> 
> Best regards,

Should be fixed by https://codereview.qt-project.org/172928, which landed in 
5.6 as 6851cf52afe188e94344ce22074af97e054f5896 but hasn't made its way to 5.8 
yet.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Benjamin TERRIER
Hi,

I just found a bug in 5.8 which make "impossible" to build Qt with MSVC on
French systems:

 https://bugreports.qt.io/browse/QTBUG-56731

There is a workaround though: fix qconfig.pri after running configure.

On a side note this bug might cause side effects on English systems as
QT_CL_MAJOR_VERSION and QT_CL_PATCH_VERSION may not be properly set.

Best regards,

Benjamin Terrier

2016-10-24 15:09 GMT+02:00 Jani Heikkinen :

> Hi all,
>
> We have finally (almost) full set of Qt 5.8.0 beta installers for testing
>
>
>
> windows: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/627/
>
> mac: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/521/
>
> linux: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/553/
>
> src: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/
> (submodules are just copied so mirroring is still ongoing)
>
>
>
> Packages are RTA tested & seems to be pretty much OK so please test the
> packages and make sure all blockers are visible in blocker list (
> https://bugreports.qt.io/issues/?filter=17924 )
> . All known blockers
> should be fixed in these packages so these will be released as Qt 5.8.0
> beta if no new blockers found during testing.
>
>
>
> Packages are based on https://codereview.qt-project.org/#/c/174531/
>
>
>
> br,
>
> Jani
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Thiago Macieira
Em terça-feira, 25 de outubro de 2016, às 07:38:34 PDT, Massimo Callegari via 
Development escreveu:
> Hi, please add the following to the blockers list:
> https://bugreports.qt.io/browse/QTBUG-56164

That's not a bug, so it can't be a blocker.

-- 
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Qt 5.8.0 Beta packages available for testing

2016-10-25 Thread Massimo Callegari via Development
Hi, please add the following to the blockers list:
https://bugreports.qt.io/browse/QTBUG-56164

Without it, I am either stuck on Qt 5.7 or forced to say goodbye to Qt.
Thanks,Massimo
  Da: Jani Heikkinen <jani.heikki...@qt.io>
 A: "development@qt-project.org" <development@qt-project.org> 
 Inviato: Lunedì 24 Ottobre 2016 15:09
 Oggetto: [Development] Qt 5.8.0 Beta packages available for testing
   
 Hi all, We have finally (almost) full set of 
Qt 5.8.0 beta installers for testing    
windows:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/627/ 
mac:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/521/ 
linux:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/553/ 
src:http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/ (submodules 
are just copied so mirroring is still ongoing)    Packages are RTA tested & 
seems to be pretty much OK so please test the packages and make sure all 
blockers are visible in blocker list 
(https://bugreports.qt.io/issues/?filter=17924 ). All known blockers should be 
fixed in these packages so these will be released as Qt 5.8.0 beta if no new 
blockers found during testing.    Packages are based 
onhttps://codereview.qt-project.org/#/c/174531/    br, Jani 
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


   ___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Qt 5.8.0 Beta packages available for testing

2016-10-24 Thread Jani Heikkinen
Hi all,
We have finally (almost) full set of Qt 5.8.0 beta installers for testing

windows: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/627/
mac: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/521/
linux: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/553/
src: http://download.qt.io/snapshots/qt/5.8/5.8.0-beta/latest_src/ (submodules 
are just copied so mirroring is still ongoing)


Packages are RTA tested & seems to be pretty much OK so please test the 
packages and make sure all blockers are visible in blocker list 
(https://bugreports.qt.io/issues/?filter=17924 
). All known blockers should be 
fixed in these packages so these will be released as Qt 5.8.0 beta if no new 
blockers found during testing.


Packages are based on https://codereview.qt-project.org/#/c/174531/

br,
Jani
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development