Re: [Development] Updating Serializing Qt Data Types documentation

2012-10-24 Thread Jedrzej Nowacki
On Tuesday 23. October 2012 19.34.46 Harri Porten wrote:
 On Tue, 23 Oct 2012, Mitch Curtis wrote:
  After https://codereview.qt-project.org/#change,37988, the Serializing
  Qt Data Types page lists the QDataStream version as 13. I thought it'd
  be a good idea to ask everyone who is interested to take a look and see
  if the descriptions of the data types serialised are still accurate. If
  they're not, please update the page (the path to which can be found in
  the aforementioned patch).
 
 Coincidentally we noticed a over-the-wire serialization problem today.
 With QVariant. But it's likely not an issue with above mentioned format
 version 13. Rather with a backward compat mode. Do I see it correctly that
 tests/ only cover 4.9 and 5.0 versions? Hmmm. I now realize that I can
 answer this question myself given that the coverage results we just
 posted...
 
  
 http://download.froglogic.com/public/qt5-squishcoco-report/QtBase/source_1
 43.html (see QVariant::load() and save())
 
 We'll investigate what's going on and submit a patch if it's a problem in
 QVariant or QDataStream.
 
 Harri.
 ___
 Development mailing list
 Development@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/development

Hi,

  I added that tests durring Qt5 development, sadly streaming was never tested 
with older versions. What is the bug, can I help somehow? Is it only Qt5 or 
Qt4 too?

Cheers,
  Jędrek
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Updating Serializing Qt Data Types documentation

2012-10-24 Thread Harri Porten
On Wed, 24 Oct 2012, Jedrzej Nowacki wrote:

  I added that tests durring Qt5 development, sadly streaming was never tested
 with older versions. What is the bug, can I help somehow? Is it only Qt5 or
 Qt4 too?

We found the reason now:

   https://bugreports.qt-project.org/browse/QTBUG-27700

Streaming of invalid QVariants with Qt 5 for older versions does not work 
anymore. The test attached to above report isn't really elegant, yet. 
We'll improve upon that and try to submit a patch. Stay tuned.

Harri.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


[Development] Updating Serializing Qt Data Types documentation

2012-10-23 Thread Mitch Curtis
After https://codereview.qt-project.org/#change,37988, the Serializing Qt 
Data Types page lists the QDataStream version as 13. I thought it'd be a good 
idea to ask everyone who is interested to take a look and see if the 
descriptions of the data types serialised are still accurate. If they're not, 
please update the page (the path to which can be found in the aforementioned 
patch).

Cheers.___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Updating Serializing Qt Data Types documentation

2012-10-23 Thread Harri Porten
On Tue, 23 Oct 2012, Mitch Curtis wrote:

 After https://codereview.qt-project.org/#change,37988, the Serializing 
 Qt Data Types page lists the QDataStream version as 13. I thought it'd 
 be a good idea to ask everyone who is interested to take a look and see 
 if the descriptions of the data types serialised are still accurate. If 
 they're not, please update the page (the path to which can be found in 
 the aforementioned patch).

Coincidentally we noticed a over-the-wire serialization problem today. 
With QVariant. But it's likely not an issue with above mentioned format 
version 13. Rather with a backward compat mode. Do I see it correctly that 
tests/ only cover 4.9 and 5.0 versions? Hmmm. I now realize that I can 
answer this question myself given that the coverage results we just 
posted...

  
http://download.froglogic.com/public/qt5-squishcoco-report/QtBase/source_143.html
 (see QVariant::load() and save())

We'll investigate what's going on and submit a patch if it's a problem in
QVariant or QDataStream.

Harri.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] Updating Serializing Qt Data Types documentation

2012-10-23 Thread Sean Harmer
On Tuesday 23 October 2012 16:17:30 Mitch Curtis wrote:
 After https://codereview.qt-project.org/#change,37988, the Serializing Qt
 Data Types page lists the QDataStream version as 13. I thought it'd be a
 good idea to ask everyone who is interested to take a look and see if the
 descriptions of the data types serialised are still accurate. If they're
 not, please update the page (the path to which can be found in the
 aforementioned patch).

Just pushed 

https://codereview.qt-project.org/#change,38021

to update types of math3d classes.

Cheers,

Sean
--
Dr Sean Harmer | sean.har...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel. Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - Qt Experts - Platform-independent software solutions
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development