Re: [Development] 5.14 API change reviews
Hi! API review seems to be still ongoing. Please make sure all reviews are ready at the end of next week (4th October EOB). br, Jani From: Development on behalf of Jani Heikkinen Sent: Monday, September 16, 2019 1:32 PM To: Edward Welbourne; development@qt-project.org Subject: Re: [Development] 5.14 API change reviews Hi all, It seems this is still badly ongoing. Even Alpha isn't out yet we should be able to finalize these as soon as possible. So please do reviews now & get reviews approved as soon as possible. br, Jani From: Development on behalf of Edward Welbourne Sent: Monday, August 26, 2019 7:14 PM To: development@qt-project.org Subject: [Development] 5.14 API change reviews Hi all, As some have clearly noticed unprompted, I've now posted the first drafts of the 5.14 API change reviews [0], in accordance with QUIP 10 [1]. Please file bugs in Jira for any changes you object to and link those bugs to QTBUG-77839 [2], blocking it. Please tag any changes you make to fix issues noticed in review, either with Fixes: for such a bug report or with a Task-number: QTBUG-77839 footer. As ever, remember that these reviews filter out lots of trivial changes, so check the actual 5.14 (and, where relevant, 5.13.1) sources if in doubt about what's really there. The boring changes filtered out of qtbase totalled more than twice the residue presented for review. [0] https://codereview.qt-project.org/q/topic:%2522api-change%2522+status:open [1] https://quips-qt-io.herokuapp.com/quip-0010-API-review.html [2] https://bugreports.qt.io/browse/QTBUG-77839 Feature freeze has happened, so please make no changes to 5.14's public APIs other than fixes in response to these reviews. If you know a module has had material changes requiring an update to the review, please either read the commit message (it says how to update it) or drop me a line, Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] 5.14 API change reviews
Jani Heikkinen (16 September 2019 12:32) > It seems this is still badly ongoing. Even Alpha isn't out yet we > should be able to finalize these as soon as possible. So please do > reviews now & get reviews approved as soon as possible. It seems I managed to start the initial review before the final downmerge completed, so there are some changes to APIs that landed with that. I've now updated all the reviews to current 5.14, picking up any API change review fixes that have been done in the mean time. Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] 5.14 API change reviews
Hi all, It seems this is still badly ongoing. Even Alpha isn't out yet we should be able to finalize these as soon as possible. So please do reviews now & get reviews approved as soon as possible. br, Jani From: Development on behalf of Edward Welbourne Sent: Monday, August 26, 2019 7:14 PM To: development@qt-project.org Subject: [Development] 5.14 API change reviews Hi all, As some have clearly noticed unprompted, I've now posted the first drafts of the 5.14 API change reviews [0], in accordance with QUIP 10 [1]. Please file bugs in Jira for any changes you object to and link those bugs to QTBUG-77839 [2], blocking it. Please tag any changes you make to fix issues noticed in review, either with Fixes: for such a bug report or with a Task-number: QTBUG-77839 footer. As ever, remember that these reviews filter out lots of trivial changes, so check the actual 5.14 (and, where relevant, 5.13.1) sources if in doubt about what's really there. The boring changes filtered out of qtbase totalled more than twice the residue presented for review. [0] https://codereview.qt-project.org/q/topic:%2522api-change%2522+status:open [1] https://quips-qt-io.herokuapp.com/quip-0010-API-review.html [2] https://bugreports.qt.io/browse/QTBUG-77839 Feature freeze has happened, so please make no changes to 5.14's public APIs other than fixes in response to these reviews. If you know a module has had material changes requiring an update to the review, please either read the commit message (it says how to update it) or drop me a line, Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] 5.14 API change reviews
El dilluns, 26 d’agost de 2019, a les 18:14:01 CEST, Edward Welbourne va escriure: >> As some have clearly noticed unprompted, I've now posted the first >> drafts of the 5.14 API change reviews [0], in accordance with QUIP 10 >> [1]. Please file bugs in Jira for any changes you object to and link >> those bugs to QTBUG-77839 [2], blocking it. Please tag any changes >> you make to fix issues noticed in review, either with Fixes: for such >> a bug report or with a Task-number: QTBUG-77839 footer. Albert Astals Cid (26 August 2019 19:10) > How hard would be for those diffs to include the documentation (in the > .cpp side). Hard. The scripts would have to identify * all the .cpp and .qdoc files that correspond to .h files being compared; * within each .cpp file, only the diffs that are in qdoc comments, excluding qdoc comments that include a \internal marker. The former isn't especially hard; the latter is - it would significantly complicate the "reset boring" script. Even then, the result would contain *all* changes to public API documentation, including typo fixes, rephrasings, ... and, admittedly, behaviour changes, which it would be interesting to include, as would doc for new things. It would probably be hard to include only the public API docs within new .cpp files. See qtsdk/packaging-tools/ (not really an ideal place for these scripts, but it's where they are) - all-api-modules, api-review-gen, resetboring.py and sync-filter-api-headers - for the scripts that I presently use to do the job. If you can see a way to adapt them to do what you want, I'd be willing to look at a code review ... Eddy. ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] 5.14 API change reviews
El dilluns, 26 d’agost de 2019, a les 18:14:01 CEST, Edward Welbourne va escriure: > Hi all, > > As some have clearly noticed unprompted, I've now posted the first > drafts of the 5.14 API change reviews [0], in accordance with QUIP 10 > [1]. Please file bugs in Jira for any changes you object to and link > those bugs to QTBUG-77839 [2], blocking it. Please tag any changes you > make to fix issues noticed in review, either with Fixes: for such a bug > report or with a Task-number: QTBUG-77839 footer. How hard would be for those diffs to include the documentation (in the .cpp side). This way it would be easier to catch that for example that the QWebSocketServer::setHandshakeTimeout function that according to https://codereview.qt-project.org/c/qt/qtwebsockets/+/271724 is new in 5.14 does not include the \since marker Cheers, Albert > > As ever, remember that these reviews filter out lots of trivial changes, > so check the actual 5.14 (and, where relevant, 5.13.1) sources if in > doubt about what's really there. The boring changes filtered out of > qtbase totalled more than twice the residue presented for review. > > [0] > https://codereview.qt-project.org/q/topic:%2522api-change%2522+status:open > [1] https://quips-qt-io.herokuapp.com/quip-0010-API-review.html > [2] https://bugreports.qt.io/browse/QTBUG-77839 > > Feature freeze has happened, so please make no changes to 5.14's public > APIs other than fixes in response to these reviews. > > If you know a module has had material changes requiring an update to the > review, please either read the commit message (it says how to update it) > or drop me a line, > > Eddy. > ___ > Development mailing list > Development@qt-project.org > https://lists.qt-project.org/listinfo/development -- Albert Astals Cid | albert.astals@kdab.com | Senior Software Engineer Klarälvdalens Datakonsult AB, a KDAB Group company Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - The Qt, C++ and OpenGL Experts ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
