Re: [Development] All deprecation warnings are P1 for 5.13.0
Am 09.02.2019 um 18:02 schrieb Thiago Macieira: On Saturday, 9 February 2019 07:30:36 PST Christian Ehrlicher wrote: QT_DISABLE_DEPRECATED_BEFORE=0x051300: Uh, that's 0x050d00 :-) Ah, this explains why I also got warnings/erros about functions which got deprecated in 5.14 :) Christian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
On Friday, 8 February 2019 22:34:21 PST Giuseppe D'Angelo via Development wrote: > Agree with the rest of the email. From a purely technical point of > view, however, I'm wondering why we didn't see those warnings before? Qt > was already built with warnings enabled AFAICS? For instance: Warnings switches were enabled in the compiler command-line and even -Werror and headersclean. However, QT_DEPRECATED did not produce a warning and deprecation warnings are not fatal. Now they do produce a warning, since your commit. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
On Saturday, 9 February 2019 01:00:46 PST Allan Sandfeld Jensen wrote: > By fixed I guess you also mean suppressed were appropriate? some are from > tests testing deprecated functions, and other are deprecated functions > calling other deprecated functions because they belong together. Yes, disable where strictly necessary. But keep this as a last-resort scenario. If we deprecated an API our own code used, then we must have a suitable replacement. If we don't, there's a good indication the deprecation is either unwarranted or needs new API. This does not apply to tests. We should simply disable deprecation warnings from tests. All the warnings I have reported are from src/ and tools/ builds. I have not got to examples, but they should also be clean of warnings too. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
On Saturday, 9 February 2019 07:30:36 PST Christian Ehrlicher wrote: > QT_DISABLE_DEPRECATED_BEFORE=0x051300: Uh, that's 0x050d00 :-) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel System Software Products ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
Il 09/02/19 08:11, Christian Ehrlicher ha scritto: It was only enabled for src, not for examples and tests so I did not saw the warnings before your commit I would guess. So even functions which were already marked deprecated for a long time did not trigger warnings. Fixing all the examples and tests before 5.13beta is ... challenging. And doing this for anything other than qtbase is not possible for me during my limited time. Well, tests should NOT be built with deprecation warnings. We need to test ALL functions, including the deprecated ones. Warnings in examples indeed should be P1. Thanks, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com KDAB - The Qt, C++ and OpenGL Experts smime.p7s Description: Firma crittografica S/MIME ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
Am 09.02.2019 um 02:27 schrieb Thiago Macieira: By beta, those that aren't fixed will get P1 bug reports in JIRA. for qtbase/src - feel free to review them :) https://codereview.qt-project.org/252626 https://codereview.qt-project.org/252627 https://codereview.qt-project.org/252628 https://codereview.qt-project.org/252629 https://codereview.qt-project.org/252630 https://codereview.qt-project.org/252631 https://codereview.qt-project.org/252632 https://codereview.qt-project.org/252633 There are a few places left which don't compile with QT_DISABLE_DEPRECATED_BEFORE=0x051300: - QDialog::setVisible() due to showExtension() - QPainter::initFrom() - I'm not sure if the function should really be deprecated... - QComboBox::setLineEdit() due to setAutoCompletion() - QAlphaWidget - the parent is a QDesktopWidget - I'm not sure if this really works with Qt5 at all - remember I had problems with this approach. Christian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
Am 09.02.2019 um 10:00 schrieb Allan Sandfeld Jensen: By beta, those that aren't fixed will get P1 bug reports in JIRA. By fixed I guess you also mean suppressed were appropriate? some are from tests testing deprecated functions, and other are deprecated functions calling other deprecated functions because they belong together. I learned about QT_WARNING_DISABLE_DEPRECATED to work around this e.g. here: https://codereview.qt-project.org/#/c/252330/3/tests/auto/widgets/itemviews/qlistwidget/tst_qlistwidget.cpp Not sure if this is feasible for all situations though. Christian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
On Samstag, 9. Februar 2019 02:27:20 CET Thiago Macieira wrote: > Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the > QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That > means we started seeing lots of warnings that weren't there in 5.12. > > ALL such warnings must be fixed by 5.13.0 release. Please treat them as P1 > (or P½ because flooding my output while building makes finding legitimate > warnings and errors more difficult). > > I've begun reporting in Gerrit on the commits that added the deprecation, if > that commit was recent enough. But there's new code using > years after those functions were deprecated... > > By beta, those that aren't fixed will get P1 bug reports in JIRA. By fixed I guess you also mean suppressed were appropriate? some are from tests testing deprecated functions, and other are deprecated functions calling other deprecated functions because they belong together. 'Allan ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
Am 09.02.2019 um 07:34 schrieb Giuseppe D'Angelo via Development: Hi, Il 09/02/19 02:27, Thiago Macieira ha scritto: Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of warnings that weren't there in 5.12. Agree with the rest of the email. From a purely technical point of view, however, I'm wondering why we didn't see those warnings before? Qt was already built with warnings enabled AFAICS? For instance: It was only enabled for src, not for examples and tests so I did not saw the warnings before your commit I would guess. So even functions which were already marked deprecated for a long time did not trigger warnings. Fixing all the examples and tests before 5.13beta is ... challenging. And doing this for anything other than qtbase is not possible for me during my limited time. Christian ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
Re: [Development] All deprecation warnings are P1 for 5.13.0
Hi, Il 09/02/19 02:27, Thiago Macieira ha scritto: Commit 7847e6bc02552fa7fc7f518e5cb3336f667b5a6d in qtbase madee the QT_DEPRECATED and QT_DEPRECATED_X warnings on by default in Qt builds. That means we started seeing lots of warnings that weren't there in 5.12. Agree with the rest of the email. From a purely technical point of view, however, I'm wondering why we didn't see those warnings before? Qt was already built with warnings enabled AFAICS? For instance: https://code.qt.io/cgit/qt/qtbase.git/tree/mkspecs/features/qt_module.prf?h=5.13#n310 My 2 c, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com KDAB - The Qt, C++ and OpenGL Experts smime.p7s Description: Firma crittografica S/MIME ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
