Re: [Development] Clazy results for Qt codebase

[Eike Ziller]

> On Oct 18, 2017, at 17:51, Sergio Martins  wrote:
> 
> On 2017-10-11 08:17, Eike Ziller wrote:
>>> On 10. Oct 2017, at 15:41, Sergio Martins  wrote:
>>> Oops, here's the non-internal URL: 
>>> https://docs.kdab.com/analysis/qt5/clazy.html
>>> Thanks Mitch
>> I’d be interested in seeing results for Qt Creator too :)
> 
> Hi Eike,
> 
> Here you go: https://docs.kdab.com/analysis/qtcreator/clazy.html

Thanks!

> 
> The clazy-temporary-iterator warnings look like real crashes, taking an 
> cbegin() from a temporary container then comparing it to cend() from another 
> temporary.
> 
> 
> 
> 
> Regards,
> -- 
> Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
> Klarälvdalens Datakonsult AB, a KDAB Group company
> Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
> KDAB - The Qt, C++ and OpenGL Experts

-- 
Eike Ziller
Principal Software Engineer

The Qt Company GmbH
Rudower Chaussee 13
D-12489 Berlin
eike.zil...@qt.io
http://qt.io
Geschäftsführer: Mika Pälsi,
Juha Varelius, Mika Harjuaho
Sitz der Gesellschaft: Berlin, Registergericht: Amtsgericht Charlottenburg, HRB 
144331 B

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Clazy results for Qt codebase

[Sergio Martins]

On 2017-10-11 08:17, Eike Ziller wrote:
On 10. Oct 2017, at 15:41, Sergio Martins  
wrote:
Oops, here's the non-internal URL: 
https://docs.kdab.com/analysis/qt5/clazy.html


Thanks Mitch


I’d be interested in seeing results for Qt Creator too :)


Hi Eike,

Here you go: https://docs.kdab.com/analysis/qtcreator/clazy.html

The clazy-temporary-iterator warnings look like real crashes, taking an 
cbegin() from a temporary container then comparing it to cend() from 
another temporary.





Regards,
--
Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - The Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Clazy results for Qt codebase

[Friedemann Kleint]

Hi,

interesting - would it it be possible to provide it as a Creator task 
file (simple tab-separated file to be loaded into Creator's issue pane,  
see http://doc.qt.io/qtcreator/creator-task-lists.html  )? That would it 
make it easy to click through and fix.


Thanks,
Friedemann

--
Friedemann Kleint
The Qt Company GmbH

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Clazy results for Qt codebase

[Eike Ziller]

> On 10. Oct 2017, at 15:41, Sergio Martins  wrote:
> 
> 
> 
> Oops, here's the non-internal URL: 
> https://docs.kdab.com/analysis/qt5/clazy.html
> 
> Thanks Mitch

I’d be interested in seeing results for Qt Creator too :)

Br, Eike

> 
> On 2017-10-10 14:27, Sergio Martins wrote:
>> Hi,
>> KDAB is now running clazy over the Qt code base, you can check the
>> results here: https://ci.kdab.com/~build/analysis/qt5/clazy.html
>> Next step is to figure out which sub-set we want to use in within
>> qt-project, if we want to enforce any via CI, which ones we want to
>> fix for Qt5 and which ones for Qt6.
>> I'll try to propose something soon, and probably focus on the checks
>> that reveal real bugs, leaving the performance stuff for later.
>> For now I've just enabled almost all of them:
>> copyable-polymorphic
>> qstring-allocations
>> old-style-connect
>> returning-void-expression
>> virtual-calls-from-ctor
>> rule-of-three
>> connect-non-signal
>> qstring-arg
>> connect-not-normalized
>> qstring-insensitive-allocation
>> container-anti-pattern
>> qstring-ref
>> lambda-in-connect
>> qt-macros
>> mutable-container-key
>> qvariant-template-instantiation
>> qcolor-from-literal
>> strict-iterators
>> qdatetime-utc
>> temporary-iterator
>> qenums
>> unused-non-trivial-variable
>> qfileinfo-exists
>> writing-to-temporary
>> qgetenv
>> wrong-qglobalstatic
>> qmap-with-pointer-key
>> auto-unexpected-qstringbuilder
>> overridden-signal
>> child-event-qobject-cast
>> post-event
>> connect-3arg-lambda
>> qdeleteall
>> qhash-namespace
>> ctor-missing-parent-argument
>> qlatin1string-non-ascii
>> detaching-temporary
>> qproperty-without-notify
>> foreach
>> qstring-left
>> incorrect-emit
>> range-loop
>> inefficient-qlist-soft
>> returning-data-from-temporary
>> install-event-filter
>> rule-of-two-soft
>> non-pod-global-static
>> virtual-signal
>> Regards,
> 
> Regards,
> -- 
> Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
> Klarälvdalens Datakonsult AB, a KDAB Group company
> Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
> KDAB - The Qt, C++ and OpenGL Experts
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Clazy results for Qt codebase

[Sergio Martins]

Oops, here's the non-internal URL: 
https://docs.kdab.com/analysis/qt5/clazy.html


Thanks Mitch



On 2017-10-10 14:27, Sergio Martins wrote:

Hi,

KDAB is now running clazy over the Qt code base, you can check the
results here: https://ci.kdab.com/~build/analysis/qt5/clazy.html

Next step is to figure out which sub-set we want to use in within
qt-project, if we want to enforce any via CI, which ones we want to
fix for Qt5 and which ones for Qt6.

I'll try to propose something soon, and probably focus on the checks
that reveal real bugs, leaving the performance stuff for later.

For now I've just enabled almost all of them:

copyable-polymorphic
qstring-allocations
old-style-connect
returning-void-expression
virtual-calls-from-ctor
rule-of-three
connect-non-signal
qstring-arg
connect-not-normalized
qstring-insensitive-allocation
container-anti-pattern
qstring-ref
lambda-in-connect
qt-macros
mutable-container-key
qvariant-template-instantiation
qcolor-from-literal
strict-iterators
qdatetime-utc
temporary-iterator
qenums
unused-non-trivial-variable
qfileinfo-exists
writing-to-temporary
qgetenv
wrong-qglobalstatic
qmap-with-pointer-key
auto-unexpected-qstringbuilder
overridden-signal
child-event-qobject-cast
post-event
connect-3arg-lambda
qdeleteall
qhash-namespace
ctor-missing-parent-argument
qlatin1string-non-ascii
detaching-temporary
qproperty-without-notify
foreach
qstring-left
incorrect-emit
range-loop
inefficient-qlist-soft
returning-data-from-temporary
install-event-filter
rule-of-two-soft
non-pod-global-static
virtual-signal


Regards,


Regards,
--
Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
Klarälvdalens Datakonsult AB, a KDAB Group company
Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322)
KDAB - The Qt, C++ and OpenGL Experts
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] Clazy results for Qt codebase

[Mitch Curtis]

It seems this page is behind a login.

> -Original Message-
> From: Development [mailto:development-bounces+mitch.curtis=qt.io@qt-
> project.org] On Behalf Of Sergio Martins
> Sent: Tuesday, 10 October 2017 3:27 PM
> To: development@qt-project.org
> Subject: [Development] Clazy results for Qt codebase
> 
> Hi,
> 
> KDAB is now running clazy over the Qt code base, you can check the results
> here: https://ci.kdab.com/~build/analysis/qt5/clazy.html
> 
> Next step is to figure out which sub-set we want to use in within qt-project,
> if we want to enforce any via CI, which ones we want to fix for Qt5 and which
> ones for Qt6.
> 
> I'll try to propose something soon, and probably focus on the checks that
> reveal real bugs, leaving the performance stuff for later.
> 
> For now I've just enabled almost all of them:
> 
> copyable-polymorphic
> qstring-allocations
> old-style-connect
> returning-void-expression
> virtual-calls-from-ctor
> rule-of-three
> connect-non-signal
> qstring-arg
> connect-not-normalized
> qstring-insensitive-allocation
> container-anti-pattern
> qstring-ref
> lambda-in-connect
> qt-macros
> mutable-container-key
> qvariant-template-instantiation
> qcolor-from-literal
> strict-iterators
> qdatetime-utc
> temporary-iterator
> qenums
> unused-non-trivial-variable
> qfileinfo-exists
> writing-to-temporary
> qgetenv
> wrong-qglobalstatic
> qmap-with-pointer-key
> auto-unexpected-qstringbuilder
> overridden-signal
> child-event-qobject-cast
> post-event
> connect-3arg-lambda
> qdeleteall
> qhash-namespace
> ctor-missing-parent-argument
> qlatin1string-non-ascii
> detaching-temporary
> qproperty-without-notify
> foreach
> qstring-left
> incorrect-emit
> range-loop
> inefficient-qlist-soft
> returning-data-from-temporary
> install-event-filter
> rule-of-two-soft
> non-pod-global-static
> virtual-signal
> 
> 
> Regards,
> --
> Sérgio Martins | sergio.mart...@kdab.com | Senior Software Engineer
> Klarälvdalens Datakonsult AB, a KDAB Group company
> Tel: Sweden (HQ) +46-563-540090, USA +1-866-777-KDAB(5322) KDAB - The
> Qt, C++ and OpenGL Experts
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development