Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Haataja Ismo
Hi,

Deployment was successful, thanks for your patience.

If you find any problems, please let me know as soon as possible!

Best Regards,
Ismo

From: development-bounces+ismo.haataja=digia@qt-project.org 
[mailto:development-bounces+ismo.haataja=digia@qt-project.org] On Behalf Of 
Haataja Ismo
Sent: 12. kesäkuuta 2014 16:12
To: development@qt-project.org
Subject: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable 
Friday June 13, 7:00 – 10:00 CEST

Just to remind this will happen tomorrow morning.

Hi,

Gerrit (https://codereview.qt-project.org/) will be unavailable while we deploy 
a new version.

The upgrade takes the current v2.2.1 based version to v2.7 based. Most of our 
customized features stay: staging system for CI, one page review and deferred 
changes. The topic review feature, very little used and not functioning 
properly, is dropped. The user experience should stay pretty much the same. 
There are some UI improvements, though, and of course a lot of bug fixes.

Full history of how Gerrit itself has evolved between these versions can be 
read from Gerrit release notes 
(https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html). 
Some usability related picks here.
* search operators are suggested as the user types the query in the search panel
* commit message can be edited from the change screen
* patch sets having unpublished draft comments are highlighted with an icon
There is plenty of new stuff, one needs to read the documentation for deeper 
knowledge.

I’ll send out a follow-up once the service is online again.

Regards,

Ismo

--
Ismo Haataja
Senior Software Specialist - Digia, Qt

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Blasche Alexander
Hi Ismo,

So far everything seems to be already.

Thank you very much for your work.


--

Alex


From: development-bounces+alexander.blasche=digia@qt-project.org 
[development-bounces+alexander.blasche=digia@qt-project.org] on behalf of 
Haataja Ismo [ismo.haat...@digia.com]
Sent: Friday, June 13, 2014 09:44
To: development@qt-project.org
Subject: Re: [Development] NOTE: Gerrit / Codereview upgrade – Service 
unavailable Friday June 13, 7:00 – 10:00 CEST

Hi,

Deployment was successful, thanks for your patience.

If you find any problems, please let me know as soon as possible!

Best Regards,
Ismo

From: development-bounces+ismo.haataja=digia@qt-project.org 
[mailto:development-bounces+ismo.haataja=digia@qt-project.org] On Behalf Of 
Haataja Ismo
Sent: 12. kesäkuuta 2014 16:12
To: development@qt-project.org
Subject: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable 
Friday June 13, 7:00 – 10:00 CEST

Just to remind this will happen tomorrow morning.

Hi,

Gerrit (https://codereview.qt-project.org/) will be unavailable while we deploy 
a new version.

The upgrade takes the current v2.2.1 based version to v2.7 based. Most of our 
customized features stay: staging system for CI, one page review and deferred 
changes. The topic review feature, very little used and not functioning 
properly, is dropped. The user experience should stay pretty much the same. 
There are some UI improvements, though, and of course a lot of bug fixes.

Full history of how Gerrit itself has evolved between these versions can be 
read from Gerrit release notes 
(https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html). 
Some usability related picks here.
* search operators are suggested as the user types the query in the search panel
* commit message can be edited from the change screen
* patch sets having unpublished draft comments are highlighted with an icon
There is plenty of new stuff, one needs to read the documentation for deeper 
knowledge.

I’ll send out a follow-up once the service is online again.

Regards,

Ismo

--
Ismo Haataja
Senior Software Specialist - Digia, Qt

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Oswald Buddenhagen
On Fri, Jun 13, 2014 at 07:44:25AM +, Haataja Ismo wrote:
> Hi,
> 
> Deployment was successful, thanks for your patience.
> 
> If you find any problems, please let me know as soon as possible!
> 
so we don't lose track, please use jira, qtqainfra/gerrit component.
as usual, check for duplicates first - 
https://bugreports.qt-project.org/issues/?jql=component%20%3D%20Gerrit%20AND%20project%20%3D%20QTQAINFRA%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

some notes on some new (mis-)features:

*don't* edit the commit message in the ui unless you are sure that this
is the last necessary change, as the next push will revert the edit
unless it's pulled down first (which most people won't do). i hope to
make that safer in the future, see QTQAINFRA-847.

*don't* use the rebase button. you'll just create noise, and there is
the same revert problem as with the commit edits. see QTQAINFRA-848.

if you can't log in because you don't see the button/link, see
QTQAINFRA-849.

some things seem to have become (even) slower. whoops.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Robert Löhning
Am 13.06.2014 09:44, schrieb Haataja Ismo:
> Hi,
>
> Deployment was successful, thanks for your patience.
>
> If you find any problems, please let me know as soon as possible!


Hi Ismo,

seems like I don't get notification mails anymore when the Sanity Bot 
complains about my patches.

Best Regards,
Robert

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Haataja Ismo
Hi,

> -Original Message-
> From: Loehning Robert
> 
> seems like I don't get notification mails anymore when the Sanity Bot
> complains about my patches.
> 
> Best Regards,
> Robert

Thanks. This is fixed now, just a configuration issue, luckily. If still not 
working, please do tell!

Ismo

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-13 Thread Oleg Shparber
Gerrit has become terribly slow, I cannot view pull requests or files. It
fails with 502 gateway error sometimes.

Thanks,
Oleg


On Fri, Jun 13, 2014 at 12:44 AM, Haataja Ismo 
wrote:

>  Hi,
>
>
>
> Deployment was successful, thanks for your patience.
>
>
>
> If you find any problems, please let me know as soon as possible!
>
>
>
> Best Regards,
>
> Ismo
>
>
>
> *From:* development-bounces+ismo.haataja=digia@qt-project.org [mailto:
> development-bounces+ismo.haataja=digia@qt-project.org] *On Behalf Of 
> *Haataja
> Ismo
> *Sent:* 12. kesäkuuta 2014 16:12
> *To:* development@qt-project.org
> *Subject:* [Development] NOTE: Gerrit / Codereview upgrade – Service
> unavailable Friday June 13, 7:00 – 10:00 CEST
>
>
>
> Just to remind this will happen tomorrow morning.
>
>
>
> Hi,
>
>
>
> Gerrit (https://codereview.qt-project.org/) will be unavailable while we
> deploy a new version.
>
>
>
> The upgrade takes the current v2.2.1 based version to v2.7 based. Most of
> our customized features stay: staging system for CI, one page review and
> deferred changes. The topic review feature, very little used and not
> functioning properly, is dropped. The user experience should stay pretty
> much the same. There are some UI improvements, though, and of course a lot
> of bug fixes.
>
>
>
> Full history of how Gerrit itself has evolved between these versions can
> be read from Gerrit release notes (
> https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html).
> Some usability related picks here.
>
> * search operators are suggested as the user types the query in the search
> panel
>
> * commit message can be edited from the change screen
>
> * patch sets having unpublished draft comments are highlighted with an icon
>
> There is plenty of new stuff, one needs to read the documentation for
> deeper knowledge.
>
>
>
> I’ll send out a follow-up once the service is online again.
>
>
>
> Regards,
>
>
>
> Ismo
>
>
>
> --
>
> Ismo Haataja
>
> Senior Software Specialist - Digia, Qt
>
>
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-14 Thread Haataja Ismo
Yes, we are having some performance issues but are working with that. Right now 
everything works smoothly again. We’ll keep following the situation.

BR,
Ismo

From: Oleg Shparber [mailto:troll...@gmail.com]
Sent: 14. kesäkuuta 2014 3:05
To: Haataja Ismo
Cc: development@qt-project.org
Subject: Re: [Development] NOTE: Gerrit / Codereview upgrade – Service 
unavailable Friday June 13, 7:00 – 10:00 CEST

Gerrit has become terribly slow, I cannot view pull requests or files. It fails 
with 502 gateway error sometimes.
Thanks,
Oleg

On Fri, Jun 13, 2014 at 12:44 AM, Haataja Ismo 
mailto:ismo.haat...@digia.com>> wrote:
Hi,

Deployment was successful, thanks for your patience.

If you find any problems, please let me know as soon as possible!

Best Regards,
Ismo

From: 
development-bounces+ismo.haataja=digia@qt-project.org<mailto:digia@qt-project.org>
 
[mailto:development-bounces+ismo.haataja<mailto:development-bounces%2Bismo.haataja>=digia@qt-project.org<mailto:digia@qt-project.org>]
 On Behalf Of Haataja Ismo
Sent: 12. kesäkuuta 2014 16:12
To: development@qt-project.org<mailto:development@qt-project.org>
Subject: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable 
Friday June 13, 7:00 – 10:00 CEST

Just to remind this will happen tomorrow morning.

Hi,

Gerrit (https://codereview.qt-project.org/) will be unavailable while we deploy 
a new version.

The upgrade takes the current v2.2.1 based version to v2.7 based. Most of our 
customized features stay: staging system for CI, one page review and deferred 
changes. The topic review feature, very little used and not functioning 
properly, is dropped. The user experience should stay pretty much the same. 
There are some UI improvements, though, and of course a lot of bug fixes.

Full history of how Gerrit itself has evolved between these versions can be 
read from Gerrit release notes 
(https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html). 
Some usability related picks here.
* search operators are suggested as the user types the query in the search panel
* commit message can be edited from the change screen
* patch sets having unpublished draft comments are highlighted with an icon
There is plenty of new stuff, one needs to read the documentation for deeper 
knowledge.

I’ll send out a follow-up once the service is online again.

Regards,

Ismo

--
Ismo Haataja
Senior Software Specialist - Digia, Qt


___
Development mailing list
Development@qt-project.org<mailto:Development@qt-project.org>
http://lists.qt-project.org/mailman/listinfo/development

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-14 Thread Sandro Andrade
On Sat, Jun 14, 2014 at 8:55 AM, Haataja Ismo  wrote:
> Yes, we are having some performance issues but are working with that. Right
> now everything works smoothly again. We’ll keep following the situation.

Hi there,

I had a change integrated and merged nearly 12 hours ago
(https://codereview.qt-project.org/#/c/87431/)
but it hasn't been replicated in gitorious
(https://qt.gitorious.org/qt/qtmodeling/activities) up to now.

Is it expected that such replication occurs automatically as before or
am I missing something ?

Thanks in advance,
Sandro

>
>
>
> BR,
>
> Ismo
>
>
>
> From: Oleg Shparber [mailto:troll...@gmail.com]
> Sent: 14. kesäkuuta 2014 3:05
> To: Haataja Ismo
> Cc: development@qt-project.org
> Subject: Re: [Development] NOTE: Gerrit / Codereview upgrade – Service
> unavailable Friday June 13, 7:00 – 10:00 CEST
>
>
>
> Gerrit has become terribly slow, I cannot view pull requests or files. It
> fails with 502 gateway error sometimes.
>
> Thanks,
> Oleg
>
>
>
> On Fri, Jun 13, 2014 at 12:44 AM, Haataja Ismo 
> wrote:
>
> Hi,
>
>
>
> Deployment was successful, thanks for your patience.
>
>
>
> If you find any problems, please let me know as soon as possible!
>
>
>
> Best Regards,
>
> Ismo
>
>
>
> From: development-bounces+ismo.haataja=digia@qt-project.org
> [mailto:development-bounces+ismo.haataja=digia@qt-project.org] On Behalf
> Of Haataja Ismo
> Sent: 12. kesäkuuta 2014 16:12
> To: development@qt-project.org
> Subject: [Development] NOTE: Gerrit / Codereview upgrade – Service
> unavailable Friday June 13, 7:00 – 10:00 CEST
>
>
>
> Just to remind this will happen tomorrow morning.
>
>
>
> Hi,
>
>
>
> Gerrit (https://codereview.qt-project.org/) will be unavailable while we
> deploy a new version.
>
>
>
> The upgrade takes the current v2.2.1 based version to v2.7 based. Most of
> our customized features stay: staging system for CI, one page review and
> deferred changes. The topic review feature, very little used and not
> functioning properly, is dropped. The user experience should stay pretty
> much the same. There are some UI improvements, though, and of course a lot
> of bug fixes.
>
>
>
> Full history of how Gerrit itself has evolved between these versions can be
> read from Gerrit release notes
> (https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html).
> Some usability related picks here.
>
> * search operators are suggested as the user types the query in the search
> panel
>
> * commit message can be edited from the change screen
>
> * patch sets having unpublished draft comments are highlighted with an icon
>
> There is plenty of new stuff, one needs to read the documentation for deeper
> knowledge.
>
>
>
> I’ll send out a follow-up once the service is online again.
>
>
>
> Regards,
>
>
>
> Ismo
>
>
>
> --
>
> Ismo Haataja
>
> Senior Software Specialist - Digia, Qt
>
>
>
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
>
>
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-15 Thread Daniel Nagy
Hello,

I have a patch for the qt declarative module but i cannot get past the
gerrit CLA agreement. It does not show me an agree button.
Can you please help me? Maybe it has something to do with the update.

Best,
Daniel Nagy

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Haataja Ismo
Hi,

> I had a change integrated and merged nearly 12 hours ago
> (https://codereview.qt-project.org/#/c/87431/)
> but it hasn't been replicated in gitorious
> (https://qt.gitorious.org/qt/qtmodeling/activities) up to now.
> 
> Is it expected that such replication occurs automatically as before or
> am I missing something ?
> 
> Thanks in advance,
> Sandro

Yes, replication should happen automatically. For some reason it looks like 
this one was not replicated in first place. But you have managed to trigger the 
replication with another change. And what I looked now with some other changes, 
replication seems to be working. We'll follow the situation.

BR,
Ismo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Sandro Andrade
On Mon, Jun 16, 2014 at 5:00 AM, Haataja Ismo  wrote:
> Hi,
>
>> I had a change integrated and merged nearly 12 hours ago
>> (https://codereview.qt-project.org/#/c/87431/)
>> but it hasn't been replicated in gitorious
>> (https://qt.gitorious.org/qt/qtmodeling/activities) up to now.
>>
>> Is it expected that such replication occurs automatically as before or
>> am I missing something ?
>>
>> Thanks in advance,
>> Sandro
>
> Yes, replication should happen automatically. For some reason it looks like 
> this one was not replicated in first place. But you have managed to trigger 
> the replication with another change. And what I looked now with some other 
> changes, replication seems to be working. We'll follow the situation.

Ok, it seems things are fine now. Thanks for replying,

Sandro

>
> BR,
> Ismo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Konstantin Tokarev


09.06.2014, 18:17, "Haataja Ismo" :
> Hi,
>
> Gerrit (https://codereview.qt-project.org/) will be unavailable while we 
> deploy a new version.
>
> The upgrade takes the current v2.2.1 based version to v2.7 based. Most of our 
> customized features stay: staging system for CI, one page review and deferred 
> changes. The topic review feature, very little used and not functioning 
> properly, is dropped. The user experience should stay pretty much the same. 
> There are some UI improvements, though, and of course a lot of bug fixes.
>
> Full history of how Gerrit itself has evolved between these versions can be 
> read from Gerrit release notes 
> (https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html).
>  Some usability related picks here.
>
> * search operators are suggested as the user types the query in the search 
> panel
>
> * commit message can be edited from the change screen
>
> * patch sets having unpublished draft comments are highlighted with an icon
>
> There is plenty of new stuff, one needs to read the documentation for deeper 
> knowledge.
>
> I’ll send out a follow-up once the service is online again.
>

Have you set up cron running gerrit-gc on all repos? It is required for new 
"super-fast fetch" feature.


-- 
Regards,
Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Oswald Buddenhagen
On Mon, Jun 16, 2014 at 05:03:18PM +0400, Konstantin Tokarev wrote:
> 
> Have you set up cron running gerrit-gc on all repos? It is required for new 
> "super-fast fetch" feature.
> 
have a specific reference for that?
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Konstantin Tokarev


16.06.2014, 17:40, "Oswald Buddenhagen" :
> On Mon, Jun 16, 2014 at 05:03:18PM +0400, Konstantin Tokarev wrote:
>>  Have you set up cron running gerrit-gc on all repos? It is required for new 
>> "super-fast fetch" feature.
>
> have a specific reference for that?

https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.6.html#_release_highlights

-- 
Regards, Konstantin
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-16 Thread Oswald Buddenhagen
On Mon, Jun 16, 2014 at 05:54:07PM +0400, Konstantin Tokarev wrote:
> 16.06.2014, 17:40, "Oswald Buddenhagen" :
> > On Mon, Jun 16, 2014 at 05:03:18PM +0400, Konstantin Tokarev wrote:
> >>  Have you set up cron running gerrit-gc on all repos? It is required for 
> >> new "super-fast fetch" feature.
> >
> > have a specific reference for that?
> 
> https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.6.html#_release_highlights
> 
i gave this a shot, but it seems gerrit gc is making a botch of the
repositories, so this will need to be postponed to the next release.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-18 Thread Mitch Curtis
On 06/09/2014 04:17 PM, Haataja Ismo wrote:
> Hi,
>
> Gerrit (https://codereview.qt-project.org/) will be unavailable while we
> deploy a new version.
>
> The upgrade takes the current v2.2.1 based version to v2.7 based. Most
> of our customized features stay: staging system for CI, one page review
> and deferred changes. The topic review feature, very little used and not
> functioning properly, is dropped. The user experience should stay pretty
> much the same. There are some UI improvements, though, and of course a
> lot of bug fixes.
>
> Full history of how Gerrit itself has evolved between these versions can
> be read from Gerrit release notes
> (https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/index.html).
> Some usability related picks here.
>
> * search operators are suggested as the user types the query in the
> search panel
>
> * commit message can be edited from the change screen
>
> * patch sets having unpublished draft comments are highlighted with an icon
>
> There is plenty of new stuff, one needs to read the documentation for
> deeper knowledge.
>
> I’ll send out a follow-up once the service is online again.
>
> Regards,
>
> Ismo
>
> --
>
> Ismo Haataja
>
> Senior Software Specialist - Digia, Qt
>
>
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
>

Do you know if searching by SHA-1 will ever work? Searching by change ID 
is good, but you don't always have one available.

Cheers.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-18 Thread Haataja Ismo
Hi,

> From: Curtis Mitch

> 
> Do you know if searching by SHA-1 will ever work? Searching by change ID
> is good, but you don't always have one available.
> 

If gerrit just has a patch set 'linked' with that SHA1, it works. And has been 
working, I think.

But our previous gerrit version didn't had the SHA1 of merged patch set. Or not 
elsewhere but in the change message saying: "Change has been successfully 
cherry-picked to the staging branch as 
2bbccf8ca1a4ba7e39413982986bc02d55e936be." Search doesn't find it from there. 
You may have already seen that the new gerrit version we deployed, doesn't show 
SHA1 when staging, just "Change has been successfully cherry-picked to the 
staging branch ." But, when a change gets merged, a new patch set is created. 
With the SHA1 that should match the actual commit. Now search should work using 
this SHA1.

So, for new changes, starting from Jun-13, search should work just fine.

A little test to convince myself :)

[ismo@masiina qtbase.git]$ git log 5.3.1 --oneline -n5
cf7805d Merge "Merge remote-tracking branch 'origin/stable' into 5.3" into 
refs/staging/5.3
bdd6046 Fix animations in static builds
753be5a Merge remote-tracking branch 'origin/stable' into 5.3
c92ece4 QRasterPlatformPixmap::createPixmapForImage(): Avoid crash when QImage 
conversion failes
4038f21 xcb: touch device mode is either Dependent or Direct, not Rel or Abs

Copy pasted four SHA1 values to search field and all but first one worked ok. 
And the first one is not done by gerrit, I think, so that's ok too.

BR,
Ismo
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] NOTE: Gerrit / Codereview upgrade – Service unavailable Friday June 13, 7:00 – 10:00 CEST

2014-06-18 Thread Mitch Curtis
On 06/18/2014 01:35 PM, Haataja Ismo wrote:
> Hi,
>
>> From: Curtis Mitch
>
>>
>> Do you know if searching by SHA-1 will ever work? Searching by change ID
>> is good, but you don't always have one available.
>>
>
> If gerrit just has a patch set 'linked' with that SHA1, it works. And has 
> been working, I think.
>
> But our previous gerrit version didn't had the SHA1 of merged patch set. Or 
> not elsewhere but in the change message saying: "Change has been successfully 
> cherry-picked to the staging branch as 
> 2bbccf8ca1a4ba7e39413982986bc02d55e936be." Search doesn't find it from there. 
> You may have already seen that the new gerrit version we deployed, doesn't 
> show SHA1 when staging, just "Change has been successfully cherry-picked to 
> the staging branch ." But, when a change gets merged, a new patch set is 
> created. With the SHA1 that should match the actual commit. Now search should 
> work using this SHA1.
>
> So, for new changes, starting from Jun-13, search should work just fine.
>
> A little test to convince myself :)
>
> [ismo@masiina qtbase.git]$ git log 5.3.1 --oneline -n5
> cf7805d Merge "Merge remote-tracking branch 'origin/stable' into 5.3" into 
> refs/staging/5.3
> bdd6046 Fix animations in static builds
> 753be5a Merge remote-tracking branch 'origin/stable' into 5.3
> c92ece4 QRasterPlatformPixmap::createPixmapForImage(): Avoid crash when 
> QImage conversion failes
> 4038f21 xcb: touch device mode is either Dependent or Direct, not Rel or Abs
>
> Copy pasted four SHA1 values to search field and all but first one worked ok. 
> And the first one is not done by gerrit, I think, so that's ok too.
>
> BR,
> Ismo
>

Thanks, that does work.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development