Re: [Development] Qt 5.12.4 changes files

2019-05-28 Thread Jani Heikkinen
> -Original Message-
> From: Frederik Gladhorn 
> Sent: tiistai 28. toukokuuta 2019 15.44
> To: development@qt-project.org
> Cc: Jani Heikkinen 
> Subject: Re: [Development] Qt 5.12.4 changes files
> 
> On mandag 27. mai 2019 10:42:44 CEST Jani Heikkinen wrote:
> > Hi,
> > Initial ones here:
> > https://codereview.qt-
> project.org/q/message:%2522Add+changes+file+for+Qt+5.
> > 12.4%2522+status:open
> >
> > Maintainers, please do needed modifications & make sure reviews are
> > done during this week
> 
> Did the git log in the commit message get lost again?
> I thought that was super helpful to confirm that there was no event (e.g.
> when the only commit was a version bump, I feel much better about
> approving the change stating that there was no change).

Yes, unfortunately that was forgotten at this time, sorry about that. It was 
turned off for creating changes files for 5.13.0. For it (and all .0 releases) 
the feature isn't that qood; there is too much changes to list those on commit 
messages. We fixed the script now and from now on all patch level releases 
should have git logs included in commit message and for .0 releases not

br,
Jani

> 
> Cheers,
> Frederik
> 
> >
> > br,
> > Jani
> > ___
> > Development mailing list
> > Development@qt-project.org
> > https://lists.qt-project.org/listinfo/development
> 
> 
> 

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development


Re: [Development] Qt 5.12.4 changes files

2019-05-28 Thread Frederik Gladhorn
On mandag 27. mai 2019 10:42:44 CEST Jani Heikkinen wrote:
> Hi,
> Initial ones here:
> https://codereview.qt-project.org/q/message:%2522Add+changes+file+for+Qt+5.
> 12.4%2522+status:open
> 
> Maintainers, please do needed modifications & make sure reviews are done
> during this week

Did the git log in the commit message get lost again?
I thought that was super helpful to confirm that there was no event (e.g. when 
the only commit was a version bump, I feel much better about approving the 
change stating that there was no change).

Cheers,
Frederik

> 
> br,
> Jani
> ___
> Development mailing list
> Development@qt-project.org
> https://lists.qt-project.org/listinfo/development




___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development