Re: [Development] pushes to gerrit failing

2012-06-06 Thread Samuel Rødal
On 06/06/2012 01:59 AM, ext Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

Not just for Girish, happens here as well.

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to 'ssh://codereview.qt-project.org/qt/qtbase'

http://asheepapart.blogspot.no/2011/10/gerrit-code-review-unpack-error-missing.html

Seems like a pretty severe issue.

--
Samuel
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread 1+1=2
$ git push gerrit HEAD:refs/for/master
Counting objects: 15, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 854 bytes, done.
Total 8 (delta 7), reused 0 (delta 0)
fatal: Unpack error, check server logremote: Resolving deltas:   0% (0/7)

error: unpack failed: error Missing unknown
e8b7a949c3099611437abf65ebd94e822f3aba9e
To dbzhang...@codereview.qt-project.org:qt/qtbase
 ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
error: failed to push some refs to
'dbzhang...@codereview.qt-project.org:qt/qtbase'

On Tue, Jun 5, 2012 at 11:29 PM, Samuel Rødal samuel.ro...@nokia.com wrote:
 On 06/06/2012 01:59 AM, ext Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

 Not just for Girish, happens here as well.

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to 
 'ssh://codereview.qt-project.org/qt/qtbase'

 http://asheepapart.blogspot.no/2011/10/gerrit-code-review-unpack-error-missing.html

 Seems like a pretty severe issue.

 --
 Samuel
 ___
 Development mailing list
 Development@qt-project.org
 http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Thiago Macieira
On terça-feira, 5 de junho de 2012 16.59.41, Girish Ramakrishnan wrote:
 Hi CI team/Gerrit team,
 Pushes to gerrit are failing (qtbase).

 girish@beast:~/Qt/qt5/qtbase$ git push gerrit HEAD:refs/for/master
 Counting objects: 12, done.
 Delta compression using up to 6 threads.
 Compressing objects: 100% (6/6), done.
 Writing objects: 100% (7/7), 1.08 KiB, done.
 Total 7 (delta 5), reused 0 (delta 0)
 fatal: Unpack error, check server log
 remote: Resolving deltas:   0% (0/5)
 error: unpack failed: error Missing unknown
 e8b7a949c3099611437abf65ebd94e822f3aba9e
 To ssh://codereview.qt-project.org/qt/qtbase
  ! [remote rejected] HEAD - refs/for/master (n/a (unpacker error))
 error: failed to push some refs to
 'ssh://codereview.qt-project.org/qt/qtbase'

Yeah, I broke it yesterday somehow creating a topic branch. I got a database
error when pushing and let Matias know immediately, but I guess he had already
left for the day.

That SHA-1 above is the commit for this patch:
https://codereview.qt-project.org/28033

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Oswald Buddenhagen
On Wed, Jun 06, 2012 at 09:03:46AM +0200, ext Thiago Macieira wrote:
 Yeah, I broke it yesterday somehow creating a topic branch. I got a database 
 error when pushing and let Matias know immediately, but I guess he had 
 already 
 left for the day.
 
we run periodic prunes, which matches the situation in the blog post.
it would seem that jgit lacks some locking, so a push coinciding with
the prune in just the wrong moment can mess up things royally.
we are working on avoiding the need to prune.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development


Re: [Development] pushes to gerrit failing

2012-06-06 Thread Thiago Macieira
On quarta-feira, 6 de junho de 2012 11.54.16, Oswald Buddenhagen wrote:
 On Wed, Jun 06, 2012 at 09:03:46AM +0200, ext Thiago Macieira wrote:
  Yeah, I broke it yesterday somehow creating a topic branch. I got a
  database error when pushing and let Matias know immediately, but I guess
  he had already left for the day.

 we run periodic prunes, which matches the situation in the blog post.
 it would seem that jgit lacks some locking, so a push coinciding with
 the prune in just the wrong moment can mess up things royally.
 we are working on avoiding the need to prune.

I don't think that's the root cause.

The root cause is the database error that I got when I did a gpush with
reviewers to a topic branch. Matias tells me that this somehow violates some
database constraints and the operation is dropped.

The review 28033 was created only partially (you can see that the sanity bot
wasn't added to it). The commit that was missing is the commit from that
review. So we had the problem the moment the database failed upon creating
28033 and left the repository in a bad state. The review exists, but not the
reference in Git:

$ git ls-remote gerrit refs/changes/* | grep /2803.
cfd19434b4fdd1846295c379531bda6ceb030a39refs/changes/32/28032/1

When the prune was run, it removed the objects that the database expected to
be there. Now we have a disconnect between what the database says should be
there and the Git repository actually has.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
 Intel Sweden AB - Registration Number: 556189-6027
 Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden


signature.asc
Description: This is a digitally signed message part.
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development