[PATCH v2 3/3] dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings
The mfd/s2mpa01.txt duplicates some of the information about bindings
with old mfd/s2mps11.txt. Now common part exists entirely in
mfd/samsung,sec-core.txt so:
- add company prefix to file name (regulator/samsung,s2mpa01.txt),
- remove duplicated information,
- reorganize the contents to match style of
regulator/samsung,s2mps11.txt.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Rob Herring
Acked-by: Lee Jones
---
Changes since v1:
1. Added accumulated acks.
2. Use -M20% so renames will be more visible (formatting is changed so
default -M50% does not consider it as renames).
---
.../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +-
.../s2mpa01.txt => regulator/samsung,s2mpa01.txt} | 69 +-
2 files changed, 32 insertions(+), 41 deletions(-)
rename Documentation/devicetree/bindings/{mfd/s2mpa01.txt =>
regulator/samsung,s2mpa01.txt} (37%)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
index 4aeb95c82304..cdd079bfc287 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
+++ b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
@@ -4,7 +4,7 @@ Binding for Samsung S2M and S5M family multi-function device
This is a part of device tree bindings for S2M and S5M family multi-function
devices.
-The Samsung S2MPS11/13/14/15, S2MPU02 and S5M8767 is a family
+The Samsung S2MPA01, S2MPS11/13/14/15, S2MPU02 and S5M8767 is a family
of multi-function devices which include voltage and current regulators, RTC,
charger controller, clock outputs and other sub-blocks. It is interfaced
to the host controller using an I2C interface. Each sub-block is usually
@@ -13,6 +13,7 @@ addressed by the host system using different I2C slave
addresses.
This document describes bindings for main device node. Optional sub-blocks
must be a sub-nodes to it. Bindings for them can be found in:
+ - bindings/regulator/samsung,s2mpa01.txt
- bindings/regulator/samsung,s2mps11.txt
- bindings/regulator/samsung,s5m8767.txt
- bindings/clock/samsung,s2mps11.txt
@@ -20,6 +21,7 @@ must be a sub-nodes to it. Bindings for them can be found in:
Required properties:
- compatible: Should be one of the following
+ - "samsung,s2mpa01-pmic",
- "samsung,s2mps11-pmic",
- "samsung,s2mps13-pmic",
- "samsung,s2mps14-pmic",
diff --git a/Documentation/devicetree/bindings/mfd/s2mpa01.txt
b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
similarity index 37%
rename from Documentation/devicetree/bindings/mfd/s2mpa01.txt
rename to Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
index c13d3d8c3947..bae3c7f838cf 100644
--- a/Documentation/devicetree/bindings/mfd/s2mpa01.txt
+++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
@@ -1,54 +1,43 @@
+Binding for Samsung S2MPA01 regulator block
+===
-* Samsung S2MPA01 Voltage and Current Regulator
+This is a part of device tree bindings for S2M family multi-function devices.
+More information can be found in bindings/mfd/sec-core.txt file.
-The Samsung S2MPA01 is a multi-function device which includes high
-efficiency buck converters including Dual-Phase buck converter, various LDOs,
-and an RTC. It is interfaced to the host controller using an I2C interface.
-Each sub-block is addressed by the host system using different I2C slave
-addresses.
+The S2MPA01 device provide buck and LDO regulators.
-Required properties:
-- compatible: Should be "samsung,s2mpa01-pmic".
-- reg: Specifies the I2C slave address of the PMIC block. It should be 0x66.
+To register these with regulator framework instantiate under main device node
+a sub-node named "regulators" with more sub-nodes for each regulator using the
+common regulator binding documented in:
+ - Documentation/devicetree/bindings/regulator/regulator.txt
-Optional properties:
-- interrupt-parent: Specifies the phandle of the interrupt controller to which
- the interrupts from s2mpa01 are delivered to.
-- interrupts: An interrupt specifier for the sole interrupt generated by the
- device.
-
-Optional nodes:
-- regulators: The regulators of s2mpa01 that have to be instantiated should be
- included in a sub-node named 'regulators'. Regulator nodes and constraints
- included in this sub-node use the standard regulator bindings which are
- documented elsewhere.
-
-Properties for BUCK regulator nodes:
-- regulator-ramp-delay: ramp delay in uV/us. May be 6250, 12500
- (default), 25000, or 5. May be 0 for disabling the ramp delay on
- BUCK{1,2,3,4}.
-
- In the absence of the regulator-ramp-delay property, the default ramp
- delay will be used.
-
- NOTE: Some BUCKs share the ramp rate setting i.e. same ramp value will be set
- for a particular group of BUCKs. So provide same
regulator-ra
[PATCH v2 1/3] dt-bindings: regulator/clock/mfd: Reorganize S2MPS-family bindings
Bindings for Samsung S2M and S5M family PMICs are in mess. They are
spread over different files and subdirectories in a non-consistent way.
The devices and respective drivers for them share a lot in common so
everything could be organized in a more readable way.
Reorganize the S2MPS11/13/14/15 Device Tree bindings to match the
drivers for this family of devices:
- move mfd/s2mps11.txt to mfd/samsung,sec-core.txt for the main MFD
driver (common for entire family),
- split clock block to clock/samsung,s2mps11.txt,
- split regulator block to regulator/samsung,s2mps11.txt.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Rob Herring
Acked-by: Lee Jones
Acked-by: Michael Turquette
---
Changes since v1:
1. Added accumulated acks.
2. Use -M20% so renames will be more visible (formatting is changed so
default -M50% does not consider it as renames).
---
.../devicetree/bindings/clock/samsung,s2mps11.txt | 49
.../devicetree/bindings/mfd/samsung,sec-core.txt | 84 +
.../s2mps11.txt => regulator/samsung,s2mps11.txt} | 135 +++--
MAINTAINERS| 4 +-
4 files changed, 178 insertions(+), 94 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
rename Documentation/devicetree/bindings/{mfd/s2mps11.txt =>
regulator/samsung,s2mps11.txt} (25%)
diff --git a/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
b/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
new file mode 100644
index ..2726c1d58a79
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
@@ -0,0 +1,49 @@
+Binding for Samsung S2M and S5M family clock generator block
+
+
+This is a part of device tree bindings for S2M and S5M family multi-function
+devices.
+More information can be found in bindings/mfd/sec-core.txt file.
+
+The S2MPS11/13/15 and S5M8767 provide three(AP/CP/BT) buffered 32.768 kHz
+outputs. The S2MPS14 provides two (AP/BT) buffered 32.768 KHz outputs.
+
+To register these as clocks with common clock framework instantiate under
+main device node a sub-node named "clocks".
+
+It uses the common clock binding documented in:
+ - Documentation/devicetree/bindings/clock/clock-bindings.txt
+
+
+Required properties of the "clocks" sub-node:
+ - #clock-cells: should be 1.
+ - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk",
+ "samsung,s2mps14-clk", "samsung,s5m8767-clk"
+ The S2MPS15 uses the same compatible as S2MPS13, as both provides similar
+ clocks.
+
+
+Each clock is assigned an identifier and client nodes use this identifier
+to specify the clock which they consume.
+Clock ID Devices
+--
+32KhzAP0S2MPS11/13/14/15, S5M8767
+32KhzCP1S2MPS11/13/15, S5M8767
+32KhzBT2S2MPS11/13/14/15, S5M8767
+
+Include dt-bindings/clock/samsung,s2mps11.h file to use preprocessor defines
+in device tree sources.
+
+
+Example:
+
+ s2mps11_pmic@66 {
+ compatible = "samsung,s2mps11-pmic";
+ reg = <0x66>;
+
+ s2m_osc: clocks {
+ compatible = "samsung,s2mps11-clk";
+ #clock-cells = <1>;
+ clock-output-names = "xx", "yy", "zz";
+ };
+ };
diff --git a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
new file mode 100644
index ..ef0166d0f643
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
@@ -0,0 +1,84 @@
+Binding for Samsung S2M and S5M family multi-function device
+
+
+This is a part of device tree bindings for S2M and S5M family multi-function
+devices.
+
+The Samsung S2MPS11/13/14/15, S2MPU02 and S5M8767 is a family
+of multi-function devices which include voltage and current regulators, RTC,
+charger controller, clock outputs and other sub-blocks. It is interfaced
+to the host controller using an I2C interface. Each sub-block is usually
+addressed by the host system using different I2C slave addresses.
+
+
+This document describes bindings for main device node. Optional sub-blocks
+must be a sub-nodes to it. Bindings for them can be found in:
+ - bindings/regulator/samsung,s2mps11.txt
+ - bindings/clock/samsung,s2mps11.txt
+
+
+Required properties:
+ - compatible: Should be one of the following
+ - "samsung,s2mps11-pmic",
+ - "samsung,s2mps13-pmic"
[PATCH v2 2/3] dt-bindings: regulator/mfd: Reorganize S5M8767 bindings
The regulator/s5m8767-regulator.txt duplicates some of the information
about bindings with old mfd/s2mps11.txt. Now common part exists entirely
in mfd/samsung,sec-core.txt so:
- add company prefix to file name (regulator/samsung,s5m8767.txt),
- remove duplicated information,
- reorganize the contents to match style of
regulator/samsung,s2mps11.txt.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Rob Herring
Acked-by: Lee Jones
---
Changes since v1:
1. Added accumulated acks.
2. Use -M20% so renames will be more visible (formatting is changed so
default -M50% does not consider it as renames).
---
.../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +-
.../{s5m8767-regulator.txt => samsung,s5m8767.txt} | 152 +
MAINTAINERS| 2 +-
3 files changed, 71 insertions(+), 87 deletions(-)
rename Documentation/devicetree/bindings/regulator/{s5m8767-regulator.txt =>
samsung,s5m8767.txt} (34%)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
index ef0166d0f643..4aeb95c82304 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
+++ b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
@@ -14,6 +14,7 @@ addressed by the host system using different I2C slave
addresses.
This document describes bindings for main device node. Optional sub-blocks
must be a sub-nodes to it. Bindings for them can be found in:
- bindings/regulator/samsung,s2mps11.txt
+ - bindings/regulator/samsung,s5m8767.txt
- bindings/clock/samsung,s2mps11.txt
@@ -23,7 +24,8 @@ Required properties:
- "samsung,s2mps13-pmic",
- "samsung,s2mps14-pmic",
- "samsung,s2mps15-pmic",
- - "samsung,s2mpu02-pmic".
+ - "samsung,s2mpu02-pmic",
+ - "samsung,s5m8767-pmic".
- reg: Specifies the I2C slave address of the pmic block. It should be 0x66.
Optional properties:
diff --git a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
similarity index 34%
rename from Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
rename to Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
index 20191315e444..093edda0c8df 100644
--- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt
@@ -1,98 +1,80 @@
-* Samsung S5M8767 Voltage and Current Regulator
-
-The Samsung S5M8767 is a multi-function device which includes voltage and
-current regulators, rtc, charger controller and other sub-blocks. It is
-interfaced to the host controller using a i2c interface. Each sub-block is
-addressed by the host system using different i2c slave address. This document
-describes the bindings for 'pmic' sub-block of s5m8767.
-
-Required properties:
-- compatible: Should be "samsung,s5m8767-pmic".
-- reg: Specifies the i2c slave address of the pmic block. It should be 0x66.
-
-- s5m8767,pmic-buck2-dvs-voltage: A set of 8 voltage values in micro-volt (uV)
- units for buck2 when changing voltage using gpio dvs. Refer to [1] below
- for additional information.
-
-- s5m8767,pmic-buck3-dvs-voltage: A set of 8 voltage values in micro-volt (uV)
- units for buck3 when changing voltage using gpio dvs. Refer to [1] below
- for additional information.
-
-- s5m8767,pmic-buck4-dvs-voltage: A set of 8 voltage values in micro-volt (uV)
- units for buck4 when changing voltage using gpio dvs. Refer to [1] below
- for additional information.
-
-- s5m8767,pmic-buck-ds-gpios: GPIO specifiers for three host gpio's used
- for selecting GPIO DVS lines. It is one-to-one mapped to dvs gpio lines.
-
-[1] If none of the 's5m8767,pmic-buck[2/3/4]-uses-gpio-dvs' optional
-property is specified, the 's5m8767,pmic-buck[2/3/4]-dvs-voltage'
-property should specify atleast one voltage level (which would be a
-safe operating voltage).
-
-If either of the 's5m8767,pmic-buck[2/3/4]-uses-gpio-dvs' optional
-property is specified, then all the eight voltage values for the
-'s5m8767,pmic-buck[2/3/4]-dvs-voltage' should be specified.
-
-Optional properties:
-- interrupt-parent: Specifies the phandle of the interrupt controller to which
- the interrupts from s5m8767 are delivered to.
-- interrupts: Interrupt specifiers for two interrupt sources.
- - First interrupt specifier is for 'irq1' interrupt.
- - Second interrupt specifier is for 'alert' interrupt.
-- s5m8767,pmic-buck2-uses-gpio-dvs: 'buck2' can be controlled by gpio dvs.
-- s5m8767,pmic-buck3-uses-gpio-dvs: 'buck3' can be controlled by gpio dvs.
-- s5m8767,pmic-buck4-uses-gpio-dvs: 'buck4' can be controlled by gpio
[PATCH v2 0/3] dt-bindings: regulator/clock/mfd: Reorganize S2M/S5M bindings
Hi,
I got all acks for the patches. Please kindly pick up. Maybe Rob or Lee?
The patchset tries to bring some order to the chaotic bindings for family
of Samsung PMIC devices: S2MPS/S2MPA/S5M.
Beside of renaming and removal of common parts I also tried to make
a consistent style used in the files. The bindings itself were not
modified.
Rebased on next-20151223.
Changes since v1:
1. Added accumulated acks.
2. Use -M20% so renames will be more visible (formatting is changed so
default -M50% does not consider it as renames).
Best regards,
Krzysztof
Krzysztof Kozlowski (3):
dt-bindings: regulator/clock/mfd: Reorganize S2MPS-family bindings
dt-bindings: regulator/mfd: Reorganize S5M8767 bindings
dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings
.../devicetree/bindings/clock/samsung,s2mps11.txt | 49 +++
.../devicetree/bindings/mfd/samsung,sec-core.txt | 88
.../s2mpa01.txt => regulator/samsung,s2mpa01.txt} | 69 --
.../s2mps11.txt => regulator/samsung,s2mps11.txt} | 135 ++
.../{s5m8767-regulator.txt => samsung,s5m8767.txt} | 152 +
MAINTAINERS| 6 +-
6 files changed, 279 insertions(+), 220 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
rename Documentation/devicetree/bindings/{mfd/s2mpa01.txt =>
regulator/samsung,s2mpa01.txt} (37%)
rename Documentation/devicetree/bindings/{mfd/s2mps11.txt =>
regulator/samsung,s2mps11.txt} (25%)
rename Documentation/devicetree/bindings/regulator/{s5m8767-regulator.txt =>
samsung,s5m8767.txt} (34%)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410
W dniu 18.12.2015 o 18:16, Pavel Fedin pisze:
> Hello!
>
>> 4. This branch is not pushed to linux-next. I will sort it out if my
>> previous pull requests get in. I will be out of office for Christmas so
>> depending on the timing of {arm-soc,Christmas,Kukjin} this may or may
>> not go into v4.5 (yay...).
>>
>> 5. If it does not get into v4.5, I will rebase it and proceed further
>> for v4.6.
>>
>> If you have any questions, please let me know.
>
> Thank you very much. No, i don't have any questions, i'm glad that my work
> is picked up and not lost, i'm just keeping an eye on it
> until it goes to stable.
>
> P.S. Not related to these sets directly, just to note... When i was writing
> the doc for SROMc bindings, i noticed that we have two
> directories for Exynos in Documentation/devicetree/bindings/arm:
> 1. Documentation/devicetree/bindings/arm/exynos
> 2. Documentation/devicetree/bindings/arm/Samsung
>
> In (1) we have only a single old file, shouldn't this be cleaned up and
> shouldn't this file be moved to (2)?
Thanks for hind but I already cleaned it up:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=068812ed108acbfe070b893faba9845fe2ea3fd9
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5
W dniu 23.12.2015 o 20:06, Tomasz Figa pisze: > 2015-12-23 19:58 GMT+09:00 Krzysztof Kozlowski : >> W dniu 23.12.2015 o 19:54, Tomasz Figa pisze: >>> Hi, >>> >>> 2015-12-23 19:51 GMT+09:00 Krzysztof Kozlowski : >>>> W dniu 22.12.2015 o 13:50, Olof Johansson pisze: >>>>> On Wed, Dec 02, 2015 at 10:39:42AM +0900, Krzysztof Kozlowski wrote: >>>>>> Hi Kukjin, >>>>>> >>>>>> Pinctrl for v4.5. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>>> >>>>>> >>>>>> The following changes since commit >>>>>> 8005c49d9aea74d382f474ce11afbbc7d7130bec: >>>>>> >>>>>> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >>>>>> >>>>>> are available in the git repository at: >>>>>> >>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >>>>>> tags/samsung-drivers-4.5 >>>>>> >>>>>> for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: >>>>>> >>>>>> pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 >>>>>> +0900) >>>>> >>>>> Hi, >>>>> >>>>> This should either go in through the pinctrl tree, or have an >>>>> acked/reviewed-by >>>>> one of the pinctrl maintainers. >>>> >>>> It was acked by Tomasz Figa - Samsung Pin Controller maintainer: >>>> https://patchwork.ozlabs.org/patch/450340/ >>> >>> Actually, is there any reason to send this through ARM SoC? Looks like >>> this pull request contains only pinctrl changes which could normally >>> go through pinctrl tree. Maybe Linus W. could simply pull it? >> >> Of course, I would be happy with it. >> >> But apparently I am the only one who continuously tracks all of these >> patches for Exynos (also for subsystems different than arch/arm/mach*). >> Yeah, I could ping everyone for every patch (not mine patch I mean)... >> but it is easier just to grab it after acking and send it. I really >> don't care about the method, just apply the damned patch ;) > > My intention was by no means to belittle your effort, really thanks > for doing this. :) > > I was just wondering if Linus couldn't pull this just as is, without > causing further commotion and unnecessarily introducing field for > potential conflicts between trees. That makes sense. The pinctrl driver change is not a direct dependency for anything in this pull request so from my side: Acked-by: Krzysztof Kozlowski Linus, The patch can be cherry-picked from: https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=samsung-drivers-4.5 (the only commit in tag: samsung-drivers-4.5) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 7/9] ARM: EXYNOS: dts: DeviceTree for v4.5
W dniu 22.12.2015 o 13:52, Olof Johansson pisze: > On Wed, Dec 02, 2015 at 10:39:44AM +0900, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> A lot of stuff here, mostly cleanups. Description in tag. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: >> >> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >> >> are available in the git repository at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >> tags/samsung-dt-4.5 >> >> for you to fetch changes up to 2cf107f1033e0343d45b59d06f16487c8362702f: >> >> ARM: dts: Unify G2D device node with other devices on exynos4 (2015-11-30 >> 17:00:43 +0900) >> >> >> Samsung DeviceTree updates and improvements for 4.5: >> 1. Pinctrl for Exynos5410. >> 2. eMMC/SDIO minor fixes usage of bindings on Snow and Peach >>Chromebooks. >> 3. Remove FIMD from Odroid XU3-family because on XU3 it cannot be used >>yet and on XU3-Lite and XU4 it is not supported. >> 4. Remove deprecated since June 2013 samsung,exynos5-hdmi. >> 5. Add support for Pseudo Random Generator on Exynos4 (Trats2 for now). >>This depends on new SSS clock. >> 6. Add rotator nodes for Exynos4 and Exynos5. >> 7. Switch DWC3_1 on Odroid XU3 and XU3-Lite to peripheral mode because >>now it cannot be used as OTG. >> 8. Cleanup the G2D usage on Exynos4 and add it to a proper domain >>in case of Exynos4210. >> 9. Put MDMA1 in proper domain on Exynos4210 as well. >> 10. Minor cleanups. > > Given the request to get acks for the pinctrl changes, can you respin this > branch without those pieces so we can merge in the rest of it? > The pinctrl changes here are only DTS changes. I reviewed the pinctrl DTSI. Why do you want an additional ack for them? However this contains the previous clock dependency (the SSS clock acked by Stephen Boyd). I responded about this already so let's don't duplicate the discussion. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5
W dniu 23.12.2015 o 19:54, Tomasz Figa pisze: > Hi, > > 2015-12-23 19:51 GMT+09:00 Krzysztof Kozlowski : >> W dniu 22.12.2015 o 13:50, Olof Johansson pisze: >>> On Wed, Dec 02, 2015 at 10:39:42AM +0900, Krzysztof Kozlowski wrote: >>>> Hi Kukjin, >>>> >>>> Pinctrl for v4.5. >>>> >>>> Best regards, >>>> Krzysztof >>>> >>>> >>>> The following changes since commit >>>> 8005c49d9aea74d382f474ce11afbbc7d7130bec: >>>> >>>> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >>>> >>>> are available in the git repository at: >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >>>> tags/samsung-drivers-4.5 >>>> >>>> for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: >>>> >>>> pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 >>>> +0900) >>> >>> Hi, >>> >>> This should either go in through the pinctrl tree, or have an >>> acked/reviewed-by >>> one of the pinctrl maintainers. >> >> It was acked by Tomasz Figa - Samsung Pin Controller maintainer: >> https://patchwork.ozlabs.org/patch/450340/ > > Actually, is there any reason to send this through ARM SoC? Looks like > this pull request contains only pinctrl changes which could normally > go through pinctrl tree. Maybe Linus W. could simply pull it? Of course, I would be happy with it. But apparently I am the only one who continuously tracks all of these patches for Exynos (also for subsystems different than arch/arm/mach*). Yeah, I could ping everyone for every patch (not mine patch I mean)... but it is easier just to grab it after acking and send it. I really don't care about the method, just apply the damned patch ;) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 6/9] ARM: EXYNOS: clk: Another clock dependency, ARMv7, for v4.5
W dniu 22.12.2015 o 13:51, Olof Johansson pisze: > On Wed, Dec 02, 2015 at 10:39:43AM +0900, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> This is also clock dependency. I put it in separate tag in case clock >> folks want to pull it also. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: >> >> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >> >> are available in the git repository at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >> tags/samsung-clk-exynos4-4.5 >> >> for you to fetch changes up to 94af7a3c310f5877dc6f756179b92f24f89a9b08: >> >> clk: samsung: exynos4: Add SSS gate clock (2015-11-18 22:02:02 +0900) > > Again, this should probably go through the clk maintainer (or have an ack). > It's just two one-line changes though, so if they're slow to respond we can > take it as a fallback. Resend if that's the case. > Wait, I am missing something. This contains only one patch which has the Stephen's Boyd ack: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/379230.html (this is in commit message already) What kind of ack do you expect here? Ack for pull-request? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5
W dniu 22.12.2015 o 13:50, Olof Johansson pisze: > On Wed, Dec 02, 2015 at 10:39:42AM +0900, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> Pinctrl for v4.5. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: >> >> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >> >> are available in the git repository at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >> tags/samsung-drivers-4.5 >> >> for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: >> >> pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 >> +0900) > > Hi, > > This should either go in through the pinctrl tree, or have an > acked/reviewed-by > one of the pinctrl maintainers. It was acked by Tomasz Figa - Samsung Pin Controller maintainer: https://patchwork.ozlabs.org/patch/450340/ Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 4/9] ARM64: EXYNOS: Soc specific code for v4.5
W dniu 22.12.2015 o 13:49, Olof Johansson pisze: > On Wed, Dec 02, 2015 at 10:39:41AM +0900, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> ARM64 change touch also defconfig. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: >> >> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >> >> are available in the git repository at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >> tags/samsung-soc64-4.5 >> >> for you to fetch changes up to db44c07a3f0b32815bd1f3e731db9e043e57cf9c: >> >> arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS >> (2015-11-22 19:31:30 +0900) > > Given that Arnd started splitting out config64 separately, there's a small > chance we'll get a conflict here. We can deal with that if needed though. > > Still, since this branch contains the previous clock branch I can't apply it > as it is. Can you respin without that for now? This depends on the clock change because: 1. Clock change removes last usage of ARCH_EXYNOS7, 2. This patch removes the ARCH_EXYNOS7 itself. So if #1 has to wait, then skip this as well. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 3/9] ARM64: EXYNOS: clk: Clock dependency for ARM64 for v4.5
W dniu 22.12.2015 o 13:46, Olof Johansson pisze: > On Wed, Dec 02, 2015 at 10:39:40AM +0900, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> Dependency for soc64 changes. >> >> Best regards, >> Krzysztof >> >> >> The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: >> >> Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) >> >> are available in the git repository at: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git >> tags/samsung-clk-arm64-symbols-4.5 >> >> for you to fetch changes up to 8c2a90ed18a74e8b9cdbba679403faa44d6024fc: >> >> clk: samsung: Don't build ARMv8 clock drivers on ARMv7 (2015-11-22 >> 19:25:29 +0900) > > Hi, > > Looks like this lacks ack from any of the clock maintainers. It got the ack from Sylwester and Tomasz - Samsung clock maintainers. If it is not sufficient... then let's wait with it for v4.6. I am on holidays now so I cannot really do anything meaningful with it. > > Given that EXYNOS_ARM64_COMMON_CLK is not yet introduced, this will cause > a breakage in bisectability on some of these platforms as well. The patch introduces EXYNOS_ARM64_COMMON_CLK which will be enabled by default on our platforms. What kind of breakage do you have in mind? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] extcon: add Maxim MAX3355 driver
On 17.12.2015 23:36, Sergei Shtylyov wrote: > Hello. > > On 12/17/2015 3:53 AM, Krzysztof Kozlowski wrote: > >>> Maxim Integrated MAX3355E chip integrates a charge pump and >>> comparators to >>> enable a system with an integrated USB OTG dual-role transceiver to >>> function as an USB OTG dual-role device. In addition to >>> sensing/controlling >>> Vbus, the chip also passes thru the ID signal from the USB OTG >>> connector. >>> On some Renesas boards, this signal is just fed into the SoC thru a GPIO >>> pin -- there's no real OTG controller, only host and gadget USB >>> controllers >>> sharing the same USB bus; however, we'd like to allow host or gadget >>> drivers to be loaded depending on the cable type, hence the need for the >>> MAX3355 extcon driver. The Vbus status signals are also wired to GPIOs >>> (however, we aren't currently interested in them), the OFFVBUS# >>> signal is >>> controlled by the host controllers, there's also the SHDN# signal >>> wired to >>> a GPIO, it should be driven high for the normal operation. >>> >>> Signed-off-by: Sergei Shtylyov >>> >>> --- >>> Changes in version 3: >>> - reformatted the change log. >>> >>> Changes in version 2: >>> - added the USB gadget cable support; >>> - added the remove() driver method which drives SHDN# GPIO low to >>> save power; >>> - dropped vendor prefix from the ID GPIO property name; >>> - changed the GPIO property name suffix to "-gpios"; >>> - switched to usign extcon_set_cable_state_() API; >>> - switched to using the gpiod/sleeping 'gpiolib' APIs; >>> - addded error messages to max3355_probe(); >>> - added IRQF_NO_SUSPEND flasg to the devm_request_threaded_irq() call; >>> - renamed 'ret' variable to 'err' in max3355_probe(); >>> - expanded the Kconfig entry help text; >>> - added vendor name to the patch summary, the bindings document, the >>> Kconfig >>>entry, the driver heading comment, the module description, and the >>> change log; >>> - fixed up and reformatted the change log. >>> >>> Documentation/devicetree/bindings/extcon/extcon-max3355.txt | 21 + >>> drivers/extcon/Kconfig |8 >>> drivers/extcon/Makefile |1 >>> drivers/extcon/extcon-max3355.c | 153 >>> >>> 4 files changed, 183 insertions(+) >>> >>> Index: >>> renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt >>> === >>> --- /dev/null >>> +++ renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt >>> @@ -0,0 +1,21 @@ >>> +Maxim Integrated MAX3355 USB OTG chip >>> +- >>> + >>> +MAX3355 integrates a charge pump and comparators to enable a system >>> with an >>> +integrated USB OTG dual-role transceiver to function as a USB OTG >>> dual-role >>> +device. >>> + >>> +Required properties: >>> +- compatible: should be "maxim,max3355"; >>> +- maxim,shdn-gpios: should contain a phandle and GPIO specifier for >>> the GPIO pin >>> + connected to the MAX3355's SHDN# pin; >> >> Could you add some indentation to the wrapped line for this property? >> For readability. > >If it's not indented enough, I can add more spaces/tabs. Ahh, now I see it is sufficient. I need fix my email client. > >>> +- id-gpios: should contain a phandle and GPIO specifier for the GPIO >>> pin >>> + connected to the MAX3355's ID_OUT pin. >> >> Ditto. >> >> Why this property lacks the vendor prefix i(n comparison to shdn-gpios >> which has the prefix)? > >Since the extcon-usb-gpio driver uses "id-gpio" prop already. I can > add back the vendor prefix if you insist. It is for USB ID and palmas has it already as well so I do not insist. Seems generic. > > [...] >>> Index: renesas/drivers/extcon/extcon-max3355.c >>> === >>> --- /dev/null >>> +++ renesas/drivers/extcon/extcon-max3355.c >>> @@ -0,0 +1,153 @@ > [...] >>> +static int max3355_probe(struct platform_device *pdev) >>&g
Re: [PATCH v9 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410
On 16.11.2015 16:43, Pavel Fedin wrote:
> This patch extends Exynos SROM controller driver with ability to configure
> controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board,
> which is connected via SROMc bank #3.
>
> With this patchset, support for the whole existing SMDK range can be added.
> Actually, only bank number is different.
>
> This patchset also depends on Exynos 5410 pinctrl support, introduced by
> patches 0003 and 0004 from this set:
> [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/330862.html
>
> Pinctrl support is necessary in order to correctly configure
> multifunctional pins of the Exynos chip.
>
Let me share the plan/status:
1. Currently Kukjin Kim is out of office (he told me he will be back on
Christmas).
2. I asked arm-soc people to pull my previous pull requests.
3. I applied this patchset to my branch:
next/stuff-late-not-split-per-branch
https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/stuff-late-not-split-per-branch
4. This branch is not pushed to linux-next. I will sort it out if my
previous pull requests get in. I will be out of office for Christmas so
depending on the timing of {arm-soc,Christmas,Kukjin} this may or may
not go into v4.5 (yay...).
5. If it does not get into v4.5, I will rebase it and proceed further
for v4.6.
If you have any questions, please let me know.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 0/9] ARM: EXYNOS: Pull request for v4.5
On 17.12.2015 10:43, Krzysztof Kozlowski wrote: > On 02.12.2015 10:39, Krzysztof Kozlowski wrote: >> Hi Kukjin, >> >> A lot of stuff for v4.5 with 3 dependencies split into >> separate tags. The need for dependency is explained both >> in merge-commit and in description of a tag which is using >> the dependency. > > Hi everyone, > > It's been like two weeks... we are after v4.4-rc5 and Christmas season > is coming... there are some dependencies here and even more stuff waits > out of queue for this pull request (moving SROM and PMU to drivers/soc, > cpufreq for Exynos542x). > > What I want to say is that I am really not sure whether further waiting > is beneficial... > All these patches have been boiling in linux-next for some time (through > my tree). > > > Are there any comments about this pull request? Ordering of branches? > Weird looking tags? Bugs? etc.? Anything waits in your tree Kukjin? > > > Maybe this could be pulled directly by arm-soc folks? > Actually in the same time I sent this mail I got an ack from Kukjin (his Business Trip to China extended further than planned), so: Arnd, Kevin and Olof, Could you pull this for v4.5 or share your comments? The number of tags is not that scary... just some dependencies split across 3 tags. Best regards, Krzysztof > >> >> The order goes like (but of course dependencies >> could be pulled all at once at beginning): >> 1. tags/samsung-dt-syscon-restart-4.5 >> 2. tags/samsung-soc-4.5 >> 3. tags/samsung-clk-arm64-symbols-4.5 >> 4. tags/samsung-soc64-4.5 >> 5. tags/samsung-drivers-4.5 >> 6. tags/samsung-clk-exynos4-4.5 >> 7. tags/samsung-dt-4.5 >> 8. tags/samsung-dt64-4.5 >> 9. tags/samsung-defconfig-4.5 >> >> I split dependencies to three tags so clock or other folks could >> easily grab them if needed. >> >> Please share your comments or pull as early as possible as we have here >> some more dependencies than usual. >> >> >> Kind regards, >> Krzysztof >> > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 0/9] ARM: EXYNOS: Pull request for v4.5
On 02.12.2015 10:39, Krzysztof Kozlowski wrote: > Hi Kukjin, > > A lot of stuff for v4.5 with 3 dependencies split into > separate tags. The need for dependency is explained both > in merge-commit and in description of a tag which is using > the dependency. Hi everyone, It's been like two weeks... we are after v4.4-rc5 and Christmas season is coming... there are some dependencies here and even more stuff waits out of queue for this pull request (moving SROM and PMU to drivers/soc, cpufreq for Exynos542x). What I want to say is that I am really not sure whether further waiting is beneficial... All these patches have been boiling in linux-next for some time (through my tree). Are there any comments about this pull request? Ordering of branches? Weird looking tags? Bugs? etc.? Anything waits in your tree Kukjin? Maybe this could be pulled directly by arm-soc folks? Best regards, Krzysztof > > The order goes like (but of course dependencies > could be pulled all at once at beginning): > 1. tags/samsung-dt-syscon-restart-4.5 > 2. tags/samsung-soc-4.5 > 3. tags/samsung-clk-arm64-symbols-4.5 > 4. tags/samsung-soc64-4.5 > 5. tags/samsung-drivers-4.5 > 6. tags/samsung-clk-exynos4-4.5 > 7. tags/samsung-dt-4.5 > 8. tags/samsung-dt64-4.5 > 9. tags/samsung-defconfig-4.5 > > I split dependencies to three tags so clock or other folks could > easily grab them if needed. > > Please share your comments or pull as early as possible as we have here > some more dependencies than usual. > > > Kind regards, > Krzysztof > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] extcon: add Maxim MAX3355 driver
2015-12-17 3:07 GMT+09:00 Sergei Shtylyov :
> Maxim Integrated MAX3355E chip integrates a charge pump and comparators to
> enable a system with an integrated USB OTG dual-role transceiver to
> function as an USB OTG dual-role device. In addition to sensing/controlling
> Vbus, the chip also passes thru the ID signal from the USB OTG connector.
> On some Renesas boards, this signal is just fed into the SoC thru a GPIO
> pin -- there's no real OTG controller, only host and gadget USB controllers
> sharing the same USB bus; however, we'd like to allow host or gadget
> drivers to be loaded depending on the cable type, hence the need for the
> MAX3355 extcon driver. The Vbus status signals are also wired to GPIOs
> (however, we aren't currently interested in them), the OFFVBUS# signal is
> controlled by the host controllers, there's also the SHDN# signal wired to
> a GPIO, it should be driven high for the normal operation.
>
> Signed-off-by: Sergei Shtylyov
>
> ---
> Changes in version 3:
> - reformatted the change log.
>
> Changes in version 2:
> - added the USB gadget cable support;
> - added the remove() driver method which drives SHDN# GPIO low to save power;
> - dropped vendor prefix from the ID GPIO property name;
> - changed the GPIO property name suffix to "-gpios";
> - switched to usign extcon_set_cable_state_() API;
> - switched to using the gpiod/sleeping 'gpiolib' APIs;
> - addded error messages to max3355_probe();
> - added IRQF_NO_SUSPEND flasg to the devm_request_threaded_irq() call;
> - renamed 'ret' variable to 'err' in max3355_probe();
> - expanded the Kconfig entry help text;
> - added vendor name to the patch summary, the bindings document, the Kconfig
> entry, the driver heading comment, the module description, and the change
> log;
> - fixed up and reformatted the change log.
>
> Documentation/devicetree/bindings/extcon/extcon-max3355.txt | 21 +
> drivers/extcon/Kconfig |8
> drivers/extcon/Makefile |1
> drivers/extcon/extcon-max3355.c | 153
>
> 4 files changed, 183 insertions(+)
>
> Index: renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt
> ===
> --- /dev/null
> +++ renesas/Documentation/devicetree/bindings/extcon/extcon-max3355.txt
> @@ -0,0 +1,21 @@
> +Maxim Integrated MAX3355 USB OTG chip
> +-
> +
> +MAX3355 integrates a charge pump and comparators to enable a system with an
> +integrated USB OTG dual-role transceiver to function as a USB OTG dual-role
> +device.
> +
> +Required properties:
> +- compatible: should be "maxim,max3355";
> +- maxim,shdn-gpios: should contain a phandle and GPIO specifier for the GPIO
> pin
> + connected to the MAX3355's SHDN# pin;
Could you add some indentation to the wrapped line for this property?
For readability.
> +- id-gpios: should contain a phandle and GPIO specifier for the GPIO pin
> + connected to the MAX3355's ID_OUT pin.
Ditto.
Why this property lacks the vendor prefix i(n comparison to shdn-gpios
which has the prefix)?
> +
> +Example (Koelsch board):
> +
> + usb-otg {
> + compatible = "maxim,max3355";
> + maxim,shdn-gpios = <&gpio2 4 GPIO_ACTIVE_LOW>;
> + id-gpios = <&gpio5 31 GPIO_ACTIVE_HIGH>;
> + };
> Index: renesas/drivers/extcon/Kconfig
> ===
> --- renesas.orig/drivers/extcon/Kconfig
> +++ renesas/drivers/extcon/Kconfig
> @@ -52,6 +52,14 @@ config EXTCON_MAX14577
> Maxim MAX14577/77836. The MAX14577/77836 MUIC is a USB port
> accessory
> detector and switch.
>
> +config EXTCON_MAX3355
> + tristate "Maxim MAX3355 USB OTG EXTCON Support"
> + help
> + If you say yes here you get support for the USB OTG role detection
> by
> + MAX3355. The MAX3355 chip integrates a charge pump and comparators
> to
> + enable a system with an integrated USB OTG dual-role transceiver to
> + function as an USB OTG dual-role device.
> +
> config EXTCON_MAX77693
> tristate "Maxim MAX77693 EXTCON Support"
> depends on MFD_MAX77693 && INPUT
> Index: renesas/drivers/extcon/Makefile
> ===
> --- renesas.orig/drivers/extcon/Makefile
> +++ renesas/drivers/extcon/Makefile
> @@ -8,6 +8,7 @@ obj-$(CONFIG_EXTCON_ARIZONA)+= extcon-a
> obj-$(CONFIG_EXTCON_AXP288)+= extcon-axp288.o
> obj-$(CONFIG_EXTCON_GPIO) += extcon-gpio.o
> obj-$(CONFIG_EXTCON_MAX14577) += extcon-max14577.o
> +obj-$(CONFIG_EXTCON_MAX3355) += extcon-max3355.o
> obj-$(CONFIG_EXTCON_MAX77693) += extcon-max77693.o
> obj-$(CONFIG_EXTCON_MAX77843) += extcon-max77843.o
> obj-$(CONFIG_EXTCON_MAX8997) += extcon-max8997.o
> Index: renesas/drivers/extcon/extcon-max3355.c
> =
Re: [PATCH 16/19] ARM: dts: s5pv210: replace legacy *,wakeup property with wakeup-source
2015-10-21 19:10 GMT+09:00 Sudeep Holla : > Though the keyboard and other driver will continue to support the legacy > "gpio-key,wakeup", "linux,input-wakeup" boolean property to enable the > wakeup source, "wakeup-source" is the new standard binding. > > This patch replaces all the legacy wakeup properties with the unified > "wakeup-source" property in order to avoid any futher copy-paste > duplication. > > Cc: Marek Szyprowski > Cc: Kukjin Kim > Cc: linux-samsung-...@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > arch/arm/boot/dts/s5pv210-aquila.dts | 4 ++-- > arch/arm/boot/dts/s5pv210-goni.dts | 4 ++-- > arch/arm/boot/dts/s5pv210-smdkv210.dts | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/19] ARM: dts: exynos: replace legacy *,wakeup property with wakeup-source
On 21.10.2015 19:10, Sudeep Holla wrote:
> Though the keyboard and other driver will continue to support the legacy
> "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the
> wakeup source, "wakeup-source" is the new standard binding.
>
> This patch replaces all the legacy wakeup properties with the unified
> "wakeup-source" property in order to avoid any futher copy-paste
> duplication.
>
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: linux-samsung-...@vger.kernel.org
> Signed-off-by: Sudeep Holla
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 6 +++---
> arch/arm/boot/dts/exynos3250-rinato.dts | 6 +++---
> arch/arm/boot/dts/exynos4210-origen.dts | 10 +-
> arch/arm/boot/dts/exynos4210-smdkv310.dts | 2 +-
> arch/arm/boot/dts/exynos4210-trats.dts | 2 +-
> arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 ++--
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +-
> arch/arm/boot/dts/exynos4412-odroidx.dts| 2 +-
> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
> arch/arm/boot/dts/exynos4412-smdk4412.dts | 2 +-
> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++--
> arch/arm/boot/dts/exynos5250-arndale.dts| 12 ++--
> arch/arm/boot/dts/exynos5250-snow.dts | 4 ++--
> arch/arm/boot/dts/exynos5250-spring.dts | 4 ++--
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 ++--
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 ++--
> 17 files changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts
> b/arch/arm/boot/dts/exynos3250-monk.dts
> index 540a0adf2be6..b77ea2163a0a 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -43,7 +43,7 @@
> linux,code = ;
> label = "power key";
> debounce-interval = <10>;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
>
> @@ -67,7 +67,7 @@
> interrupt-parent = <&gpx1>;
> interrupts = <5 0>;
> reg = <0x25>;
> - wakeup;
> + wakeup-source;
>
> muic: max77836-muic {
> compatible = "maxim,max77836-muic";
> @@ -184,7 +184,7 @@
> interrupt-parent = <&gpx0>;
> interrupts = <7 0>;
> reg = <0x66>;
> - wakeup;
> + wakeup-source;
>
> s2mps14_osc: clocks {
> compatible = "samsung,s2mps14-clk";
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
> b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 41a5fafb9aa9..7acd11d2d957 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -43,7 +43,7 @@
> linux,code = ;
> label = "power key";
> debounce-interval = <10>;
> - gpio-key,wakeup;
> + wakeup-source;
> };
> };
>
> @@ -58,7 +58,7 @@
> interrupt-parent = <&gpx1>;
> interrupts = <5 0>;
> reg = <0x25>;
> - wakeup;
> + wakeup-source;
>
> muic: max77836-muic {
> compatible = "maxim,max77836-muic";
> @@ -245,7 +245,7 @@
> interrupt-parent = <&gpx0>;
> interrupts = <7 0>;
> reg = <0x66>;
> - wakeup;
> + wakeup-source;
I think here and in Monk board these four "wakeup" properties are bogus,
not parsed by driver. Instead wakeup is always initialized to true.
Anyway fixing this is not part of this patch but instead this should be
fixed in separate commit. Here everything looks good:
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/19] ARM: dts: exynos: replace legacy *,wakeup property with wakeup-source
On 16.12.2015 19:32, Sudeep Holla wrote: > > > On 15/12/15 23:32, Krzysztof Kozlowski wrote: >> On 16.12.2015 01:35, Sudeep Holla wrote: >>> >>> >>> On 21/10/15 11:10, Sudeep Holla wrote: >>>> Though the keyboard and other driver will continue to support the >>>> legacy >>>> "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the >>>> wakeup source, "wakeup-source" is the new standard binding. >>>> >>>> This patch replaces all the legacy wakeup properties with the unified >>>> "wakeup-source" property in order to avoid any futher copy-paste >>>> duplication. >>>> >>>> Cc: Kukjin Kim >>>> Cc: Krzysztof Kozlowski >>> >>> Ping, do you prefer taking via your tree or should I send to armsoc >>> directly ? >> >> Usually it depends on the dependencies... but: >> 1. I just received this patch - 12/19. > > Sorry for that. The initial idea was to show all the changes but merge > the binding and dependencies first, so didn't cc all. > >> 2. No cover letter, no other patches, no explanation about any >> dependencies or other related changes. Nothing. Just one patch. > > Yes this was initially posted as part of the series, but only > dependencies were merged for v4.4 > >> 3. The patch mentions new standard binding. Was the new binding already >> merged? Or is it part of these series? What about backward compatibility? > > Not a brand new binding, but made existing one a standard so that we > don't continue to be creative and generate more bindings for the same > thing. Yes binding and dependent patches are already in mainline. And > yes backward compatibility is maintained as mentioned in the commit > message. That explains everything, thanks. We'll take it through samsung-soc, just give me some time for review. As for other patch - the s5pv210 - I did not get it directly but I think I can find it on list subscription archives. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver
2015-12-16 10:11 GMT+09:00 Sebastian Reichel : > Hi, > > On Tue, Dec 15, 2015 at 04:53:31PM -0800, Eric Anholt wrote: >> >>> What motivated the location of this power domain driver in >> >>> arch/arm/mach-bcm? Should not we have this in drivers/power/ or >> >>> somewhere in drivers/ at the very least? >> >> >> >> ls stronly suggests that power contains drivers for power supplies and >> >> batteries, not power domains. > > Indeed it's used for fuel gauges and chargers, but also for > reboot/powerdown and adaptive voltage scaling, so another > subdirectory for power-domains wouldn't be that odd. > >> >> There are 6 power domain drivers in >> >> arch/arm, 3 in drivers/clk, and 3 in drivers/soc. >> > >> > If we ever have to support a different architecture which happens to use >> > a similar power domain, then we want it to be in a location which makes >> > it easy for sharing it in the first place. As it stands today, it does >> > not seem useful to me to have this code in arch/arm/mach-bcm/ at all. >> > >> > Maybe there is room from a drivers/power/domains/ of some kind? > > I like the idea, but let's include generic power domain maintainers > in this discussion, as I suggested here (I got a power domain driver > patch for drivers/power just a few days ago): > > https://lkml.org/lkml/2015/12/15/815 > > Also somebody would have to step up to maintain that directory. This could go into drivers/soc. We put there a lot of mach-specific stuff which we want to make a little more generic (like generic enough multiplatform, multiarchitecture etc). Rockchip has its own power domains there. Dove and Mediatek seem as well but I am not sure. Some other architectures keep this still in arm/mach (exynos, ux500, zx, imx, s34c64xx, shmobile) but this looks more of like a legacy choice. However, since generic power domains have its own maintainers entry and reside under drivers/base/power, maybe making a separate directory for power domains drivers makes sense? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 12/19] ARM: dts: exynos: replace legacy *,wakeup property with wakeup-source
On 16.12.2015 01:35, Sudeep Holla wrote: > > > On 21/10/15 11:10, Sudeep Holla wrote: >> Though the keyboard and other driver will continue to support the legacy >> "gpio-key,wakeup", "linux-keypad,wakeup" boolean property to enable the >> wakeup source, "wakeup-source" is the new standard binding. >> >> This patch replaces all the legacy wakeup properties with the unified >> "wakeup-source" property in order to avoid any futher copy-paste >> duplication. >> >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski > > Ping, do you prefer taking via your tree or should I send to armsoc > directly ? Usually it depends on the dependencies... but: 1. I just received this patch - 12/19. 2. No cover letter, no other patches, no explanation about any dependencies or other related changes. Nothing. Just one patch. 3. The patch mentions new standard binding. Was the new binding already merged? Or is it part of these series? What about backward compatibility? BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
On 14.12.2015 15:38, Chanwoo Choi wrote: > This patch adds the generic exynos bus frequency driver for AMBA AXI bus > of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC > have the common architecture for bus between DRAM and sub-blocks in SoC. > This driver can support the generic bus frequency driver for Exynos SoCs. > > In devicetree, Each bus block has a bus clock, regulator, operation-point > and devfreq-event devices which measure the utilization of each bus block. > > Signed-off-by: Chanwoo Choi > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon > --- > drivers/devfreq/Kconfig | 15 ++ > drivers/devfreq/Makefile| 1 + > drivers/devfreq/exynos/Makefile | 1 + > drivers/devfreq/exynos/exynos-bus.c | 449 > > 4 files changed, 466 insertions(+) > create mode 100644 drivers/devfreq/exynos/exynos-bus.c > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 64281bb2f650..55ec774f794c 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -66,6 +66,21 @@ config DEVFREQ_GOV_USERSPACE > > comment "DEVFREQ Drivers" > > +config ARM_EXYNOS_BUS_DEVFREQ > + bool "ARM EXYNOS Generic Memory Bus DEVFREQ Driver" > + depends on ARCH_EXYNOS > + select DEVFREQ_GOV_SIMPLE_ONDEMAND > + select DEVFREQ_EVENT_EXYNOS_PPMU > + select PM_DEVFREQ_EVENT > + select PM_OPP > + help > + This adds the common DEVFREQ driver for Exynos Memory bus. Exynos > + Memory bus has one more group of memory bus (e.g, MIF and INT block). > + Each memory bus group could contain many memoby bus block. It reads > + PPMU counters of memory controllers by using DEVFREQ-event device > + and adjusts the operating frequencies and voltages with OPP support. > + This does not yet operate with optimal voltages. > + > config ARM_EXYNOS4_BUS_DEVFREQ > bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" > depends on (CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412) && > !ARCH_MULTIPLATFORM > diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile > index 5134f9ee983d..375ebbb4fcfb 100644 > --- a/drivers/devfreq/Makefile > +++ b/drivers/devfreq/Makefile > @@ -6,6 +6,7 @@ obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o > obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o > > # DEVFREQ Drivers > +obj-$(CONFIG_ARCH_EXYNOS)+= exynos/ Why limiting it to ARCH_EXYNOS? Are there real dependencies on exynos mach code? Or on ARM code? If not, then this probably should be obj-y to allow compile testing. Particular objects would be selected by ARM_EXYNOS_BUS_DEVFREQ. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
On 14.12.2015 15:38, Chanwoo Choi wrote: > THis patch adds the bus device tree nodes for both MIF (Memory) and INT > (Internal) block to enable the bus frequency. > > The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS > bus is parent device in INT block using VDD_INT. > > Signed-off-by: Chanwoo Choi > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47 > + > arch/arm/boot/dts/exynos4412-trats2.dts | 47 > + > 2 files changed, 94 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 01/20] PM / devfreq: exynos: Add generic exynos bus frequency driver
On 11.12.2015 16:52, Chanwoo Choi wrote: > Dear MyungJoo, > > Almost device tree patches in this series are reviewed by Exynos maintainer. > Could you please review this series? Are there any objections to merging DT patches through Samsung-soc? Looking at the code, there are no dependencies between DT and drivers, right? Best regards, Krzysztof > > Best Regards, > Chanwoo Choi > > On 2015년 12월 11일 14:07, Chanwoo Choi wrote: >> This patch adds the generic exynos bus frequency driver for AMBA AXI bus >> of sub-blocks in exynos SoC with DEVFREQ framework. The Samsung Exynos SoC >> have the common architecture for bus between DRAM and sub-blocks in SoC. >> This driver can support the generic bus frequency driver for Exynos SoCs. >> >> In devicetree, Each bus block has a bus clock, regulator, operation-point >> and devfreq-event devices which measure the utilization of each bus block. >> >> Signed-off-by: Chanwoo Choi >> [linux.amoon: Tested on Odroid U3] >> Tested-by: Anand Moon >> --- >> drivers/devfreq/Kconfig | 15 ++ >> drivers/devfreq/Makefile| 1 + >> drivers/devfreq/exynos/Makefile | 1 + >> drivers/devfreq/exynos/exynos-bus.c | 449 >> >> 4 files changed, 466 insertions(+) >> create mode 100644 drivers/devfreq/exynos/exynos-bus.c -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 20/20] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
On 11.12.2015 14:07, Chanwoo Choi wrote:
> THis patch adds the bus device tree nodes for both MIF (Memory) and INT
> (Internal) block to enable the bus frequency.
>
> The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS
> bus is parent device in INT block using VDD_INT.
>
> Signed-off-by: Chanwoo Choi
> [linux.amoon: Tested on Odroid U3]
> Tested-by: Anand Moon
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47
> arch/arm/boot/dts/exynos4412-trats2.dts | 48
> +
> 2 files changed, 95 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 7bd65026761e..b6818aec7cf9 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -501,3 +501,50 @@
> &watchdog {
> status = "okay";
> };
> +
> +&bus_acp {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
I meant put them in proper place, respecting alphabetical order. The 'b'
comes before 'w'.
As for the new nodes (bus_XXX) your previous sorting (first parent, then
passive) was also okay - it had sense. This is up to you. Just put
everything not at the end of file.
Best regards,
Krzysztof
> +
> +&bus_c2c {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> +&bus_display {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_fsys {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_leftbus {
> + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> + vdd-supply = <&buck3_reg>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_rightbus {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts
> b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 92438eb6eec6..0b8aff3b8cb7 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -1251,3 +1251,51 @@
> vtmu-supply = <&ldo10_reg>;
> status = "okay";
> };
> +
> +&bus_acp {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_c2c {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> +&bus_display {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +
> +&bus_fsys {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_leftbus {
> + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> + vdd-supply = <&buck3_reg>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_rightbus {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 18/20] ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the bus device-tree node of INT (internal) block > to enable the bus frequency scaling. The following sub-blocks share > the VDD_INT power source: > - LEFTBUS (parent device) > - RIGHTBUS > - PERIL > - LCD0 > - FSYS > - MCUISP / ISP > - MFC > > The LEFTBUS is parent device with devfreq ondemand governor > and the rest devices has the dependency on LEFTBUS bus. I pointed this previously. If you wish to leave the sentence in such form then "rest of" and "have" not "has". Best regards, Krzysztof > > Signed-off-by: Chanwoo Choi > Reviewed-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos3250-rinato.dts | 41 > + > 1 file changed, 41 insertions(+) > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 17/20] ARM: dts: Add exynos4412-ppmu-common dtsi to delete duplicate PPMU node
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the exynos4412-ppmu-common.dtsi to duplicate PPMU node I think the goal of the patch was to remove duplication of nodes, not to duplicate them. :) Except of that patch is okay: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > because exynos3250-rinato/monk, exynos4412-trats2/odroidu3 has the same > PPMU device tree node. > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250-monk.dts | 41 + > arch/arm/boot/dts/exynos3250-rinato.dts | 41 + > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 + > arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 49 > + > arch/arm/boot/dts/exynos4412-trats2.dts | 41 + > 5 files changed, 53 insertions(+), 120 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 16/20] ARM: dts: Add bus nodes using VDD_MIF for Exynos4210
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the bus nodes for Exynos4210 SoC. Exynos4210 SoC has > one power line for all buses to translate data between DRAM and sub-blocks. > > Following list specifies the detailed relation between DRAM and sub-blocks: > - DMC/ACP clock for DMC (Dynamic Memory Controller) > - ACLK200 clock for LCD0 > - ACLK100 clock for PERIL/PERIR/MFC(PCLK) > - ACLK160 clock for CAM/TV/LCD0/LCD1 > - ACLK133 clock for FSYS/GPS > - GDL/GDR clock for LEFTBUS/RIGHTBUS > - SCLK_MFC clock for MFC > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos4210.dtsi | 159 > ++ > 1 file changed, 159 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 15/20] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the bus noes using VDD_INT for Exynos4x12 SoC. > Exynos4x12 has the following AXI buses to translate data between > DRAM and sub-blocks. > > Following list specifies the detailed relation between DRAM and sub-blocks: > - ACLK100 clock for PERIL/PERIR/MFC(PCLK) > - ACLK160 clock for CAM/TV/LCD > : The minimum clock of ACLK160 should be over 160MHz. > When drop the clock under 160MHz, show the broken image. > - ACLK133 clock for FSYS > - GDL clock for LEFTBUS > - GDR clock for RIGHTBUS > - SCLK_MFC clock for MFC > > Signed-off-by: Chanwoo Choi > [linux.amoon: Tested on Odroid U3] > Tested-by: Anand Moon > --- > arch/arm/boot/dts/exynos4x12.dtsi | 106 > ++ > 1 file changed, 106 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 14/20] ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
On 11.12.2015 14:07, Chanwoo Choi wrote:
> This patch adds the bus noes using VDD_MIF for Exynos4x12 SoC.
"noes", pointed at v2.
> Exynos4x12 has the following AXI buses to translate data
> between DRAM and DMC/ACP/C2C.
>
> Signed-off-by: Chanwoo Choi
> [linux.amoon: Tested on Odroid U3]
> Tested-by: Anand Moon
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 68
> +++
> 1 file changed, 68 insertions(+)
The code itself:
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi
> index 84a23f962946..99a0f4ca3d47 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -281,6 +281,74 @@
> clocks = <&clock CLK_SMMU_LITE1>, <&clock CLK_FIMC_LITE1>;
> #iommu-cells = <0>;
> };
> +
> + bus_dmc: bus_dmc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_DMC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_acp: bus_acp {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_ACP>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_acp_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_c2c: bus_c2c {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_C2C>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_dmc_opp_table: opp_table1 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp@1 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <90>;
> + };
> + opp@13400 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <90>;
> + };
> + opp@16000 {
> + opp-hz = /bits/ 64 <16000>;
> + opp-microvolt = <90>;
> + };
> + opp@26700 {
> + opp-hz = /bits/ 64 <26700>;
> + opp-microvolt = <95>;
> + };
> + opp@4 {
> + opp-hz = /bits/ 64 <4>;
> + opp-microvolt = <105>;
> + };
> + };
> +
> + bus_acp_opp_table: opp_table2 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp@1 {
> + opp-hz = /bits/ 64 <1>;
> + };
> + opp@13400 {
> + opp-hz = /bits/ 64 <13400>;
> + };
> + opp@16000 {
> + opp-hz = /bits/ 64 <16000>;
> + };
> + opp@26700 {
> + opp-hz = /bits/ 64 <26700>;
> + };
> + };
> };
>
> &combiner {
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 13/20] ARM: dts: Add bus nodes using VDD_INT for Exynos3250
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the bus nodes using VDD_INT for Exynos3250 SoC. > Exynos3250 has following AXI buses to translate data between > DRAM and sub-blocks. > > Following list specifies the detailed relation between DRAM and sub-blocks: > - ACLK400 clock for MCUISP > - ACLK266 clock for ISP > - ACLK200 clock for FSYS > - ACLK160 clock for LCD0 > - ACLK100 clock for PERIL > - GDL clock for LEFTBUS > - GDR clock for RIGHTBUS > - SCLK_MFC clock for MFC > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250.dtsi | 147 > ++ > 1 file changed, 147 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 03/20] ARM: dts: Add DMC bus node for Exynos3250
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the DMC (Dynamic Memory Controller) bus node for Exynos3250 > SoC. > The DMC is an AMBA AXI-compliant slave to interface external JEDEC standard > SDRAM devices. The bus includes the OPP tables and the source clock for DMC > block. > > Following list specifies the detailed relation between the clock and DMC > block: > - The source clock of DMC block : div_dmc > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++ > 1 file changed, 34 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 02/20] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
On 11.12.2015 14:07, Chanwoo Choi wrote: > This patch adds the documentation for generic exynos bus frequency > driver. > > Signed-off-by: Chanwoo Choi > --- > .../devicetree/bindings/devfreq/exynos-bus.txt | 93 > ++ > 1 file changed, 93 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt > Thanks, now it looks good to me. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Make CPU configuration more readable for exynos542x/5800
On 11.12.2015 15:21, Viresh Kumar wrote: > On 11-12-15, 15:17, Krzysztof Kozlowski wrote: >> Exynos5420 and Exynos5800 boards boot from big core (A15) but >> Exynos5420 boards choose otherwise: LITTLE core (A7) (on Exynos5422 this > > s/Exynos5420/Exynos5422 Damn, one can get confused. Thanks for review! Krzysztof > and then you can add > > Reviewed-by: Viresh Kumar > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: dts: Make CPU configuration more readable for exynos542x/5800
Exynos5420 and Exynos5800 boards boot from big core (A15) but
Exynos5420 boards choose otherwise: LITTLE core (A7) (on Exynos5422 this
is property of the board - configurable by pulling up/down gpg2-1).
To make user-visible CPU ordering more consistent the 'cpus' node was
overridden by exynos5422-cpus.dtsi.
However this is a little bit ugly and error-prone. Overriding the CPU
child nodes requires to basically reverse what was done initially in
exynos5420.dtsi.
Instead, split CPU configuration entirely to separate files which should
be included by board DTS.
Suggested-by: Viresh Kumar
Signed-off-by: Krzysztof Kozlowski
---
Tested on Exynos5422 based Odroid XU4. Please kindly test on Exynos5420
or Exynos5800 boards.
---
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 1 +
arch/arm/boot/dts/exynos5420-cpus.dtsi| 92 ++
arch/arm/boot/dts/exynos5420-peach-pit.dts| 1 +
arch/arm/boot/dts/exynos5420-smdk5420.dts | 1 +
arch/arm/boot/dts/exynos5420.dtsi | 72 +-
arch/arm/boot/dts/exynos5422-cpus.dtsi| 130 ++
arch/arm/boot/dts/exynos5800-peach-pi.dts | 1 +
7 files changed, 170 insertions(+), 128 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos5420-cpus.dtsi
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 4ecef6981d5c..365eec6f6687 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -11,6 +11,7 @@
/dts-v1/;
#include "exynos5420.dtsi"
+#include "exynos5420-cpus.dtsi"
#include
#include
#include
diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi
b/arch/arm/boot/dts/exynos5420-cpus.dtsi
new file mode 100644
index ..7aaf0313274f
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
@@ -0,0 +1,92 @@
+/*
+ * SAMSUNG EXYNOS5420 SoC cpu device tree source
+ *
+ * Copyright (c) 2015 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This file provides desired ordering for Exynos5420 and Exynos5800
+ * boards: CPU[0123] being the A15.
+ *
+ * The Exynos5420, 5422 and 5800 actually share the same CPU configuration
+ * but particular boards choose different booting order.
+ *
+ * Exynos5420 and Exynos5800 always boot from Cortex-A15. On Exynos5422
+ * booting cluster (big or LITTLE) is chosen by IROM code by reading
+ * the gpg2-1 GPIO. By default all Exynos5422 based boards choose booting
+ * from the LITTLE: Cortex-A7.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/ {
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpu0: cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x0>;
+ clock-frequency = <18>;
+ cci-control-port = <&cci_control1>;
+ };
+
+ cpu1: cpu@1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x1>;
+ clock-frequency = <18>;
+ cci-control-port = <&cci_control1>;
+ };
+
+ cpu2: cpu@2 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x2>;
+ clock-frequency = <18>;
+ cci-control-port = <&cci_control1>;
+ };
+
+ cpu3: cpu@3 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a15";
+ reg = <0x3>;
+ clock-frequency = <18>;
+ cci-control-port = <&cci_control1>;
+ };
+
+ cpu4: cpu@100 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x100>;
+ clock-frequency = <10>;
+ cci-control-port = <&cci_control0>;
+ };
+
+ cpu5: cpu@101 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <0x101>;
+ clock-frequency = <10>;
+ cci-control-port = <&cci_control0>;
+ };
+
+ cpu6: cpu@102 {
+
Re: [PATCH] MAINTAINERS: Add missing platform maintainers for dts files
On 11.12.2015 08:38, Rob Herring wrote: > Platform dts files need to be reviewed primarily by the platform > maintainers as dts files typically go in thru their trees. Add the missing > paths where there are existing maintainers listed. > > Signed-off-by: Rob Herring > --- > MAINTAINERS | 20 +++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 69c8a9c..415b731 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -950,6 +950,8 @@ M:Rob Herring > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > S: Maintained > F: arch/arm/mach-highbank/ > +F: arch/arm/boot/dts/highbank.dts > +F: arch/arm/boot/dts/ecx-*.dts* > > ARM/CAVIUM NETWORKS CNS3XXX MACHINE SUPPORT > M: Krzysztof Halasa > @@ -1025,6 +1027,7 @@ M: Barry Song > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > T: git git://git.kernel.org/pub/scm/linux/kernel/git/baohua/linux.git > S: Maintained > +F: arch/arm/boot/dts/prima2* > F: arch/arm/mach-prima2/ > F: drivers/clk/sirf/ > F: drivers/clocksource/timer-prima2.c > @@ -1126,6 +1129,10 @@ W: http://www.hisilicon.com > S: Supported > T: git git://github.com/hisilicon/linux-hisi.git > F: arch/arm/mach-hisi/ > +F: arch/arm/boot/dts/hi3* > +F: arch/arm/boot/dts/hip* > +F: arch/arm/boot/dts/hisi* > +F: arch/arm64/boot/dts/hisilicon/ > > ARM/HP JORNADA 7XX MACHINE SUPPORT > M: Kristoffer Ericson > @@ -1202,6 +1209,7 @@ M: Santosh Shilimkar > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > S: Maintained > F: arch/arm/mach-keystone/ > +F: arch/arm/boot/dts/k2* > T: git > git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git > > ARM/TEXAS INSTRUMENT KEYSTONE CLOCK FRAMEWORK > @@ -1270,6 +1278,7 @@ L: linux-arm-ker...@lists.infradead.org (moderated > for non-subscribers) > S: Maintained > F: arch/arm/mach-berlin/ > F: arch/arm/boot/dts/berlin* > +F: arch/arm64/boot/dts/marvell/berlin* > > > ARM/Marvell Dove/MV78xx0/Orion SOC support > @@ -1406,7 +1415,9 @@ M: David Brown > L: linux-arm-...@vger.kernel.org > L: linux-...@vger.kernel.org > S: Maintained > +F: arch/arm/boot/dts/qcom-* > F: arch/arm/mach-qcom/ > +F: arch/arm64/boot/dts/qcom/* > F: drivers/soc/qcom/ > F: drivers/tty/serial/msm_serial.h > F: drivers/tty/serial/msm_serial.c > @@ -1456,6 +1467,8 @@ L: linux-arm-ker...@lists.infradead.org (moderated > for non-subscribers) > L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > S: Maintained > F: arch/arm/boot/dts/s3c* > +F: arch/arm/boot/dts/s5p* > +F: arch/arm/boot/dts/samsung* > F: arch/arm/boot/dts/exynos* > F: arch/arm64/boot/dts/exynos/ > F: arch/arm/plat-samsung/ Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/7] ARM: dts: exynos4412-odroid*: enable MFC device
On 10.12.2015 16:44, Krzysztof Kozlowski wrote:
> On 09.12.2015 22:58, Marek Szyprowski wrote:
>> Enable support for Multimedia Codec (MFC) device for all Exynos4412-based
... and one more finding: I think the abbreviation is Multi Format Codec.
BR,
Krzysztof
>> Odroid boards.
>>
>> Signed-off-by: Marek Szyprowski
>> ---
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 24
>>
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index edf0fc8..5825abf 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -18,6 +18,24 @@
>> stdout-path = &serial_1;
>> };
>>
>> +reserved-memory {
>> +#address-cells = <1>;
>> +#size-cells = <1>;
>> +ranges;
>> +
>> +mfc_left: region@7700 {
>> +compatible = "shared-dma-pool";
>> +reusable;
>> +reg = <0x7700 0x100>;
>
> Doesn't this exceed the memory of Odroid X?
>
> For other Exynos4412 boards the length is 0x80. I am curious: any
> particular reason for the difference?
>
> Best regards,
> Krzysztof
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/7] ARM: dts: exynos4412-odroid*: enable MFC device
On 09.12.2015 22:58, Marek Szyprowski wrote:
> Enable support for Multimedia Codec (MFC) device for all Exynos4412-based
> Odroid boards.
>
> Signed-off-by: Marek Szyprowski
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 24
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index edf0fc8..5825abf 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -18,6 +18,24 @@
> stdout-path = &serial_1;
> };
>
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + mfc_left: region@7700 {
> + compatible = "shared-dma-pool";
> + reusable;
> + reg = <0x7700 0x100>;
Doesn't this exceed the memory of Odroid X?
For other Exynos4412 boards the length is 0x80. I am curious: any
particular reason for the difference?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/19] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
On 10.12.2015 16:07, Chanwoo Choi wrote:
> On 2015년 12월 10일 15:53, Krzysztof Kozlowski wrote:
>> On 10.12.2015 15:43, Chanwoo Choi wrote:
>>> On 2015년 12월 10일 15:32, Krzysztof Kozlowski wrote:
>>>> On 10.12.2015 15:08, Chanwoo Choi wrote:
>>>>> On 2015년 12월 10일 14:57, Krzysztof Kozlowski wrote:
>>>>>> On 09.12.2015 13:08, Chanwoo Choi wrote:
>>>>>>> This patch adds the bus noes using VDD_INT for Exynos4x12 SoC.
>>>>>>> Exynos4x12 has the following AXI buses to translate data between
>>>>>>> DRAM and sub-blocks.
>>>>>>>
>>>>>>> Following list specifies the detailed relation between DRAM and
>>>>>>> sub-blocks:
>>>>>>> - ACLK100 clock for PERIL/PERIR/MFC(PCLK)
>>>>>>> - ACLK160 clock for CAM/TV/LCD
>>>>>>> : The minimum clock of ACLK160 should be over 160MHz.
>>>>>>> When drop the clock under 160MHz, show the broken image.
>>>>>>> - ACLK133 clock for FSYS
>>>>>>> - GDL clock for LEFTBUS
>>>>>>> - GDR clock for RIGHTBUS
>>>>>>> - SCLK_MFC clock for MFC
>>>>>>>
>>>>>>> Signed-off-by: Chanwoo Choi
>>>>>>> ---
>>>>>>> arch/arm/boot/dts/exynos4x12.dtsi | 112
>>>>>>> ++
>>>>>>> 1 file changed, 112 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
>>>>>>> b/arch/arm/boot/dts/exynos4x12.dtsi
>>>>>>> index 3bcf0939755e..8bc4aee156b5 100644
>>>>>>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>>>>>>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>>>>>>> @@ -354,6 +354,118 @@
>>>>>>> opp-microvolt = <95>;
>>>>>>> };
>>>>>>> };
>>>>>>> +
>>>>>>> + bus_leftbus: bus_leftbus {
>>>>>>> + compatible = "samsung,exynos-bus";
>>>>>>> + clocks = <&clock CLK_DIV_GDL>;
>>>>>>> + clock-names = "bus";
>>>>>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>>>>>> + status = "disabled";
>>>>>>> + };
>>>>>>> +
>>>>>>> + bus_rightbus: bus_rightbus {
>>>>>>> + compatible = "samsung,exynos-bus";
>>>>>>> + clocks = <&clock CLK_DIV_GDR>;
>>>>>>> + clock-names = "bus";
>>>>>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>>>>>> + status = "disabled";
>>>>>>> + };
>>>>>>
>>>>>> These two nodes are symmetrical. The MFC below and other buses in other
>>>>>> DTS share opps. How about changing the binding so multiple clocks could
>>>>>> be specified at once ("bus0", "bus1")? I think there is no need for a
>>>>>> bus device for each clock.
>>>>>
>>>>> The your commented method is possible.
>>>>>
>>>>> But, I focus on implementing the generic bus frequency driver.
>>>>>
>>>>> If specific bus device-tree node includes the one more clocks,
>>>>> when adding the new Exynos SoC, the exynos-bus.c should be added
>>>>> for new Exynos SoC. Because, each Exynos SoC has the different
>>>>> set of bus device.
>>>>>
>>>>> If we use my approach, we don't need to modify the exynos-bus.c
>>>>> driver to support for the bus frequency of new Exynos SoC.
>>>>
>>>> This won't change. The driver will just support from 1 to N clocks for
>>>> given bus device and set the same OPP to all of them. This will only
>>>> limit the number of duplicated entries. This won't affect the generic
>>>> approach of driver itself.
>>>
>>> You're right aspect of only implementation of device driver.
>>>
>>> But,
>>> If we use your commented approach, we can show the information
>
Re: [PATCH v2 19/19] ARM: dts: Add support of bus frequency for exynos4412-trats/odroidu3
On 09.12.2015 13:08, Chanwoo Choi wrote:
> THis patch adds the bus device tree nodes for both MIF (Memory) and INT
> (Internal) block to enable the bus frequency.
>
> The DMC bus is parent device in MIF block using VDD_MIF and the LEFTBUS
> bus is parent device in INT block using VDD_INT.
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 47
> +
> arch/arm/boot/dts/exynos4412-trats2.dts | 47
> +
> 2 files changed, 94 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 171dea1e3e4a..12d08242a179 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -544,3 +544,50 @@
> };
> };
> };
> +
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> +&bus_acp {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_c2c {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_leftbus {
> + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> + vdd-supply = <&buck3_reg>;
> + status = "okay";
> +};
> +
> +&bus_rightbus {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_display {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_fsys {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts
> b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 40a474c4374b..aecd545803ad 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -1286,3 +1286,50 @@
> vtmu-supply = <&ldo10_reg>;
> status = "okay";
> };
> +
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> +&bus_acp {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_c2c {
> + devfreq = <&bus_dmc>;
> + status = "okay";
> +};
> +
> +&bus_leftbus {
> + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>;
> + vdd-supply = <&buck3_reg>;
> + status = "okay";
> +};
> +
> +&bus_rightbus {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_display {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_fsys {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_peri {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
> +
> +&bus_mfc {
> + devfreq = <&bus_leftbus>;
> + status = "okay";
> +};
The nodes in both files are mostly sorted alphabetically. Could you
place them in such order as well?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 18/19] ARM: dts: Expand the voltage range of buck1/3 regulator for exynos4412-odroidu3
On 09.12.2015 13:08, Chanwoo Choi wrote: > This patch expands the voltage range of buck1/3 regulator due to as following: > - MIF (Memory Interface) bus frequency needs the 9uV ~ 105uV V. > - INT (Internal) bus frequency needs 9uV ~ 100uV. 9->90 and duplicated "uV V". Maybe just: 900 - 1050 mV 900 - 1000 mV ? > > Signed-off-by: Chanwoo Choi > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > For the contents of patch: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 17/19] ARM: dts: Add support of bus frequency using VDD_INT for exynos3250-rinato
On 09.12.2015 13:08, Chanwoo Choi wrote: > This patch adds the bus device-tree node of INT (internal) block > to enable the bus frequency. The following sub-blocks share "to enable the bus frequency scaling" > the VDD_INT power source: > - LEFTBUS (parent device) > - RIGHTBUS > - PERIL > - LCD0 > - FSYS > - MCUISP / ISP > - MFC > > The LEFTBUS is parent device with devfreq ondemand governor > and the rest devices has the dependency on LEFTBUS bus. How about: "and the rest of devices depend on the LEFTBUS device." ? The patch is good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/19] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
On 10.12.2015 15:43, Chanwoo Choi wrote:
> On 2015년 12월 10일 15:32, Krzysztof Kozlowski wrote:
>> On 10.12.2015 15:08, Chanwoo Choi wrote:
>>> On 2015년 12월 10일 14:57, Krzysztof Kozlowski wrote:
>>>> On 09.12.2015 13:08, Chanwoo Choi wrote:
>>>>> This patch adds the bus noes using VDD_INT for Exynos4x12 SoC.
>>>>> Exynos4x12 has the following AXI buses to translate data between
>>>>> DRAM and sub-blocks.
>>>>>
>>>>> Following list specifies the detailed relation between DRAM and
>>>>> sub-blocks:
>>>>> - ACLK100 clock for PERIL/PERIR/MFC(PCLK)
>>>>> - ACLK160 clock for CAM/TV/LCD
>>>>> : The minimum clock of ACLK160 should be over 160MHz.
>>>>> When drop the clock under 160MHz, show the broken image.
>>>>> - ACLK133 clock for FSYS
>>>>> - GDL clock for LEFTBUS
>>>>> - GDR clock for RIGHTBUS
>>>>> - SCLK_MFC clock for MFC
>>>>>
>>>>> Signed-off-by: Chanwoo Choi
>>>>> ---
>>>>> arch/arm/boot/dts/exynos4x12.dtsi | 112
>>>>> ++
>>>>> 1 file changed, 112 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
>>>>> b/arch/arm/boot/dts/exynos4x12.dtsi
>>>>> index 3bcf0939755e..8bc4aee156b5 100644
>>>>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>>>>> @@ -354,6 +354,118 @@
>>>>> opp-microvolt = <95>;
>>>>> };
>>>>> };
>>>>> +
>>>>> + bus_leftbus: bus_leftbus {
>>>>> + compatible = "samsung,exynos-bus";
>>>>> + clocks = <&clock CLK_DIV_GDL>;
>>>>> + clock-names = "bus";
>>>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>>>> + status = "disabled";
>>>>> + };
>>>>> +
>>>>> + bus_rightbus: bus_rightbus {
>>>>> + compatible = "samsung,exynos-bus";
>>>>> + clocks = <&clock CLK_DIV_GDR>;
>>>>> + clock-names = "bus";
>>>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>>>> + status = "disabled";
>>>>> + };
>>>>
>>>> These two nodes are symmetrical. The MFC below and other buses in other
>>>> DTS share opps. How about changing the binding so multiple clocks could
>>>> be specified at once ("bus0", "bus1")? I think there is no need for a
>>>> bus device for each clock.
>>>
>>> The your commented method is possible.
>>>
>>> But, I focus on implementing the generic bus frequency driver.
>>>
>>> If specific bus device-tree node includes the one more clocks,
>>> when adding the new Exynos SoC, the exynos-bus.c should be added
>>> for new Exynos SoC. Because, each Exynos SoC has the different
>>> set of bus device.
>>>
>>> If we use my approach, we don't need to modify the exynos-bus.c
>>> driver to support for the bus frequency of new Exynos SoC.
>>
>> This won't change. The driver will just support from 1 to N clocks for
>> given bus device and set the same OPP to all of them. This will only
>> limit the number of duplicated entries. This won't affect the generic
>> approach of driver itself.
>
> You're right aspect of only implementation of device driver.
>
> But,
> If we use your commented approach, we can show the information
> of only parent device through sysfs. We cannot see the information
> of passive device. The some information includes the current
> frequency and correlation of parent device. (But, current patchset
> don' include the topology information between parent device and
> passive device. I'll do it on later patches).
>
> For example,
> We can see the following bus device through /sys/class/devfreq.
>
> drwxr-xr-x 2 root root 0 Dec 31 17:00 .
> drwxr-xr-x 44 root root 0 Dec 31 17:00 ..
> lrwxrwxrwx 1 root root 0 Dec 31 17:00 bus_display ->
> ../../devices/platform/bus_display/devfreq/bus_display
> lrwxrwxrwx 1 root root 0 Dec 31 17:00 bus_fsys ->
> ../../devices/platform/bus_fsys/devfreq/bus_fsys
> lrwxrwxrwx 1 root root 0 Dec 31 17:00 bus_leftbu
Re: [PATCH v2 16/19] ARM: dts: Add PPMU node for exynos4412-odroidu3
On 09.12.2015 13:08, Chanwoo Choi wrote:
> This patch add dt node for PPMU_{DMC0|DMC1|LEFTBUS|RIGHTBUS} for
> exynos4412-odroidu3 board. Each PPMU dt node includes one event of
> 'PPMU Count3'.
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 40
> +
> 1 file changed, 40 insertions(+)
>
The patch itself is good but now I see that it is duplicated with
Rinato, Monk and Trats2. Probably for all other Exynos4 and
one-cluster-Exynos5 boards this would be exactly the same as well.
How about making a DTSI file with common PPMU events configuration?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/19] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
On 10.12.2015 15:08, Chanwoo Choi wrote:
> On 2015년 12월 10일 14:57, Krzysztof Kozlowski wrote:
>> On 09.12.2015 13:08, Chanwoo Choi wrote:
>>> This patch adds the bus noes using VDD_INT for Exynos4x12 SoC.
>>> Exynos4x12 has the following AXI buses to translate data between
>>> DRAM and sub-blocks.
>>>
>>> Following list specifies the detailed relation between DRAM and sub-blocks:
>>> - ACLK100 clock for PERIL/PERIR/MFC(PCLK)
>>> - ACLK160 clock for CAM/TV/LCD
>>> : The minimum clock of ACLK160 should be over 160MHz.
>>> When drop the clock under 160MHz, show the broken image.
>>> - ACLK133 clock for FSYS
>>> - GDL clock for LEFTBUS
>>> - GDR clock for RIGHTBUS
>>> - SCLK_MFC clock for MFC
>>>
>>> Signed-off-by: Chanwoo Choi
>>> ---
>>> arch/arm/boot/dts/exynos4x12.dtsi | 112
>>> ++
>>> 1 file changed, 112 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
>>> b/arch/arm/boot/dts/exynos4x12.dtsi
>>> index 3bcf0939755e..8bc4aee156b5 100644
>>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>>> @@ -354,6 +354,118 @@
>>> opp-microvolt = <95>;
>>> };
>>> };
>>> +
>>> + bus_leftbus: bus_leftbus {
>>> + compatible = "samsung,exynos-bus";
>>> + clocks = <&clock CLK_DIV_GDL>;
>>> + clock-names = "bus";
>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + bus_rightbus: bus_rightbus {
>>> + compatible = "samsung,exynos-bus";
>>> + clocks = <&clock CLK_DIV_GDR>;
>>> + clock-names = "bus";
>>> + operating-points-v2 = <&bus_leftbus_opp_table>;
>>> + status = "disabled";
>>> + };
>>
>> These two nodes are symmetrical. The MFC below and other buses in other
>> DTS share opps. How about changing the binding so multiple clocks could
>> be specified at once ("bus0", "bus1")? I think there is no need for a
>> bus device for each clock.
>
> The your commented method is possible.
>
> But, I focus on implementing the generic bus frequency driver.
>
> If specific bus device-tree node includes the one more clocks,
> when adding the new Exynos SoC, the exynos-bus.c should be added
> for new Exynos SoC. Because, each Exynos SoC has the different
> set of bus device.
>
> If we use my approach, we don't need to modify the exynos-bus.c
> driver to support for the bus frequency of new Exynos SoC.
This won't change. The driver will just support from 1 to N clocks for
given bus device and set the same OPP to all of them. This will only
limit the number of duplicated entries. This won't affect the generic
approach of driver itself.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 14/19] ARM: dts: Add bus nodes using VDD_INT for Exynos4x12
On 09.12.2015 13:08, Chanwoo Choi wrote:
> This patch adds the bus noes using VDD_INT for Exynos4x12 SoC.
> Exynos4x12 has the following AXI buses to translate data between
> DRAM and sub-blocks.
>
> Following list specifies the detailed relation between DRAM and sub-blocks:
> - ACLK100 clock for PERIL/PERIR/MFC(PCLK)
> - ACLK160 clock for CAM/TV/LCD
> : The minimum clock of ACLK160 should be over 160MHz.
> When drop the clock under 160MHz, show the broken image.
> - ACLK133 clock for FSYS
> - GDL clock for LEFTBUS
> - GDR clock for RIGHTBUS
> - SCLK_MFC clock for MFC
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 112
> ++
> 1 file changed, 112 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi
> index 3bcf0939755e..8bc4aee156b5 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -354,6 +354,118 @@
> opp-microvolt = <95>;
> };
> };
> +
> + bus_leftbus: bus_leftbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_GDL>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_rightbus: bus_rightbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_GDR>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
These two nodes are symmetrical. The MFC below and other buses in other
DTS share opps. How about changing the binding so multiple clocks could
be specified at once ("bus0", "bus1")? I think there is no need for a
bus device for each clock.
Best regards,
Krzysztof
> +
> + bus_display: bus_display {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_ACLK160>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_display_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_fsys: bus_fsys {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_ACLK133>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_fsys_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_peri: bus_peri {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_ACLK100>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_peri_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_mfc: bus_mfc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_SCLK_MFC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_leftbus_opp_table: opp_table3 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <925000>;
> + };
> + opp02 {
> + opp-hz = /bits/ 64 <16000>;
> + opp-microvolt = <95>;
> + };
> + opp03 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <100>;
> + };
> + };
> +
> + bus_display_opp_table: opp_table4 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <16000>;
> + opp-microvolt = <95>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <100>;
> + };
> + };
> +
> + bus_fsys_opp_table: opp_table5 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <925000>;
> + };
> + };
> +
> + bus_peri_opp_table: opp_table6 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <5000>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <1>;
Re: [PATCH v2 13/19] ARM: dts: Add bus nodes using VDD_MIF for Exynos4x12
On 09.12.2015 13:08, Chanwoo Choi wrote:
> This patch adds the bus noes using VDD_MIF for Exynos4x12 SoC.
s/noes/nodes/
> Exynos4x12 has the following AXI buses to translate data
> between DRAM and DMC/ACP/C2C.
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 72
> +++
> 1 file changed, 72 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi
> index b77dac61ffb5..3bcf0939755e 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -282,6 +282,78 @@
> clocks = <&clock CLK_SMMU_LITE1>, <&clock CLK_FIMC_LITE1>;
> #iommu-cells = <0>;
> };
> +
> + bus_dmc: bus_dmc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_DMC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_acp: bus_acp {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_ACP>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_acp_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_c2c: bus_c2c {
> + compatible = "samsung,exynos-bus";
> + clocks = <&clock CLK_DIV_C2C>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_dmc_opp_table: opp_table1 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <90>;
> + };
> + opp02 {
> + opp-hz = /bits/ 64 <16000>;
> + opp-microvolt = <90>;
> + };
> + opp03 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <95>;
The exyno4_bus.c (from mainline) uses 267 MHz here. Why choosing 200 MHz?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 03/19] ARM: dts: Add DMC bus node for Exynos3250
On 10.12.2015 11:17, Chanwoo Choi wrote:
> On 2015년 12월 10일 11:04, Krzysztof Kozlowski wrote:
>> On 10.12.2015 11:00, Chanwoo Choi wrote:
>>> On 2015년 12월 10일 10:20, Krzysztof Kozlowski wrote:
>>>> On 10.12.2015 10:09, Chanwoo Choi wrote:
>>>>> On 2015년 12월 10일 09:44, Krzysztof Kozlowski wrote:
>>>>>> On 09.12.2015 13:07, Chanwoo Choi wrote:
>>>>>>> This patch adds the DMC (Dynamic Memory Controller) bus node for
>>>>>>> Exynos3250 SoC.
>>>>>>> The DMC is an AMBA AXI-compliant slave to interface external JEDEC
>>>>>>> standard
>>>>>>> SDRAM devices. The bus includes the OPP tables and the source clock for
>>>>>>> DMC
>>>>>>> block.
>>>>>>>
>>>>>>> Following list specifies the detailed relation between the clock and
>>>>>>> DMC block:
>>>>>>> - The source clock of DMC block : div_dmc
>>>>>>>
>>>>>>> Signed-off-by: Chanwoo Choi
>>>>>>> ---
>>>>>>> arch/arm/boot/dts/exynos3250.dtsi | 34
>>>>>>> ++
>>>>>>> 1 file changed, 34 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>>>>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>>>>>> index 2f30d632f1cc..7214c5e42150 100644
>>>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>>>>>> @@ -687,6 +687,40 @@
>>>>>>> clock-names = "ppmu";
>>>>>>> status = "disabled";
>>>>>>> };
>>>>>>> +
>>>>>>> + bus_dmc: bus_dmc {
>>>>>>> + compatible = "samsung,exynos-bus";
>>>>>>> + clocks = <&cmu_dmc CLK_DIV_DMC>;
>>>>>>> + clock-names = "bus";
>>>>>>> + operating-points-v2 = <&bus_dmc_opp_table>;
>>>>>>> + status = "disabled";
>>>>>>> + };
>>>>>>> +
>>>>>>> + bus_dmc_opp_table: opp_table1 {
>>>>>>
>>>>>> This is the firsy opp_table, right? So:
>>>>>> s/opp_table1/opp_table0/
>>>>>
>>>>> Right. It is first opp_table in exynos3250.dtsi.
>>>>> But, I'm considering the OPP table of CPU freqeuncy as opp_table0.
>>>>> So, I have the plan that support the operation-points-v2 for Exynos3250
>>>>> CPU.
>>>>
>>>> Ok
>>>>
>>>>>
>>>>>>
>>>>>>> + compatible = "operating-points-v2";
>>>>>>> + opp-shared;
>>>>>>> +
>>>>>>> + opp00 {
>>>>>>> + opp-hz = /bits/ 64 <5000>;
>>>>>>> + opp-microvolt = <80>;
>>>>>>> + };
>>>>>>> + opp01 {
>>>>>>> + opp-hz = /bits/ 64 <1>;
>>>>>>> + opp-microvolt = <80>;
>>>>>>> + };
>>>>>>> + opp02 {
>>>>>>> + opp-hz = /bits/ 64 <13400>;
>>>>>>> + opp-microvolt = <80>;
>>>>>>
>>>>>> Why 134, not 133 MHz?
>>>>>
>>>>> When I used the 13300, the source clock is changed to 100Mhz instead
>>>>> of 133MHz.
>>>>> I add following test result on exynos3250-rinato board.
>>>>>
>>>>> Case1.
>>>>> When I use the 134 MHz, the source clock is changed to 133MHz
>>>>> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13400)
>>>>> (real: 13334)
>>>>>
>>>>> Case2.
>>>>> When I use the 133 MHz, the source clock is changed to 100MHz
>>>>> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13300)
>>>>> (real: 1)
>>>>
>>>> Now I remember that issue. You could use here directly 13334 but
>>>> that also would look a little bit weird... so 134 is ok for me. Could
>>>> just add a comment that desired frequency is actually "133 MHz"?
>>>
>>> Do you prefer among following example?
>>>
>>> Example1.
>>> opp02 {
>>> /* The desired frequency is 133MHz because
>>> * clock change has the dependency on clock driver.
>>> * When set rate as 134MHz, the clock driver would
>>> * change the 133MHz actually instead of 134MHz.
>>> */
>>> opp-hz = /bits/ 64 <13400>;
>>> opp-microvolt = <80>;
>>> };
>>>
>>> Example2.
>>> opp02 {
>>> opp-hz = /bits/ 64 <13334>;
>>> opp-microvolt = <80>;
>>> };
>>
>> I would prefer the second one (13334) but I don't have strong
>> feelings about it.
>
> If you ok, I want to maintain the original approach as following:
>
> opp02 {
> opp-hz = /bits/ 64 <13400>;
> opp-microvolt = <80>;
> };
OK
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 12/19] ARM: dts: Add bus nodes using VDD_INT for Exynos3250
On 09.12.2015 13:08, Chanwoo Choi wrote:
> This patch adds the bus nodes using VDD_INT for Exynos3250 SoC.
> Exynos3250 has following AXI buses to translate data between
> DRAM and sub-blocks.
>
> Following list specifies the detailed relation between DRAM and sub-blocks:
> - ACLK400 clock for MCUISP
> - ACLK266 clock for ISP
> - ACLK200 clock for FSYS
> - ACLK160 clock for LCD0
> - ACLK100 clock for PERIL
> - GDL clock for LEFTBUS
> - GDR clock for RIGHTBUS
> - SCLK_MFC clock for MFC
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 160
> ++
> 1 file changed, 160 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 7214c5e42150..46dee1951ec1 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -721,6 +721,166 @@
> opp-microvolt = <875000>;
> };
> };
> +
> + bus_leftbus: bus_leftbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_GDL>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_rightbus: bus_rightbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_GDR>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_lcd0: bus_lcd0 {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_ACLK_160>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_fsys: bus_fsys {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_ACLK_200>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_mcuisp: bus_mcuisp {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_ACLK_400_MCUISP>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_mcuisp_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_isp: bus_isp {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_ACLK_266>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_isp_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_peril: bus_peril {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_ACLK_100>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_peril_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_mfc: bus_mfc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_SCLK_MFC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_leftbus_opp_table: opp_table2 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <5000>;
> + opp-microvolt = <90>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <8000>;
> + opp-microvolt = <90>;
> + };
> + opp02 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <100>;
> + };
> + opp03 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <100>;
> + };
> + opp04 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <100>;
> + };
> + };
> +
> + bus_mcuisp_opp_table: opp_table3 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> +
Re: [PATCH v2 03/19] ARM: dts: Add DMC bus node for Exynos3250
On 10.12.2015 11:00, Chanwoo Choi wrote:
> On 2015년 12월 10일 10:20, Krzysztof Kozlowski wrote:
>> On 10.12.2015 10:09, Chanwoo Choi wrote:
>>> On 2015년 12월 10일 09:44, Krzysztof Kozlowski wrote:
>>>> On 09.12.2015 13:07, Chanwoo Choi wrote:
>>>>> This patch adds the DMC (Dynamic Memory Controller) bus node for
>>>>> Exynos3250 SoC.
>>>>> The DMC is an AMBA AXI-compliant slave to interface external JEDEC
>>>>> standard
>>>>> SDRAM devices. The bus includes the OPP tables and the source clock for
>>>>> DMC
>>>>> block.
>>>>>
>>>>> Following list specifies the detailed relation between the clock and DMC
>>>>> block:
>>>>> - The source clock of DMC block : div_dmc
>>>>>
>>>>> Signed-off-by: Chanwoo Choi
>>>>> ---
>>>>> arch/arm/boot/dts/exynos3250.dtsi | 34 ++
>>>>> 1 file changed, 34 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> index 2f30d632f1cc..7214c5e42150 100644
>>>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>>>> @@ -687,6 +687,40 @@
>>>>> clock-names = "ppmu";
>>>>> status = "disabled";
>>>>> };
>>>>> +
>>>>> + bus_dmc: bus_dmc {
>>>>> + compatible = "samsung,exynos-bus";
>>>>> + clocks = <&cmu_dmc CLK_DIV_DMC>;
>>>>> + clock-names = "bus";
>>>>> + operating-points-v2 = <&bus_dmc_opp_table>;
>>>>> + status = "disabled";
>>>>> + };
>>>>> +
>>>>> + bus_dmc_opp_table: opp_table1 {
>>>>
>>>> This is the firsy opp_table, right? So:
>>>> s/opp_table1/opp_table0/
>>>
>>> Right. It is first opp_table in exynos3250.dtsi.
>>> But, I'm considering the OPP table of CPU freqeuncy as opp_table0.
>>> So, I have the plan that support the operation-points-v2 for Exynos3250 CPU.
>>
>> Ok
>>
>>>
>>>>
>>>>> + compatible = "operating-points-v2";
>>>>> + opp-shared;
>>>>> +
>>>>> + opp00 {
>>>>> + opp-hz = /bits/ 64 <5000>;
>>>>> + opp-microvolt = <80>;
>>>>> + };
>>>>> + opp01 {
>>>>> + opp-hz = /bits/ 64 <1>;
>>>>> + opp-microvolt = <80>;
>>>>> + };
>>>>> + opp02 {
>>>>> + opp-hz = /bits/ 64 <13400>;
>>>>> + opp-microvolt = <80>;
>>>>
>>>> Why 134, not 133 MHz?
>>>
>>> When I used the 13300, the source clock is changed to 100Mhz instead of
>>> 133MHz.
>>> I add following test result on exynos3250-rinato board.
>>>
>>> Case1.
>>> When I use the 134 MHz, the source clock is changed to 133MHz
>>> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13400)
>>> (real: 13334)
>>>
>>> Case2.
>>> When I use the 133 MHz, the source clock is changed to 100MHz
>>> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13300)
>>> (real: 1)
>>
>> Now I remember that issue. You could use here directly 13334 but
>> that also would look a little bit weird... so 134 is ok for me. Could
>> just add a comment that desired frequency is actually "133 MHz"?
>
> Do you prefer among following example?
>
> Example1.
> opp02 {
> /* The desired frequency is 133MHz because
>* clock change has the dependency on clock driver.
>* When set rate as 134MHz, the clock driver would
>* change the 133MHz actually instead of 134MHz.
>*/
> opp-hz = /bits/ 64 <13400>;
> opp-microvolt = <80>;
> };
>
> Example2.
> opp02 {
> opp-hz = /bits/ 64 <13334>;
> opp-microvolt = <80>;
> };
I would prefer the second one (13334) but I don't have strong
feelings about it.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 09/19] PM / devfreq: exynos: Update documentation for bus devices using passive governor
On 09.12.2015 13:08, Chanwoo Choi wrote:
> This patch updates the documentation for passive bus devices and adds the
> detailed example of Exynos3250.
>
> Signed-off-by: Chanwoo Choi
> ---
> .../devicetree/bindings/devfreq/exynos-bus.txt | 244
> -
> 1 file changed, 241 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> index 54a1f9c46c88..c4fdc70f8eac 100644
> --- a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> @@ -13,18 +13,23 @@ SoC has the different sub-blocks. So, this difference
> should be specified
> in devicetree file instead of each device driver. In result, this driver
> is able to support the bus frequency for all Exynos SoCs.
>
> -Required properties for bus device:
> +Required properties for all bus devices:
> - compatible: Should be "samsung,exynos-bus".
> - clock-names : the name of clock used by the bus, "bus".
> - clocks : phandles for clock specified in "clock-names" property.
> - #clock-cells: should be 1.
> - operating-points-v2: the OPP table including frequency/voltage information
>to support DVFS (Dynamic Voltage/Frequency Scaling) feature.
> +
> +Required properties for only parent bus device:
Maybe:
"Required properties only for parent bus devices:"
In this binding documentation file the idea of "parent" is not
explained. I now it is related to passive devfreq governor but looking
at the binding itself it is a new idea, not covered here.
> - vdd-supply: the regulator to provide the buses with the voltage.
> - devfreq-events: the devfreq-event device to monitor the curret utilization
>of buses.
>
> -Optional properties for bus device:
> +Required properties for only passive bus device:
"Required properties only for passive bus devices:"
> +- devfreq: the parent bus device.
> +
> +Optional properties for only parent bus device:
> - exynos,saturation-ratio: the percentage value which is used to calibrate
> the performance count againt total cycle count.
>
> @@ -33,7 +38,20 @@ Example1:
> power line (regulator). The MIF (Memory Interface) AXI bus is used to
> transfer data between DRAM and CPU and uses the VDD_MIF regualtor.
>
> - - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block
> + - MIF (Memory Interface) block
> + : VDD_MIF |--- DMC (Dynamic Memory Controller)
> +
> + - INT (Internal) block
> + : VDD_INT |--- LEFTBUS (parent device)
> + |--- PERIL
> + |--- MFC
> + |--- G3D
> + |--- RIGHTBUS
> + |--- FSYS
> + |--- LCD0
> + |--- PERIR
> + |--- ISP
> + |--- CAM
>
> - MIF bus's frequency/voltage table
> ---
> @@ -46,6 +64,24 @@ Example1:
> |L5| 40 |875000 |
> ---
>
> + - INT bus's frequency/voltage table
> + --
> + |Block|LEFTBUS|RIGHTBUS|MCUISP |ISP|PERIL ||VDD_INT |
> + | name| |LCD0| | | |||
> + | | |FSYS| | | |||
> + | | |MFC | | | |||
> + --
> + |Mode |*parent|passive |passive|passive|passive|||
> + --
> + |Lv |Frequency ||Voltage |
> + --
> + |L1 |5 |5 |5 |5 |5 ||90 |
> + |L2 |8 |8 |8 |8 |8 ||90 |
> + |L3 |10 |10 |10 |10 |10 ||100 |
> + |L4 |134000 |134000 |20 |20 | ||100 |
> + |L5 |20 |20 |40 |30 | ||100 |
> + --
> +
> Example2 :
> The bus of DMC (Dynamic Memory Controller) block in exynos3250.dtsi
> are listed below:
> @@ -84,6 +120,167 @@ Example2 :
> };
> };
>
> + bus_leftbus: bus_leftbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_GDL>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_rightbus: bus_rightbus {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu CLK_DIV_GDR>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_leftbus_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_lcd0: bus_lcd0 {
> + compatible = "sams
Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
On 10.12.2015 09:49, Chanwoo Choi wrote:
> Hi,
>
(...)
>>
>>> +
>>> + bus_dmc: bus_dmc {
>>> + compatible = "samsung,exynos-bus";
>>> + clocks = <&cmu_dmc CLK_DIV_DMC>;
>>> + clock-names = "bus";
>>> + operating-points-v2 = <&bus_dmc_opp_table>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + bus_dmc_opp_table: opp_table0 {
>>> + compatible = "operating-points-v2";
>>> + opp-shared;
>>> +
>>> + opp00 {
>>
>> Maybe use convention with frequency, like:
>> opp@5000
>> This also used in opp.txt examples.
>
> In the Documentations/devicetree/bindings/opp/opp.txt,
> the example uses the 'opp@0x'. I check the opp.txt of Linux 4.4-rc4.
Yes, it was changed by Viresh in "PM / OPP: Rename OPP nodes as
opp@". You can find the most actual bindings in linux-next.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency driver and new passive governor
On 10.12.2015 09:57, Krzysztof Kozlowski wrote: > On 09.12.2015 13:07, Chanwoo Choi wrote: > > (...) > >> .../devicetree/bindings/devfreq/exynos-bus.txt | 383 +++ > > How about adding this file to the MAINTAINERS to devfreq exynos entry? > Unfortunately, in current linux-next, I can find the entry for devfreq D'oh! I meant:^ I cannot find the entry for... BR, Krzysztof > exynos. However I saw patches adding such entries... aren't they merged > to linux-next? > > Best regards, > Krzysztof > >> arch/arm/boot/dts/exynos3250-monk.dts |6 + >> arch/arm/boot/dts/exynos3250-rinato.dts| 47 + >> arch/arm/boot/dts/exynos3250.dtsi | 194 >> arch/arm/boot/dts/exynos4210.dtsi | 172 >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi| 93 +- >> arch/arm/boot/dts/exynos4412-trats2.dts| 47 + >> arch/arm/boot/dts/exynos4x12.dtsi | 184 >> drivers/devfreq/Kconfig| 37 +- >> drivers/devfreq/Makefile |2 + >> drivers/devfreq/devfreq.c | 120 ++- >> drivers/devfreq/exynos/Makefile|3 +- >> drivers/devfreq/exynos/exynos-bus.c| 549 ++ >> drivers/devfreq/exynos/exynos4_bus.c | 1055 >> >> drivers/devfreq/exynos/exynos4_bus.h | 110 -- >> drivers/devfreq/exynos/exynos5_bus.c | 431 >> drivers/devfreq/exynos/exynos_ppmu.c | 119 --- >> drivers/devfreq/exynos/exynos_ppmu.h | 86 -- >> drivers/devfreq/governor.h |7 + >> drivers/devfreq/governor_passive.c | 109 ++ >> drivers/devfreq/governor_performance.c |1 + >> drivers/devfreq/governor_powersave.c |1 + >> drivers/devfreq/governor_simpleondemand.c |1 + >> drivers/devfreq/governor_userspace.c |1 + >> include/linux/devfreq.h| 28 + >> 25 files changed, 1958 insertions(+), 1828 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt >> create mode 100644 drivers/devfreq/exynos/exynos-bus.c >> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c >> delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h >> delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c >> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c >> delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h >> create mode 100644 drivers/devfreq/governor_passive.c >> > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 03/19] ARM: dts: Add DMC bus node for Exynos3250
On 10.12.2015 10:09, Chanwoo Choi wrote:
> On 2015년 12월 10일 09:44, Krzysztof Kozlowski wrote:
>> On 09.12.2015 13:07, Chanwoo Choi wrote:
>>> This patch adds the DMC (Dynamic Memory Controller) bus node for Exynos3250
>>> SoC.
>>> The DMC is an AMBA AXI-compliant slave to interface external JEDEC standard
>>> SDRAM devices. The bus includes the OPP tables and the source clock for DMC
>>> block.
>>>
>>> Following list specifies the detailed relation between the clock and DMC
>>> block:
>>> - The source clock of DMC block : div_dmc
>>>
>>> Signed-off-by: Chanwoo Choi
>>> ---
>>> arch/arm/boot/dts/exynos3250.dtsi | 34 ++
>>> 1 file changed, 34 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>>> b/arch/arm/boot/dts/exynos3250.dtsi
>>> index 2f30d632f1cc..7214c5e42150 100644
>>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>>> @@ -687,6 +687,40 @@
>>> clock-names = "ppmu";
>>> status = "disabled";
>>> };
>>> +
>>> + bus_dmc: bus_dmc {
>>> + compatible = "samsung,exynos-bus";
>>> + clocks = <&cmu_dmc CLK_DIV_DMC>;
>>> + clock-names = "bus";
>>> + operating-points-v2 = <&bus_dmc_opp_table>;
>>> + status = "disabled";
>>> + };
>>> +
>>> + bus_dmc_opp_table: opp_table1 {
>>
>> This is the firsy opp_table, right? So:
>> s/opp_table1/opp_table0/
>
> Right. It is first opp_table in exynos3250.dtsi.
> But, I'm considering the OPP table of CPU freqeuncy as opp_table0.
> So, I have the plan that support the operation-points-v2 for Exynos3250 CPU.
Ok
>
>>
>>> + compatible = "operating-points-v2";
>>> + opp-shared;
>>> +
>>> + opp00 {
>>> + opp-hz = /bits/ 64 <5000>;
>>> + opp-microvolt = <80>;
>>> + };
>>> + opp01 {
>>> + opp-hz = /bits/ 64 <1>;
>>> + opp-microvolt = <80>;
>>> + };
>>> + opp02 {
>>> + opp-hz = /bits/ 64 <13400>;
>>> + opp-microvolt = <80>;
>>
>> Why 134, not 133 MHz?
>
> When I used the 13300, the source clock is changed to 100Mhz instead of
> 133MHz.
> I add following test result on exynos3250-rinato board.
>
> Case1.
> When I use the 134 MHz, the source clock is changed to 133MHz
> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13400) (real:
> 13334)
>
> Case2.
> When I use the 133 MHz, the source clock is changed to 100MHz
> : exynos-bus soc:bus_dmc: old_freq(2) -> new_freq (13300) (real:
> 1)
Now I remember that issue. You could use here directly 13334 but
that also would look a little bit weird... so 134 is ok for me. Could
just add a comment that desired frequency is actually "133 MHz"?
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/19] PM / devferq: Add generic exynos bus frequency driver and new passive governor
On 09.12.2015 13:07, Chanwoo Choi wrote: (...) > .../devicetree/bindings/devfreq/exynos-bus.txt | 383 +++ How about adding this file to the MAINTAINERS to devfreq exynos entry? Unfortunately, in current linux-next, I can find the entry for devfreq exynos. However I saw patches adding such entries... aren't they merged to linux-next? Best regards, Krzysztof > arch/arm/boot/dts/exynos3250-monk.dts |6 + > arch/arm/boot/dts/exynos3250-rinato.dts| 47 + > arch/arm/boot/dts/exynos3250.dtsi | 194 > arch/arm/boot/dts/exynos4210.dtsi | 172 > arch/arm/boot/dts/exynos4412-odroid-common.dtsi| 93 +- > arch/arm/boot/dts/exynos4412-trats2.dts| 47 + > arch/arm/boot/dts/exynos4x12.dtsi | 184 > drivers/devfreq/Kconfig| 37 +- > drivers/devfreq/Makefile |2 + > drivers/devfreq/devfreq.c | 120 ++- > drivers/devfreq/exynos/Makefile|3 +- > drivers/devfreq/exynos/exynos-bus.c| 549 ++ > drivers/devfreq/exynos/exynos4_bus.c | 1055 > > drivers/devfreq/exynos/exynos4_bus.h | 110 -- > drivers/devfreq/exynos/exynos5_bus.c | 431 > drivers/devfreq/exynos/exynos_ppmu.c | 119 --- > drivers/devfreq/exynos/exynos_ppmu.h | 86 -- > drivers/devfreq/governor.h |7 + > drivers/devfreq/governor_passive.c | 109 ++ > drivers/devfreq/governor_performance.c |1 + > drivers/devfreq/governor_powersave.c |1 + > drivers/devfreq/governor_simpleondemand.c |1 + > drivers/devfreq/governor_userspace.c |1 + > include/linux/devfreq.h| 28 + > 25 files changed, 1958 insertions(+), 1828 deletions(-) > create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt > create mode 100644 drivers/devfreq/exynos/exynos-bus.c > delete mode 100644 drivers/devfreq/exynos/exynos4_bus.c > delete mode 100644 drivers/devfreq/exynos/exynos4_bus.h > delete mode 100644 drivers/devfreq/exynos/exynos5_bus.c > delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.c > delete mode 100644 drivers/devfreq/exynos/exynos_ppmu.h > create mode 100644 drivers/devfreq/governor_passive.c > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 04/19] ARM: dts: Add DMC bus frequency for exynos3250-rinato/monk
On 09.12.2015 13:07, Chanwoo Choi wrote:
> This patch adds the DMC (Dynamic Memory Controller) bus frequency node
> which includes the devfreq-events and regulator properties. The bus
> frequency support the DVFS (Dynamic Voltage Frequency Scaling) feature
> with ondemand governor.
>
> The devfreq-events (ppmu_dmc0*) can monitor the utilization of DMC bus
> on runtime and the buck1_reg (VDD_MIF power line) supplies the power to
> the DMC block.
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 6 ++
> arch/arm/boot/dts/exynos3250-rinato.dts | 6 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts
> b/arch/arm/boot/dts/exynos3250-monk.dts
> index 443a35085846..d982586a6533 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -498,6 +498,12 @@
> };
> };
>
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
> +
> &xusbxti {
> clock-frequency = <2400>;
> };
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts
> b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 3e64d5dcdd60..61477943015b 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -675,6 +675,12 @@
> };
> };
>
> +&bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>;
> + status = "okay";
> +};
I would prefer to put this in alphabetical order... which could be
tricky because the nodes are not entirely sorted. Maybe after the "&adc"
node?
Anyway the change looks good:
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 03/19] ARM: dts: Add DMC bus node for Exynos3250
On 09.12.2015 13:07, Chanwoo Choi wrote:
> This patch adds the DMC (Dynamic Memory Controller) bus node for Exynos3250
> SoC.
> The DMC is an AMBA AXI-compliant slave to interface external JEDEC standard
> SDRAM devices. The bus includes the OPP tables and the source clock for DMC
> block.
>
> Following list specifies the detailed relation between the clock and DMC
> block:
> - The source clock of DMC block : div_dmc
>
> Signed-off-by: Chanwoo Choi
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 34 ++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
> b/arch/arm/boot/dts/exynos3250.dtsi
> index 2f30d632f1cc..7214c5e42150 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -687,6 +687,40 @@
> clock-names = "ppmu";
> status = "disabled";
> };
> +
> + bus_dmc: bus_dmc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu_dmc CLK_DIV_DMC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_dmc_opp_table: opp_table1 {
This is the firsy opp_table, right? So:
s/opp_table1/opp_table0/
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
> + opp-hz = /bits/ 64 <5000>;
> + opp-microvolt = <80>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <80>;
> + };
> + opp02 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <80>;
Why 134, not 133 MHz?
> + };
> + opp03 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <80>;
Shouldn't this be 825 mV, not 800? I think we used previously that value
for our devices.
Best regards,
Krzysztof
> + };
> + opp04 {
> + opp-hz = /bits/ 64 <4>;
> + opp-microvolt = <875000>;
> + };
> + };
> };
> };
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 02/19] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver
On 09.12.2015 13:07, Chanwoo Choi wrote:
> This patch adds the documentation for generic exynos bus frequency
> driver.
>
> Signed-off-by: Chanwoo Choi
> ---
> .../devicetree/bindings/devfreq/exynos-bus.txt | 94
> ++
> 1 file changed, 94 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> new file mode 100644
> index ..54a1f9c46c88
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/exynos-bus.txt
> @@ -0,0 +1,94 @@
> +* Generic Exynos Bus frequency device
> +
> +The Samsung Exynos SoC have many buses for data transfer between DRAM
> +and sub-blocks in SoC. Almost Exynos SoC have the common architecture
> +for buses. Generally, the each bus of Exynos SoC includes the source clock
> +and power line and then is able to change the clock according to the usage
> +of each buses on runtime. When gathering the usage of each buses on runtime,
> +thie driver uses the PPMU (Platform Performance Monitoring Unit) which
s/thie/the/
> +is able to measure the current load of sub-blocks.
> +
> +There are a little different composition among Exynos SoC because each Exynos
> +SoC has the different sub-blocks. So, this difference should be specified
> +in devicetree file instead of each device driver. In result, this driver
> +is able to support the bus frequency for all Exynos SoCs.
> +
> +Required properties for bus device:
> +- compatible: Should be "samsung,exynos-bus".
> +- clock-names : the name of clock used by the bus, "bus".
> +- clocks : phandles for clock specified in "clock-names" property.
> +- #clock-cells: should be 1.
This is a clock consumer, right? So the clock-cells is not valid here.
> +- operating-points-v2: the OPP table including frequency/voltage information
> + to support DVFS (Dynamic Voltage/Frequency Scaling) feature.
> +- vdd-supply: the regulator to provide the buses with the voltage.
> +- devfreq-events: the devfreq-event device to monitor the curret utilization
s/curret/current/
> + of buses.
> +
> +Optional properties for bus device:
> +- exynos,saturation-ratio: the percentage value which is used to calibrate
> + the performance count againt total cycle count.
s/againt/against/
> +
> +Example1:
> + Show the AXI buses of Exynos3250 SoC. Exynos3250 divides the buses to
> + power line (regulator). The MIF (Memory Interface) AXI bus is used to
> + transfer data between DRAM and CPU and uses the VDD_MIF regualtor.
> +
> + - power line(VDD_MIF) --> bus for DMC (Dynamic Memory Controller) block
> +
> + - MIF bus's frequency/voltage table
> + ---
> + |Lv| Freq | Voltage |
> + ---
> + |L1| 5 |80 |
> + |L2| 10 |80 |
> + |L3| 134000 |80 |
> + |L4| 20 |80 |
> + |L5| 40 |875000 |
> + ---
> +
> +Example2 :
> + The bus of DMC (Dynamic Memory Controller) block in exynos3250.dtsi
> + are listed below:
s/are/is/ (one bus is listed)
> +
> + bus_dmc: bus_dmc {
> + compatible = "samsung,exynos-bus";
> + clocks = <&cmu_dmc CLK_DIV_DMC>;
> + clock-names = "bus";
> + operating-points-v2 = <&bus_dmc_opp_table>;
> + status = "disabled";
> + };
> +
> + bus_dmc_opp_table: opp_table0 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp00 {
Maybe use convention with frequency, like:
opp@5000
This also used in opp.txt examples.
> + opp-hz = /bits/ 64 <5000>;
> + opp-microvolt = <80>;
> + };
> + opp01 {
> + opp-hz = /bits/ 64 <1>;
> + opp-microvolt = <80>;
> + };
> + opp02 {
> + opp-hz = /bits/ 64 <13400>;
> + opp-microvolt = <80>;
> + };
> + opp03 {
> + opp-hz = /bits/ 64 <2>;
> + opp-microvolt = <80>;
> + };
> + opp04 {
> + opp-hz = /bits/ 64 <4>;
> + opp-microvolt = <875000>;
> + };
> + };
> +
> + Usage case to handle the frequency and voltage of bus on runtime
> + in exynos3250-rinato.dts are listed below:
s/are/is/
> +
> + &bus_dmc {
> + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>;
> + vdd-supply = <&buck1_reg>; /* VDD_MIF */
> + status = "okay";
> + };
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-in
Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi
On 08.12.2015 10:33, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 12/07/2015 09:45 PM, Krzysztof Kozlowski wrote: >> On 07.12.2015 21:52, Inki Dae wrote: >>> From: Javier Martinez Canillas >>> >>> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent >>> since it uses a phandle to describe the connection between the DP port and >>> the display panel but uses the OF graph ports and endpoints to describe the >>> connection betwen the DP port, a bridge chip and the panel. >>> >>> The Exynos DP driver and the DT binding have been changed to allow also to >>> describe the DP port to panel connection using ports / endpoints (OF graph) >>> so this patch changes the Exynos5800 Peach Pi DT to make it consistent with >>> the Exynos5420 Peach Pit that has a eDP to LVDS chip and uses OF graph too. >>> >>> Signed-off-by: Javier Martinez Canillas >>> Tested-by: Javier Martinez Canillas >>> Reviewed-by: Inki Dae >>> --- >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >> >> Looks sensible: >> Reviewed-by: Krzysztof Kozlowski >> >> Dependencies are not mentioned, does it depend on patch 1? >> > > Yes, it depends on patch 1/4 so it should be merged through the Exynos DRM > tree to maintain bisectability. Inki's patch maintains the DT ABI backward > compatibility though so another option is to wait until the DRM change hit > mainline and then pick $SUBJECT. Thanks. We could also use a tag with DRM changes for samsung-soc but since I already flushed my queue for v4.5 I think it would be an overkill. From my point of view it can safely go through exynos-drm tree. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi
On 08.12.2015 00:36, Inki Dae wrote: > Hi Javier, > > 2015-12-07 22:41 GMT+09:00 Javier Martinez Canillas : >> Hello Inki, >> >> On 12/07/2015 09:52 AM, Inki Dae wrote: >>> From: Javier Martinez Canillas >>> >> >> Thanks a lot for posting this patch. >> >>> The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent >>> since it uses a phandle to describe the connection between the DP port and >>> the display panel but uses the OF graph ports and endpoints to describe the >>> connection betwen the DP port, a bridge chip and the panel. >>> >>> The Exynos DP driver and the DT binding have been changed to allow also to >>> describe the DP port to panel connection using ports / endpoints (OF graph) >>> so this patch changes the Exynos5800 Peach Pi DT to make it consistent with >>> the Exynos5420 Peach Pit that has a eDP to LVDS chip and uses OF graph too. >>> >>> Signed-off-by: Javier Martinez Canillas >>> Tested-by: Javier Martinez Canillas >> >> This tag was not in my original patch, it's true that I tested >> it but will someone believe me? ;) > > Oops. I confused you spread Reviewed-by and Tested-by here and there. > Don't worry about that. Will remove it if you don't give me Tested-by. > :) Actually authorship (the "From") in this case means Tested-by. Author always tests the patch so it would look weird if we start adding tested-by to our own patches, right? Dear Inki, However the patch misses your SoB. You touched and sent it so please extend the SoB chain-of-blame. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/4] ARM: dts: Use OF graph for DP to panel connection in exynos5800-peach-pi
On 07.12.2015 21:52, Inki Dae wrote: > From: Javier Martinez Canillas > > The DT binding for the Exynos DRM Display Port (DP) driver isn't consistent > since it uses a phandle to describe the connection between the DP port and > the display panel but uses the OF graph ports and endpoints to describe the > connection betwen the DP port, a bridge chip and the panel. > > The Exynos DP driver and the DT binding have been changed to allow also to > describe the DP port to panel connection using ports / endpoints (OF graph) > so this patch changes the Exynos5800 Peach Pi DT to make it consistent with > the Exynos5420 Peach Pit that has a eDP to LVDS chip and uses OF graph too. > > Signed-off-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Reviewed-by: Inki Dae > --- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > Looks sensible: Reviewed-by: Krzysztof Kozlowski Dependencies are not mentioned, does it depend on patch 1? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings
On 04.12.2015 21:11, Mark Brown wrote: > On Fri, Dec 04, 2015 at 10:10:05AM +0900, Krzysztof Kozlowski wrote: >> The mfd/s2mpa01.txt duplicates some of the information about bindings >> with old mfd/s2mps11.txt. Now common part exists entirely in >> mfd/samsung,sec-core.txt so: > > Acked-by: Mark Brown > >> - add company prefix to file name (regulator/samsung,s2mpa01.txt), > > I'm not 100% convinced about these prefixes BTW, the duplication isn't > usually an issue within a subsystem. They don't do any harm either > though. > I am not convinced neither... Some of newer documents use prefixes so I had an impression that this is a more organized way. If there are objections I can drop it. Thanks for ack! Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings
On 05.12.2015 00:55, Rob Herring wrote: > On Fri, Dec 04, 2015 at 10:10:05AM +0900, Krzysztof Kozlowski wrote: >> The mfd/s2mpa01.txt duplicates some of the information about bindings >> with old mfd/s2mps11.txt. Now common part exists entirely in >> mfd/samsung,sec-core.txt so: >> - add company prefix to file name (regulator/samsung,s2mpa01.txt), >> - remove duplicated information, >> - reorganize the contents to match style of >>regulator/samsung,s2mps11.txt. >> >> Signed-off-by: Krzysztof Kozlowski > > Next time, use git format-patch -M option. > > Acked-by: Rob Herring > It is already used but I also changed the style and formatting to the similarity dropped below default level of 50%. I could of course first rename and then change formatting/contents but that would be a little bit too much for this simple patchset, don't you think? Anyway thanks for acks! Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] dt-bindings: regulator/clock/mfd: Reorganize S2MPS-family bindings
Bindings for Samsung S2M and S5M family PMICs are in mess. They are
spread over different files and subdirectories in a non-consistent way.
The devices and respective drivers for them share a lot in common so
everything could be organized in a more readable way.
Reorganize the S2MPS11/13/14/15 Device Tree bindings to match the
drivers for this family of devices:
- move mfd/s2mps11.txt to mfd/samsung,sec-core.txt for the main MFD
driver (common for entire family),
- split clock block to clock/samsung,s2mps11.txt,
- split regulator block to regulator/samsung,s2mps11.txt.
Signed-off-by: Krzysztof Kozlowski
---
.../devicetree/bindings/clock/samsung,s2mps11.txt | 49 +++
Documentation/devicetree/bindings/mfd/s2mps11.txt | 153 -
.../devicetree/bindings/mfd/samsung,sec-core.txt | 84 +++
.../bindings/regulator/samsung,s2mps11.txt | 102 ++
MAINTAINERS| 4 +-
5 files changed, 238 insertions(+), 154 deletions(-)
create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
delete mode 100644 Documentation/devicetree/bindings/mfd/s2mps11.txt
create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
create mode 100644
Documentation/devicetree/bindings/regulator/samsung,s2mps11.txt
diff --git a/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
b/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
new file mode 100644
index ..2726c1d58a79
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/samsung,s2mps11.txt
@@ -0,0 +1,49 @@
+Binding for Samsung S2M and S5M family clock generator block
+
+
+This is a part of device tree bindings for S2M and S5M family multi-function
+devices.
+More information can be found in bindings/mfd/sec-core.txt file.
+
+The S2MPS11/13/15 and S5M8767 provide three(AP/CP/BT) buffered 32.768 kHz
+outputs. The S2MPS14 provides two (AP/BT) buffered 32.768 KHz outputs.
+
+To register these as clocks with common clock framework instantiate under
+main device node a sub-node named "clocks".
+
+It uses the common clock binding documented in:
+ - Documentation/devicetree/bindings/clock/clock-bindings.txt
+
+
+Required properties of the "clocks" sub-node:
+ - #clock-cells: should be 1.
+ - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk",
+ "samsung,s2mps14-clk", "samsung,s5m8767-clk"
+ The S2MPS15 uses the same compatible as S2MPS13, as both provides similar
+ clocks.
+
+
+Each clock is assigned an identifier and client nodes use this identifier
+to specify the clock which they consume.
+Clock ID Devices
+--
+32KhzAP0S2MPS11/13/14/15, S5M8767
+32KhzCP1S2MPS11/13/15, S5M8767
+32KhzBT2S2MPS11/13/14/15, S5M8767
+
+Include dt-bindings/clock/samsung,s2mps11.h file to use preprocessor defines
+in device tree sources.
+
+
+Example:
+
+ s2mps11_pmic@66 {
+ compatible = "samsung,s2mps11-pmic";
+ reg = <0x66>;
+
+ s2m_osc: clocks {
+ compatible = "samsung,s2mps11-clk";
+ #clock-cells = <1>;
+ clock-output-names = "xx", "yy", "zz";
+ };
+ };
diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt
b/Documentation/devicetree/bindings/mfd/s2mps11.txt
deleted file mode 100644
index 09b94c97faac..
--- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
+++ /dev/null
@@ -1,153 +0,0 @@
-
-* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator
-
-The Samsung S2MPS11 is a multi-function device which includes voltage and
-current regulators, RTC, charger controller and other sub-blocks. It is
-interfaced to the host controller using an I2C interface. Each sub-block is
-addressed by the host system using different I2C slave addresses.
-
-Required properties:
-- compatible: Should be one of the following
- - "samsung,s2mps11-pmic"
- - "samsung,s2mps13-pmic"
- - "samsung,s2mps14-pmic"
- - "samsung,s2mps15-pmic"
- - "samsung,s2mpu02-pmic".
-- reg: Specifies the I2C slave address of the pmic block. It should be 0x66.
-
-Optional properties:
-- interrupt-parent: Specifies the phandle of the interrupt controller to which
- the interrupts from s2mps11 are delivered to.
-- interrupts: Interrupt specifiers for interrupt sources.
-- samsung,s2mps11-wrstbi-ground: Indicates that WRSTBI pin of PMIC is pulled
- down. When the system is suspended it will always go down thus triggerring
- unwanted buck warm reset
[PATCH 0/3] dt-bindings: regulator/clock/mfd: Reorganize S2M/S5M bindings
Hi, The patchset tries to bring some order to the chaotic bindings for family of Samsung PMIC devices: S2MPS/S2MPA/S5M. Beside of renaming and removal of common parts I also tried to make a consistent style used in the files. The bindings itself were not modified. The patchset should be probably pulled at once (later patches depend on previous). With respective acks maybe through MFD tree? Best regards, Krzysztof Krzysztof Kozlowski (3): dt-bindings: regulator/clock/mfd: Reorganize S2MPS-family bindings dt-bindings: regulator/mfd: Reorganize S5M8767 bindings dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings .../devicetree/bindings/clock/samsung,s2mps11.txt | 49 +++ Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 Documentation/devicetree/bindings/mfd/s2mps11.txt | 153 --- .../devicetree/bindings/mfd/samsung,sec-core.txt | 88 +++ .../bindings/regulator/s5m8767-regulator.txt | 163 - .../bindings/regulator/samsung,s2mpa01.txt | 79 ++ .../bindings/regulator/samsung,s2mps11.txt | 102 + .../bindings/regulator/samsung,s5m8767.txt | 145 ++ MAINTAINERS| 6 +- 9 files changed, 467 insertions(+), 408 deletions(-) create mode 100644 Documentation/devicetree/bindings/clock/samsung,s2mps11.txt delete mode 100644 Documentation/devicetree/bindings/mfd/s2mpa01.txt delete mode 100644 Documentation/devicetree/bindings/mfd/s2mps11.txt create mode 100644 Documentation/devicetree/bindings/mfd/samsung,sec-core.txt delete mode 100644 Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s2mps11.txt create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] dt-bindings: regulator/mfd: Reorganize S5M8767 bindings
The regulator/s5m8767-regulator.txt duplicates some of the information about bindings with old mfd/s2mps11.txt. Now common part exists entirely in mfd/samsung,sec-core.txt so: - add company prefix to file name (regulator/samsung,s5m8767.txt), - remove duplicated information, - reorganize the contents to match style of regulator/samsung,s2mps11.txt. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +- .../bindings/regulator/s5m8767-regulator.txt | 163 - .../bindings/regulator/samsung,s5m8767.txt | 145 ++ MAINTAINERS| 2 +- 4 files changed, 149 insertions(+), 165 deletions(-) delete mode 100644 Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt create mode 100644 Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt diff --git a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt index ef0166d0f643..4aeb95c82304 100644 --- a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt +++ b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt @@ -14,6 +14,7 @@ addressed by the host system using different I2C slave addresses. This document describes bindings for main device node. Optional sub-blocks must be a sub-nodes to it. Bindings for them can be found in: - bindings/regulator/samsung,s2mps11.txt + - bindings/regulator/samsung,s5m8767.txt - bindings/clock/samsung,s2mps11.txt @@ -23,7 +24,8 @@ Required properties: - "samsung,s2mps13-pmic", - "samsung,s2mps14-pmic", - "samsung,s2mps15-pmic", - - "samsung,s2mpu02-pmic". + - "samsung,s2mpu02-pmic", + - "samsung,s5m8767-pmic". - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. Optional properties: diff --git a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt deleted file mode 100644 index 20191315e444.. --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt +++ /dev/null @@ -1,163 +0,0 @@ -* Samsung S5M8767 Voltage and Current Regulator - -The Samsung S5M8767 is a multi-function device which includes voltage and -current regulators, rtc, charger controller and other sub-blocks. It is -interfaced to the host controller using a i2c interface. Each sub-block is -addressed by the host system using different i2c slave address. This document -describes the bindings for 'pmic' sub-block of s5m8767. - -Required properties: -- compatible: Should be "samsung,s5m8767-pmic". -- reg: Specifies the i2c slave address of the pmic block. It should be 0x66. - -- s5m8767,pmic-buck2-dvs-voltage: A set of 8 voltage values in micro-volt (uV) - units for buck2 when changing voltage using gpio dvs. Refer to [1] below - for additional information. - -- s5m8767,pmic-buck3-dvs-voltage: A set of 8 voltage values in micro-volt (uV) - units for buck3 when changing voltage using gpio dvs. Refer to [1] below - for additional information. - -- s5m8767,pmic-buck4-dvs-voltage: A set of 8 voltage values in micro-volt (uV) - units for buck4 when changing voltage using gpio dvs. Refer to [1] below - for additional information. - -- s5m8767,pmic-buck-ds-gpios: GPIO specifiers for three host gpio's used - for selecting GPIO DVS lines. It is one-to-one mapped to dvs gpio lines. - -[1] If none of the 's5m8767,pmic-buck[2/3/4]-uses-gpio-dvs' optional -property is specified, the 's5m8767,pmic-buck[2/3/4]-dvs-voltage' -property should specify atleast one voltage level (which would be a -safe operating voltage). - -If either of the 's5m8767,pmic-buck[2/3/4]-uses-gpio-dvs' optional -property is specified, then all the eight voltage values for the -'s5m8767,pmic-buck[2/3/4]-dvs-voltage' should be specified. - -Optional properties: -- interrupt-parent: Specifies the phandle of the interrupt controller to which - the interrupts from s5m8767 are delivered to. -- interrupts: Interrupt specifiers for two interrupt sources. - - First interrupt specifier is for 'irq1' interrupt. - - Second interrupt specifier is for 'alert' interrupt. -- s5m8767,pmic-buck2-uses-gpio-dvs: 'buck2' can be controlled by gpio dvs. -- s5m8767,pmic-buck3-uses-gpio-dvs: 'buck3' can be controlled by gpio dvs. -- s5m8767,pmic-buck4-uses-gpio-dvs: 'buck4' can be controlled by gpio dvs. - -Additional properties required if either of the optional properties are used: - -- s5m8767,pmic-buck234-default-dvs-idx: Default voltage setting selected from - the possible 8 options selectable by the dvs gpios. The value of this - property should be between 0 and 7. If not specified or if out of rang
[PATCH 3/3] dt-bindings: regulator/mfd: Reorganize S2MPA01 bindings
The mfd/s2mpa01.txt duplicates some of the information about bindings
with old mfd/s2mps11.txt. Now common part exists entirely in
mfd/samsung,sec-core.txt so:
- add company prefix to file name (regulator/samsung,s2mpa01.txt),
- remove duplicated information,
- reorganize the contents to match style of
regulator/samsung,s2mps11.txt.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/mfd/s2mpa01.txt | 90 --
.../devicetree/bindings/mfd/samsung,sec-core.txt | 4 +-
.../bindings/regulator/samsung,s2mpa01.txt | 79 +++
3 files changed, 82 insertions(+), 91 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mfd/s2mpa01.txt
create mode 100644
Documentation/devicetree/bindings/regulator/samsung,s2mpa01.txt
diff --git a/Documentation/devicetree/bindings/mfd/s2mpa01.txt
b/Documentation/devicetree/bindings/mfd/s2mpa01.txt
deleted file mode 100644
index c13d3d8c3947..
--- a/Documentation/devicetree/bindings/mfd/s2mpa01.txt
+++ /dev/null
@@ -1,90 +0,0 @@
-
-* Samsung S2MPA01 Voltage and Current Regulator
-
-The Samsung S2MPA01 is a multi-function device which includes high
-efficiency buck converters including Dual-Phase buck converter, various LDOs,
-and an RTC. It is interfaced to the host controller using an I2C interface.
-Each sub-block is addressed by the host system using different I2C slave
-addresses.
-
-Required properties:
-- compatible: Should be "samsung,s2mpa01-pmic".
-- reg: Specifies the I2C slave address of the PMIC block. It should be 0x66.
-
-Optional properties:
-- interrupt-parent: Specifies the phandle of the interrupt controller to which
- the interrupts from s2mpa01 are delivered to.
-- interrupts: An interrupt specifier for the sole interrupt generated by the
- device.
-
-Optional nodes:
-- regulators: The regulators of s2mpa01 that have to be instantiated should be
- included in a sub-node named 'regulators'. Regulator nodes and constraints
- included in this sub-node use the standard regulator bindings which are
- documented elsewhere.
-
-Properties for BUCK regulator nodes:
-- regulator-ramp-delay: ramp delay in uV/us. May be 6250, 12500
- (default), 25000, or 5. May be 0 for disabling the ramp delay on
- BUCK{1,2,3,4}.
-
- In the absence of the regulator-ramp-delay property, the default ramp
- delay will be used.
-
- NOTE: Some BUCKs share the ramp rate setting i.e. same ramp value will be set
- for a particular group of BUCKs. So provide same
regulator-ramp-delay=.
-
- The following BUCKs share ramp settings:
- * 1 and 6
- * 2 and 4
- * 8, 9, and 10
-
-The following are the names of the regulators that the s2mpa01 PMIC block
-supports. Note: The 'n' in LDOn and BUCKn represents the LDO or BUCK number
-as per the datasheet of s2mpa01.
-
- - LDOn
- - valid values for n are 1 to 26
- - Example: LDO1, LD02, LDO26
- - BUCKn
- - valid values for n are 1 to 10.
- - Example: BUCK1, BUCK2, BUCK9
-
-Example:
-
- s2mpa01_pmic@66 {
- compatible = "samsung,s2mpa01-pmic";
- reg = <0x66>;
-
- regulators {
- ldo1_reg: LDO1 {
- regulator-name = "VDD_ALIVE";
- regulator-min-microvolt = <100>;
- regulator-max-microvolt = <100>;
- };
-
- ldo2_reg: LDO2 {
- regulator-name = "VDDQ_MMC2";
- regulator-min-microvolt = <280>;
- regulator-max-microvolt = <280>;
- regulator-always-on;
- };
-
- buck1_reg: BUCK1 {
- regulator-name = "vdd_mif";
- regulator-min-microvolt = <95>;
- regulator-max-microvolt = <135>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck2_reg: BUCK2 {
- regulator-name = "vdd_arm";
- regulator-min-microvolt = <95>;
- regulator-max-microvolt = <135>;
- regulator-always-on;
- regulator-boot-on;
- regulator-ramp-delay = <5>;
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
b/Documentation/devicetree/bindings/mfd/samsung,sec-core.txt
index 4aeb95c82304..cdd079bfc287 100644
--- a/Documentation/devicetree/bindin
Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi
On 02.12.2015 18:36, Martyn Welch wrote:
>
>
> On 01/12/15 23:51, Krzysztof Kozlowski wrote:
>> On 02.12.2015 04:12, Martyn Welch wrote:
>>> The peach pi has a GPIO connected to the firmware write protect,
>>> developer
>>> mode and recovery mode lines. This patch adds the required nodes to the
>>> device tree to configure the pinmuxing and allow these to be read from
>>> user space.
>>>
>>> Cc: Rob Herring
>>> Cc: Pawel Moll
>>> Cc: Mark Rutland
>>> Cc: Ian Campbell
>>> Cc: Kumar Gala
>>> Cc: Russell King
>>> Cc: Kukjin Kim
>>> Cc: Krzysztof Kozlowski
>>> Cc: devicetree@vger.kernel.org
>>> Cc: linux-arm-ker...@lists.infradead.org
>>> Cc: linux-samsung-...@vger.kernel.org
>>> Signed-off-by: Martyn Welch
>>> ---
>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 40
>>> +++
>>> 1 file changed, 40 insertions(+)
>>
>> Hi,
>>
>> Thanks for the patch.
>>
>> Few points from my side:
>> 1. Please add a prefix to the subject: "ARM: dts:".
>>
>
> Ok, sorry.
>
>> 2. There is no need of such huge CC-list in the body of commit. This
>> CC-list comes from get_maintainer so there is no benefit of duplicating
>> it here. The CC is usually used to notify other people who might be
>> interested but get_maintainer does not point them.
>>
>
> Ok, yes these were pulled from get_maintainer.
>
>> 3. I received only this third patch. I did not receive cover letter
>> explaining possible dependencies so I am not sure how to deal with the
>> patch. It looks like there are no dependencies... but maybe there are?
>> Is this is a new binding or no? Please provide a cover letter (if it
>> exists already be sure to send it to all interested parties) or send
>> entire patchset so the big picture could be seen.
>>
>
> I'll make sure I do that next time.
>
> The cover letter read:
>
> Some Chromebooks have gpio attached to signals used to cause the
> firmware to enter alternative modes of operation and/or control other
> device characteristics (such as write protection on flash devices). This
> patch adds a driver that exposes a read-only interface to allow these
> signals to be read from user space.
>
> In addition this patch series provides the required bindings for this to
> the peach-pi Chromebook.
>
>
> This is a new binding, but the driver is based on functionality in the
> kernel shipped on Chromebooks. The binding has been modified based on
> the form of existing bindings in the mainline kernel.
>
> Does that help?
Yes, that helps. With the changes above (subject and reduced CC-line in
commit message):
Reviewed-by: Krzysztof Kozlowski
As there are no dependencies this should go through samsung-soc. Just
let us know about DT bindings being accepted/applied.
Best regards,
Krzysztof
>
> Martyn
>
>> The patch itself looks good but I'll wait with a review tag for #3.
>>
>> Best regards,
>> Krzysztof
>>
>>
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> index 49a4f43..485c18f 100644
>>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>>> @@ -53,6 +53,25 @@
>>> };
>>> };
>>>
>>> +chromeos-firmware {
>>> +compatible = "google,gpio-firmware";
>>> +
>>> +pinctrl-names = "default";
>>> +pinctrl-0 = <&wp_gpio &dev_mode &rec_mode>;
>>> +
>>> +write-protect {
>>> +gpios = <&gpx3 0 GPIO_ACTIVE_LOW>;
>>> +};
>>> +
>>> +developer-switch {
>>> +gpios = <&gpx1 3 GPIO_ACTIVE_HIGH>;
>>> +};
>>> +
>>> +recovery-switch {
>>> +gpios = <&gpx0 7 GPIO_ACTIVE_LOW>;
>>> +};
>>> +};
>>> +
>>> gpio-keys {
>>> compatible = "gpio-keys";
>>>
>>> @@ -731,6 +750,13 @@
>>> samsung,pin-val = <0>;
>>> };
>>>
>>> +rec_mode: rec-mode {
>>> +samsung,pins = "gpx0-7";
>>> +samsung,pin-function = <0>;
>>> +samsung,pin-pud = <0>;
>>> +samsung,pin-drv = <0>;
>>&
Re: [PATCH v3 5/5] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF
On 01.12.2015 18:03, Pavel Fedin wrote: > Hello! > > Tested it on top of 4.4-rc3. > >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig >> index 3a10f1a8317a..d279edf9b10d 100644 >> --- a/arch/arm/mach-exynos/Kconfig >> +++ b/arch/arm/mach-exynos/Kconfig >> @@ -27,6 +27,9 @@ menuconfig ARCH_EXYNOS >> select SRAM >> select THERMAL >> select MFD_SYSCON >> +select POWER_RESET >> +select POWER_RESET_SYSCON >> +select POWER_RESET_SYSCON_POWEROFF > > "select POWER_SUPPLY" is missing here. Without is we get: > --- cut --- > warning: (ARCH_HISI && ARCH_INTEGRATOR && ARCH_EXYNOS && ARCH_VEXPRESS && > REALVIEW_DT) selects POWER_RESET which has unmet direct > dependencies (POWER_SUPPLY) > warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON which has unmet direct > dependencies (POWER_SUPPLY && POWER_RESET && OF) > warning: (ARCH_EXYNOS) selects POWER_RESET_SYSCON_POWEROFF which has unmet > direct dependencies (POWER_SUPPLY && POWER_RESET && OF) > --- cut --- > >> help >>Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > Otherwise works fine. > > Tested-by: Pavel Fedin Testing was a little bit too late (late not only looking at date of v1 and v2 but even for v3)... I appreciate it but I applied it already and in fact I sent a pull request with it. Actually the proper fix I think is to remove the dependency between POWER_RESET and POWER_SUPPLY. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 2/9] ARM: EXYNOS: Exynos SoC/mach specific code for v4.5
Hi Kukjin,
SoC/mach specific code.
Best regards,
Krzysztof
The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec:
Linux 4.4-rc1 (2015-11-15 17:00:27 -0800)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git
tags/samsung-soc-4.5
for you to fetch changes up to 8438aef01d3560549b3a95d247b3a69311fa6f2d:
ARM: EXYNOS: Remove redundant code from regs-pmu.h (2015-11-20 16:00:47 +0900)
Samsung Exynos improvements for 4.5:
1. Switch from Exynos-specific restart/poweroff handler
(mach-exynos/pmu.c) to generic syscon-reboot and syscon-poweroff
drivers.
This depends on adding syscon nodes to DTS to preserve
bisectability.
2. Minor improvements.
Alim Akhtar (5):
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos3250
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos4
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos5
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos5410
ARM: EXYNOS: Switch to syscon reboot and poweroff
Krzysztof Kozlowski (2):
Merge tag 'samsung-dt-syscon-restart-4.5' into next/soc
ARM: EXYNOS: Constify local exynos_pmu_data structure
Pankaj Dubey (1):
ARM: EXYNOS: Remove redundant code from regs-pmu.h
arch/arm/boot/dts/exynos3250.dtsi | 14
arch/arm/boot/dts/exynos4.dtsi| 14
arch/arm/boot/dts/exynos5.dtsi| 14
arch/arm/boot/dts/exynos5410.dtsi | 14
arch/arm/mach-exynos/Kconfig | 3 +++
arch/arm/mach-exynos/pmu.c| 45 ++-
arch/arm/mach-exynos/regs-pmu.h | 9
7 files changed, 61 insertions(+), 52 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 5/9] ARM: EXYNOS: Drivers for v4.5
Hi Kukjin, Pinctrl for v4.5. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-drivers-4.5 for you to fetch changes up to 023e06dfa6882f500b9c86fd61f0b1913aa07f36: pinctrl: exynos: add exynos5410 SoC specific data (2015-11-16 10:54:43 +0900) Exynos-specific drivers for 4.5: 1. Add a pinctrl driver for Exynos5410. Hakjoo Kim (1): pinctrl: exynos: add exynos5410 SoC specific data .../bindings/pinctrl/samsung-pinctrl.txt | 1 + drivers/pinctrl/samsung/pinctrl-exynos.c | 103 + drivers/pinctrl/samsung/pinctrl-samsung.c | 2 + drivers/pinctrl/samsung/pinctrl-samsung.h | 1 + 4 files changed, 107 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 6/9] ARM: EXYNOS: clk: Another clock dependency, ARMv7, for v4.5
Hi Kukjin, This is also clock dependency. I put it in separate tag in case clock folks want to pull it also. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-exynos4-4.5 for you to fetch changes up to 94af7a3c310f5877dc6f756179b92f24f89a9b08: clk: samsung: exynos4: Add SSS gate clock (2015-11-18 22:02:02 +0900) Add a Security SubSystem (SSS) clock for Exynos4, needed by exynos-rng driver (Pseudo Random Number Generator). Krzysztof Kozlowski (1): clk: samsung: exynos4: Add SSS gate clock drivers/clk/samsung/clk-exynos4.c | 1 + include/dt-bindings/clock/exynos4.h | 1 + 2 files changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 3/9] ARM64: EXYNOS: clk: Clock dependency for ARM64 for v4.5
Hi Kukjin, Dependency for soc64 changes. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-clk-arm64-symbols-4.5 for you to fetch changes up to 8c2a90ed18a74e8b9cdbba679403faa44d6024fc: clk: samsung: Don't build ARMv8 clock drivers on ARMv7 (2015-11-22 19:25:29 +0900) Remove CONFIG_ARCH_EXYNOS7 symbol from Samsung clocks and instead build all drivers for ARM64 SoCs under CONFIG_EXYNOS_ARM64_COMMON_CLK. After the commit there will be no more users of CONFIG_ARCH_EXYNOS7 except ARM64 mach code. Krzysztof Kozlowski (1): clk: samsung: Don't build ARMv8 clock drivers on ARMv7 drivers/clk/samsung/Kconfig | 6 ++ drivers/clk/samsung/Makefile | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 1/9] ARM: EXYNOS: dts: Syscon dependency for v4.5
Hi Kukjin,
The DT changes are needed before switching to syscon-based reboot
and power off method.
Best regards,
Krzysztof
The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec:
Linux 4.4-rc1 (2015-11-15 17:00:27 -0800)
are available in the git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git
tags/samsung-dt-syscon-restart-4.5
for you to fetch changes up to 35135f4b95f03be7ebbf31221ce738f1ec0faa02:
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos5410 (2015-11-20
15:58:44 +0900)
Device Tree changes adding necessary nodes for syscon reboot/poweroff
handlers on Exynos boards. The mach-exynos changes must base on top
of this to retain the bisectability of not loosing reboot/poweroff
features.
Alim Akhtar (4):
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos3250
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos4
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos5
ARM: dts: Add syscon-{reboot, poweroff} nodes for exynos5410
arch/arm/boot/dts/exynos3250.dtsi | 14 ++
arch/arm/boot/dts/exynos4.dtsi| 14 ++
arch/arm/boot/dts/exynos5.dtsi| 14 ++
arch/arm/boot/dts/exynos5410.dtsi | 14 ++
4 files changed, 56 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 4/9] ARM64: EXYNOS: Soc specific code for v4.5
Hi Kukjin, ARM64 change touch also defconfig. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-soc64-4.5 for you to fetch changes up to db44c07a3f0b32815bd1f3e731db9e043e57cf9c: arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS (2015-11-22 19:31:30 +0900) Samsung Exynos ARM64 improvements: 1. Use just one Kconfig symbol for Exynos SoC: ARCH_EXYNOS. This depends on change in drivers/clk where the old ARCH_EXYNOS7 was used. Krzysztof Kozlowski (3): clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Merge tag 'samsung-clk-arm64-symbols-4.5' into next/soc64 arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS arch/arm64/Kconfig.platforms| 11 ++- arch/arm64/boot/dts/exynos/Makefile | 2 +- arch/arm64/configs/defconfig| 2 +- drivers/clk/samsung/Kconfig | 6 ++ drivers/clk/samsung/Makefile| 4 ++-- 5 files changed, 12 insertions(+), 13 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 9/9] ARM: EXYNOS: Defconfig for v4.5
Hi Kukjin, This may conflict with other arm-soc updates... Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-defconfig-4.5 for you to fetch changes up to 00a5e81fff2d81c3b1bf45712d3a12c905bc7c66: ARM: exynos_defconfig: Set recommended options for systemd (2015-12-01 08:28:44 +0900) Defconfig (exynos and multi_v7) changes for Exynos based boards for 4.5: 1. Enable Maxim 8997 and 77693 family drivers (charger, extcon, LED, RTC, haptic/motor, regulator). 2. Build ChromeOS EC drivers as modules on multi_v7. 3. Enable drivers important for Exynos4210-based Universal C210 board. 4. Enable NFSv4 client. 5. On exynos_defconfig set some options to a value recommended by systemd. This also makes it more consistent with multi_v7. Javier Martinez Canillas (1): ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules Krzysztof Kozlowski (6): ARM: exynos_defconfig: Enable Maxim 8997 family drivers ARM: exynos_defconfig: Enable Maxim 77693 LED and haptic drivers ARM: multi_v7_defconfig: Enable Maxim 8997 family drivers ARM: multi_v7_defconfig: Enable Maxim 77693 LED and haptic drivers ARM: exynos_defconfig: Enable NFSv4 client ARM: exynos_defconfig: Set recommended options for systemd Marek Szyprowski (1): ARM: exynos_defconfig: Add drivers for Exynos4210 Universal C210 board arch/arm/configs/exynos_defconfig | 18 -- arch/arm/configs/multi_v7_defconfig | 15 --- 2 files changed, 28 insertions(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 8/9] ARM64: EXYNOS: dts: DeviceTree for ARM64 for v4.5
Hi Kukjin, Few changes for Espresso board. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt64-4.5 for you to fetch changes up to fb026cb6524744c8bd0f133f4b0d8e2595d04e15: arm64: dts: Add reboot node for exynos7 (2015-11-18 22:47:16 +0900) Samsung DeviceTree ARM64 updates and improvements for 4.5: 1. Add S2MPS15 PMIC node to Espresso board. This gives proper control over regulators, provides 32KHz clocks and RTC driver. 2. Enable HS200 mode operation on Espresso board for MMC0. 3. Add reboot capability (generic syscon-reboot). Alim Akhtar (3): arm64: dts: Add S2MPS15 PMIC node on exynos7-espresso arm64: dts: Enable HS200 mode operation on exynos7-espresso arm64: dts: Add reboot node for exynos7 arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 282 +++- arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 + 2 files changed, 288 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 7/9] ARM: EXYNOS: dts: DeviceTree for v4.5
Hi Kukjin, A lot of stuff here, mostly cleanups. Description in tag. Best regards, Krzysztof The following changes since commit 8005c49d9aea74d382f474ce11afbbc7d7130bec: Linux 4.4-rc1 (2015-11-15 17:00:27 -0800) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-dt-4.5 for you to fetch changes up to 2cf107f1033e0343d45b59d06f16487c8362702f: ARM: dts: Unify G2D device node with other devices on exynos4 (2015-11-30 17:00:43 +0900) Samsung DeviceTree updates and improvements for 4.5: 1. Pinctrl for Exynos5410. 2. eMMC/SDIO minor fixes usage of bindings on Snow and Peach Chromebooks. 3. Remove FIMD from Odroid XU3-family because on XU3 it cannot be used yet and on XU3-Lite and XU4 it is not supported. 4. Remove deprecated since June 2013 samsung,exynos5-hdmi. 5. Add support for Pseudo Random Generator on Exynos4 (Trats2 for now). This depends on new SSS clock. 6. Add rotator nodes for Exynos4 and Exynos5. 7. Switch DWC3_1 on Odroid XU3 and XU3-Lite to peripheral mode because now it cannot be used as OTG. 8. Cleanup the G2D usage on Exynos4 and add it to a proper domain in case of Exynos4210. 9. Put MDMA1 in proper domain on Exynos4210 as well. 10. Minor cleanups. Andrzej Hajda (1): dt-bindings: remove deprecated compatible string from exynos-hdmi Hakjoo Kim (1): ARM: dts: Add pinctrl support to exynos5410 Javier Martinez Canillas (7): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common ARM: dts: Remove unneeded GPIO include in exynos4412-odroidu3 Krzysztof Kozlowski (4): clk: samsung: exynos4: Add SSS gate clock Merge tag 'samsung-clk-exynos4-4.5' into next/dt ARM: dts: Add PRNG module for exynos4 ARM: dts: Enable PRNG module on exynos4412-trats2 Marek Szyprowski (10): ARM: dts: Remove fimd node from exynos5422-odroidxu3-common ARM: dts: Add rotator nodes on exynos4 ARM: dts: Fix power domain for sysmmu-rotator device on exynos4 ARM: dts: Add rotator node on exynos5250 ARM: dts: Add rotator node on exynos5420 ARM: dts: Use peripheral mode for dwc3_1 on exynos5422-odroidxu3 ARM: dts: exynos4210-universal_c210: Disable DMA for UARTs ARM: dts: MDMA1 device belongs to LCD0 power domain on exynos4210 ARM: dts: Add power domain to G2D device on exynos4210 ARM: dts: Unify G2D device node with other devices on exynos4 .../bindings/display/exynos/exynos_hdmi.txt| 7 +- arch/arm/boot/dts/exynos4.dtsi | 18 +- arch/arm/boot/dts/exynos4210-origen.dts| 4 - arch/arm/boot/dts/exynos4210-smdkv310.dts | 4 - arch/arm/boot/dts/exynos4210-universal_c210.dts| 8 + arch/arm/boot/dts/exynos4210.dtsi | 14 +- arch/arm/boot/dts/exynos4412-odroid-common.dtsi| 4 - arch/arm/boot/dts/exynos4412-odroidu3.dts | 1 - arch/arm/boot/dts/exynos4412-origen.dts| 4 - arch/arm/boot/dts/exynos4412-smdk4412.dts | 4 - arch/arm/boot/dts/exynos4412-trats2.dts| 4 + arch/arm/boot/dts/exynos4x12.dtsi | 5 +- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 6 +- arch/arm/boot/dts/exynos5250.dtsi | 9 + arch/arm/boot/dts/exynos5410-pinctrl.dtsi | 406 + arch/arm/boot/dts/exynos5410.dtsi | 36 ++ arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +- arch/arm/boot/dts/exynos5420.dtsi | 19 + arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 5 - arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts| 2 +- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +- drivers/clk/samsung/clk-exynos4.c | 1 + include/dt-bindings/clock/exynos4.h| 1 + 24 files changed, 527 insertions(+), 47 deletions(-) create mode 100644 arch/arm/boot/dts/exynos5410-pinctrl.dtsi -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL 0/9] ARM: EXYNOS: Pull request for v4.5
Hi Kukjin, A lot of stuff for v4.5 with 3 dependencies split into separate tags. The need for dependency is explained both in merge-commit and in description of a tag which is using the dependency. The order goes like (but of course dependencies could be pulled all at once at beginning): 1. tags/samsung-dt-syscon-restart-4.5 2. tags/samsung-soc-4.5 3. tags/samsung-clk-arm64-symbols-4.5 4. tags/samsung-soc64-4.5 5. tags/samsung-drivers-4.5 6. tags/samsung-clk-exynos4-4.5 7. tags/samsung-dt-4.5 8. tags/samsung-dt64-4.5 9. tags/samsung-defconfig-4.5 I split dependencies to three tags so clock or other folks could easily grab them if needed. Please share your comments or pull as early as possible as we have here some more dependencies than usual. Kind regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] Addition of binding for firmware signals on peach-pi
On 02.12.2015 04:12, Martyn Welch wrote:
> The peach pi has a GPIO connected to the firmware write protect, developer
> mode and recovery mode lines. This patch adds the required nodes to the
> device tree to configure the pinmuxing and allow these to be read from
> user space.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Cc: Ian Campbell
> Cc: Kumar Gala
> Cc: Russell King
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-samsung-...@vger.kernel.org
> Signed-off-by: Martyn Welch
> ---
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 40
> +++
> 1 file changed, 40 insertions(+)
Hi,
Thanks for the patch.
Few points from my side:
1. Please add a prefix to the subject: "ARM: dts:".
2. There is no need of such huge CC-list in the body of commit. This
CC-list comes from get_maintainer so there is no benefit of duplicating
it here. The CC is usually used to notify other people who might be
interested but get_maintainer does not point them.
3. I received only this third patch. I did not receive cover letter
explaining possible dependencies so I am not sure how to deal with the
patch. It looks like there are no dependencies... but maybe there are?
Is this is a new binding or no? Please provide a cover letter (if it
exists already be sure to send it to all interested parties) or send
entire patchset so the big picture could be seen.
The patch itself looks good but I'll wait with a review tag for #3.
Best regards,
Krzysztof
>
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> index 49a4f43..485c18f 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -53,6 +53,25 @@
> };
> };
>
> + chromeos-firmware {
> + compatible = "google,gpio-firmware";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&wp_gpio &dev_mode &rec_mode>;
> +
> + write-protect {
> + gpios = <&gpx3 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + developer-switch {
> + gpios = <&gpx1 3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + recovery-switch {
> + gpios = <&gpx0 7 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
>
> @@ -731,6 +750,13 @@
> samsung,pin-val = <0>;
> };
>
> + rec_mode: rec-mode {
> + samsung,pins = "gpx0-7";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> tpm_irq: tpm-irq {
> samsung,pins = "gpx1-0";
> samsung,pin-function = <0>;
> @@ -752,6 +778,13 @@
> samsung,pin-drv = <0>;
> };
>
> + dev_mode: dev-mode {
> + samsung,pins = "gpx1-3";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <3>;
> + samsung,pin-drv = <0>;
> + };
> +
> ec_irq: ec-irq {
> samsung,pins = "gpx1-5";
> samsung,pin-function = <0>;
> @@ -773,6 +806,13 @@
> samsung,pin-drv = <0>;
> };
>
> + wp_gpio: wp_gpio {
> + samsung,pins = "gpx3-0";
> + samsung,pin-function = <0>;
> + samsung,pin-pud = <0>;
> + samsung,pin-drv = <0>;
> + };
> +
> max77802_irq: max77802-irq {
> samsung,pins = "gpx3-1";
> samsung,pin-function = <0>;
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv2] ARM: dts: use vmmc-supply of emmc/sd for exynos5422-odroidxu3
On 27.11.2015 15:42, Anand Moon wrote:
> hi Krzysztof,
>
> On 22 October 2015 at 18:34, Anand Moon wrote:
>> hi Krzysztof,
>>
>> On 22 October 2015 at 06:31, Krzysztof Kozlowski
>> wrote:
>>> On 20.10.2015 21:56, Anand Moon wrote:
>>>> Changes need for host controller to detect UHS-I highspeed cards.
>>>> Changes in VDDQ_MMC2 voltage range help scale
>>>> the required voltage to detect and load the microSD cards.
>>>
>>> Thanks for updating description of commit.
>>>
>>>>
>>>> Signed-off-by: Anand Moon
>>>> ---
>>>> Changes based on
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
>>>> v4.4-next/dt-samsung branch
>>>>
>>>> Changes:
>>>> Drop the ranp_delay for LDO9.
>>>>
>>>> Thanks to : Krzysztof, Doug Anderson, Jaehoon Chung for helping
>>>> me out figure out the mmc core requirement.
>>>>
>>>> Also drop the previous changes:
>>>> use cd-gpio method to detect sd-card.
>>>> Added UHS-I bus speed support.
>>>>
>>>> [4.713553] random: nonblocking pool is initialized
>>>> [4.718423] 1453.hdmi supply hdmi-en not found, using dummy
>>>> regulator
>>>> [4.726206] exynos-drm exynos-drm: bound 1440.fimd (ops
>>>> fimd_component_ops)
>>>> [4.732555] exynos-drm exynos-drm: bound 1445.mixer (ops
>>>> mixer_component_ops)
>>>> [4.740180] exynos-drm exynos-drm: bound 1453.hdmi (ops
>>>> hdmi_component_ops)
>>>> [4.746936] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
>>>> [4.753428] [drm] No driver support for vblank timestamp query.
>>>> [4.940794] Console: switching to colour frame buffer device 274x77
>>>> [4.995344] exynos-drm exynos-drm: fb0: frame buffer device
>>>> [5.024573] [drm] Initialized exynos 1.0.0 20110530 on minor 0
>>>> [5.031164] exynos-dwc3 usb@1200: no suspend clk specified
>>>> [5.054571] usb 2-1: new full-speed USB device number 2 using
>>>> exynos-ohci
>>>> [5.159527] dwmmc_exynos 1222.mmc: Busy; trying anyway
>>>> [5.163705] mmc_host mmc1: Timeout sending command (cmd 0x202000 arg
>>>> 0x0 status 0x0)
>>>> ---
>>>> arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 7 ++-
>>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>>>> index 1af5bdc..a4be3e0 100644
>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
>>>> @@ -182,9 +182,10 @@
>>>>
>>>> ldo13_reg: LDO13 {
>>>> regulator-name = "vdd_ldo13";
>>>> - regulator-min-microvolt = <280>;
>>>> + regulator-min-microvolt = <180>;
>>>
>>> You did not convinced me in previous discussion about the change to
>>> 1.8V. I said that:
>>>> On the same diagram few lines below:
>>>> VDDQ_MMC2: 2.8V 250mA
>>>
>>> You responded:
>>>> You are correct.
>>>
>>> So I am confused. Are you sure that this SD card block can/should
>>> operate on 1.8V? Have you actually tried this?
>>>
>>
>> Look like I missed this point. Here is the link I would like to share.
>>
>> http://www.hjreggel.net/cardspeed/cs_sdxc.html
>> Section: Summary of SD modes
>>
>> https://en.wikipedia.org/wiki/Secure_Digital
>> Section: Power consumption
>>
>> Their different requirement for voltage requirement for UHS-I, the max
>> value is around 3.3V
>
> Do you have any comment on this voltage selection for UHS-I card (1.8V).
I asked whether you tried this, whether setting real 1.8V works fine.
You did not respond. As you can see on Odroid schematics, the VDDQ for
MMC[01] operates under 1.8V.
The VDDQ for MMC2 - under 2.8V.
In commit description you mentioned that this voltage "helps scale the
required voltage to detect and load the microSD cards". What does it
mean "help"? I would expect that detecting and loading of microSD cards
either works or does not work. I am not sure how does it help.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: dts: Remove unneeded GPIO include in exynos4412-odroidu3
On 25.11.2015 21:11, Javier Martinez Canillas wrote: > The header is already included in the > exynos4412-odroid-common DTSI so there's no need to do it again > in the DTS file. > > Signed-off-by: Javier Martinez Canillas > > --- > > arch/arm/boot/dts/exynos4412-odroidu3.dts | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 5/5] ARM: exynos: select POWER_RESET_SYSCON and POWER_RESET_SYSCON_POWEROFF
On 20.11.2015 14:17, Alim Akhtar wrote:
> Since we switch to use generic syscon regmap based reset/poweroff
> driver for exynos SoC, lets select it from ARCH_EXYNOS instead of
> enabling it from various defconfigs. This also select POWER_RESET
> as SYSCON-{reset, poweroff} drivers depends on it.
>
> Also because of the above changes we don't need special handling
> for reboot/poweroff in exynos pmu driver. This patch also removes
> the same from exynos pmu driver to keep git bisect working.
>
> Note: This will break reboot/poweroff on boards with older dtbs
> with a newer kernel.
>
> Signed-off-by: Alim Akhtar
> Reviewed-by: Javier Martinez Canillas
> Acked-by: Moritz Fischer
> ---
> arch/arm/mach-exynos/Kconfig |3 +++
> arch/arm/mach-exynos/pmu.c | 43
> --
> 2 files changed, 3 insertions(+), 43 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski
Thanks, applied with different title:
"ARM: EXYNOS: Switch to syscon reboot and poweroff"
https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/soc
I'll be pushing this to Kukjin for v4.5 (unless he picks it by himself).
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/6] Switch to generic syscon regmap based drivers
On 20.11.2015 03:06, Alim Akhtar wrote:
> Hi Krzysztof/Ulf/Kukjin
>
> On Thu, Oct 22, 2015 at 5:47 AM, Krzysztof Kozlowski
> wrote:
>> On 22.10.2015 00:01, Alim Akhtar wrote:
>>> On Wed, Oct 21, 2015 at 8:25 PM, Javier Martinez Canillas
>>> wrote:
>>>> Hello Alim,
>>>>
>>>> On 10/21/2015 04:50 PM, Alim Akhtar wrote:
>>>>
>>>> [snip]
>>>>
>>>>>>
>>>>>> [0]:
>>>>>> From c9b250ee03bae338339b70693e906145c719f783 Mon Sep 17 00:00:00 2001
>>>>>> From: Javier Martinez Canillas
>>>>>> Date: Wed, 21 Oct 2015 11:59:44 +0200
>>>>>> Subject: [RFT PATCH] mmc: pwrseq: Use highest priority for eMMC restart
>>>>>> handler
>>>>>>
>>>>>> The pwrseq_emmc driver does a eMMC card reset before a system reboot to
>>>>>> allow broken or limited ROM boot-loaders, that don't have an eMMC reset
>>>>>> logic, to be able to read the second stage from the eMMC.
>>>>>>
>>>>>> But this has to be called before a system reboot handler and while most
>>>>>> of them use the priority 128, there are other restart handlers (such as
>>>>>> the syscon-reboot one) that use a higher priority. So, use the highest
>>>>>> priority to make sure that the eMMC hw is reset before a system reboot.
>>>>>>
>>>>>> Signed-off-by: Javier Martinez Canillas
>>>>>> ---
>>>>> Looks good.
>>>>> Reviewed-by: Alim Akhtar
>>>>>
>>>>
>>
>> +Cc Ulf,
>>
>> Javier,
>>
>> First of all, thanks Javier for digging into the issue. Actually I have
>> Odroid U3 but because of user-space limitations (which I need for other
>> work) I cannot test all of mainline patches there.
>>
>>
>>>> Thanks, should I post it as a proper patch or are adding it to your
>>>> series?
>>> Suggest you to post as a patch collecting {Tested, Reviewed}-by (easy
>>> for maintainers to pickup ) and probably CCing Ulf for his feedback.
>>>
>>>> I think the latter is more reasonable so with an ack from Ulf,
>>>> all patches can go through the linux-samsung tree.
>>>>
>>> yes, that is reasonable, as I said, let Krzysztof and Ulf take a call here.
>>
>> Javier, Alim, Ulf,
>>
>> I am not grabbing any more patches for v4.4 because I doubt that they
>> could be merged to arm-soc for this cycle. My last pull requests for
>> v4.4 is still pending...
>>
>> This means that I plan to pick up these series for v4.5, after closing
>> v4.4 merge window (unless Kukjin picks it also). Because of that, we
>> have plenty of time, so my idea is:
>> 1. Wait for some comments from Ulf on Javier's fix.
>> 2. If the fix goes into v4.4, then problem solved.
>> 3. If not and it get acked, then it can go with this set.
>> 4. If not and it get applied by Ulf for v4.5, then a tag from him would
>> be a nice way to solve dependency.
>>
>> Either way we don't have to hurry, I think.
>>
>
> Is It the right time to get this series in?
> Thanks!!
I started applying it but stopped at #5. It should be squashed with #6
to get rid of (not important) conflict between syscon reboot and
existing Exynos restart handler:
syscon-poweroff syscon-poweroff: pm_power_off already claimed c001e52c
exynos_power_off
syscon-poweroff: probe of syscon-poweroff failed with error -16
The conflict is not really an issue because of ordering of init calls
the Exynos will register itself before syscon. Nevertheless splitting
the patches does not really make sense... so please merge #5 with #6.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 3/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5
On 20.10.2015 18:24, Alim Akhtar wrote:
> This patch adds syscon-{reboot, poweroff} nodes to allow the
> generic syscon-{reboot, poweroff} driver to reset/poweroff exynos5 SoCs.
>
> Signed-off-by: Alim Akhtar
> Reviewed-by: Pankaj Dubey
> Reviewed-by: Javier Martinez Canillas
> Acked-by: Moritz Fischer
> ---
> arch/arm/boot/dts/exynos5.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 4/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos5410 SoC
On 20.10.2015 18:24, Alim Akhtar wrote:
> This patch adds syscon-{reboot, poweroff} nodes to allow the
> generic syscon-{reboot, poweroff} driver to reset/poweroff exynos5410 SoC.
>
> Signed-off-by: Alim Akhtar
> Reviewed-by: Pankaj Dubey
> Reviewed-by: Javier Martinez Canillas
> Acked-by: Moritz Fischer
> ---
> arch/arm/boot/dts/exynos5410.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos4
On 20.10.2015 18:24, Alim Akhtar wrote:
> This patch adds syscon-{reboot, poweroff} nodes to allow the
> generic syscon-{reboot, poweroff} driver to reset/poweroff exynos4 SoC.
>
> Signed-off-by: Alim Akhtar
> Reviewed-by: Pankaj Dubey
> Reviewed-by: Javier Martinez Canillas
> Tested-by: Tobias Jakobi
> Acked-by: Moritz Fischer
> ---
> arch/arm/boot/dts/exynos4.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/6] arm: dts: Add syscon-{reboot, poweroff} nodes for exynos3250 SoCs
On 20.10.2015 18:24, Alim Akhtar wrote:
> This patch adds syscon-{reboot, poweroff} nodes to allow the
> generic syscon-{reboot, poweroff} driver to reset/poweroff exynos3250 SoC.
>
> Signed-off-by: Alim Akhtar
> Reviewed-by: Pankaj Dubey
> Reviewed-by: Javier Martinez Canillas
> Acked-by: Moritz Fischer
> ---
> arch/arm/boot/dts/exynos3250.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 2/2] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS
The ARMv8 Exynos family SoCs in Linux kernel are currently: - Exynos5433 (controlled by ARCH_EXYNOS), - Exynos7 (controlled by ARCH_EXYNOS7). It duplicates Kconfig symbols unnecessarily, so consolidate them into one ARCH_EXYNOS. Future SoCs could fall also under the ARCH_EXYNOS symbol. The commit should not bring any visible functional change. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chanwoo Choi Reviewed-by: Pankaj Dubey Tested-by: Alim Akhtar Reviewed-by: Tomasz Figa --- Changes since v1: 1. Minor cleanups after Tomasz's comments. 2. Added tags: Chanwoo's, Pankaj's, Alim's and Tomasz's. --- arch/arm64/Kconfig.platforms| 11 ++- arch/arm64/boot/dts/exynos/Makefile | 2 +- arch/arm64/configs/defconfig| 2 +- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 4043c35962cc..64f1116640bc 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -13,21 +13,14 @@ config ARCH_BERLIN This enables support for Marvell Berlin SoC Family config ARCH_EXYNOS - bool - help - This enables support for Samsung Exynos SoC family - -config ARCH_EXYNOS7 - bool "ARMv8 based Samsung Exynos7" - select ARCH_EXYNOS + bool "ARMv8 based Samsung Exynos SoC family" select COMMON_CLK_SAMSUNG select HAVE_S3C2410_WATCHDOG if WATCHDOG select HAVE_S3C_RTC if RTC_CLASS select PINCTRL select PINCTRL_EXYNOS - help - This enables support for Samsung Exynos7 SoC family + This enables support for ARMv8 based Samsung Exynos SoC family. config ARCH_LAYERSCAPE bool "ARMv8 based Freescale Layerscape SoC family" diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile index 20310e5b6d6f..50c9b9383cfa 100644 --- a/arch/arm64/boot/dts/exynos/Makefile +++ b/arch/arm64/boot/dts/exynos/Makefile @@ -1,4 +1,4 @@ -dtb-$(CONFIG_ARCH_EXYNOS7) += exynos7-espresso.dtb +dtb-$(CONFIG_ARCH_EXYNOS) += exynos7-espresso.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index bdd7aa358d2a..a396fa7c69a5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -33,7 +33,7 @@ CONFIG_MODULE_UNLOAD=y # CONFIG_IOSCHED_DEADLINE is not set CONFIG_ARCH_BCM_IPROC=y CONFIG_ARCH_BERLIN=y -CONFIG_ARCH_EXYNOS7=y +CONFIG_ARCH_EXYNOS=y CONFIG_ARCH_LAYERSCAPE=y CONFIG_ARCH_HISI=y CONFIG_ARCH_MEDIATEK=y -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS so it is built also on ARMv7. This does not bring any kind of benefit. There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like multi_v7 for ARMv7). Instead build clock drivers only for respective SoC's architecture. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Chanwoo Choi Acked-by: Sylwester Nawrocki Tested-by: Alim Akhtar Acked-by: Tomasz Figa --- Changes since v1: 1. Use one Kconfig symbol for clocks of all ARM64 SoCs (after discussion): EXYNOS_ARM64_COMMON_CLK. 2. Minor cleanups after Tomasz's comments. 3. Added tags: Chanwoo's, Sylwester's, Alim's and Tomasz's (the tags were given for v1 but assuming that change from 1. is not major enough to require re-tagging). --- drivers/clk/samsung/Kconfig | 6 ++ drivers/clk/samsung/Makefile | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index 84196ecdaa12..3a2c032965e6 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -2,6 +2,7 @@ config COMMON_CLK_SAMSUNG bool select COMMON_CLK +# ARM SoCs: config S3C2410_COMMON_CLK bool select COMMON_CLK_SAMSUNG @@ -24,3 +25,8 @@ config S3C2443_COMMON_CLK bool select COMMON_CLK_SAMSUNG +# ARM64 SoCs (e.g. Exynos5433, Exynos7): +config EXYNOS_ARM64_COMMON_CLK + def_bool ARCH_EXYNOS + depends on ARM64 || COMPILE_TEST + select COMMON_CLK_SAMSUNG diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index 5f6833ea355d..fc367d4b2902 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250)+= clk-exynos5250.o obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o -obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o +obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 0/2] arm64: EXYNOS: Consolidate Exynos7 symbol
Hi, We don't need ARCH_EXYNOS7 symbol because all ARMv8 platforms should fall under generic ARCH_EXYNOS. In the same time there is no sense in building clocks for these ARMv8 SoCs on ARMv7 builds. In future this will also influence PMU [1] driver. Patch 2 *depends* on patch 1. Patch 1 received acks from Samsung clock folks so everything can go through Samsung-soc or ARM64 tree. Best regards, Krzysztof [1] https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg48090.html Krzysztof Kozlowski (2): clk: samsung: Don't build ARMv8 clock drivers on ARMv7 arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into ARCH_EXYNOS arch/arm64/Kconfig.platforms| 11 ++- arch/arm64/boot/dts/exynos/Makefile | 2 +- arch/arm64/configs/defconfig| 2 +- drivers/clk/samsung/Kconfig | 6 ++ drivers/clk/samsung/Makefile| 4 ++-- 5 files changed, 12 insertions(+), 13 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RESEND PATCH v3] dt-bindings: Consolidate SRAM bindings from all vendors
SRAM bindings for various SoCs, using the mmio-sram genalloc
API, are spread over different places - per SoC vendor. Since all of
these are quite similar (they depend on mmio-sram) move them to a common
place.
Suggested-by: Rob Herring
Signed-off-by: Krzysztof Kozlowski
Cc: Heiko Stuebner
Cc: Maxime Ripard
Cc: Chen-Yu Tsai
Cc: Kukjin Kim
Acked-by: Maxime Ripard
Acked-by: Heiko Stuebner
---
Changes since v2:
1. Update paths to sram.txt.
Changes since v1:
1. New patch. Extended suggestion from Rob.
---
Documentation/devicetree/bindings/arm/arm,scpi.txt | 2 +-
.../bindings/{arm/rockchip/pmu-sram.txt => sram/rockchip-pmu-sram.txt} | 0
.../bindings/{arm/rockchip/smp-sram.txt => sram/rockchip-smp-sram.txt} | 2 +-
.../bindings/{arm/exynos/smp-sysram.txt => sram/samsung-sram.txt} | 2 +-
Documentation/devicetree/bindings/{misc => sram}/sram.txt | 0
.../devicetree/bindings/{soc/sunxi/sram.txt => sram/sunxi-sram.txt} | 2 +-
6 files changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/{arm/rockchip/pmu-sram.txt =>
sram/rockchip-pmu-sram.txt} (100%)
rename Documentation/devicetree/bindings/{arm/rockchip/smp-sram.txt =>
sram/rockchip-smp-sram.txt} (92%)
rename Documentation/devicetree/bindings/{arm/exynos/smp-sysram.txt =>
sram/samsung-sram.txt} (95%)
rename Documentation/devicetree/bindings/{misc => sram}/sram.txt (100%)
rename Documentation/devicetree/bindings/{soc/sunxi/sram.txt =>
sram/sunxi-sram.txt} (97%)
diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt
b/Documentation/devicetree/bindings/arm/arm,scpi.txt
index 86302de67c2c..313dabdc14f9 100644
--- a/Documentation/devicetree/bindings/arm/arm,scpi.txt
+++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt
@@ -63,7 +63,7 @@ Required properties:
- compatible : should be "arm,juno-sram-ns" for Non-secure SRAM on Juno
The rest of the properties should follow the generic mmio-sram description
-found in ../../misc/sysram.txt
+found in ../../sram/sram.txt
Each sub-node represents the reserved area for SCPI.
diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt
b/Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/arm/rockchip/pmu-sram.txt
rename to Documentation/devicetree/bindings/sram/rockchip-pmu-sram.txt
diff --git a/Documentation/devicetree/bindings/arm/rockchip/smp-sram.txt
b/Documentation/devicetree/bindings/sram/rockchip-smp-sram.txt
similarity index 92%
rename from Documentation/devicetree/bindings/arm/rockchip/smp-sram.txt
rename to Documentation/devicetree/bindings/sram/rockchip-smp-sram.txt
index d9416fb8db6f..800701ecffca 100644
--- a/Documentation/devicetree/bindings/arm/rockchip/smp-sram.txt
+++ b/Documentation/devicetree/bindings/sram/rockchip-smp-sram.txt
@@ -12,7 +12,7 @@ Required sub-node properties:
- compatible : should be "rockchip,rk3066-smp-sram"
The rest of the properties should follow the generic mmio-sram discription
-found in ../../misc/sram.txt
+found in Documentation/devicetree/bindings/sram/sram.txt
Example:
diff --git a/Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
b/Documentation/devicetree/bindings/sram/samsung-sram.txt
similarity index 95%
rename from Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
rename to Documentation/devicetree/bindings/sram/samsung-sram.txt
index 4a0a4f70a0ce..6bc474b2b885 100644
--- a/Documentation/devicetree/bindings/arm/exynos/smp-sysram.txt
+++ b/Documentation/devicetree/bindings/sram/samsung-sram.txt
@@ -15,7 +15,7 @@ Required sub-node properties:
"samsung,exynos4210-sysram-ns" : for Non-secure SYSRAM
The rest of the properties should follow the generic mmio-sram discription
-found in ../../misc/sysram.txt
+found in Documentation/devicetree/bindings/sram/sram.txt
Example:
diff --git a/Documentation/devicetree/bindings/misc/sram.txt
b/Documentation/devicetree/bindings/sram/sram.txt
similarity index 100%
rename from Documentation/devicetree/bindings/misc/sram.txt
rename to Documentation/devicetree/bindings/sram/sram.txt
diff --git a/Documentation/devicetree/bindings/soc/sunxi/sram.txt
b/Documentation/devicetree/bindings/sram/sunxi-sram.txt
similarity index 97%
rename from Documentation/devicetree/bindings/soc/sunxi/sram.txt
rename to Documentation/devicetree/bindings/sram/sunxi-sram.txt
index 067698112f5f..8d5665468fe7 100644
--- a/Documentation/devicetree/bindings/soc/sunxi/sram.txt
+++ b/Documentation/devicetree/bindings/sram/sunxi-sram.txt
@@ -16,7 +16,7 @@ SRAM nodes
--
Each SRAM is described using the mmio-sram bindings documented in
-Documentation/devicetree/bindings/misc/sram.txt
+Documentation/devicetree/bindings/sram/sram.txt
Each SRAM will have SRAM sections that are going to be handled by the
SRAM controller as subnodes. These sections
Re: [PATCH v7 1/4] Documentation: dt-bindings: Describe SROMc configuration
On 12.11.2015 05:43, Rob Herring wrote: > On Wed, Nov 11, 2015 at 12:44 AM, Pavel Fedin wrote: >> Hello! >> +- samsung,srom-timing : array of 6 integers, specifying bank timings in the +following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs. +Each value is specified in cycles and has the following +meaning and valid range: +Tacp : Page mode access cycle at Page mode (0 - 15) +Tcah : Address holding time after CSn (0 - 15) +Tcoh : Chip selection hold on OEn (0 - 15) +Tacc : Access cycle (0 - 31, the actual time is N + 1) +Tcos : Chip selection set-up before OEn (0 - 15) +Tacs : Address set-up before CSn (0 - 15) >>> >>> This is not easily extended. Perhaps a property per value instead. >> >> We had a discussion with Krzysztof about it, he agreed with this form of >> the property. >> My concern was that it's just too much typing, and makes little sense >> because these >> settings always go together. If register layout changes, or parameter set >> changes in >> incompatible way, then it's another device, not exynos-srom anymore. >> So would you agree with that, or is your position strong? > > I'm thinking for a new version of the controller which could add (or > remove) new timing parameters, but then I guess you can interpret the > field differently based on the compatible string. Anyway, your problem > to deal with. Actually I also preferred properties per one timing... but finally agreed on simpler approach. Adding new parameters to the array is still possible (because the order matters) and removal as well (by ignoring some indices). All ARMv7 Exynos SoCs have exactly the same registers for SROM controller (Exynos3250, Exynos4, Exynos5). On newer Exynos ARMv8 (Exynos5433 and Exynos7420) I don't know because it is not documented. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC
On 09.11.2015 14:54, Alim Akhtar wrote: > Hi Krzysztof, > > On 11/07/2015 08:39 AM, Krzysztof Kozlowski wrote: >> W dniu 07.11.2015 o 07:33, Rob Herring pisze: >>> On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >>>> From: Thomas Abraham >>>> >>>> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 >>>> device >>>> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck >>>> regulators. >>>> This also supports RTC and three 32.768KHz clock outputs. >>>> >>>> Cc: devicetree@vger.kernel.org >>>> Signed-off-by: Thomas Abraham >>>> Signed-off-by: Alim Akhtar >>>> --- >>>> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 >>>> ++--- >>>> 1 file changed, 14 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> index 890f0b0e1643..4c0543ceec25 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >>>> @@ -1,5 +1,5 @@ >>>> >>>> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current >>>> Regulator >>>> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >>>> >>>> The Samsung S2MPS11 is a multi-function device which includes >>>> voltage and >>>> current regulators, RTC, charger controller and other sub-blocks. >>>> It is >>>> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C >>>> interface. Each sub-block is >>>> addressed by the host system using different I2C slave addresses. >>>> >>>> Required properties: >>>> -- compatible: Should be "samsung,s2mps11-pmic" or >>>> "samsung,s2mps13-pmic" >>>> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >>>> +- compatible: Should be one of the following >>>> +- "samsung,s2mps11-pmic" >>>> +- "samsung,s2mps13-pmic" >>>> +- "samsung,s2mps14-pmic" >>>> +- "samsung,s2mps15-pmic" >>>> +- "samsung,s2mpu02-pmic". >>>> - reg: Specifies the I2C slave address of the pmic block. It >>>> should be 0x66. >>>> >>>> Optional properties: >>>> @@ -24,7 +28,7 @@ Optional properties: >>>> unwanted buck warm reset (setting buck voltages to default values). >>>> >>>> Optional nodes: >>>> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) >>>> buffered 32.768 >>>> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide >>>> three(AP/CP/BT) buffered 32.768 >>> >>> s5m8767 doesn't seem to be documented. Can you please fix or remove. >> >> What exactly do you have in mind? >> >> The s5m8767-clk is already documented as part of clk-s2mps11.c driver: >> Documentation/devicetree/bindings/mfd/s2mps11.txt >> >> The main s5m8767 MFD driver is documented as part of regulator driver: >> Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt >> >> Yes, this may be confusing... They S2M and S5M family devices share: >> - main mfd driver, >> - rtc driver, >> - clk driver. >> >> but regulator drivers are separate. >> > Indeed things are documented but in very confusing manners, e.g. > compatible name "samsung,s5m8767-pmic" belongs to MFD not regulator. The compatible itself belongs to MFD but in the same time the required properties for regulator driver (which expects to be child of that compatible) are stored next to it. > It should have being in */bindings/mfd/s2mps11.txt > Not sure if it make sense to change it though. Then the naming would be confusing. :) Actually I have it on my todo list to fix things up. Truth is that all of these devices are tightly coupled. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC
W dniu 07.11.2015 o 07:33, Rob Herring pisze: > On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >> From: Thomas Abraham >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> This also supports RTC and three 32.768KHz clock outputs. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Thomas Abraham >> Signed-off-by: Alim Akhtar >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 21 >> ++--- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> index 890f0b0e1643..4c0543ceec25 100644 >> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> @@ -1,5 +1,5 @@ >> >> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current >> Regulator >> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >> >> The Samsung S2MPS11 is a multi-function device which includes voltage and >> current regulators, RTC, charger controller and other sub-blocks. It is >> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. >> Each sub-block is >> addressed by the host system using different I2C slave addresses. >> >> Required properties: >> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >> +- compatible: Should be one of the following >> +- "samsung,s2mps11-pmic" >> +- "samsung,s2mps13-pmic" >> +- "samsung,s2mps14-pmic" >> +- "samsung,s2mps15-pmic" >> +- "samsung,s2mpu02-pmic". >> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >> >> Optional properties: >> @@ -24,7 +28,7 @@ Optional properties: >>unwanted buck warm reset (setting buck voltages to default values). >> >> Optional nodes: >> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered >> 32.768 >> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) >> buffered 32.768 > > s5m8767 doesn't seem to be documented. Can you please fix or remove. What exactly do you have in mind? The s5m8767-clk is already documented as part of clk-s2mps11.c driver: Documentation/devicetree/bindings/mfd/s2mps11.txt The main s5m8767 MFD driver is documented as part of regulator driver: Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt Yes, this may be confusing... They S2M and S5M family devices share: - main mfd driver, - rtc driver, - clk driver. but regulator drivers are separate. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration
On 06.11.2015 17:14, Pavel Fedin wrote: > Hello! > >>> +- samsung,srom-timing : array of 6 integers, specifying bank timings in the >>> +following order: Tacp, Tcah, Tcoh, Tacc, Tcos, >>> Tacs. >>> +Each value is specified in cycles and has the >>> following >>> +meaning and valid range: >>> +Tacp : Page mode access cycle at Page mode (0 - 15) >>> +Tcah : Address holding time after CSn (0 - 15) >>> +Tcoh : Chip selection hold on OEn (0 - 15) >>> +Tacc : Access cycle (0 - 32) >> >> All of the manuals have error here. Probably it can be either: 1-32 or >> 0-31. I would bet on 0-31, what do you think? > > Damn, everything starts from 0, so i automatically put '0 - 32'. The actual > time, however, varies from 1 to 32, but the value is > from 0 to 31, i. e. - 1 > What shall we do? Just document this, or adjust the code to take number of > cycles and subtract 1? To tell the truth, i'm already > sick of these small fixups, and i would prefer just to fix documentation. Whatever you choose. Just make it correct. :) The problem is that Datasheet has errors for these values... Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 4/4] ARM: dts: Add Ethernet chip to SMDK5410
On 05.11.2015 21:03, Pavel Fedin wrote: > The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO > initialization is required. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 > +++ > arch/arm/boot/dts/exynos5410.dtsi | 6 + > 2 files changed, 47 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 3/4] drivers: exynos-srom: Add support for bank configuration
On 05.11.2015 21:03, Pavel Fedin wrote: > Implement handling properties in subnodes and adding child devices to the > system. Child devices will not be added if configuration fails. > > Since the driver now does more than suspend-resume support, dependency on > CONFIG_PM is removed. > > Signed-off-by: Pavel Fedin > --- > arch/arm/mach-exynos/Kconfig | 2 +- > drivers/soc/samsung/Kconfig | 2 +- > drivers/soc/samsung/exynos-srom.c | 61 > +-- > 3 files changed, 61 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410
On 05.11.2015 21:03, Pavel Fedin wrote: > This machine uses own SoC device tree file, add missing part. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410.dtsi | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
