Re: [PATCH v2 0/9] ARM: dts: Add compatible property to "partitions" node

[Simon Horman]

On Mon, Dec 28, 2015 at 11:15:30AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Dec 28, 2015 at 6:01 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Mon, Dec 21, 2015 at 11:33:44AM +0100, Geert Uytterhoeven wrote:
> >> As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible
> >> property to "partitions" node"), which is in v4.4-rc6, the "partitions"
> >> subnode of an SPI FLASH device node must have a compatible property. The
> >> partitions are no longer detected if it is not present.
> >>
> >> However, several DTSes in -next have already been converted to the
> >> "partitions" subnode without "compatible" property, introduced by
> >> commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a
> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
> >> partitions in a special 'partitions' subnode"). Hence all of these are
> >> now broken in -next, and will be broken in upstream during the merge
> >> window.
> >>
> >> This series fixes all users in next-20151221.
> >> Tested on r8a7791/koelsch.
> >>
> >> Changes since v1:
> >>   - Add Acked-by,
> >>   - Fix new users in -next (kirkwood, ci20).
> >>
> >> Most of these are in arm-soc/for-next. Exceptions are kirkwood (in
> >> mvebu/for-next), and ci20 (in mips/mips-for-linux-next).
> >>
> >> Given we're late in the v4.4-rc cycle, perhaps it's easiest if the
> >> arm-soc maintainers take all applicable patches directly, bypassing the
> >> mvebu and shmobile maintainers?
> >>
> >> Thanks for queuing for v4.5!
> >>
> >> Geert Uytterhoeven (9):
> >>   ARM: mvebu: ix4-300d: Add compatible property to "partitions" node
> >>   ARM: mvebu: kirkwood: Add compatible property to "partitions" node
> >>   ARM: shmobile: bockw dts: Add compatible property to "partitions" node
> >>   ARM: shmobile: lager dts: Add compatible property to "partitions" node
> >>   ARM: shmobile: koelsch dts: Add compatible property to "partitions"
> >> node
> >>   ARM: shmobile: porter dts: Add compatible property to "partitions"
> >> node
> >>   ARM: shmobile: gose dts: Add compatible property to "partitions" node
> >>   ARM: shmobile: silk dts: Add compatible property to "partitions" node
> >
> > Thanks, I have queued up the above "shmobile" patches for v4.6.
> 
> I'm afraid v4.6 is too late, leaving all SPI FLASHes broken in v4.5.

Thanks. I'll re-queue them up as fixes for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/6] arm64: renesas: add USB 2.0 device nodes for r8a7795

[Simon Horman]

On Fri, Dec 25, 2015 at 08:52:35PM +0900, Yoshihiro Shimoda wrote:
> This patch set is based on the renesas.git / 
> 20151221renesas-devel-20151221-v4.4-rc6 tag.
> (commit id = fe0e8e675dedf1877709a17258e88151c2614b77)
> 
> Changed from v1:
>  - Fix register size from 0xff to 0x100 in patch 2

Thanks, I have queued these up for v4.6.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: porter: add DU DT support

[Simon Horman]

On Mon, Dec 28, 2015 at 05:35:33PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/28/2015 08:29 AM, Simon Horman wrote:
> 
> >>Define  the Porter board dependent part of the DU device node.
> >>Add the device node  for Analog Devices ADV7511W  HDMI transmitter to I2C2
> >>bus and the HDMI connector. Add the necessary subnodes to interconnect  DU
> >>and HDMI devices.
> >>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com>
> >>
> >>---
> >>This patch is against 'renesas-devel-20151221-v4.4-rc6' tag of Simon 
> >>Horman's
> >>'renesas.git' repo.
> >
> >Thanks, I have queued this up for v4.6.
> 
>Actually, I was going to check this patch WRT the DU channels used, given
> Laurent's remark. OK, I will just send an incremental patch if needed.

Thanks and sorry for being a bit hasty.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: porter: add DU DT support

[Simon Horman]

On Fri, Dec 25, 2015 at 01:45:30AM +0300, Sergei Shtylyov wrote:
> Define  the Porter board dependent part of the DU device node.
> Add the device node  for Analog Devices ADV7511W  HDMI transmitter to I2C2
> bus and the HDMI connector. Add the necessary subnodes to interconnect  DU
> and HDMI devices.
> 
> Signed-off-by: Sergei Shtylyov 
> 
> ---
> This patch is against 'renesas-devel-20151221-v4.4-rc6' tag of Simon Horman's
> 'renesas.git' repo.

Thanks, I have queued this up for v4.6.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/9] ARM: dts: Add compatible property to "partitions" node

[Simon Horman]

On Mon, Dec 21, 2015 at 11:33:44AM +0100, Geert Uytterhoeven wrote:
>   Hi,
> 
> As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add compatible
> property to "partitions" node"), which is in v4.4-rc6, the "partitions"
> subnode of an SPI FLASH device node must have a compatible property. The
> partitions are no longer detected if it is not present.
> 
> However, several DTSes in -next have already been converted to the
> "partitions" subnode without "compatible" property, introduced by
> commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a
> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
> partitions in a special 'partitions' subnode"). Hence all of these are
> now broken in -next, and will be broken in upstream during the merge
> window.
> 
> This series fixes all users in next-20151221.
> Tested on r8a7791/koelsch.
> 
> Changes since v1:
>   - Add Acked-by,
>   - Fix new users in -next (kirkwood, ci20).
> 
> Most of these are in arm-soc/for-next. Exceptions are kirkwood (in
> mvebu/for-next), and ci20 (in mips/mips-for-linux-next).
> 
> Given we're late in the v4.4-rc cycle, perhaps it's easiest if the
> arm-soc maintainers take all applicable patches directly, bypassing the
> mvebu and shmobile maintainers?
> 
> Thanks for queuing for v4.5!
> 
> Geert Uytterhoeven (9):
>   ARM: mvebu: ix4-300d: Add compatible property to "partitions" node
>   ARM: mvebu: kirkwood: Add compatible property to "partitions" node
>   ARM: shmobile: bockw dts: Add compatible property to "partitions" node
>   ARM: shmobile: lager dts: Add compatible property to "partitions" node
>   ARM: shmobile: koelsch dts: Add compatible property to "partitions"
> node
>   ARM: shmobile: porter dts: Add compatible property to "partitions"
> node
>   ARM: shmobile: gose dts: Add compatible property to "partitions" node
>   ARM: shmobile: silk dts: Add compatible property to "partitions" node

Thanks, I have queued up the above "shmobile" patches for v4.6.

>   MIPS: dts: jz4780/ci20: Add compatible property to "partitions" node
> 
>  arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts  | 1 +
>  arch/arm/boot/dts/kirkwood-pogoplug-series-4.dts | 1 +
>  arch/arm/boot/dts/r8a7778-bockw.dts  | 1 +
>  arch/arm/boot/dts/r8a7790-lager.dts  | 1 +
>  arch/arm/boot/dts/r8a7791-koelsch.dts| 1 +
>  arch/arm/boot/dts/r8a7791-porter.dts | 1 +
>  arch/arm/boot/dts/r8a7793-gose.dts   | 1 +
>  arch/arm/boot/dts/r8a7794-silk.dts   | 1 +
>  arch/mips/boot/dts/ingenic/ci20.dts  | 1 +
>  9 files changed, 9 insertions(+)
> 
> -- 
> 1.9.1
> 
> Gr{oetje,eeting}s,
> 
>   Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
>   -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: I2C eeprom compatibles? (was Re: [PATCH/RFC 03/19] ARM: shmobile: gose: add i2c2 bus to device tree)

[Simon Horman]

On Fri, Dec 18, 2015 at 11:32:15AM +0100, Wolfram Sang wrote:
> On Fri, Dec 18, 2015 at 10:06:48AM +0100, Arnd Bergmann wrote:
> > On Friday 18 December 2015 08:35:32 Wolfram Sang wrote:
> > > > 
> > > > It seems to me that we have some consensus around:
> > > > 
> > > >   compatible = "renesas,r1ex24002", "24c02";
> > > 
> > > Thinking again, "generic,24c02" or "generic-24c02" could also be an
> > > option.
> > > 
> > > > Should this be added to 
> > > > Documentation/devicetree/bindings/eeprom/eeprom.txt ?
> > > > Or documented elsewhere?
> > > 
> > > Probably we need a DT maintainers advice here? I don't mind vendor
> > > specific compatibles being documented, but I'm reluctant to add all
> > > these compatibles for the myriads of I2C eeproms to the at24 driver. 99%
> > > are covered by the generic case.
> > > 
> > > Adding DT to CC.
> > 
> > I'd rather use some vendor string in addition to 24c02. Isn't this 
> > originally
> > an Atmel part? In that case, using "atmel,24c02" as the most generic string
> > would be appropriate,
> 
> Yeah, the at24 driver is named after Atmel chips AFAIR. Having "atmel,*"
> as the generic fallback sounds like a good solution to me, too.
> 
> > and IIRC the i2c framework will just match that with
> > the "24c02" entry in the i2c_device_id list.
> 
> True, although this behaviour is often complained about. There have been
> attempts to make i2c/spi behave like the rest of the DT world and to
> deprecate the current way. It didn't happen because of lots gory details,
> however :/

My reading of the above is that we are currently leaning towards:

compatible = "renesas,r1ex24002", "atmel,24c02";

And we are unsure what to do about the documentation.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/7] ARM: shmobile: dtsi: Add SCIF fallback compatibility strings

[Simon Horman]

On Mon, Dec 14, 2015 at 07:57:48PM +0100, Geert Uytterhoeven wrote:
>   Hi Simon, Magnus,
> 
> This patch series adds fallback compatibility strings for SCIF and HSCIF
> to the DTS files for R-Car Gen1, Gen2, and Gen3, as defined in
> "[PATCH v3 02/27] serial: sh-sci: Add fallback compatibility strings" of
> series "[PATCH v3 00/27] serial: sh-sci: External Clock Support".
> This will allow the sh-sci driver to match on family-specific compatible
> values to enable BGR support later.
> 
> Note that fallback compatibility strings for SCIFA/SCIFB are not added
> yet.
> 
> Dependencies:
>   - This series is against renesas-devel-20151214-v4.4-rc5,
>   - It can be applied independently, as soon as the aforementioned DT
> binding patch has been accepted,
>   - Later series depend on this:
>   - "[PATCH v3 00/12] ARM: shmobile: dtsi: Rename the serial port
>clock to fck",
>   - "[PATCH v2 0/7] ARM: shmobile: dtsi: Add BRG support for (H)SCIF",
>   - "[PATCH v2 0/9] ARM: shmobile: dts: Enable SCIF_CLK frequency and
>pins".

I have marked this and the above series as deferred pending
acceptance of the driver changes.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 0/3] usb: renesas_usbhs: More compat strings

[Simon Horman]

Hi,

this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.

Changes since v3:
* State that one or more compat string should be used

Changes since v2:
* Split documentation of SoC names into separate patch
* Use correct fallback compatibility string in example

Changes since v1:
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
a single compatibility string for all of R-Car.

Simon Horman (3):
  usb: renesas_usbhs: add SoC names to compatibility string
documentation
  usb: renesas_usbhs: add fallback compatibility strings
  usb: renesas_usbhs: add device tree support for r8a779[23]

 .../devicetree/bindings/usb/renesas_usbhs.txt  | 22 --
 drivers/usb/renesas_usbhs/common.c |  9 +
 2 files changed, 25 insertions(+), 6 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

[Simon Horman]

This extends the documentation of compatibility strings a little to
include the SoC names.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Acked-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com>

---
v3
* Split into separate patch
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63db44e..a14c0bb561d5 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,10 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
-   - "renesas,usbhs-r8a7790"
-   - "renesas,usbhs-r8a7791"
-   - "renesas,usbhs-r8a7794"
-   - "renesas,usbhs-r8a7795"
+   - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
+   - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
+   - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Acked-by: Rob Herring <r...@kernel.org>
Acked-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 45d9ae13ffa3..b6040563e51a 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -5,6 +5,8 @@ Required properties:
 
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
+   - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v4 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Acked-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com>
---
v4
* State that one or more compat string should be used

v3
* Moved documentation of SoC names to a separate patch
* Use correct fallback compatibility string in example

v2
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 12 ++--
 drivers/usb/renesas_usbhs/common.c  |  9 +
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index a14c0bb561d5..45d9ae13ffa3 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -1,11 +1,19 @@
 Renesas Electronics USBHS driver
 
 Required properties:
-  - compatible: Must contain one of the following:
+  - compatible: Must contain one or more of the following:
+
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
+   - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
+   - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first followed
+   by the generic version.
+
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
@@ -22,7 +30,7 @@ Optional properties:
 
 Example:
usbhs: usb@e659 {
-   compatible = "renesas,usbhs-r8a7790";
+   compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs";
reg = <0 0xe659 0 0x100>;
interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index d82fa36c3465..db9a17bd8997 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
+   {
+   .compatible = "renesas,rcar-gen2-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
+   {
+   /* Gen3 is compatible with Gen2 */
+   .compatible = "renesas,rcar-gen3-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] arm64: dts: r8a7795: Add Cortex-A57 CPU cores

[Simon Horman]

On Sat, Dec 12, 2015 at 08:07:51AM +0900, Simon Horman wrote:
> On Fri, Dec 04, 2015 at 02:38:52PM +0100, Dirk Behme wrote:
> > From: Gaku Inami <gaku.inami...@bp.renesas.com>
> > 
> > Add Cortex-A57 CPU cores to r8a7795 SoC for a total of 4 x Cortex-A57.
> > 
> > Signed-off-by: Gaku Inami <gaku.inami...@bp.renesas.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara...@renesas.com>
> > Sigend-off-by: Dirk Behme <dirk.be...@gmail.com>
> 
> Thanks, I have queued this up for v4.5.

I meant to test this earlier but somehow it slopped my mind.

With this patch applied I still only see one CPU brought up
whereas I was expecting 4. Are more patches needed in order to
get more CPUs operating?

I am using renesas-devel-20151214-v4.4-rc5 + the cpg-mmsr driver (v6).
I built the kernel using the defconfig.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

On Fri, Dec 11, 2015 at 03:24:27PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/11/2015 5:12 AM, Simon Horman wrote:
> 
> >Add fallback compatibility strings for R-Car Gen2 and Gen3.
> >This is in keeping with the fallback scheme being adopted wherever
> >appropriate for drivers for Renesas SoCs.
> >
> >Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> >---
> >v3
> >* Moved documentation of SoC names to a separate patch
> >* Use correct fallback compatibility string in example
> >
> >v2
> >* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
> >   a single compatibility string for all of R-Car.
> >---
> >  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +-
> >  drivers/usb/renesas_usbhs/common.c  |  9 +
> >  2 files changed, 18 insertions(+), 1 deletion(-)
> >
> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
> >b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >index a14c0bb561d5..c55cf77006d0 100644
> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
> >
> >  Required properties:
> >- compatible: Must contain one of the following:
> 
>Really?

Would "...one or more of the following" help?

> >+
> > - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> > - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> > - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
> > - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
> >+- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
> >+- "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
> >+
> >+When compatible with the generic version, nodes must list the
> >+SoC-specific version corresponding to the platform first followed
> >+by the generic version.
> >+
> 
>This kinda contradicts the above claim.
> 
> [...]
> 
> MBR, Sergei
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8 v5] enable to use thermal-zone on r8a7790/1

[Simon Horman]

On Tue, Dec 15, 2015 at 01:16:20AM +, Kuninori Morimoto wrote:
> 
> Hi
> 
> These are v5 of thermal-zone support for r8a7790/r8a7791.
> 
> Kuninori Morimoto (8):
>   1) thermal: rcar: move rcar_thermal_dt_ids to upside
>   2) thermal: rcar: check every rcar_thermal_update_temp() return value
>   3) thermal: rcar: check irq possibility in rcar_thermal_irq_xxx()
>   4) thermal: rcar: rcar_thermal_get_temp() return error if strange temp
>   5) thermal: rcar: enable to use thermal-zone on DT
>   6) ARM: shmobile: r8a7790: enable to use thermal-zone
>   7) ARM: shmobile: r8a7791: enable to use thermal-zone
>   8) thermal: of-thermal: of_thermal_set_trip_temp() call 
> thermal_zone_device_update()

I have marked patches 6 and 7 as deferred pending acceptance of the driver
changes.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/16] serial: sh-sci: Drop the interface clock

[Simon Horman]

On Mon, Dec 14, 2015 at 05:15:40PM +0900, Simon Horman wrote:
> Hi Greg,
> 
> On Sat, Dec 12, 2015 at 10:42:37PM -0800, Greg Kroah-Hartman wrote:
> > On Thu, Nov 19, 2015 at 07:35:58PM +0100, Geert Uytterhoeven wrote:
> > > From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> > > 
> > > As no platform defines an interface clock the SCI driver always falls
> > > back to a clock named "peripheral_clk".
> > >   - On SH platforms that clock is the base clock for the SCI functional
> > > clock and has the same frequency,
> > >   - On ARM platforms that clock doesn't exist, and clk_get() will return
> > > the default clock for the device.
> > > We can thus make the functional clock mandatory and drop the interface
> > > clock.
> > > 
> > > EPROBE_DEFER is handled for clocks that may be referenced from DT (i.e.
> > > "fck" and deprecated "sci_ick").
> > > 
> > > Cc: devicetree@vger.kernel.org
> > > Signed-off-by: Laurent Pinchart 
> > > <laurent.pinchart+rene...@ideasonboard.com>
> > > Acked-by: Simon Horman <horms+rene...@verge.net.au>
> > > [geert: Handle EPROBE_DEFER, reformat description, break long comment 
> > > line]
> > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> > 
> > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> 
> If its not too much trouble I would prefer if you took this into the serial
> tree.

Sorry, I meant to can this email rather than sent it.
Please ignore the above!!!
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/16] serial: sh-sci: Drop the interface clock

[Simon Horman]

Hi Greg,

On Sat, Dec 12, 2015 at 10:42:37PM -0800, Greg Kroah-Hartman wrote:
> On Thu, Nov 19, 2015 at 07:35:58PM +0100, Geert Uytterhoeven wrote:
> > From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> > 
> > As no platform defines an interface clock the SCI driver always falls
> > back to a clock named "peripheral_clk".
> >   - On SH platforms that clock is the base clock for the SCI functional
> > clock and has the same frequency,
> >   - On ARM platforms that clock doesn't exist, and clk_get() will return
> > the default clock for the device.
> > We can thus make the functional clock mandatory and drop the interface
> > clock.
> > 
> > EPROBE_DEFER is handled for clocks that may be referenced from DT (i.e.
> > "fck" and deprecated "sci_ick").
> > 
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> > Acked-by: Simon Horman <horms+rene...@verge.net.au>
> > [geert: Handle EPROBE_DEFER, reformat description, break long comment line]
> > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> 
> Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

If its not too much trouble I would prefer if you took this into the serial
tree.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] staging: board: armadillo800eva: Use "arm,pl390"

[Simon Horman]

On Mon, Dec 14, 2015 at 08:51:24AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Dec 14, 2015 at 7:29 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Sun, Dec 13, 2015 at 09:16:47PM -0800, Greg Kroah-Hartman wrote:
> >> On Mon, Dec 14, 2015 at 02:05:26PM +0900, Simon Horman wrote:
> >> > On Fri, Dec 11, 2015 at 11:28:30AM -0500, Greg Kroah-Hartman wrote:
> >> > > On Fri, Nov 20, 2015 at 01:36:57PM +0100, Geert Uytterhoeven wrote:
> >> > > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> >> > > > ---
> >> > > > Must be applied together with "ARM: shmobile: r8a7740 dtsi: Use
> >> > > > "arm,pl390" for GIC"!
> >> > > >
> >> > > > Greg: Can you please provide your ack? Thanks!
> >> > >
> >> > > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> >> >
> >> > Thanks Greg,
> >> >
> >> > I have taken the liberty of assuming that ack also applies to
> >> > patch 5/6 of this series, the other staging/board patch in
> >> > this series.
> >>
> >> Oops, yes, good call, thanks for doing this.
> >
> > No problem.
> >
> > For the record I have queued up these patches for v4.6 as I
> > believe that the ARM SoC maintainers prefer not to have
> > driver changes depending on DT changes and the first four patches
> > of this series are DT changes.
> 
> Do you mean you have queued up the DT changes for v4.5, and the
> staging changes for v4.6.? That would break staging/board in v4.5, as both
> changes should be together as close as possible.

That is what I meant. Thanks for letting me know that it wont fly.
I'll see about bundling all the changes in a single branch for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] staging: board: armadillo800eva: Use "arm,pl390"

[Simon Horman]

On Fri, Dec 11, 2015 at 11:28:30AM -0500, Greg Kroah-Hartman wrote:
> On Fri, Nov 20, 2015 at 01:36:57PM +0100, Geert Uytterhoeven wrote:
> > Signed-off-by: Geert Uytterhoeven 
> > ---
> > Must be applied together with "ARM: shmobile: r8a7740 dtsi: Use
> > "arm,pl390" for GIC"!
> > 
> > Greg: Can you please provide your ack? Thanks!
> 
> Acked-by: Greg Kroah-Hartman 

Thanks Greg,

I have taken the liberty of assuming that ack also applies to
patch 5/6 of this series, the other staging/board patch in
this series.

I have queued up this series accordingly.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] staging: board: armadillo800eva: Use "arm,pl390"

[Simon Horman]

On Sun, Dec 13, 2015 at 09:16:47PM -0800, Greg Kroah-Hartman wrote:
> On Mon, Dec 14, 2015 at 02:05:26PM +0900, Simon Horman wrote:
> > On Fri, Dec 11, 2015 at 11:28:30AM -0500, Greg Kroah-Hartman wrote:
> > > On Fri, Nov 20, 2015 at 01:36:57PM +0100, Geert Uytterhoeven wrote:
> > > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> > > > ---
> > > > Must be applied together with "ARM: shmobile: r8a7740 dtsi: Use
> > > > "arm,pl390" for GIC"!
> > > > 
> > > > Greg: Can you please provide your ack? Thanks!
> > > 
> > > Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > 
> > Thanks Greg,
> > 
> > I have taken the liberty of assuming that ack also applies to
> > patch 5/6 of this series, the other staging/board patch in
> > this series.
> 
> Oops, yes, good call, thanks for doing this.

No problem.

For the record I have queued up these patches for v4.6 as I
believe that the ARM SoC maintainers prefer not to have
driver changes depending on DT changes and the first four patches
of this series are DT changes.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] arm64: dts: r8a7795: Add pmu device nodes

[Simon Horman]

On Fri, Dec 04, 2015 at 02:38:53PM +0100, Dirk Behme wrote:
> From: Yoshifumi Hosoya 
> 
> Enabling the performance monitor unit on r8a7795.
> 
> Signed-off-by: Masaru Nagai 
> Signed-off-by: Yoshifumi Hosoya 
> Sigend-off-by: Dirk Behme 

I took the liberty of correcting the spelling of "Signed" when
queuing up this patch for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] arm64: dts: r8a7795: Add PSCI node

[Simon Horman]

On Fri, Dec 04, 2015 at 02:38:51PM +0100, Dirk Behme wrote:
> From: Gaku Inami 
> 
> Add PSCI node for r8a7795 SoC, and cpu node enable-method property is
> set to "psci".
> 
> Signed-off-by: Gaku Inami 
> Signed-off-by: Takeshi Kihara 
> Sigend-off-by: Dirk Behme 

I took the liberty of correcting the spelling of "Sigend" when
queueing this patch up for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] arm64: dts: r8a7795: Add Cortex-A57 CPU cores

[Simon Horman]

On Fri, Dec 04, 2015 at 02:38:52PM +0100, Dirk Behme wrote:
> From: Gaku Inami 
> 
> Add Cortex-A57 CPU cores to r8a7795 SoC for a total of 4 x Cortex-A57.
> 
> Signed-off-by: Gaku Inami 
> Signed-off-by: Takeshi Kihara 
> Sigend-off-by: Dirk Behme 

Thanks, I have queued this up for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

On Thu, Dec 10, 2015 at 07:28:06AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> Thank you for your patch
> 
> > Add fallback compatibility strings for R-Car Gen2 and Gen3.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Also add SoC names.
> > 
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > ---
> (snip)
> >  Required properties:
> >- compatible: Must contain one of the following:
> > -   - "renesas,usbhs-r8a7790"
> > -   - "renesas,usbhs-r8a7791"
> > -   - "renesas,usbhs-r8a7794"
> > -   - "renesas,usbhs-r8a7795"
> > +
> > +   - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
> > +   - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
> > +   - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
> > +   - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
> > +   - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device
> > +   - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device
> > +
> > +   When compatible with the generic version, nodes must list the
> > +   SoC-specific version corresponding to the platform first followed
> > +   by the generic version.
> 
> I think these can be separated ?
> 
>  1. document update for "renesas,usbhs-r8a77xx"
>  2. add new "rcar-genX" (this patch)

Sure, will do.

> >  Example:
> > usbhs: usb@e659 {
> > -   compatible = "renesas,usbhs-r8a7790";
> > +   compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs";
> 
> I think you want
> 
>  -compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs";
>  +compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs";

Thanks, I will fix that.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
v3
* Moved documentation of SoC names to a separate patch
* Use correct fallback compatibility string in example

v2
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 +-
 drivers/usb/renesas_usbhs/common.c  |  9 +
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index a14c0bb561d5..c55cf77006d0 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
+
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
+   - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
+   - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatible device
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first followed
+   by the generic version.
+
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
@@ -22,7 +30,7 @@ Optional properties:
 
 Example:
usbhs: usb@e659 {
-   compatible = "renesas,usbhs-r8a7790";
+   compatible = "renesas,usbhs-r8a7790", "renesas,rcar-gen2-usbhs";
reg = <0 0xe659 0 0x100>;
interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index d82fa36c3465..db9a17bd8997 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
+   {
+   .compatible = "renesas,rcar-gen2-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
+   {
+   /* Gen3 is compatible with Gen2 */
+   .compatible = "renesas,rcar-gen3-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Acked-by: Rob Herring <r...@kernel.org>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index c55cf77006d0..471a0649e63e 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -5,6 +5,8 @@ Required properties:
 
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
+   - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatible device
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

[Simon Horman]

This extends the documentation of compatibility strings a little to
include the SoC names.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
v3
* Split into separate patch
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63db44e..a14c0bb561d5 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,10 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
-   - "renesas,usbhs-r8a7790"
-   - "renesas,usbhs-r8a7791"
-   - "renesas,usbhs-r8a7794"
-   - "renesas,usbhs-r8a7795"
+   - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
+   - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
+   - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 0/3] usb: renesas_usbhs: More compat strings

[Simon Horman]

Hi,

this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.

Changes since v2:
* Split documentation of SoC names into separate patch
* Use correct fallback compatibility string in example

Changes since v1:
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.

Simon Horman (3):
  usb: renesas_usbhs: add SoC names to compatibility string
documentation
  usb: renesas_usbhs: add fallback compatibility strings
  usb: renesas_usbhs: add device tree support for r8a779[23]

 .../devicetree/bindings/usb/renesas_usbhs.txt| 20 +++-
 drivers/usb/renesas_usbhs/common.c   |  9 +
 2 files changed, 24 insertions(+), 5 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/4] PCI: rcar, rcar-gen2: More Gen2 compatibility strings

[Simon Horman]

On Wed, Dec 09, 2015 at 12:37:43PM -0600, Bjorn Helgaas wrote:
> On Thu, Dec 03, 2015 at 07:51:36AM +0900, Simon Horman wrote:
> > Hi,
> > 
> > this short series adds generic gen2 and SoC-specific r8a7793 compatibility
> > strings to the rcar PCI and rcar-gen2 PCIE drivers. The intention is to
> > provide a complete set of compatibility strings for known Gen2 SoCs.
> > 
> > Key Changes in v2:
> > * Include "rcar-" in generic bindings
> > 
> > Simon Horman (4):
> >   PCI: rcar-gen2: add gen2 fallback compatibility string
> >   PCI: rcar-gen2: add device tree support for r8a7793
> >   PCI: rcar: add gen2 fallback compatibility string
> >   PCI: rcar: add device tree support for r8a7793
> > 
> >  Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 12 ++--
> >  Documentation/devicetree/bindings/pci/rcar-pci.txt  | 14 +++---
> >  drivers/pci/host/pci-rcar-gen2.c|  1 +
> >  drivers/pci/host/pcie-rcar.c|  1 +
> >  4 files changed, 23 insertions(+), 5 deletions(-)
> 
> I applied these:
> 
> >   PCI: rcar-gen2: add gen2 fallback compatibility string
> >   PCI: rcar: add gen2 fallback compatibility string
> 
> to pci/host-rcar for v4.5, thanks!
> 
> I haven't applied the R8A7793 binding documentation updates yet, but
> I'll be happy to do so given a short description of why they're
> useful (since they don't update a DT or the driver).  Or they could be
> merged via a DT tree.

To clarify: you would like a description in the changelog?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

On Thu, Dec 10, 2015 at 09:56:24PM -0600, Rob Herring wrote:
> On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote:
> > Add fallback compatibility strings for R-Car Gen2 and Gen3.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> 
> Binding looks okay, but one possible typo.
> 
> Acked-by: Rob Herring <r...@kernel.org>
> 
> > --- a/drivers/usb/renesas_usbhs/common.c
> > +++ b/drivers/usb/renesas_usbhs/common.c
> > @@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
> > .compatible = "renesas,usbhs-r8a7795",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> > +   {
> > +   .compatible = "renesas,rcar-gen2-usbhs",
> > +   .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > +   },
> > +   {
> > +   /* Gen3 is compatible with Gen2 */
> > +   .compatible = "renesas,rcar-gen3-usbhs",
> > +   .data = (void *)USBHS_TYPE_RCAR_GEN2,
> 
> This supposed to be GEN3?

Confusingly the symbol is called GEN2 as it was there for Gen 2
before Gen 3 came along and (so far) Gen 3 is compatible with Gen 2.

I'd be happy to change the name but I think that would be best
as an incremental change on top of this one.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/8 v4] enable to use thermal-zone on r8a7790/1

[Simon Horman]

On Tue, Dec 08, 2015 at 05:26:20AM +, Kuninori Morimoto wrote:
> 
> Hi
> 
> These are v4 of thermal-zone support for r8a7790/r8a7791.
> Mainly, it cares return value of get_temp()
> 
> I think 8) is needed on of-thermal (?)
> 
> Kuninori Morimoto (8):
>   1) thermal: rcar: move rcar_thermal_dt_ids to upside
>   2) thermal: rcar: check every rcar_thermal_update_temp() return value
>   3) thermal: rcar: check irq possibility in rcar_thermal_irq_xxx()
>   4) thermal: rcar: retern error rcar_thermal_get_temp() if no ctemp 
> update
>   5) thermal: rcar: enable to use thermal-zone on DT
>   6) ARM: shmobile: r8a7790: enable to use thermal-zone
>   7) ARM: shmobile: r8a7791: enable to use thermal-zone
>   8) thermal: of-thermal: of_thermal_set_trip_temp() call 
> thermal_zone_device_update()
> 

I have marked patches 6 and 7 as deferred pending acceptance of the driver
changes.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/2] usb: renesas_usbhs: More compat strings

[Simon Horman]

Hi,

this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.

Changes since v1:
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.

*** BLURB HERE ***

Simon Horman (2):
  usb: renesas_usbhs: add fallback compatibility strings
  usb: renesas_usbhs: add device tree support for r8a779[23]

 .../devicetree/bindings/usb/renesas_usbhs.txt| 20 +++-
 drivers/usb/renesas_usbhs/common.c   |  9 +
 2 files changed, 24 insertions(+), 5 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen2 and Gen3.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Also add SoC names.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
v2
* Add R-Car Gen2 and Gen3 fallback compatibility strings rather than
  a single compatibility string for all of R-Car.
---
 .../devicetree/bindings/usb/renesas_usbhs.txt  | 18 +-
 drivers/usb/renesas_usbhs/common.c |  9 +
 2 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63db44e..b959059826cd 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,18 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: Must contain one of the following:
-   - "renesas,usbhs-r8a7790"
-   - "renesas,usbhs-r8a7791"
-   - "renesas,usbhs-r8a7794"
-   - "renesas,usbhs-r8a7795"
+
+   - "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
+   - "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
+   - "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
+   - "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device
+   - "renesas,rcar-gen3-usbhs" for R-Car Gen3 compatibile device
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first followed
+   by the generic version.
+
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
@@ -22,7 +30,7 @@ Optional properties:
 
 Example:
usbhs: usb@e659 {
-   compatible = "renesas,usbhs-r8a7790";
+   compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs";
reg = <0 0xe659 0 0x100>;
interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index d82fa36c3465..db9a17bd8997 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,15 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
+   {
+   .compatible = "renesas,rcar-gen2-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
+   {
+   /* Gen3 is compatible with Gen2 */
+   .compatible = "renesas,rcar-gen3-usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] usb: renesas_usbhs: add device tree support for r8a779[23]

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
Acked-by: Rob Herring <r...@kernel.org>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index b959059826cd..efb3199a2a80 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -5,6 +5,8 @@ Required properties:
 
- "renesas,usbhs-r8a7790" for r8a7790 (R-Car H2) compatible device
- "renesas,usbhs-r8a7791" for r8a7791 (R-Car M2-W) compatible device
+   - "renesas,usbhs-r8a7792" for r8a7792 (R-Car V2H) compatible device
+   - "renesas,usbhs-r8a7793" for r8a7793 (R-Car M2-N) compatible device
- "renesas,usbhs-r8a7794" for r8a7794 (R-Car E2) compatible device
- "renesas,usbhs-r8a7795" for r8a7795 (R-Car H3) compatible device
- "renesas,rcar-gen2-usbhs" for R-Car Gen2 compatibile device
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/13] ARM: shmobile: genmai dts: Update console parameters

[Simon Horman]

On Tue, Dec 08, 2015 at 06:54:10PM +0100, Geert Uytterhoeven wrote:
> Change the console alias to "serial0", for consistency with other
> boards (the first unlabeled serial port is always called "serial0").
> Add serial port config to chosen/stdout-path.
> 
> Signed-off-by: Geert Uytterhoeven 
> ---
>  arch/arm/boot/dts/r7s72100-genmai.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r7s72100-genmai.dts 
> b/arch/arm/boot/dts/r7s72100-genmai.dts
> index a9da7a89fc4ba65a..47533c2c419e164d 100644
> --- a/arch/arm/boot/dts/r7s72100-genmai.dts
> +++ b/arch/arm/boot/dts/r7s72100-genmai.dts
> @@ -17,12 +17,12 @@
>   compatible = "renesas,genmai", "renesas,r7s72100";
>  
>   aliases {
> - serial2 = 
> + serial0 = 
>   };
>  
>   chosen {
>   bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> - stdout-path = 
> + stdout-path = "serial0:115200n8";
>   };
>  
>   memory {

As noted elsewhere the serial2 -> serial0 portion of
this patch seems to result in no console.

I am wary about that change as it is user-space visible
but I didn't expect it to also have an impact on the kernel console.

In case it helps anyone now or in the future the output with earlyprintk
follows.

-- after with early printk --
[0.00] Booting Linux on physical CPU 0x0
[0.00] Linux version 4.4.0-rc4-00017-gb298a5a501ed-dirty 
(ho...@ayumi.isobedori.kobe.vergenet.net) (gcc version 4.6.3 (GCC) ) #1213 SMP 
Thu Dec 10 15:05:11 JST 2015
[0.00] CPU: ARMv7 Processor [413fc090] revision 0 (ARMv7), cr=18c5307d
[0.00] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing 
instruction cache
[0.00] Machine model: Genmai
[0.00] debug: ignoring loglevel setting.
[0.00] bootconsole [earlycon0] enabled
[0.00] Memory policy: Data cache writeback
[0.00] On node 0 totalpages: 32768
[0.00] free_area_init_node: node 0, pgdat c0829180, node_mem_map 
c7ef8000
[0.00]   Normal zone: 256 pages used for memmap
[0.00]   Normal zone: 0 pages reserved
[0.00]   Normal zone: 32768 pages, LIFO batch:7
[0.00] CPU: All CPU(s) started in SVC mode.
[0.00] PERCPU: Embedded 10 pages/cpu @c7ee s17984 r0 d22976 u40960
[0.00] pcpu-alloc: s17984 r0 d22976 u40960 alloc=10*4096
[0.00] pcpu-alloc: [0] 0 
[0.00] Built 1 zonelists in Zone order, mobility grouping on.  Total 
pages: 32512
[0.00] Kernel command line: console=ttySC2,115200 root=/dev/nfs rw 
ip=dhcp ignore_loglevel earlyprintk=sh-sci.2,115200
[0.00] PID hash table entries: 512 (order: -1, 2048 bytes)
[0.00] Dentry cache hash table entries: 16384 (order: 4, 65536 bytes)
[0.00] Inode-cache hash table entries: 8192 (order: 3, 32768 bytes)
[0.00] Memory: 121208K/131072K available (4976K kernel code, 242K 
rwdata, 1360K rodata, 1744K init, 268K bss, 9864K reserved, 0K cma-reserved, 0K 
highmem)
[0.00] Virtual kernel memory layout:
[0.00] vector  : 0x - 0x1000   (   4 kB)
[0.00] fixmap  : 0xffc0 - 0xfff0   (3072 kB)
[0.00] vmalloc : 0xc880 - 0xff80   ( 880 MB)
[0.00] lowmem  : 0xc000 - 0xc800   ( 128 MB)
[0.00] pkmap   : 0xbfe0 - 0xc000   (   2 MB)
[0.00]   .text : 0xc0008000 - 0xc063904c   (6341 kB)
[0.00]   .init : 0xc063a000 - 0xc07ee000   (1744 kB)
[0.00]   .data : 0xc07ee000 - 0xc082aa20   ( 243 kB)
[0.00].bss : 0xc082d000 - 0xc0870354   ( 269 kB)
[0.00] Hierarchical RCU implementation.
[0.00]  Build-time adjustment of leaf fanout to 32.
[0.00]  RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=1.
[0.00] RCU: Adjusting geometry for rcu_fanout_leaf=32, nr_cpu_ids=1
[0.00] NR_IRQS:16 nr_irqs:16 16
[0.00] clocksource_probe: no matching clocksources found
[0.00] sched_clock: 32 bits at 100 Hz, resolution 1000ns, wraps 
every 2147483647500ns
[0.00] Console: colour dummy device 80x30
[0.00] Calibrating delay loop (skipped) preset value.. 266.66 BogoMIPS 
(lpj=133)
[0.00] pid_max: default: 32768 minimum: 301
[0.00] Mount-cache hash table entries: 1024 (order: 0, 4096 bytes)
[0.00] Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes)
[0.00] CPU: Testing write buffer coherency: ok
[0.00] CPU0: thread -1, cpu 0, socket 0, mpidr 8000
[0.00] Setting up static identity map for 0x8009000 - 0x8009058
[0.00] Brought up 1 CPUs
[0.00] SMP: Total of 1 processors activated (266.66 BogoMIPS).
[0.00] CPU: All CPU(s) started in SVC mode.
[0.00] devtmpfs: initialized
[0.00] VFP support v0.3: implementor 41 architecture 3 part 30 variant 
9 rev 4
[

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

On Tue, Dec 08, 2015 at 05:35:28PM +0300, Sergei Shtylyov wrote:
> On 12/08/2015 08:51 AM, Simon Horman wrote:
> 
> >Add fallback compatibility string.
> >This is in keeping with the fallback scheme being adopted wherever
> >appropriate for drivers for Renesas SoCs.
> >
> >Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> >---
> >  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++--
> >  drivers/usb/renesas_usbhs/common.c  | 4 
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
> >b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >index 7d48f63db44e..8c50df8441c9 100644
> >--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> >@@ -1,7 +1,7 @@
> >  Renesas Electronics USBHS driver
> >
> >  Required properties:
> >-  - compatible: Must contain one of the following:
> >+  - compatible: "renesas,usbhs-", "renesas,rcar-usbhs" as fallback.
> > - "renesas,usbhs-r8a7790"
> > - "renesas,usbhs-r8a7791"
> > - "renesas,usbhs-r8a7794"
> [...]
> >diff --git a/drivers/usb/renesas_usbhs/common.c 
> >b/drivers/usb/renesas_usbhs/common.c
> >index d82fa36c3465..2a9d4f405f30 100644
> >--- a/drivers/usb/renesas_usbhs/common.c
> >+++ b/drivers/usb/renesas_usbhs/common.c
> >@@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
> > .compatible = "renesas,usbhs-r8a7795",
> > .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > },
> >+{
> >+.compatible = "renesas,usbhs",
> 
>You just documented "renesas,rcar-usbhs".

Thanks. I meant to use "renesas,rcar-usbhs" throughout the patch.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

On Tue, Dec 08, 2015 at 08:32:49AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > > Add fallback compatibility string.
> > > > This is in keeping with the fallback scheme being adopted wherever
> > > > appropriate for drivers for Renesas SoCs.
> > > > 
> > > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > > > ---
> > > (snip)
> > > > +   {
> > > > +   .compatible = "renesas,usbhs",
> > > > +   .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > > > +   },
> > > > { },
> > > >  };
> > > 
> > > I think this is too much. This driver is used not only from R-Car Gen2.
> > > It will work as normal mode if .data was 0.
> > > see usbhs_parse_dt()
> > 
> > Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver?
> 
> I mean this
> 
> + {
> + .compatible = "renesas,usbhs",
> + },

(As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
 with what I documented elsewhere in the patch)

My understanding is that will cause the driver to operate in a different manner
to if USBHS_TYPE_RCAR_GEN2 was set. And thus meaning
of the generic and SoC-specifc compatibility strings will cause
the driver to operate differently.

Currently the only compat strings present are as follows:

* renesas,usbhs-r8a7790
* renesas,usbhs-r8a7791
* renesas,usbhs-r8a7794
* renesas,usbhs-r8a7795

And they all set USBHS_TYPE_RCAR_GEN2 (even though r8a7795 is a Gen3 SoC).

What I am aiming is either:
* A compatibility string for R-Car or;
* Two compatibility strings, one for R-Car Gen2 and one for R-Car Gen3

And for this new compatibility string or strings to operate the same
way as the current compatibility strings.


Looking over the driver its not clear to me why the
non-USBHS_TYPE_RCAR_GEN2 case is handled by the code as
there are no compatibility strings present that trigger that mode of
operation. I feel that I must be missing something.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

On Wed, Dec 09, 2015 at 06:29:07AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
> > > >  with what I documented elsewhere in the patch)
> > > 
> > > "renesas,rcar-usbhs" is better,
> > > but I guess you want to have "renesas,rcar-gen2-usbhs" ?
> > > 
> > > My understanding is these
> > > 
> > >  * renesas,usbhs-r8a77xx  # SoC specific
> > >  * renesas,rcar-usbhs # R-Car common
> > >  * renesas,rcar-gen2-usbhs# R-Car Gen2 common
> > >  * renesas,rcar-gen3-usbhs# R-Car Gen3 common
> > >  * renesas,usbhs  # Renesas USBHS common
> > > 
> > 
> > I was intentionally including gen3 as well. So I think we have two options:
> > 
> > 1. renesas,rcar-usbhs
> > 2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs
> 
> Renesas USB always have pick feature/settings.
> Thus, generic name (= "renesas,rcar-usbhs") is very risky IMO.
> I think 2 is more safety.

Sure, better safe than sorry.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

On Wed, Dec 09, 2015 at 04:48:47AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > (As Sergei noted elsewhere, "renesas,rcar-usbhs" is consistent
> >  with what I documented elsewhere in the patch)
> 
> "renesas,rcar-usbhs" is better,
> but I guess you want to have "renesas,rcar-gen2-usbhs" ?
> 
> My understanding is these
> 
>  * renesas,usbhs-r8a77xx  # SoC specific
>  * renesas,rcar-usbhs # R-Car common
>  * renesas,rcar-gen2-usbhs# R-Car Gen2 common
>  * renesas,rcar-gen3-usbhs# R-Car Gen3 common
>  * renesas,usbhs  # Renesas USBHS common
> 

I was intentionally including gen3 as well. So I think we have two options:

1. renesas,rcar-usbhs
2. renesas,rcar-gen2-usbhs and renesas,rcar-gen3-usbhs

Which do you prefer?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

On Tue, Dec 08, 2015 at 06:05:51AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > Add fallback compatibility string.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> > 
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > ---
> (snip)
> > +   {
> > +   .compatible = "renesas,usbhs",
> > +   .data = (void *)USBHS_TYPE_RCAR_GEN2,
> > +   },
> > { },
> >  };
> 
> I think this is too much. This driver is used not only from R-Car Gen2.
> It will work as normal mode if .data was 0.
> see usbhs_parse_dt()

Are you suggesting that we remove USBHS_TYPE_RCAR_GEN2 from the driver?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] PCI: rcar-gen2: Add device tree support for r8a7793

[Simon Horman]

On Mon, Dec 07, 2015 at 09:38:33AM -0600, Bjorn Helgaas wrote:
> On Sat, Dec 05, 2015 at 11:38:37AM +0100, Geert Uytterhoeven wrote:
> > Hi Bjorn,
> > 
> > On Fri, Dec 4, 2015 at 10:26 PM, Bjorn Helgaas <helg...@kernel.org> wrote:
> > > On Tue, Dec 01, 2015 at 04:24:30PM +0900, Simon Horman wrote:
> > >> Simply document new compat strings.
> > >> There appears to be no need for a driver updates.
> > >>
> > >> Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > >> ---
> > >>  Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 1 +
> > >>  1 file changed, 1 insertion(+)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
> > >> b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > >> index b19be08a8113..7c231b3e5872 100644
> > >> --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > >> +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > >> @@ -8,6 +8,7 @@ OHCI and EHCI controllers.
> > >>  Required properties:
> > >>  - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
> > >> "renesas,pci-r8a7791" for the R8A7791 SoC;
> > >> +   "renesas,pci-r8a7793" for the R8A7793 SoC;
> > >
> > > What's the benefit of adding a string here if the driver doesn't check
> > > for it?  Since the driver doesn't look for it, there's no way to test
> > > anything.
> > 
> > If we ever discover a difference between PCI on r8a7793 compared to PCI on
> > other SoCs of the R-Car Gen2 family, we can handle that difference in the
> > driver.
> > 
> > > It doesn't seem like this file is an authoritative source of names, so
> > 
> > Yes it is. When adding compatible values to a DTS, checkpatch.pl will check
> > for their existence in the binding documentation. Hence we always add the
> > compatible values to the DT binding docs, before we start using them.
> > 
> > > if we add it here, there's the possibility the r8a7793 will be
> > > canceled or renamed, and then we'd have to update this if the driver
> > > ever did need an r8a7793-specific quirk.  If we waited until the
> > 
> > I don't understand what you mean here.
> > 
> > > driver actually needs a quirk, then we'd know exactly what name to
> > > look for and we could update the driver, DT, and doc all together.
> > 
> > If we update driver, DT, and doc only after we discover the need for a 
> > quirk,
> > it's already too late, due to stable DT rules. Hence we always document and
> > use SoC-specific compatible values, sometimes combined with family-specific
> > compatible values. The driver only matches to the as least specific value as
> > possible.
> 
> The stable DT rules seem to be the key here, but I don't know what
> they are.  I found Documentation/devicetree/bindings/ABI.txt, but it
> doesn't clear it up for me.
> 
> I was assuming vendors could ship a DT in a platform ROM, in the same
> way platforms ship with an ACPI system description.  For ACPI, the
> _HID/_CID in the ROM in the field is authoritative in the sense that
> we have to regard it as a fixed, unchangeable feature of the platform.
> If we want a driver to recognize that device, we have to build the ID
> from the ROM into the driver, and it doesn't matter what is documented
> in the spec or in the kernel source.
> 
> If we had a one-sentence description of why adding the doc update when
> we actually need it is too late, that would probably be enough.

I agree that would be useful.

> I'm perfectly happy with the PCI changes, so if somebody else wants to
> just merge all these via a DT tree, I'm happy to ack the PCI ones.

I have no fixed ideas about who should take these changes
but I think you could take them through the PCI tree if you
are so inclined.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: r8a7778: tidyup #sound-dai-cells settings

[Simon Horman]

On Tue, Dec 08, 2015 at 01:30:12AM +, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > From: Kuninori Morimoto 
> > > 
> > > Renesas sound driver needs #sound-dai-cells settings, but, this usage
> > > is a little bit confusable. It came from ALSA SoC historical reasons.
> > > The sound DAI naming method is different between Single/Multi DAI in
> > > the ALSA framework, and it is used for sound card matching.
> > > And this #sound-dai-cells has relationship to it.
> > > Current SoC dtsi has #sound-dai-cells = <1> as default settings
> > > (= it is assuming that board/platform has multi DAI), and
> > > board/platform side needs to overwrite it if board/platform was single
> > > DAI. This style is more confusable for users.
> > > This patch removes SoC side default settings, and force to set it by
> > > board/platform side.
> > > 
> > > Signed-off-by: Kuninori Morimoto 
> > > ---
> > > This patch is based on Geert's
> > > ARM: shmobile: bockw dts: Override #sound-dai-cells to zero
> > 
> > Is Geert's patch necessary with this patch?
> 
> I think best order (for git bisect) is
> 
>   1. Geert's patch
>   2. My patch

Thanks, I will make it so.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: r8a7778: tidyup #sound-dai-cells settings

[Simon Horman]

On Tue, Dec 08, 2015 at 12:10:59AM +, Kuninori Morimoto wrote:
> 
> From: Kuninori Morimoto 
> 
> Renesas sound driver needs #sound-dai-cells settings, but, this usage
> is a little bit confusable. It came from ALSA SoC historical reasons.
> The sound DAI naming method is different between Single/Multi DAI in
> the ALSA framework, and it is used for sound card matching.
> And this #sound-dai-cells has relationship to it.
> Current SoC dtsi has #sound-dai-cells = <1> as default settings
> (= it is assuming that board/platform has multi DAI), and
> board/platform side needs to overwrite it if board/platform was single
> DAI. This style is more confusable for users.
> This patch removes SoC side default settings, and force to set it by
> board/platform side.
> 
> Signed-off-by: Kuninori Morimoto 
> ---
> This patch is based on Geert's
> ARM: shmobile: bockw dts: Override #sound-dai-cells to zero

Is Geert's patch necessary with this patch?

>  arch/arm/boot/dts/r8a7778.dtsi | 7 ++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> index 4f8e078..b140627 100644
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -236,7 +236,12 @@
>   };
>  
>   rcar_sound: sound@ffd9 {
> - #sound-dai-cells = <1>;
> + /*
> +  * #sound-dai-cells is required
> +  *
> +  * Single DAI : #sound-dai-cells = <0>; <_sound>;
> +  * Multi  DAI : #sound-dai-cells = <1>; <_sound N>;
> +  */
>   compatible = "renesas,rcar_sound-r8a7778", 
> "renesas,rcar_sound-gen1";
>   reg =   <0xffd9 0x1000>,/* SRU */
>   <0xffd91000 0x240>, /* SSI */
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] rcar_jpu: add fallback compatibility string

[Simon Horman]

Add fallback compatibility string.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/media/renesas,jpu.txt | 13 +++--
 drivers/media/platform/rcar_jpu.c   |  1 +
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/renesas,jpu.txt 
b/Documentation/devicetree/bindings/media/renesas,jpu.txt
index 0cb94201bf92..c96de75f0089 100644
--- a/Documentation/devicetree/bindings/media/renesas,jpu.txt
+++ b/Documentation/devicetree/bindings/media/renesas,jpu.txt
@@ -5,11 +5,12 @@ and decoding function conforming to the JPEG baseline 
process, so that the JPU
 can encode image data and decode JPEG data quickly.
 
 Required properties:
-  - compatible: should containg one of the following:
-   - "renesas,jpu-r8a7790" for R-Car H2
-   - "renesas,jpu-r8a7791" for R-Car M2-W
-   - "renesas,jpu-r8a7792" for R-Car V2H
-   - "renesas,jpu-r8a7793" for R-Car M2-N
+- compatible: "renesas,jpu-", "renesas,jpu" as fallback.
+   Examples with soctypes are:
+ - "renesas,jpu-r8a7790" for R-Car H2
+ - "renesas,jpu-r8a7791" for R-Car M2-W
+ - "renesas,jpu-r8a7792" for R-Car V2H
+ - "renesas,jpu-r8a7793" for R-Car M2-N
 
   - reg: Base address and length of the registers block for the JPU.
   - interrupts: JPU interrupt specifier.
@@ -17,7 +18,7 @@ Required properties:
 
 Example: R8A7790 (R-Car H2) JPU node
jpeg-codec@fe98 {
-   compatible = "renesas,jpu-r8a7790";
+   compatible = "renesas,jpu-r8a7790", "renesas,jpu";
reg = <0 0xfe98 0 0x10300>;
interrupts = <0 272 IRQ_TYPE_LEVEL_HIGH>;
clocks = <_clks R8A7790_CLK_JPU>;
diff --git a/drivers/media/platform/rcar_jpu.c 
b/drivers/media/platform/rcar_jpu.c
index f8e3e83c52a2..53cec95abb08 100644
--- a/drivers/media/platform/rcar_jpu.c
+++ b/drivers/media/platform/rcar_jpu.c
@@ -1611,6 +1611,7 @@ static const struct of_device_id jpu_dt_ids[] = {
{ .compatible = "renesas,jpu-r8a7791" }, /* M2-W */
{ .compatible = "renesas,jpu-r8a7792" }, /* V2H */
{ .compatible = "renesas,jpu-r8a7793" }, /* M2-N */
+   { .compatible = "renesas,jpu" },
{ },
 };
 MODULE_DEVICE_TABLE(of, jpu_dt_ids);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] usb: renesas_usbhs: More compat strings

[Simon Horman]

Hi,

this short series adds generic, and soc-specific r8a7792 and r8a7793 compat
strings to the Renesas USBHS driver. The intention is to provide a complete
set of compat strings for known R-Car SoCs.

Simon Horman (2):
  usb: renesas_usbhs: add fallback compatibility string
  usb: renesas_usbhs: add device tree support for r8a779[23]

 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 14 --
 drivers/usb/renesas_usbhs/common.c  |  4 
 2 files changed, 12 insertions(+), 6 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

[Simon Horman]

Add fallback compatibility string.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++--
 drivers/usb/renesas_usbhs/common.c  | 4 
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 7d48f63db44e..8c50df8441c9 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -1,7 +1,7 @@
 Renesas Electronics USBHS driver
 
 Required properties:
-  - compatible: Must contain one of the following:
+  - compatible: "renesas,usbhs-", "renesas,rcar-usbhs" as fallback.
- "renesas,usbhs-r8a7790"
- "renesas,usbhs-r8a7791"
- "renesas,usbhs-r8a7794"
@@ -22,7 +22,7 @@ Optional properties:
 
 Example:
usbhs: usb@e659 {
-   compatible = "renesas,usbhs-r8a7790";
+   compatible = "renesas,usbhs-r8a7790", "renesas,rcar-usbhs";
reg = <0 0xe659 0 0x100>;
interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <_clks R8A7790_CLK_HSUSB>;
diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index d82fa36c3465..2a9d4f405f30 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
.compatible = "renesas,usbhs-r8a7795",
.data = (void *)USBHS_TYPE_RCAR_GEN2,
},
+   {
+   .compatible = "renesas,usbhs",
+   .data = (void *)USBHS_TYPE_RCAR_GEN2,
+   },
{ },
 };
 MODULE_DEVICE_TABLE(of, usbhs_of_match);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] usb: renesas_usbhs: add device tree support for r8a779[23]

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Also add names for SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt 
b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
index 8c50df8441c9..b31f036d2171 100644
--- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
+++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
@@ -2,10 +2,12 @@ Renesas Electronics USBHS driver
 
 Required properties:
   - compatible: "renesas,usbhs-", "renesas,rcar-usbhs" as fallback.
-   - "renesas,usbhs-r8a7790"
-   - "renesas,usbhs-r8a7791"
-   - "renesas,usbhs-r8a7794"
-   - "renesas,usbhs-r8a7795"
+   - "renesas,usbhs-r8a7790" (R-Car H2)
+   - "renesas,usbhs-r8a7791" (R-Car M2-W)
+   - "renesas,usbhs-r8a7792" (R-Car V2H)
+   - "renesas,usbhs-r8a7793" (R-Car M2-N)
+   - "renesas,usbhs-r8a7794" (R-Car E2)
+   - "renesas,usbhs-r8a7795" (R-Car H3)
   - reg: Base address and length of the register for the USBHS
   - interrupts: Interrupt specifier for the USBHS
   - clocks: A list of phandle + clock specifier pairs
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Add R8A7791 EtherAVB DT support

[Simon Horman]

On Fri, Dec 04, 2015 at 05:00:37PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/3/2015 1:19 AM, Sergei Shtylyov wrote:
> 
> >Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >'renesas-devel-20151201-v4.4-rc3' tag. Here we add the EtherAVB device tree
> >support for the R8A7791 SoC. The 2nd patch depends on the Simon's recent
> >EtherAVB driver patches in order to work...
> 
>Well, not exactly "work", as the node is disabled. Anyway, Simon's
> patches got merged to net-next.git by Dave, so I think this series can be
> merged now as well...

Thanks, I have queued these up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/4] PCI: rcar, rcar-gen2: More Gen2 compatibility strings

[Simon Horman]

Hi,

this short series adds generic gen2 and SoC-specific r8a7793 compatibility
strings to the rcar PCI and rcar-gen2 PCIE drivers. The intention is to
provide a complete set of compatibility strings for known Gen2 SoCs.

Key Changes in v2:
* Include "rcar-" in generic bindings

Simon Horman (4):
  PCI: rcar-gen2: add gen2 fallback compatibility string
  PCI: rcar-gen2: add device tree support for r8a7793
  PCI: rcar: add gen2 fallback compatibility string
  PCI: rcar: add device tree support for r8a7793

 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 12 ++--
 Documentation/devicetree/bindings/pci/rcar-pci.txt  | 14 +++---
 drivers/pci/host/pci-rcar-gen2.c|  1 +
 drivers/pci/host/pcie-rcar.c|  1 +
 4 files changed, 23 insertions(+), 5 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/4] PCI: rcar-gen2: add gen2 fallback compatibility string

[Simon Horman]

Add fallback compatibility string for R-Car Gen 2 family.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
v2
* Include "rcar-" in new compatibility string
---
 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +--
 drivers/pci/host/pci-rcar-gen2.c|  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
index 891463cb09c2..089a99dcdf10 100644
--- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
+++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
@@ -8,7 +8,14 @@ OHCI and EHCI controllers.
 Required properties:
 - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
  "renesas,pci-r8a7791" for the R8A7791 SoC;
- "renesas,pci-r8a7794" for the R8A7794 SoC.
+ "renesas,pci-r8a7794" for the R8A7794 SoC;
+ "renesas,pci-rcar-gen2" for a generic R-Car Gen2 compatible 
device.
+
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first
+ followed by the generic version.
+
 - reg: A list of physical regions to access the device: the first is
the operational registers for the OHCI/EHCI controllers and the
second is for the bridge configuration and control registers.
@@ -32,7 +39,7 @@ Optional properties:
 Example SoC configuration:
 
pci0: pci@ee09  {
-   compatible = "renesas,pci-r8a7790";
+   compatible = "renesas,pci-r8a7790", "renesas,pci-rcar-gen2";
clocks = <_clks R8A7790_CLK_EHCI>;
reg = <0x0 0xee09 0x0 0xc00>,
  <0x0 0xee08 0x0 0x1100>;
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
index 62951165dcbb..9980a4bdae7e 100644
--- a/drivers/pci/host/pci-rcar-gen2.c
+++ b/drivers/pci/host/pci-rcar-gen2.c
@@ -430,6 +430,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
 }
 
 static struct of_device_id rcar_pci_of_match[] = {
+   { .compatible = "renesas,pci-rcar-gen2", },
{ .compatible = "renesas,pci-r8a7790", },
{ .compatible = "renesas,pci-r8a7791", },
{ .compatible = "renesas,pci-r8a7794", },
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 4/4] PCI: rcar: add device tree support for r8a7793

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
* The r8a7792 and r8a7794 are omitted from this change as the
  hardware in question does not appear to be present on those SoCs.

v2
* No change
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt 
b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 6b4d2f798386..d529530b27d2 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -4,6 +4,7 @@ Required properties:
 compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
"renesas,pcie-r8a7790" for the R8A7790 SoC;
"renesas,pcie-r8a7791" for the R8A7791 SoC;
+   "renesas,pcie-r8a7793" for the R8A7793 SoC;
"renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
 
When compatible with the generic version, nodes must list the
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/4] PCI: rcar: add gen2 fallback compatibility string

[Simon Horman]

Add fallback compatibility string for R-Car Gen 2 family.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
v2
* Include "rcar-" in new compatibility string
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 13 ++---
 drivers/pci/host/pcie-rcar.c   |  1 +
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt 
b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 29d3b989d3b0..6b4d2f798386 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -1,8 +1,15 @@
 * Renesas RCar PCIe interface
 
 Required properties:
-- compatible: should contain one of the following
-   "renesas,pcie-r8a7779", "renesas,pcie-r8a7790", "renesas,pcie-r8a7791"
+compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
+   "renesas,pcie-r8a7790" for the R8A7790 SoC;
+   "renesas,pcie-r8a7791" for the R8A7791 SoC;
+   "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 compatible device.
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first
+   followed by the generic version.
+
 - reg: base address and length of the pcie controller registers.
 - #address-cells: set to <3>
 - #size-cells: set to <2>
@@ -25,7 +32,7 @@ Example:
 SoC specific DT Entry:
 
pcie: pcie@fe00 {
-   compatible = "renesas,pcie-r8a7791";
+   compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2";
reg = <0 0xfe00 0 0x8>;
#address-cells = <3>;
#size-cells = <2>;
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index f4fa6c537448..047279bdc3fe 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -917,6 +917,7 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie 
*pcie,
 
 static const struct of_device_id rcar_pcie_of_match[] = {
{ .compatible = "renesas,pcie-r8a7779", .data = rcar_pcie_hw_init_h1 },
+   { .compatible = "renesas,pcie-rcar-gen2", .data = rcar_pcie_hw_init },
{ .compatible = "renesas,pcie-r8a7790", .data = rcar_pcie_hw_init },
{ .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init },
{},
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/4] PCI: rcar-gen2: add device tree support for r8a7793

[Simon Horman]

Simply document new compatibility string.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
* The r8a7792 is omitted from this change as the hardware in question
  does not appear to be present on that SoC.

v2
* No change
---
 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
index 089a99dcdf10..9c50e0c9d6da 100644
--- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
+++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
@@ -8,6 +8,7 @@ OHCI and EHCI controllers.
 Required properties:
 - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
  "renesas,pci-r8a7791" for the R8A7791 SoC;
+ "renesas,pci-r8a7793" for the R8A7793 SoC;
  "renesas,pci-r8a7794" for the R8A7794 SoC;
  "renesas,pci-rcar-gen2" for a generic R-Car Gen2 compatible 
device.
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

[Simon Horman]

On Tue, Dec 01, 2015 at 09:42:52AM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 1, 2015 at 8:43 AM, Simon Horman <horms+rene...@verge.net.au> 
> wrote:
> > Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> >
> > Also correct typo.
> >
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > ---
> >  Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +--
> >  drivers/net/ethernet/renesas/ravb_main.c   |  2 ++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > index b486f3f5f6a3..115006325bff 100644
> > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > @@ -1,12 +1,19 @@
> >  * Renesas Electronics Ethernet AVB
> >
> >  This file provides information on what the device node for the Ethernet AVB
> > -interface contains.
> > +interface.
> >
> >  Required properties:
> >  - compatible: "renesas,etheravb-r8a7790" if the device is a part of 
> > R8A7790 SoC.
> >   "renesas,etheravb-r8a7794" if the device is a part of R8A7794 
> > SoC.
> >   "renesas,etheravb-r8a7795" if the device is a part of R8A7795 
> > SoC.
> > + "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible 
> > interface.
> > + "renesas,etheravb-gen3" for generic R-Car Gen 3 compatible 
> > interface.
> > +
> 
> (Same comment, different audience)
> 
> Shouldn't that be "renesas,etheravb-rcar-gen" or "renesas,etheravb-rcar2"?
> 
> Else you'll be in trouble when Renesas starts focussing on airplanes
> (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2).

Sure, lets go with:

renesas,etheravb-rcar-gen2 and renesas,etheravb-rcar-gen3.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] PCI: rcar-gen2: Add generic compatibility string

[Simon Horman]

On Tue, Dec 01, 2015 at 09:41:49AM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 1, 2015 at 8:24 AM, Simon Horman <horms+rene...@verge.net.au> 
> wrote:
> > Add fallback compatibility string for R-Car Gen 2 Family.
> > This is in keeping with the fallback scheme being adopted wherever
> > appropriate for drivers for Renesas SoCs.
> >
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > ---
> >  Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +--
> >  drivers/pci/host/pci-rcar-gen2.c|  1 +
> >  2 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
> > b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > index 891463cb09c2..b19be08a8113 100644
> > --- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > +++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
> > @@ -8,7 +8,14 @@ OHCI and EHCI controllers.
> >  Required properties:
> >  - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
> >   "renesas,pci-r8a7791" for the R8A7791 SoC;
> > - "renesas,pci-r8a7794" for the R8A7794 SoC.
> > + "renesas,pci-r8a7794" for the R8A7794 SoC;
> > + "renesas,pci-gen2" for a generic R-Car Gen2 compatible device.
> 
> Shouldn't that be "renesas,pci-rcar-gen" or "renesas,pci-rcar2"?
> 
> Else you'll be in trouble when Renesas starts focussing on airplanes
> (R-Plane Gen2), rockets (R-Rocket Gen2), or IoT (R-IoT Gen2).

Point taken.

I think renesas,pci-rcar-gen2 should work well enough.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2 net-next] ravb: Add fallback compatibility strings

[Simon Horman]

On Tue, Dec 01, 2015 at 01:26:08PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 12/1/2015 10:43 AM, Simon Horman wrote:
> 
> >Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families.
> >This is in keeping with the fallback scheme being adopted wherever
> >appropriate for drivers for Renesas SoCs.
> >
> >Also correct typo.
> >
> >Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> >---
> >  Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +--
> >  drivers/net/ethernet/renesas/ravb_main.c   |  2 ++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> >diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
> >b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >index b486f3f5f6a3..115006325bff 100644
> >--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> >@@ -1,12 +1,19 @@
> >  * Renesas Electronics Ethernet AVB
> >
> >  This file provides information on what the device node for the Ethernet AVB
> >-interface contains.
> >+interface.
> 
>Why?

Because I miss read it (multiple times).
I'll drop this change.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: usb-dmac: Document SoC specific bindings

[Simon Horman]

On Tue, Dec 01, 2015 at 09:33:09AM +0100, Geert Uytterhoeven wrote:
> On Tue, Dec 1, 2015 at 7:47 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Wed, Nov 25, 2015 at 09:20:32AM +0900, Simon Horman wrote:
> >> On Tue, Nov 24, 2015 at 02:16:55PM -0600, Rob Herring wrote:
> >> > On Tue, Nov 24, 2015 at 11:20:41AM +0900, Simon Horman wrote:
> >> > > In general Renesas hardware is not documented to the extent where the
> >> > > relationship between IP blocks on different SoCs can be assumed 
> >> > > although
> >> > > they may appear to operate the same way. Furthermore the documentation
> >> > > typically does not specify a version for individual IP blocks. For 
> >> > > these
> >> > > reasons a convention of using the SoC name in place of a version and
> >> > > providing SoC-specific compat strings has been adopted.
> >> > >
> >> > > Although not universally liked this convention is used in the bindings 
> >> > > for
> >> > > most drivers for Renesas hardware. The purpose of this patch is to
> >> > > update the Renesas USB DMA Controller driver to follow this convention.
> >> > >
> >> > > Cc: devicetree@vger.kernel.org
> >> > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
> >> > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> >> > >
> >> > > ---
> >> > > * r8a7792 (R-Car V2H) is omitted as my reading of the documentation
> >> > >   is that Renesas USB-DMAC does not exist on that SoC
> >> > > * r8a7795 (R-Car H2) is omitted as its unclear to me on the 
> >> > > compatibility
> >> > >   of USB-DMAC that SoC
> >> > >
> >> > > * Once this has been merged I intend to provide follow-up patches
> >> > >   to use these new compat strings in the relevant dtsi files.
> >> > > ---
> >> > >  Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 
> >> > > +++--
> >> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> >> > >
> >> > > diff --git 
> >> > > a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt 
> >> > > b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> >> > > index 040f365954cc..3bb624e10615 100644
> >> > > --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> >> > > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> >> > > @@ -1,7 +1,12 @@
> >> > >  * Renesas USB DMA Controller Device Tree bindings
> >> > >
> >> > >  Required Properties:
> >> > > -- compatible: must contain "renesas,usb-dmac"
> >> > > +- compatible: "renesas,usb-dmac-", "renesas,usb-dmac" as 
> >> > > fallback.
> >> > > +   Examples with soctypes are:
> >> > > + - "renesas,usb-dmac-r8a7790" (R-Car H2)
> >> > > + - "renesas,usb-dmac-r8a7791" (R-Car M2-W)
> >> > > + - "renesas,usb-dmac-r8a7793" (R-Car M2-N)
> >> > > + - "renesas,usb-dmac-r8a7794" (R-Car E2)
> >> >
> >> > Weren't you changing the order of SoC and block names on new bindings?
> >>
> >> Could you clarify what the desired order is?
> >> My intention is for these bindings to use the preferred order.
> >
> > ping
> 
> Not speaking for Rob, but I think he means e.g. "renesas,r8a7790-usb-dmac".

Thanks. Reviewing previous emails I see that now.
I will see about making it so.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net-next 0/2] ravb: More compatibility strings

[Simon Horman]

Hi,

this short series adds generic gen2 and gen3, and soc-specific
compatibility strings for the missing gen2 SoCs.

Key Changes in v2:
* Include "rcar-" in generic bindings

Simon Horman (2):
  ravb: add fallback compatibility strings
  ravb: add device tree support for r8a779[123]

 Documentation/devicetree/bindings/net/renesas,ravb.txt | 12 +++-
 drivers/net/ethernet/renesas/ravb_main.c   |  2 ++
 2 files changed, 13 insertions(+), 1 deletion(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net-next 2/2] ravb: add device tree support for r8a779[123]

[Simon Horman]

Simply document new compatibility strings.
As a previous patch adds a generic R-Car Gen2 compatibility string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
v2
* No change
---
 Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index 7555116b5db2..81a9f9e6b45f 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -5,6 +5,9 @@ interface contains.
 
 Required properties:
 - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
SoC.
+ "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
+ "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
+ "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
  "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
  "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
  "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible 
interface.
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 net-next 1/2] ravb: add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families.
This is in keeping with the fallback scheme being adopted wherever appropriate
for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
v2
* Drop bogus typo non-fix
* include "rcar-" in generic bindings
---
 Documentation/devicetree/bindings/net/renesas,ravb.txt | 9 -
 drivers/net/ethernet/renesas/ravb_main.c   | 2 ++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b486f3f5f6a3..7555116b5db2 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -7,6 +7,13 @@ Required properties:
 - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
SoC.
  "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
  "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
+ "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible 
interface.
+ "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible 
interface.
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first
+ followed by the generic version.
+
 - reg: offset and length of (1) the register block and (2) the stream buffer.
 - interrupts: A list of interrupt-specifiers, one for each entry in
  interrupt-names.
@@ -37,7 +44,7 @@ Optional properties:
 Example:
 
ethernet@e680 {
-   compatible = "renesas,etheravb-r8a7795";
+   compatible = "renesas,etheravb-r8a7795", 
"renesas,etheravb-rcar-gen3";
reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
interrupt-parent = <>;
interrupts = ,
diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index 990dc55cdada..c12b163ed7fe 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1656,7 +1656,9 @@ static int ravb_mdio_release(struct ravb_private *priv)
 static const struct of_device_id ravb_match_table[] = {
{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
+   { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 
},
{ .compatible = "renesas,etheravb-r8a7795", .data = (void *)RCAR_GEN3 },
+   { .compatible = "renesas,etheravb-rcar-gen3", .data = (void *)RCAR_GEN3 
},
{ }
 };
 MODULE_DEVICE_TABLE(of, ravb_match_table);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2] dmaengine: usb-dmac: Document SoC specific compatibility strings

[Simon Horman]

In general Renesas hardware is not documented to the extent where the
relationship between IP blocks on different SoCs can be assumed although
they may appear to operate the same way. Furthermore the documentation
typically does not specify a version for individual IP blocks. For these
reasons a convention of using the SoC name in place of a version and
providing SoC-specific compatibility strings has been adopted.

Although not universally liked this convention is used in the bindings for
most drivers for Renesas hardware. The purpose of this patch is to
update the Renesas USB DMA Controller driver to follow this convention.

Cc: devicetree@vger.kernel.org
Acked-by: Rob Herring <r...@kernel.org>
Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
Notes:
* r8a7792 (R-Car V2H) is omitted as my reading of the documentation
  is that Renesas USB-DMAC does not exist on that SoC.

v2:
* Use ,- rather than ,-
  pattern for new compatibility strings
* Added compatibility string for r8a7795 on advice from Shimoda-san
* Added Acks
---
 Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt 
b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
index 040f365954cc..e7780a186a36 100644
--- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
@@ -1,7 +1,13 @@
 * Renesas USB DMA Controller Device Tree bindings
 
 Required Properties:
-- compatible: must contain "renesas,usb-dmac"
+-compatible: "renesas,-usb-dmac", "renesas,usb-dmac" as fallback.
+   Examples with soctypes are:
+ - "renesas,r8a7790-usb-dmac" (R-Car H2)
+ - "renesas,r8a7791-usb-dmac" (R-Car M2-W)
+ - "renesas,r8a7793-usb-dmac" (R-Car M2-N)
+ - "renesas,r8a7794-usb-dmac" (R-Car E2)
+ - "renesas,r8a7795-usb-dmac" (R-Car H3)
 - reg: base address and length of the registers block for the DMAC
 - interrupts: interrupt specifiers for the DMAC, one for each entry in
   interrupt-names.
@@ -15,7 +21,7 @@ Required Properties:
 Example: R8A7790 (R-Car H2) USB-DMACs
 
usb_dmac0: dma-controller@e65a {
-   compatible = "renesas,usb-dmac";
+   compatible = "renesas,r8a7790-usb-dmac", "renesas,usb-dmac";
reg = <0 0xe65a 0 0x100>;
interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
  0 109 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 09:08:57AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Mon, Nov 30, 2015 at 1:42 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Mon, Nov 30, 2015 at 12:14:21AM +0300, Sergei Shtylyov wrote:
> >> On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:
> >> >>Add support  for yet another ARM member of the R-Car family, R-Car M2, 
> >> >>also
> >> >R-Car M2-W?
> >>
> >>Right, forgot about the postfixes.
> >>
> >> >>known as R8A7791.
> >> >
> >> >There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> >>
> >>Will fix.
> >
> > I would prefer if we added generic gen2 and gen3 compat strings to the 
> > driver
> > and only documented new soc-specific compat strings.
> >
> > Actually by chance I was planning to up patches to do that and add compat
> > strings for the missing Gen2 boards. But I won't complain if you beat me to
> > it.
> 
> You're aware we have to keep the existing SoC-specific ones in the driver,
> for backwards compatibility?

Yes, I am aware of that.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] ARM: shmobile: sh73a0: Add MSIOF support

[Simon Horman]

On Mon, Nov 30, 2015 at 03:16:50PM +0100, Geert Uytterhoeven wrote:
>   Hi Simon, Magnus,
> 
> This patch series adds support for the 4 MSIOF channels on SH-Mobile
> AG5.
> 
> It has been tested (TX only) using MSIOF1 on the CN21 test connector.
> RX hasn't been tested, as there are one-directional buffers between the
> real MSIOF interface on high-density connector CN8 and the CN21 test
> connector.
> 
> Functionality-wise, this depends on the bindings in "[PATCH] spi:
> sh-msiof: Add support for SH-Mobile AG5", and pinctrl in "[PATCH]
> pinctrl: sh-pfc: sh73a0: Add MSIOF support".
> 
> Thanks!

Thanks, I have queued these up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 10:08:22PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/30/2015 03:42 AM, Simon Horman wrote:
> 
> >>>>Add support  for yet another ARM member of the R-Car family, R-Car M2, 
> >>>>also
> >>
> >>>R-Car M2-W?
> >>
> >>Right, forgot about the postfixes.
> >>
> >>>>known as R8A7791.
> >>>
> >>>There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> >>
> >>Will fix.
> >
> >I would prefer if we added generic gen2 and gen3 compat strings to the driver
> >and only documented new soc-specific compat strings.
> 
>That's a new policy it seems. Previously you preferred the SoC-specific
> strings to be used, didn;t you?

Yes, that is correct on all counts.

To clarify new policy for Renesas IP is:
soc-specific compat + generic compat as fallback

> >Actually by chance I was planning to up patches to do that and add compat
> >strings for the missing Gen2 boards. But I won't complain if you beat me to
> >it.
> 
>No, I'm pretty busy as is. :-)

Ok, I'll handle this.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: usb-dmac: Document SoC specific bindings

[Simon Horman]

Hi Rob,

On Wed, Nov 25, 2015 at 09:20:32AM +0900, Simon Horman wrote:
> On Tue, Nov 24, 2015 at 02:16:55PM -0600, Rob Herring wrote:
> > On Tue, Nov 24, 2015 at 11:20:41AM +0900, Simon Horman wrote:
> > > In general Renesas hardware is not documented to the extent where the
> > > relationship between IP blocks on different SoCs can be assumed although
> > > they may appear to operate the same way. Furthermore the documentation
> > > typically does not specify a version for individual IP blocks. For these
> > > reasons a convention of using the SoC name in place of a version and
> > > providing SoC-specific compat strings has been adopted.
> > > 
> > > Although not universally liked this convention is used in the bindings for
> > > most drivers for Renesas hardware. The purpose of this patch is to
> > > update the Renesas USB DMA Controller driver to follow this convention.
> > > 
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
> > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > > 
> > > ---
> > > * r8a7792 (R-Car V2H) is omitted as my reading of the documentation
> > >   is that Renesas USB-DMAC does not exist on that SoC
> > > * r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
> > >   of USB-DMAC that SoC
> > > 
> > > * Once this has been merged I intend to provide follow-up patches
> > >   to use these new compat strings in the relevant dtsi files.
> > > ---
> > >  Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++--
> > >  1 file changed, 7 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt 
> > > b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > > index 040f365954cc..3bb624e10615 100644
> > > --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > > @@ -1,7 +1,12 @@
> > >  * Renesas USB DMA Controller Device Tree bindings
> > >  
> > >  Required Properties:
> > > -- compatible: must contain "renesas,usb-dmac"
> > > +- compatible: "renesas,usb-dmac-", "renesas,usb-dmac" as 
> > > fallback.
> > > +   Examples with soctypes are:
> > > + - "renesas,usb-dmac-r8a7790" (R-Car H2)
> > > + - "renesas,usb-dmac-r8a7791" (R-Car M2-W)
> > > + - "renesas,usb-dmac-r8a7793" (R-Car M2-N)
> > > + - "renesas,usb-dmac-r8a7794" (R-Car E2)
> > 
> > Weren't you changing the order of SoC and block names on new bindings? 
> 
> Could you clarify what the desired order is?
> My intention is for these bindings to use the preferred order.

ping
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/4] PCI: rcar, rcar-gen2: More Gen2 compat strings

[Simon Horman]

Hi,

this short series adds generic gen2 and soc-specific r8a7793 compat strings
to the rcar PCI and rcar-gen2 PCIE drivers. The intention is to provide
a complete set of compat strings for known Gen2 SoCs.

Simon Horman (4):
  PCI: rcar-gen2: Add generic compatibility string
  PCI: rcar-gen2: Add device tree support for r8a7793
  PCI: rcar: Add Gen2 fallback compatibility string
  PCI: rcar: Add device tree support for r8a7793

 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 12 ++--
 Documentation/devicetree/bindings/pci/rcar-pci.txt  | 14 +++---
 drivers/pci/host/pci-rcar-gen2.c|  1 +
 drivers/pci/host/pcie-rcar.c|  1 +
 4 files changed, 23 insertions(+), 5 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] PCI: rcar-gen2: Add generic compatibility string

[Simon Horman]

Add fallback compatibility string for R-Car Gen 2 Family.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 11 +--
 drivers/pci/host/pci-rcar-gen2.c|  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
index 891463cb09c2..b19be08a8113 100644
--- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
+++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
@@ -8,7 +8,14 @@ OHCI and EHCI controllers.
 Required properties:
 - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
  "renesas,pci-r8a7791" for the R8A7791 SoC;
- "renesas,pci-r8a7794" for the R8A7794 SoC.
+ "renesas,pci-r8a7794" for the R8A7794 SoC;
+ "renesas,pci-gen2" for a generic R-Car Gen2 compatible device.
+
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first
+ followed by the generic version.
+
 - reg: A list of physical regions to access the device: the first is
the operational registers for the OHCI/EHCI controllers and the
second is for the bridge configuration and control registers.
@@ -32,7 +39,7 @@ Optional properties:
 Example SoC configuration:
 
pci0: pci@ee09  {
-   compatible = "renesas,pci-r8a7790";
+   compatible = "renesas,pci-r8a7790", "renesas,pci-gen2";
clocks = <_clks R8A7790_CLK_EHCI>;
reg = <0x0 0xee09 0x0 0xc00>,
  <0x0 0xee08 0x0 0x1100>;
diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
index 62951165dcbb..a93403823353 100644
--- a/drivers/pci/host/pci-rcar-gen2.c
+++ b/drivers/pci/host/pci-rcar-gen2.c
@@ -430,6 +430,7 @@ static int rcar_pci_probe(struct platform_device *pdev)
 }
 
 static struct of_device_id rcar_pci_of_match[] = {
+   { .compatible = "renesas,pci-gen2", },
{ .compatible = "renesas,pci-r8a7790", },
{ .compatible = "renesas,pci-r8a7791", },
{ .compatible = "renesas,pci-r8a7794", },
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/4] PCI: rcar: Add Gen2 fallback compatibility string

[Simon Horman]

Add fallback compatibility string for R-Car Gen 2 Family.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 13 ++---
 drivers/pci/host/pcie-rcar.c   |  1 +
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt 
b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 29d3b989d3b0..872cea085be8 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -1,8 +1,15 @@
 * Renesas RCar PCIe interface
 
 Required properties:
-- compatible: should contain one of the following
-   "renesas,pcie-r8a7779", "renesas,pcie-r8a7790", "renesas,pcie-r8a7791"
+compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
+   "renesas,pcie-r8a7790" for the R8A7790 SoC;
+   "renesas,pcie-r8a7791" for the R8A7791 SoC;
+   "renesas,pcie-gen2" for a generic R-Car Gen2 compatible device.
+
+   When compatible with the generic version, nodes must list the
+   SoC-specific version corresponding to the platform first
+   followed by the generic version.
+
 - reg: base address and length of the pcie controller registers.
 - #address-cells: set to <3>
 - #size-cells: set to <2>
@@ -25,7 +32,7 @@ Example:
 SoC specific DT Entry:
 
pcie: pcie@fe00 {
-   compatible = "renesas,pcie-r8a7791";
+   compatible = "renesas,pcie-r8a7791", "renesas,pcie-gen2";
reg = <0 0xfe00 0 0x8>;
#address-cells = <3>;
#size-cells = <2>;
diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c
index f4fa6c537448..17ee0422ddb1 100644
--- a/drivers/pci/host/pcie-rcar.c
+++ b/drivers/pci/host/pcie-rcar.c
@@ -917,6 +917,7 @@ static int rcar_pcie_parse_map_dma_ranges(struct rcar_pcie 
*pcie,
 
 static const struct of_device_id rcar_pcie_of_match[] = {
{ .compatible = "renesas,pcie-r8a7779", .data = rcar_pcie_hw_init_h1 },
+   { .compatible = "renesas,pcie-gen2", .data = rcar_pcie_hw_init },
{ .compatible = "renesas,pcie-r8a7790", .data = rcar_pcie_hw_init },
{ .compatible = "renesas,pcie-r8a7791", .data = rcar_pcie_hw_init },
{},
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] PCI: rcar-gen2: Add device tree support for r8a7793

[Simon Horman]

Simply document new compat strings.
There appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt 
b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
index b19be08a8113..7c231b3e5872 100644
--- a/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
+++ b/Documentation/devicetree/bindings/pci/pci-rcar-gen2.txt
@@ -8,6 +8,7 @@ OHCI and EHCI controllers.
 Required properties:
 - compatible: "renesas,pci-r8a7790" for the R8A7790 SoC;
  "renesas,pci-r8a7791" for the R8A7791 SoC;
+ "renesas,pci-r8a7793" for the R8A7793 SoC;
  "renesas,pci-r8a7794" for the R8A7794 SoC;
  "renesas,pci-gen2" for a generic R-Car Gen2 compatible device.
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] PCI: rcar: Add device tree support for r8a7793

[Simon Horman]

Simply document new compat strings.
As a previous patch adds a generic R-Car Gen2 compat string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
* The r8a7792 and r8a7794 are omitted from this change as the
  hardware in question does not appear to be present on those SoCs.
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt 
b/Documentation/devicetree/bindings/pci/rcar-pci.txt
index 872cea085be8..4548b9b54165 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci.txt
+++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt
@@ -4,6 +4,7 @@ Required properties:
 compatible: "renesas,pcie-r8a7779" for the R8A7779 SoC;
"renesas,pcie-r8a7790" for the R8A7790 SoC;
"renesas,pcie-r8a7791" for the R8A7791 SoC;
+   "renesas,pcie-r8a7793" for the R8A7793 SoC;
"renesas,pcie-gen2" for a generic R-Car Gen2 compatible device.
 
When compatible with the generic version, nodes must list the
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ravb: add R8A7791 support

[Simon Horman]

On Tue, Dec 01, 2015 at 01:01:18AM +0300, Sergei Shtylyov wrote:
> Add support  for yet another ARM member of the R-Car family, R-Car M2-W,
> also known as R8A7791.
> 
> Signed-off-by: Sergei Shtylyov 
> 
> ---
> The patch is against DaveM's 'net-next.git' repo but I wouldn't mind if it's
> applied to 'net.git' instead. :-)
> 
> Changes in version 2:
> - fixed the SoC name in the changelog.

I have no particular problem with this patch but as mentioned elsewhere I
have been working on a more comprehensive patchset which I have now posted as:

"[PATCH 0/2 net-next] ravb: More compat strings"
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2 net-next] ravb: Add device tree support for r8a779[123]

[Simon Horman]

Simply document new compat strings.
As a previous patch adds a generic R-Car Gen2 compat string
there appears to be no need for a driver updates.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index 115006325bff..076accb652ad 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -5,6 +5,9 @@ interface.
 
 Required properties:
 - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
SoC.
+ "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC.
+ "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC.
+ "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC.
  "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
  "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
  "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible 
interface.
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2 net-next] ravb: Add fallback compatibility strings

[Simon Horman]

Add fallback compatibility strings for R-Car Gen 2 & 3 SoC Families.
This is in keeping with the fallback scheme being adopted wherever
appropriate for drivers for Renesas SoCs.

Also correct typo.

Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/net/renesas,ravb.txt | 11 +--
 drivers/net/ethernet/renesas/ravb_main.c   |  2 ++
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt 
b/Documentation/devicetree/bindings/net/renesas,ravb.txt
index b486f3f5f6a3..115006325bff 100644
--- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
+++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
@@ -1,12 +1,19 @@
 * Renesas Electronics Ethernet AVB
 
 This file provides information on what the device node for the Ethernet AVB
-interface contains.
+interface.
 
 Required properties:
 - compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 
SoC.
  "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC.
  "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC.
+ "renesas,etheravb-gen2" for generic R-Car Gen 2 compatible 
interface.
+ "renesas,etheravb-gen3" for generic R-Car Gen 3 compatible 
interface.
+
+ When compatible with the generic version, nodes must list the
+ SoC-specific version corresponding to the platform first
+ followed by the generic version.
+
 - reg: offset and length of (1) the register block and (2) the stream buffer.
 - interrupts: A list of interrupt-specifiers, one for each entry in
  interrupt-names.
@@ -37,7 +44,7 @@ Optional properties:
 Example:
 
ethernet@e680 {
-   compatible = "renesas,etheravb-r8a7795";
+   compatible = "renesas,etheravb-r8a7795", 
"renesas,etheravb-gen3";
reg = <0 0xe680 0 0x800>, <0 0xe6a0 0 0x1>;
interrupt-parent = <>;
interrupts = ,
diff --git a/drivers/net/ethernet/renesas/ravb_main.c 
b/drivers/net/ethernet/renesas/ravb_main.c
index 990dc55cdada..d3b4f574d346 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1656,7 +1656,9 @@ static int ravb_mdio_release(struct ravb_private *priv)
 static const struct of_device_id ravb_match_table[] = {
{ .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 },
+   { .compatible = "renesas,etheravb-gen2",.data = (void *)RCAR_GEN2 },
{ .compatible = "renesas,etheravb-r8a7795", .data = (void *)RCAR_GEN3 },
+   { .compatible = "renesas,etheravb-gen3",.data = (void *)RCAR_GEN3 },
{ }
 };
 MODULE_DEVICE_TABLE(of, ravb_match_table);
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2 net-next] ravb: More compat strings

[Simon Horman]

Hi,

this short series adds generic gen2 and gen3, and soc-specific compat strings
for the missing gen2 SoCs.

Simon Horman (2):
  ravb: Add fallback compatibility strings
  ravb: Add device tree support for r8a779[123]

 Documentation/devicetree/bindings/net/renesas,ravb.txt | 14 --
 drivers/net/ethernet/renesas/ravb_main.c   |  2 ++
 2 files changed, 14 insertions(+), 2 deletions(-)

-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ravb: add R8A7791 support

[Simon Horman]

On Mon, Nov 30, 2015 at 12:14:21AM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 11/29/2015 10:26 PM, Geert Uytterhoeven wrote:
> 
> >>Add support  for yet another ARM member of the R-Car family, R-Car M2, also
> 
> >R-Car M2-W?
> 
>Right, forgot about the postfixes.
> 
> >>known as R8A7791.
> >
> >There's also R-Car M2-N, aka R8A7793, but you probably know that ;-)
> 
>Will fix.

I would prefer if we added generic gen2 and gen3 compat strings to the driver
and only documented new soc-specific compat strings.

Actually by chance I was planning to up patches to do that and add compat
strings for the missing Gen2 boards. But I won't complain if you beat me to
it.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 0/4] ARM: shmobile: r8a7740/sh73a0 DT Cache Handling

[Simon Horman]

On Wed, Nov 25, 2015 at 09:45:20AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Nov 25, 2015 at 2:50 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Mon, Nov 23, 2015 at 02:55:58PM +0100, Geert Uytterhoeven wrote:
> >> This patch series add minimal L1 and L2 cache descriptions to DT for
> >> r8a7740 and sh73a0, and migrates the shmobile DT-based generic r8a7740
> >> platform from calling l2x0_of_init() to the generic l2c OF
> >> initialization.
> >>
> >> Note that the conversion to the generic l2c OF initialization is not
> >> done yet for sh73a0, as this initializes the L2 cache earlier, breaking
> >> the (fragile) sh73a0 secondary CPU bringup code.
> >>
> >> Also note that this conversion should be done on r8a7778, and r8a7779,
> >> too.
> >
> > Based on your work I have prepared a DT patch for the r8a7779.
> 
> Thanks for following up.
> 
> > I don't think that a C patch is necessary, please correct me if I am wrong.
> 
> Yes you do!
> Without machine_desc.l2x_aux_{val,mask}, the information in DT is not used.
> Cfr. arch/arm/mach-shmobile/setup-r8a7740.c

Thanks, I see "ARM: shmobile: r8a7740: Migrate to generic l2c OF
initialization" with new eyes.

> > Regarding the r8a7778: My reading of the documentation is that although a
> > pl310 L2 cache controller is present it is not available for use as there
> > is no L2 cache memory present. For this reason I do not think any patches
> > are required for the r8a7798.
> 
> I agree after consulting the datasheet.
> 
> >> Dependencies:
> >>   - This series applies to renesas-devel-20151123-v4.4-rc2,
> >>   - Patch 3 depends on patch 1,
> >>   - Patch 4 depends on patch 3.
> >>
> >> Given C code changesets depending on DT changesets in the same branch
> >> are frowned upon, you may want to postpone patches 3 and 4 to v4.6.
> >> Of course I'll sleep better if you just apply all 4 of them now ;-)
> >
> > I have queued up the DT changes for v4.5.
> > And tentatively queued up the C changes for v4.6.
> 
> Thank you!
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: usb-dmac: Document SoC specific bindings

[Simon Horman]

On Tue, Nov 24, 2015 at 05:49:05AM +, Yoshihiro Shimoda wrote:
> Hi Simon-san,
> 
> > From: Simon Horman [mailto:horms+rene...@verge.net.au]
> > Sent: Tuesday, November 24, 2015 11:21 AM
> > 
> > In general Renesas hardware is not documented to the extent where the
> > relationship between IP blocks on different SoCs can be assumed although
> > they may appear to operate the same way. Furthermore the documentation
> > typically does not specify a version for individual IP blocks. For these
> > reasons a convention of using the SoC name in place of a version and
> > providing SoC-specific compat strings has been adopted.
> > 
> > Although not universally liked this convention is used in the bindings for
> > most drivers for Renesas hardware. The purpose of this patch is to
> > update the Renesas USB DMA Controller driver to follow this convention.
> > 
> > Cc: devicetree@vger.kernel.org
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> 
> Thank you for the patch!
> 
> > ---
> > * r8a7792 (R-Car V2H) is omitted as my reading of the documentation
> >   is that Renesas USB-DMAC does not exist on that SoC
> 
> I agree with you.
> 
> > * r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
> >   of USB-DMAC that SoC
> 
> I think this is R-Car H3, not H2.

Yes, H3. Sorry about that.

> Since R-Car H3's USB-DMAC is compatible with other SoCs,
> would you add the R-Car H3's compatible string, if possible?

Sure, will do.

> Anyway,
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dmaengine: usb-dmac: Document SoC specific bindings

[Simon Horman]

On Tue, Nov 24, 2015 at 02:16:55PM -0600, Rob Herring wrote:
> On Tue, Nov 24, 2015 at 11:20:41AM +0900, Simon Horman wrote:
> > In general Renesas hardware is not documented to the extent where the
> > relationship between IP blocks on different SoCs can be assumed although
> > they may appear to operate the same way. Furthermore the documentation
> > typically does not specify a version for individual IP blocks. For these
> > reasons a convention of using the SoC name in place of a version and
> > providing SoC-specific compat strings has been adopted.
> > 
> > Although not universally liked this convention is used in the bindings for
> > most drivers for Renesas hardware. The purpose of this patch is to
> > update the Renesas USB DMA Controller driver to follow this convention.
> > 
> > Cc: devicetree@vger.kernel.org
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
> > 
> > ---
> > * r8a7792 (R-Car V2H) is omitted as my reading of the documentation
> >   is that Renesas USB-DMAC does not exist on that SoC
> > * r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
> >   of USB-DMAC that SoC
> > 
> > * Once this has been merged I intend to provide follow-up patches
> >   to use these new compat strings in the relevant dtsi files.
> > ---
> >  Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt 
> > b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > index 040f365954cc..3bb624e10615 100644
> > --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > @@ -1,7 +1,12 @@
> >  * Renesas USB DMA Controller Device Tree bindings
> >  
> >  Required Properties:
> > -- compatible: must contain "renesas,usb-dmac"
> > +- compatible: "renesas,usb-dmac-", "renesas,usb-dmac" as fallback.
> > + Examples with soctypes are:
> > +   - "renesas,usb-dmac-r8a7790" (R-Car H2)
> > +   - "renesas,usb-dmac-r8a7791" (R-Car M2-W)
> > +   - "renesas,usb-dmac-r8a7793" (R-Car M2-N)
> > +   - "renesas,usb-dmac-r8a7794" (R-Car E2)
> 
> Weren't you changing the order of SoC and block names on new bindings? 

Could you clarify what the desired order is?
My intention is for these bindings to use the preferred order.

> Either way:
> 
> Acked-by: Rob Herring <r...@kernel.org>
> 
> Rob
> 
> >  - reg: base address and length of the registers block for the DMAC
> >  - interrupts: interrupt specifiers for the DMAC, one for each entry in
> >interrupt-names.
> > @@ -15,7 +20,7 @@ Required Properties:
> >  Example: R8A7790 (R-Car H2) USB-DMACs
> >  
> > usb_dmac0: dma-controller@e65a {
> > -   compatible = "renesas,usb-dmac";
> > +   compatible = "renesas,usb-dmac-r8a7790", "renesas,usb-dmac";
> > reg = <0 0xe65a 0 0x100>;
> > interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
> >   0 109 IRQ_TYPE_LEVEL_HIGH>;
> > -- 
> > 2.1.4
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dmaengine: usb-dmac: Document SoC specific bindings

[Simon Horman]

In general Renesas hardware is not documented to the extent where the
relationship between IP blocks on different SoCs can be assumed although
they may appear to operate the same way. Furthermore the documentation
typically does not specify a version for individual IP blocks. For these
reasons a convention of using the SoC name in place of a version and
providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for
most drivers for Renesas hardware. The purpose of this patch is to
update the Renesas USB DMA Controller driver to follow this convention.

Cc: devicetree@vger.kernel.org
Cc: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com>
Signed-off-by: Simon Horman <horms+rene...@verge.net.au>

---
* r8a7792 (R-Car V2H) is omitted as my reading of the documentation
  is that Renesas USB-DMAC does not exist on that SoC
* r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
  of USB-DMAC that SoC

* Once this has been merged I intend to provide follow-up patches
  to use these new compat strings in the relevant dtsi files.
---
 Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt 
b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
index 040f365954cc..3bb624e10615 100644
--- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
@@ -1,7 +1,12 @@
 * Renesas USB DMA Controller Device Tree bindings
 
 Required Properties:
-- compatible: must contain "renesas,usb-dmac"
+- compatible: "renesas,usb-dmac-", "renesas,usb-dmac" as fallback.
+ Examples with soctypes are:
+   - "renesas,usb-dmac-r8a7790" (R-Car H2)
+   - "renesas,usb-dmac-r8a7791" (R-Car M2-W)
+   - "renesas,usb-dmac-r8a7793" (R-Car M2-N)
+   - "renesas,usb-dmac-r8a7794" (R-Car E2)
 - reg: base address and length of the registers block for the DMAC
 - interrupts: interrupt specifiers for the DMAC, one for each entry in
   interrupt-names.
@@ -15,7 +20,7 @@ Required Properties:
 Example: R8A7790 (R-Car H2) USB-DMACs
 
usb_dmac0: dma-controller@e65a {
-   compatible = "renesas,usb-dmac";
+   compatible = "renesas,usb-dmac-r8a7790", "renesas,usb-dmac";
reg = <0 0xe65a 0 0x100>;
interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
  0 109 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] arm64: renesas: r8a7795 dtsi: Add all HSCIF nodes

[Simon Horman]

On Thu, Nov 19, 2015 at 07:29:11PM +0100, Geert Uytterhoeven wrote:
> Add the device nodes for all HSCIF serial ports, incl. clocks, clock
> domain, and dma properties.
> 
> Signed-off-by: Geert Uytterhoeven 

Thanks, I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] VIN, ADV7180 for r8a7794/alt

[Simon Horman]

On Wed, Nov 18, 2015 at 01:51:05PM +0100, Ulrich Hecht wrote:
> Hi!
> 
> This series adds VIN support for the Alt board.  The hardware configuration
> for I2C1 and the video decoder of Alt is exactly identical to that of Silk,
> so these are largely identical to Sergei's Silk definitions.
> 
> To be applied on top of Horms's "ARM: shmobile: alt: Add pfc pins to DT"
> patch.

Thanks, I have queued-up this series on top of the patch mentioned above.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode

[Simon Horman]

On Fri, Nov 13, 2015 at 08:56:18AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Fri, Nov 13, 2015 at 1:28 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote:
> >> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <ho...@verge.net.au> wrote:
> >> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote:
> >> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to 
> >> >> a
> >> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
> >> >> partitions in a special 'partitions' subnode"), having partitions as
> >> >> direct subnodes of an mtd device is discouraged:
> >> >>
> >> >> spi0.0: 'partitions' subnode not found on /spi@e6b1/flash@0. 
> >> >> Trying to parse direct subnodes as partitions.
> >> >
> >> > I seem to see something else, perhaps I have a hardware problem?
> >> >
> >> >  m25p80 spi0.0: unrecognized JEDEC id bytes: 01,  2, 20
> >>
> >> That indeed means QSPI doesn't work. Is it reproducible?
> >> Is this on Koelsch?
> >
> > Yes. It appears to happy reliably in my Koelsch.
> 
> Which tree / config?
> 
> I've just tried renesas-devel-20151113-v4.3 and topic/gen3-latest with
> shmobile_defconfig, and the QSPI flash was detected correctly on both (the
> former failed to parse partitions, as the code for the partitions subnode is
> not yet in v4.3).

* I am able to reproduce the "unrecognized JDEC id" problem on my Koelsch board
  using renesas-devel-20151113-v4.3 with shmobile_defconfig.

* I also noticed the partitions problem (on the gose board).
  Perhaps I should have held off on applying the patches in question.
  But the appears to be resolved now that the branch
  with the patch in question has been rebased on top of v4.4-rc1.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] iommu/ipmmu-vmsa: Include SoC part number in DT binding docs

[Simon Horman]

On Tue, Nov 17, 2015 at 12:53:20PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+rene...@opensource.se>
> 
> Add part numbers for APE6 and current set of R-Car Gen2 SoCs to the
> IPMMU DT binding documentation. The example is also updated to show
> how the generic compatible string may be used as fallback.
> 
> Signed-off-by: Magnus Damm <damm+rene...@opensource.se>

Acked-by: Simon Horman <horms+rene...@verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode

[Simon Horman]

On Thu, Nov 12, 2015 at 11:03:33AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Nov 12, 2015 at 2:15 AM, Simon Horman <ho...@verge.net.au> wrote:
> > On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote:
> >> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a
> >> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
> >> partitions in a special 'partitions' subnode"), having partitions as
> >> direct subnodes of an mtd device is discouraged:
> >>
> >> spi0.0: 'partitions' subnode not found on /spi@e6b1/flash@0. 
> >> Trying to parse direct subnodes as partitions.
> >
> > I seem to see something else, perhaps I have a hardware problem?
> >
> >  m25p80 spi0.0: unrecognized JEDEC id bytes: 01,  2, 20
> 
> That indeed means QSPI doesn't work. Is it reproducible?
> Is this on Koelsch?

Yes. It appears to happy reliably in my Koelsch.

> 
> >> Hence move the SPI FLASH partitions to a "partitions" subnode.
> >
> > Thanks, I will queue this up.
> >
> > I assume we also need this for other boards with flash nodes
> > in mainline: bockw, lager, porter, silk.
> 
> Indeed. I converted Koelsch only to see if it works, and as a reminder for
> the other boards. But as you added more deprecated usage, I sent out what
> I had.
> 
> > I'm happy to prepare patches to do that if you want to pass.
> 
> Feel free to convert the other boards if you have time. Thanks!

Sure, will do.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: koelsch: Move SPI FLASH partitions to subnode

[Simon Horman]

On Tue, Nov 10, 2015 at 09:35:06AM +0100, Geert Uytterhoeven wrote:
> As of commits 5cfdedb7b9a0fe38 ("mtd: ofpart: move ofpart partitions to a
> dedicated dt node") and fe2585e9c29a650a ("doc: dt: mtd: support
> partitions in a special 'partitions' subnode"), having partitions as
> direct subnodes of an mtd device is discouraged:
> 
> spi0.0: 'partitions' subnode not found on /spi@e6b1/flash@0. Trying 
> to parse direct subnodes as partitions.

I seem to see something else, perhaps I have a hardware problem?

 m25p80 spi0.0: unrecognized JEDEC id bytes: 01,  2, 20

> Hence move the SPI FLASH partitions to a "partitions" subnode.

Thanks, I will queue this up.

I assume we also need this for other boards with flash nodes
in mainline: bockw, lager, porter, silk.

I'm happy to prepare patches to do that if you want to pass.

> Signed-off-by: Geert Uytterhoeven 

[snip]
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] dmaengine: rcar-dmac: Document SoC specific bindings

[Simon Horman]

In general Renesas hardware is not documented to the extent where the
relationship between IP blocks on different SoCs can be assumed although
they may appear to operate the same way. Furthermore the documentation
typically does not specify a version for individual IP blocks. For these
reasons a convention of using the SoC name in place of a version and
providing SoC-specific compat strings has been adopted.

Although not universally liked this convention is used in the bindings for
most drivers for Renesas hardware. The purpose of this patch is to
update the Renesas R-Car DMA Controller driver to follow this convention.

Cc: devicetree@vger.kernel.org
Cc: Magnus Damm <magnus.d...@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Signed-off-by: Simon Horman <horms+rene...@verge.net.au>
---
 Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt | 13 ++---
 1 file changed, 10 insertions(+), 3 deletions(-)

Once this has been merged I intend to provide follow-up patches
to use these new compat strings in the relevant dtsi files.

diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt 
b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
index 09daeef1ff22..5b902ac8d97e 100644
--- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
+++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.txt
@@ -14,7 +14,14 @@ not described in these device tree bindings.
 
 Required Properties:
 
-- compatible: must contain "renesas,rcar-dmac"
+- compatible: "renesas,dmac-", "renesas,rcar-dmac" as fallback.
+ Examples with soctypes are:
+   - "renesas,dmac-r8a7790" (R-Car H2)
+   - "renesas,dmac-r8a7791" (R-Car M2-W)
+   - "renesas,dmac-r8a7792" (R-Car V2H)
+   - "renesas,dmac-r8a7793" (R-Car M2-N)
+   - "renesas,dmac-r8a7794" (R-Car E2)
+   - "renesas,dmac-r8a7795" (R-Car H3)
 
 - reg: base address and length of the registers block for the DMAC
 
@@ -35,7 +42,7 @@ Required Properties:
 Example: R8A7790 (R-Car H2) SYS-DMACs
 
dmac0: dma-controller@e670 {
-   compatible = "renesas,rcar-dmac";
+   compatible = "renesas,dmac-r8a7790", "renesas,rcar-dmac";
reg = <0 0xe670 0 0x2>;
interrupts = <0 197 IRQ_TYPE_LEVEL_HIGH
  0 200 IRQ_TYPE_LEVEL_HIGH
@@ -65,7 +72,7 @@ Example: R8A7790 (R-Car H2) SYS-DMACs
};
 
dmac1: dma-controller@e672 {
-   compatible = "renesas,rcar-dmac";
+   compatible = "renesas,dmac-r8a7790", "renesas,rcar-dmac";
reg = <0 0xe672 0 0x2>;
interrupts = <0 220 IRQ_TYPE_LEVEL_HIGH
  0 216 IRQ_TYPE_LEVEL_HIGH
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PCI: rcar (usb): DT can override default window settings

[Simon Horman]

On Thu, Nov 05, 2015 at 07:49:47AM -0600, Rob Herring wrote:
> On Tue, Nov 03, 2015 at 04:19:26PM +, Phil Edworthy wrote:
> > If the dtb specifies dma-ranges, we use those values. Otherwise, we
> > default to the values that were previously hardcoded into the driver.
> > 
> > Signed-off-by: Phil Edworthy <phil.edwor...@renesas.com>
> > ---
> >  .../devicetree/bindings/pci/pci-rcar-gen2.txt  |  6 ++
> 
> Acked-by: Rob Herring <r...@kernel.org>

Bjorn,

this looks good to me. Please feel free to apply.

Acked-by: Simon Horman <horms+rene...@verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: renesas: salvator-x: Setup ethernet0 alias for U-Boot

[Simon Horman]

On Fri, Oct 30, 2015 at 03:37:26PM +0200, Laurent Pinchart wrote:
> Hi Geert,
> 
> On Friday 30 October 2015 14:16:03 Geert Uytterhoeven wrote:
> > On Fri, Oct 30, 2015 at 2:06 PM, Laurent Pinchart wrote:
> > > On Friday 30 October 2015 10:25:20 Geert Uytterhoeven wrote:
> > >> Add an ethernet0 alias for the wired network card so that U-Boot can
> > >> find the device-node and add an appropriate "local-mac-address"
> > >> property.
> > > 
> > > I like that :-) Can U-Boot add the property ? I thought it needed a
> > > placeholder.
> > 
> > At least for Salvator-X it does. See also the thread at
> > http://www.spinics.net/lists/arm-kernel/msg456841.html
> 
> Cool :-)
> 
> Acked-by: Laurent Pinchart 

Thanks, I will include this in the next spin of the ravb integration
patches for r8a7795/salvator-x.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: henninger: remove board DT

[Simon Horman]

On Thu, Oct 29, 2015 at 12:34:29AM +0300, Sergei Shtylyov wrote:
> The Henninger low cost board was never sold and so  had  no  users outside
> Renesas (and Cogent Embedded). Instead Renesas  has made the Porter  board
> which has mostly similar hardware. Now that the Porter board support is on
> par with Henninger, we can remove  the Henninger's device tree file.
> 
> Signed-off-by: Sergei Shtylyov 

Thanks, I have queued this up for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: porter: add CAN0 DT support

[Simon Horman]

On Wed, Oct 28, 2015 at 12:03:22AM +0300, Sergei Shtylyov wrote:
> Define the Porter board dependent part of the CAN0 device node.
> 
> This patch is  analogous to the commit 457acc4a6ce8 (ARM: shmobile:
> henninger: add CAN0 DT support) as there are no differences between the
> boards in this respect.
> 
> Signed-off-by: Sergei Shtylyov 

Thanks, I have queued this up for v4.5 after updating the changelog
as per checkpatch.pl's insight:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> 
("")' - ie: 'commit 457acc4a6ce8 ("ARM: shmobile: henninger: add 
CAN0 DT support")'
#8: 
This patch is  analogous to the commit 457acc4a6ce8 (ARM: shmobile:
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key,wakeup with wakeup-source property

[Simon Horman]

On Thu, Oct 22, 2015 at 10:37:54AM +0100, Sudeep Holla wrote:
> 
> 
> On 22/10/15 01:50, Simon Horman wrote:
> >On Wed, Oct 21, 2015 at 11:23:03AM +0100, Sudeep Holla wrote:
> >>
> >>
> >>On 21/10/15 11:18, Geert Uytterhoeven wrote:
> >>>On Wed, Oct 21, 2015 at 12:10 PM, Sudeep Holla <sudeep.ho...@arm.com> 
> >>>wrote:
> >>>>Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
> >>>>check for/support the legacy "gpio-key,wakeup" boolean property to
> >>>>enable gpio buttons as wakeup source, "wakeup-source" is the new
> >>>>standard binding.
> >>>>
> >>>>This patch replaces the legacy "gpio-key,wakeup" with the unified
> >>>>"wakeup-source" property in order to avoid any futher copy-paste
> >>>>duplication.
> >>>
> >>>Thanks!
> >>>
> >>>I made the same changes to my local tree a few weeks ago, but never found
> >>>time to send them out...
> >>>
> >>
> >>Ah OK, even I had these changes for long. I waited until I fixed all the
> >>binding documents(which was boring ;))
> >>
> >>>>Cc: Simon Horman <ho...@verge.net.au>
> >>>>Cc: Magnus Damm <magnus.d...@gmail.com>
> >>>>Cc: linux...@vger.kernel.org
> >>>>Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com>
> >>>
> >>>Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>
> >
> >Can I clarify that you would like me to pick up this patch?
> >If so I'm happy to do so.
> >
> 
> Yes you can pick up this patch as it has no dependency on driver changes.

Thanks, I have queued this up for v4.5.

It should appear in the devel branch of the renesas tree some time today.
I will include it in the next branch, which is included in the linux-next
tree, once v4.4-rc1 has been released.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: shmobile: r8a7791: fix "gpio-ranges" props

[Simon Horman]

On Thu, Oct 22, 2015 at 01:06:02PM +0200, Geert Uytterhoeven wrote:
> On Thu, Oct 22, 2015 at 1:05 AM, Sergei Shtylyov
>  wrote:
> > On R8A7791, GPIO banks 1 and 7  are missing  pins 26 to 31.  Correct the
> > "gpio-ranges" properties of the GPIO1 node (GPIO7 is already correct).
> >
> > Signed-off-by: Sergei Shtylyov 
> 
> LEDs and keys on r8a7791/koelsch (which are connected to a higher gpio)
> still work fine.
> 
> Tested-by: Geert Uytterhoeven 

Thanks, I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: shmobile: r8a7790: fix "gpio-ranges" props

[Simon Horman]

On Thu, Oct 22, 2015 at 02:04:41AM +0300, Sergei Shtylyov wrote:
> On R8A7790, GPIO banks 1 and 2 are missing  pins 30 and 31.  Correct the
> "gpio-ranges" properties of the corresponding device nodes.
> 
> Signed-off-by: Sergei Shtylyov 
> 
> ---
> This patch is against the 'renesas-devel-20151019-v4.3-rc6' of Simon Horman's
> 'renesas.git' repo.

Thanks, I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/19] ARM: dts: shmobile/r8a7xxx: replace gpio-key,wakeup with wakeup-source property

[Simon Horman]

On Wed, Oct 21, 2015 at 11:23:03AM +0100, Sudeep Holla wrote:
> 
> 
> On 21/10/15 11:18, Geert Uytterhoeven wrote:
> >On Wed, Oct 21, 2015 at 12:10 PM, Sudeep Holla <sudeep.ho...@arm.com> wrote:
> >>Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
> >>check for/support the legacy "gpio-key,wakeup" boolean property to
> >>enable gpio buttons as wakeup source, "wakeup-source" is the new
> >>standard binding.
> >>
> >>This patch replaces the legacy "gpio-key,wakeup" with the unified
> >>"wakeup-source" property in order to avoid any futher copy-paste
> >>duplication.
> >
> >Thanks!
> >
> >I made the same changes to my local tree a few weeks ago, but never found
> >time to send them out...
> >
> 
> Ah OK, even I had these changes for long. I waited until I fixed all the
> binding documents(which was boring ;))
>
> >>Cc: Simon Horman <ho...@verge.net.au>
> >>Cc: Magnus Damm <magnus.d...@gmail.com>
> >>Cc: linux...@vger.kernel.org
> >>Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com>
> >
> >Acked-by: Geert Uytterhoeven <geert+rene...@glider.be>

Can I clarify that you would like me to pick up this patch?
If so I'm happy to do so.

Else:

Acked-by: Simon Horman <horms+rene...@verge.net.au>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: shmobile: silk: add SDHI1 DT support

[Simon Horman]

On Wed, Oct 21, 2015 at 09:13:02PM +0300, Sergei Shtylyov wrote:
> On 10/21/2015 03:31 AM, Simon Horman wrote:
> 
> >>>>There should have been [PATCH v3] in the subject, of course.
> >>>
> >>>Thanks for following up.
> >>>
> >>>I have queued this up for v4.5.
> >>
> >>Again, not seeing anything new today from renesas.git...
> >
> >Thanks for noticing, it should be there now.
> 
>Hm, again nothing... :-(

Sorry, third time lucky.

https://git.kernel.org/cgit/linux/kernel/git/horms/renesas.git/tag/?id=renesas-devel-20151021-v4.3-rc6
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: shmobile: silk: add SDHI1 DT support

[Simon Horman]

On Tue, Oct 20, 2015 at 08:58:20PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 10/19/2015 03:46 AM, Simon Horman wrote:
> 
> >>There should have been [PATCH v3] in the subject, of course.
> >
> >Thanks for following up.
> >
> >I have queued this up for v4.5.
> 
>Again, not seeing anything new today from renesas.git...

Thanks for noticing, it should be there now.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: shmobile: silk: add SDHI1 DT support

[Simon Horman]

On Sun, Oct 18, 2015 at 02:04:53PM +0300, Sergei Shtylyov wrote:
> There should have been [PATCH v3] in the subject, of course.

Thanks for following up.

I have queued this up for v4.5.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: porter: add HS-USB DT support

[Simon Horman]

On Wed, Oct 14, 2015 at 10:35:46PM +0300, Sergei Shtylyov wrote:
> Enable HS-USB device  for the Porter board, defining the GPIO that the
> driver should check  when probing (which is the ID output from MAX3355
> OTG chip).
> 
> Note that there  will be pinctrl-related error messages if both internal
> PCI  and  HS-USB drivers are enabled but they should be just ignored.
> 
> This patch is  analogous  to the commit 6f4f7156e0e6 (ARM: shmobile:
> henninger: enable HS-USB) as there  are no differences between the
> boards in this respect.
> 
> Signed-off-by: Sergei Shtylyov 
> 

Thanks Sergei,

I have queued this up for v4.5.

I took the liberty of tweaking the changelog to address a complaint made
by Mr. Check Patch.

ERROR: Please use git commit description style 'commit <12+ chars of sha1> 
("")' - ie: 'commit 6f4f7156e0e6 ("ARM: shmobile: henninger: enable 
HS-USB")'
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property

[Simon Horman]

[cc linux-sh]

On Tue, Oct 13, 2015 at 02:32:43PM +0100, Sudeep Holla wrote:
> The keyboard driver for GPIO buttons(gpio-keys) checks for one of the
> two boolean properties to enable gpio buttons as wakeup source:
> 1. "wakeup-source" or
> 2. the legacy "gpio-key,wakeup"
> 
> However juno, ste-snowball and emev2-kzm9d dts file have a undetected
> "wakeup" property to indictate the wakeup source.
> 
> This patch fixes it by making use of "wakeup-source" property.
> 
> Cc: Simon Horman <ho...@verge.net.au>
> Cc: Magnus Damm <magnus.d...@gmail.com>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com>
> ---
>  arch/arm/boot/dts/emev2-kzm9d.dts |  8 
>  arch/arm/boot/dts/ste-snowball.dts| 10 +-
>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 12 ++--
>  3 files changed, 15 insertions(+), 15 deletions(-)

emev2-kzm9d portion:

Acked-by: Simon Horman <horms+rene...@verge.net.au>

My preferred course of action would be to take that portion through the
renesas tree if it was broken out into a separate patch. But I won't
object if someone wants to take the whole patch/series.

> diff --git a/arch/arm/boot/dts/emev2-kzm9d.dts 
> b/arch/arm/boot/dts/emev2-kzm9d.dts
> index 955c24ee4a8c..8c24975e8f9d 100644
> --- a/arch/arm/boot/dts/emev2-kzm9d.dts
> +++ b/arch/arm/boot/dts/emev2-kzm9d.dts
> @@ -35,28 +35,28 @@
>  
>   button@1 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   label = "DSW2-1";
>   linux,code = ;
>   gpios = < 14 GPIO_ACTIVE_HIGH>;
>   };
>   button@2 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   label = "DSW2-2";
>   linux,code = ;
>   gpios = < 15 GPIO_ACTIVE_HIGH>;
>   };
>   button@3 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   label = "DSW2-3";
>   linux,code = ;
>   gpios = < 16 GPIO_ACTIVE_HIGH>;
>   };
>   button@4 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   label = "DSW2-4";
>   linux,code = ;
>   gpios = < 17 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/ste-snowball.dts 
> b/arch/arm/boot/dts/ste-snowball.dts
> index 32a5ccb14e7e..e80e42163883 100644
> --- a/arch/arm/boot/dts/ste-snowball.dts
> +++ b/arch/arm/boot/dts/ste-snowball.dts
> @@ -47,35 +47,35 @@
>  
>   button@1 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   linux,code = <2>;
>   label = "userpb";
>   gpios = < 0 0x4>;
>   };
>   button@2 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   linux,code = <3>;
>   label = "extkb1";
>   gpios = < 23 0x4>;
>   };
>   button@3 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   linux,code = <4>;
>   label = "extkb2";
>   gpios = < 24 0x4>;
>   };
>   button@4 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   linux,code = <5>;
>   label = "extkb3";
>   gpios = < 1 0x4>;
>   };
>   button@5 {
>   debounce_interval = <50>;
> - wakeup = <1>;
> + wakeup-source;
>   linux,code = <6>;
>   label = "extkb4";
>  

Re: [PATCH] ARM: shmobile: porter: add QSPI DT support

[Simon Horman]

On Mon, Oct 12, 2015 at 08:53:26AM +0200, Geert Uytterhoeven wrote:
> On Mon, Oct 12, 2015 at 2:04 AM, Simon Horman <ho...@verge.net.au> wrote:
> >> + flash@0 {
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + compatible = "spansion,s25fl512s", "jedec,spi-nor";
> >
> > spansion,s25fl512s is used in several dt files but it seems to be
> > undocumented. Do we have a plan to resolve this?
> 
> Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt:
> 
> - compatible : May include a device-specific string consisting of the
>manufacturer and name of the chip. Bear in mind the DT binding
>is not Linux-only, but in case of Linux, see the "m25p_ids"
>table in drivers/mtd/devices/m25p80.c for the list of supported
>chips.
>Must also include "jedec,spi-nor" for any SPI NOR flash that 
> can
>be identified by the JEDEC READ ID opcode (0x9F).
> 
> Hence it's OK.

Thanks, I guess checkpatch needs to learn about that rule.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: shmobile: porter: enable internal PCI and USB PHY

[Simon Horman]

On Tue, Oct 13, 2015 at 01:12:18AM +0300, Sergei Shtylyov wrote:
> Enable  internal AHB-PCI bridges for the USB EHCI/OHCI controllers attached
> to them and also enable  USB PHY device  for the Porter board.  We have to
> enable  everything in one patch since EHCI/OHCI devices are already linked
> to the USB PHY device.
> 
> Signed-off-by: Sergei Shtylyov 

Thanks, I have queued this up for v4.4.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html