Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros
Hi Jacek, On Tue, Jan 20, 2015 at 01:53:05PM +0100, Jacek Anaszewski wrote: > On 01/20/2015 12:12 PM, Lee Jones wrote: > >On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > > > >>Add macros for max77693 led part related binding. > >> > >>Signed-off-by: Jacek Anaszewski > >>Acked-by: Kyungmin Park > >>Cc: Lee Jones > >>Cc: Chanwoo Choi > >>--- > >> include/dt-bindings/mfd/max77693.h | 21 + > >> 1 file changed, 21 insertions(+) > >> create mode 100644 include/dt-bindings/mfd/max77693.h > >> > >>diff --git a/include/dt-bindings/mfd/max77693.h > >>b/include/dt-bindings/mfd/max77693.h > >>new file mode 100644 > >>index 000..f53e197 > >>--- /dev/null > >>+++ b/include/dt-bindings/mfd/max77693.h > >>@@ -0,0 +1,21 @@ > >>+/* > >>+ * This header provides macros for MAX77693 device binding > >>+ * > >>+ * Copyright (C) 2014, Samsung Electronics Co., Ltd. > >>+ * > >>+ * Author: Jacek Anaszewski > >>+ */ > >>+ > >>+#ifndef __DT_BINDINGS_MAX77693_H__ > >>+#define __DT_BINDINGS_MAX77693_H > >>+ > >>+/* External trigger type */ > >>+#define MAX77693_LED_TRIG_TYPE_EDGE0 > >>+#define MAX77693_LED_TRIG_TYPE_LEVEL 1 > >>+ > >>+/* Boost modes */ > >>+#define MAX77693_LED_BOOST_OFF 0 > >>+#define MAX77693_LED_BOOST_ADAPTIVE1 > >>+#define MAX77693_LED_BOOST_FIXED 2 > >>+ > >>+#endif /* __DT_BINDINGS_MAX77693_H */ > > > >These look fairly generic. Do generic LED defines already exist? If > >not, can they? > > I am not entirely sure that they are generic. Different devices > may define different trigger types for low current LEDs and flash > LEDs. Boost modes could also have different semantics. > > Regardless of the above we can consider renaming the file to > include/dt-bindings/leds/max77693.h > > Bryan - what is your opinion? At least trigger type can be chosen for lm3555 (as3645a) as well. I'm not sure about boost mode. -- Regards, Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros
On 01/20/2015 12:12 PM, Lee Jones wrote: On Fri, 09 Jan 2015, Jacek Anaszewski wrote: Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi --- include/dt-bindings/mfd/max77693.h | 21 + 1 file changed, 21 insertions(+) create mode 100644 include/dt-bindings/mfd/max77693.h diff --git a/include/dt-bindings/mfd/max77693.h b/include/dt-bindings/mfd/max77693.h new file mode 100644 index 000..f53e197 --- /dev/null +++ b/include/dt-bindings/mfd/max77693.h @@ -0,0 +1,21 @@ +/* + * This header provides macros for MAX77693 device binding + * + * Copyright (C) 2014, Samsung Electronics Co., Ltd. + * + * Author: Jacek Anaszewski + */ + +#ifndef __DT_BINDINGS_MAX77693_H__ +#define __DT_BINDINGS_MAX77693_H + +/* External trigger type */ +#define MAX77693_LED_TRIG_TYPE_EDGE0 +#define MAX77693_LED_TRIG_TYPE_LEVEL 1 + +/* Boost modes */ +#define MAX77693_LED_BOOST_OFF 0 +#define MAX77693_LED_BOOST_ADAPTIVE1 +#define MAX77693_LED_BOOST_FIXED 2 + +#endif /* __DT_BINDINGS_MAX77693_H */ These look fairly generic. Do generic LED defines already exist? If not, can they? I am not entirely sure that they are generic. Different devices may define different trigger types for low current LEDs and flash LEDs. Boost modes could also have different semantics. Regardless of the above we can consider renaming the file to include/dt-bindings/leds/max77693.h Bryan - what is your opinion? -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros
On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > Add macros for max77693 led part related binding. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chanwoo Choi > --- > include/dt-bindings/mfd/max77693.h | 21 + > 1 file changed, 21 insertions(+) > create mode 100644 include/dt-bindings/mfd/max77693.h > > diff --git a/include/dt-bindings/mfd/max77693.h > b/include/dt-bindings/mfd/max77693.h > new file mode 100644 > index 000..f53e197 > --- /dev/null > +++ b/include/dt-bindings/mfd/max77693.h > @@ -0,0 +1,21 @@ > +/* > + * This header provides macros for MAX77693 device binding > + * > + * Copyright (C) 2014, Samsung Electronics Co., Ltd. > + * > + * Author: Jacek Anaszewski > + */ > + > +#ifndef __DT_BINDINGS_MAX77693_H__ > +#define __DT_BINDINGS_MAX77693_H > + > +/* External trigger type */ > +#define MAX77693_LED_TRIG_TYPE_EDGE 0 > +#define MAX77693_LED_TRIG_TYPE_LEVEL 1 > + > +/* Boost modes */ > +#define MAX77693_LED_BOOST_OFF 0 > +#define MAX77693_LED_BOOST_ADAPTIVE 1 > +#define MAX77693_LED_BOOST_FIXED 2 > + > +#endif /* __DT_BINDINGS_MAX77693_H */ These look fairly generic. Do generic LED defines already exist? If not, can they? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros
On Fri 2015-01-09 16:22:54, Jacek Anaszewski wrote: > Add macros for max77693 led part related binding. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Lee Jones > Cc: Chanwoo Choi Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH/RFC v10 04/19] dt-binding: mfd: max77693: Add DT binding related macros
Add macros for max77693 led part related binding. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park Cc: Lee Jones Cc: Chanwoo Choi --- include/dt-bindings/mfd/max77693.h | 21 + 1 file changed, 21 insertions(+) create mode 100644 include/dt-bindings/mfd/max77693.h diff --git a/include/dt-bindings/mfd/max77693.h b/include/dt-bindings/mfd/max77693.h new file mode 100644 index 000..f53e197 --- /dev/null +++ b/include/dt-bindings/mfd/max77693.h @@ -0,0 +1,21 @@ +/* + * This header provides macros for MAX77693 device binding + * + * Copyright (C) 2014, Samsung Electronics Co., Ltd. + * + * Author: Jacek Anaszewski + */ + +#ifndef __DT_BINDINGS_MAX77693_H__ +#define __DT_BINDINGS_MAX77693_H + +/* External trigger type */ +#define MAX77693_LED_TRIG_TYPE_EDGE0 +#define MAX77693_LED_TRIG_TYPE_LEVEL 1 + +/* Boost modes */ +#define MAX77693_LED_BOOST_OFF 0 +#define MAX77693_LED_BOOST_ADAPTIVE1 +#define MAX77693_LED_BOOST_FIXED 2 + +#endif /* __DT_BINDINGS_MAX77693_H */ -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
