RE: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
Hi Alexandre,
> -Original Message-
> From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com]
> Sent: 2015年3月2日 17:54
> To: Yang, Wenyou
> Cc: Ferre, Nicolas; mark.rutl...@arm.com; devicetree@vger.kernel.org;
> li...@arm.linux.org.uk; pawel.m...@arm.com; ijc+devicet...@hellion.org.uk;
> linux-
> ker...@vger.kernel.org; robh...@kernel.org; ga...@codeaurora.org;
> li...@maxim.org.za; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree
> node
>
> Hi Wenyou,
>
> I'd prefer fixing the sram lookup in pm.c. I'll propose something however, I
> can't
> test on my side.
I can help test it if you give me your patches to me.
>
> On 02/03/2015 at 14:03:29 +0800, Wenyou Yang wrote :
> > Fix PM does not work on the at91sam9g20ek board
> > --->8---
> > at91_pm_sram_init: failed to find sram device!
> > ---<8---
> >
> > Signed-off-by: Wenyou Yang
> > ---
> > arch/arm/boot/dts/at91sam9260.dtsi |9 +++--
> > arch/arm/boot/dts/at91sam9g20.dtsi |9 +
> > 2 files changed, 12 insertions(+), 6 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/at91sam9260.dtsi
> > b/arch/arm/boot/dts/at91sam9260.dtsi
> > index fff0ee6..d1eb27c 100644
> > --- a/arch/arm/boot/dts/at91sam9260.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> > @@ -69,9 +69,14 @@
> > };
> > };
> >
> > - sram0: sram@002ff000 {
> > + sram0: sram@0020 {
> > compatible = "mmio-sram";
> > - reg = <0x002ff000 0x2000>;
> > + reg = <0x0020 0x1000>;
> > + };
> > +
> > + sram1: sram@0030 {
> > + compatible = "mmio-sram";
> > + reg = <0x0030 0x1000>;
> > };
> >
> > ahb {
> > diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi
> > b/arch/arm/boot/dts/at91sam9g20.dtsi
> > index f593016..eb9a62d 100644
> > --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> > @@ -16,13 +16,14 @@
> > reg = <0x2000 0x0800>;
> > };
> >
> > - sram0: sram@002ff000 {
> > - status = "disabled";
> > + sram0: sram@0020 {
> > + compatible = "mmio-sram";
> > + reg = <0x0020 0x4000>;
> > };
> >
> > - sram1: sram@002fc000 {
> > + sram1: sram@0030 {
> > compatible = "mmio-sram";
> > - reg = <0x002fc000 0x8000>;
> > + reg = <0x0030 0x4000>;
> > };
> >
> > ahb {
> > --
> > 1.7.9.5
> >
> >
> > ___
> > linux-arm-kernel mailing list
> > linux-arm-ker...@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com
Best Regards,
Wenyou Yang
Re: [PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
Hi Wenyou,
I'd prefer fixing the sram lookup in pm.c. I'll propose something
however, I can't test on my side.
On 02/03/2015 at 14:03:29 +0800, Wenyou Yang wrote :
> Fix PM does not work on the at91sam9g20ek board
> --->8---
> at91_pm_sram_init: failed to find sram device!
> ---<8---
>
> Signed-off-by: Wenyou Yang
> ---
> arch/arm/boot/dts/at91sam9260.dtsi |9 +++--
> arch/arm/boot/dts/at91sam9g20.dtsi |9 +
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi
> b/arch/arm/boot/dts/at91sam9260.dtsi
> index fff0ee6..d1eb27c 100644
> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> @@ -69,9 +69,14 @@
> };
> };
>
> - sram0: sram@002ff000 {
> + sram0: sram@0020 {
> compatible = "mmio-sram";
> - reg = <0x002ff000 0x2000>;
> + reg = <0x0020 0x1000>;
> + };
> +
> + sram1: sram@0030 {
> + compatible = "mmio-sram";
> + reg = <0x0030 0x1000>;
> };
>
> ahb {
> diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi
> b/arch/arm/boot/dts/at91sam9g20.dtsi
> index f593016..eb9a62d 100644
> --- a/arch/arm/boot/dts/at91sam9g20.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g20.dtsi
> @@ -16,13 +16,14 @@
> reg = <0x2000 0x0800>;
> };
>
> - sram0: sram@002ff000 {
> - status = "disabled";
> + sram0: sram@0020 {
> + compatible = "mmio-sram";
> + reg = <0x0020 0x4000>;
> };
>
> - sram1: sram@002fc000 {
> + sram1: sram@0030 {
> compatible = "mmio-sram";
> - reg = <0x002fc000 0x8000>;
> + reg = <0x0030 0x4000>;
> };
>
> ahb {
> --
> 1.7.9.5
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-ker...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ARM: dts: at919260/at91sam9g20: fix SRAM device tree node
Fix PM does not work on the at91sam9g20ek board
--->8---
at91_pm_sram_init: failed to find sram device!
---<8---
Signed-off-by: Wenyou Yang
---
arch/arm/boot/dts/at91sam9260.dtsi |9 +++--
arch/arm/boot/dts/at91sam9g20.dtsi |9 +
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi
b/arch/arm/boot/dts/at91sam9260.dtsi
index fff0ee6..d1eb27c 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -69,9 +69,14 @@
};
};
- sram0: sram@002ff000 {
+ sram0: sram@0020 {
compatible = "mmio-sram";
- reg = <0x002ff000 0x2000>;
+ reg = <0x0020 0x1000>;
+ };
+
+ sram1: sram@0030 {
+ compatible = "mmio-sram";
+ reg = <0x0030 0x1000>;
};
ahb {
diff --git a/arch/arm/boot/dts/at91sam9g20.dtsi
b/arch/arm/boot/dts/at91sam9g20.dtsi
index f593016..eb9a62d 100644
--- a/arch/arm/boot/dts/at91sam9g20.dtsi
+++ b/arch/arm/boot/dts/at91sam9g20.dtsi
@@ -16,13 +16,14 @@
reg = <0x2000 0x0800>;
};
- sram0: sram@002ff000 {
- status = "disabled";
+ sram0: sram@0020 {
+ compatible = "mmio-sram";
+ reg = <0x0020 0x4000>;
};
- sram1: sram@002fc000 {
+ sram1: sram@0030 {
compatible = "mmio-sram";
- reg = <0x002fc000 0x8000>;
+ reg = <0x0030 0x4000>;
};
ahb {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
