Re: [PATCH] of/selftest: remove the duplicate of_changeset_init
On Mon, Mar 2, 2015 at 12:49 AM, Wang Long long.wangl...@huawei.com wrote: Remove the duplicate of_changeset_init. In of_selftest_changeset testcase, the struct of_changeset chgset is initialized twice, but only once is enough. so, drop the first initializtion code. Signed-off-by: Wang Long long.wangl...@huawei.com Applied for 4.0. Thanks. Rob --- drivers/of/unittest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 0cf9a23..199fb23 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void) struct device_node *n1, *n2, *n21, *nremove, *parent, *np; struct of_changeset chgset; - of_changeset_init(chgset); n1 = __of_node_dup(NULL, /testcase-data/changeset/n1); selftest(n1, testcase setup failure\n); n2 = __of_node_dup(NULL, /testcase-data/changeset/n2); -- 1.8.3.4 -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] of/selftest: remove the duplicate of_changeset_init
Remove the duplicate of_changeset_init. In of_selftest_changeset testcase, the struct of_changeset chgset is initialized twice, but only once is enough. so, drop the first initializtion code. Signed-off-by: Wang Long long.wangl...@huawei.com --- drivers/of/unittest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 0cf9a23..199fb23 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -478,7 +478,6 @@ static void __init of_selftest_changeset(void) struct device_node *n1, *n2, *n21, *nremove, *parent, *np; struct of_changeset chgset; - of_changeset_init(chgset); n1 = __of_node_dup(NULL, /testcase-data/changeset/n1); selftest(n1, testcase setup failure\n); n2 = __of_node_dup(NULL, /testcase-data/changeset/n2); -- 1.8.3.4 -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html